FieldConfig - Code Metrics - Inspection of "refactor" - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b8b70e...552805 )

by Portey

created 2015-12-04 13:20 UTC

FieldConfig A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

88.89%

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
wmc	6
c	3
b	0
f	0
lcom	1
cbo	1
dl	0
loc	42
ccs	16
cts	18
cp	0.8889
rs	10

4 Methods

Rating	Name	Size	Complexity
A	getRules()	12	1
A	resolve()	10	3
A	getType()	4	1
A	isRequired()	4	1

<?php
/*
* This file is a part of graphql-youshido project.
*
* @author Alexandr Viniychuk <[email protected]>
* created: 11/30/15 1:30 AM
*/

namespace Youshido\GraphQL\Type\Config\Field;

use Youshido\GraphQL\Type\Config\Config;
use Youshido\GraphQL\Type\Object\AbstractObjectType;
use Youshido\GraphQL\Type\TypeInterface;
use Youshido\GraphQL\Type\TypeMap;

class FieldConfig extends Config
{

    public function getRules()
    {
        return [
            'name'              => ['type' => TypeMap::TYPE_STRING, 'required' => true],
            'type'              => ['type' => TypeMap::TYPE_ANY, 'required' => true],
            'args'              => ['type' => TypeMap::TYPE_ARRAY],
            'required'          => ['type' => TypeMap::TYPE_BOOLEAN],
            'description'       => ['type' => TypeMap::TYPE_STRING],
            'resolve'           => ['type' => TypeMap::TYPE_FUNCTION],
            'deprecationReason' => ['type' => TypeMap::TYPE_STRING],
        ];
    }

    public function resolve($value = null, $args = [])
    {
        $resolveFunction = $this->get('resolve', null);

        if($resolveFunction && is_callable($resolveFunction)) {
           return $resolveFunction($value, $args);
        }

        return $this->getType()->resolve($value, $args);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * @return TypeInterface|AbstractObjectType
     */
    public function getType()
    {
        return $this->data['type'];
    }

    public function isRequired()
    {
        return $this->get('required', false);
    }


}

1		<?php
2		/*
3		* This file is a part of graphql-youshido project.
4		*
5		* @author Alexandr Viniychuk <[email protected]>
6		* created: 11/30/15 1:30 AM
7		*/
8
9		namespace Youshido\GraphQL\Type\Config\Field;
10
11		use Youshido\GraphQL\Type\Config\Config;
12		use Youshido\GraphQL\Type\Object\AbstractObjectType;
13		use Youshido\GraphQL\Type\TypeInterface;
14		use Youshido\GraphQL\Type\TypeMap;
15
16		class FieldConfig extends Config
17		{
18
19	6	public function getRules()
20		{
21		return [
22	6	'name' => ['type' => TypeMap::TYPE_STRING, 'required' => true],
23	6	'type' => ['type' => TypeMap::TYPE_ANY, 'required' => true],
24	6	'args' => ['type' => TypeMap::TYPE_ARRAY],
25	6	'required' => ['type' => TypeMap::TYPE_BOOLEAN],
26	6	'description' => ['type' => TypeMap::TYPE_STRING],
27	6	'resolve' => ['type' => TypeMap::TYPE_FUNCTION],
28	6	'deprecationReason' => ['type' => TypeMap::TYPE_STRING],
29	6	];
30		}
31
32	3	public function resolve($value = null, $args = [])
33		{
34	3	$resolveFunction = $this->get('resolve', null);
35
36	3	if($resolveFunction && is_callable($resolveFunction)) {
37	1	return $resolveFunction($value, $args);
38		}
39
40	3	return $this->getType()->resolve($value, $args);
		0 ignored issues – show Bug introduced 2015-12-04 13:24 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Youshido\GraphQL\Type\TypeInterface` as the method `resolve()` does only exist in the following implementations of said interface: `Youshido\GraphQL\Definition\ArgumentListType`, `Youshido\GraphQL\Definition\ArgumentType`, `Youshido\GraphQL\Definition\EnumValueListType`, `Youshido\GraphQL\Definition\EnumValueType`, `Youshido\GraphQL\Definition\FieldListType`, `Youshido\GraphQL\Definition\FieldType`, `Youshido\GraphQL\Definition\InputValueListType`, `Youshido\GraphQL\Definition\InputValueType`, `Youshido\GraphQL\Definition\InterfaceListType`, `Youshido\GraphQL\Definition\InterfaceType`, `Youshido\GraphQL\Definition\PossibleOfListType`, `Youshido\GraphQL\Definition\PossibleOfType`, `Youshido\GraphQL\Definition\QueryListType`, `Youshido\GraphQL\Definition\QueryType`, `Youshido\GraphQL\Definition\SchemaType`, `Youshido\GraphQL\Definition\TypeDefinitionType`, `Youshido\GraphQL\Type\ListType\AbstractListType`, `Youshido\GraphQL\Type\ListType\ListType`, `Youshido\GraphQL\Type\Ob...AbstractInputObjectType`, `Youshido\GraphQL\Type\Object\AbstractObjectType`, `Youshido\GraphQL\Type\Object\InputObjectType`, `Youshido\GraphQL\Type\Object\ObjectType`, `Youshido\Tests\DataProvider\UserType`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
41		}
42
43		/**
44		* @return TypeInterface\|AbstractObjectType
45		*/
46	4	public function getType()
47		{
48	4	return $this->data['type'];
49		}
50
51		public function isRequired()
52		{
53		return $this->get('required', false);
54		}
55
56
57		}

Youshido / GraphQL

Push — master ( b8b70e...552805 )

FieldConfig A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like