Youshido / GraphQL

Tests/Performance/LoadTest.php

Spacing +3 added lines, -3 removed lines

@@ -43,12 +43,12 @@ 
             $authors = [];
             while (count($authors) < rand(1, 4)) {
                 $authors[] = [
-                    'name' => 'Author ' . substr(md5(time()), 0, 4)
+                    'name' => 'Author '.substr(md5(time()), 0, 4)
                 ];
             }
             $data[] = [
                 'id'      => $i,
-                'title'   => 'Title of ' . $i,
+                'title'   => 'Title of '.$i,
                 'authors' => $authors,
             ];
         }
@@ -69,7 +69,7 @@ 
 //        return true;
         $p->processPayload('{ posts { id, title, authors { name } } }');
         $res = $p->getResponseData();
-        echo "Count: " . count($res['data']['posts']) . "\n";
+        echo "Count: ".count($res['data']['posts'])."\n";
         printf("Test Time: %04f\n", microtime(true) - $time);
 //        $p->getResponseData();
     }

Tests/Library/Type/InputObjectTypeTest.php

Unused Use Statements -7 removed lines

@@ -9,13 +9,7 @@ 
 namespace Youshido\Tests\Library\Type;
 
 
-use Youshido\GraphQL\Execution\Context\ExecutionContext;
 use Youshido\GraphQL\Execution\Processor;
-use Youshido\GraphQL\Execution\Request;
-use Youshido\GraphQL\Field\Field;
-use Youshido\GraphQL\Parser\Ast\Argument;
-use Youshido\GraphQL\Parser\Ast\ArgumentValue\Literal;
-use Youshido\GraphQL\Parser\Ast\Query;
 use Youshido\GraphQL\Schema\Schema;
 use Youshido\GraphQL\Type\InputObject\InputObjectType;
 use Youshido\GraphQL\Type\ListType\ListType;
@@ -24,7 +18,6 @@ 
 use Youshido\GraphQL\Type\Scalar\BooleanType;
 use Youshido\GraphQL\Type\Scalar\StringType;
 use Youshido\GraphQL\Type\TypeMap;
-use Youshido\GraphQL\Validator\ResolveValidator\ResolveValidator;
 use Youshido\Tests\DataProvider\TestInputObjectType;
 
 class InputObjectTypeTest extends \PHPUnit_Framework_TestCase

Spacing +4 added lines, -4 removed lines

@@ -60,7 +60,7 @@ 
                 'fields' => [
                     'empty' => [
                         'type'    => new StringType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ]
@@ -79,7 +79,7 @@ 
                             ]))
                         ],
                         'type'    => new BooleanType(),
-                        'resolve' => function ($object, $args) {
+                        'resolve' => function($object, $args) {
                             return true;
                         }
                     ]
@@ -100,7 +100,7 @@ 
                 'fields' => [
                     'empty' => [
                         'type'    => new StringType(),
-                        'resolve' => function () { }
+                        'resolve' => function() { }
                     ],
                 ]
             ]),
@@ -122,7 +122,7 @@ 
                                 ]
                             ])
                         ],
-                        'resolve' => function () { return 'success message'; }
+                        'resolve' => function() { return 'success message'; }
                     ]
                 ]
             ])

src/Type/ListType/AbstractListType.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
         $isValid = is_null($value) || is_array($value) || (is_object($value) && in_array('IteratorAggregate', class_implements($value)));
         $itemType = $this->config->get('itemType');
         if ($isValid && $itemType->isInputType()) {
-            foreach($value as $item) {
+            foreach ($value as $item) {
                 $isValid = $itemType->isValidValue($item);
                 if (!$isValid) return false;
             }

Braces +3 added lines, -1 removed lines

@@ -37,7 +37,9 @@
         if ($isValid && $itemType->isInputType()) {
             foreach($value as $item) {
                 $isValid = $itemType->isValidValue($item);
-                if (!$isValid) return false;
+                if (!$isValid) {
+                    return false;
+                }
             }
         }
         return $isValid;

src/Introspection/QueryType.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
         if ($value && $value->getKind() == TypeMap::KIND_ENUM) {
             $data = [];
             foreach ($value->getValues() as $enumValue) {
-                if(!$args['includeDeprecated'] && (isset($enumValue['isDeprecated']) && $enumValue['isDeprecated'])) {
+                if (!$args['includeDeprecated'] && (isset($enumValue['isDeprecated']) && $enumValue['isDeprecated'])) {
                     continue;
                 }
 
@@ -91,7 +91,7 @@ 
         }
 
         /** @var AbstractObjectType $value */
-        return array_filter($value->getConfig()->getFields(), function ($field) use ($args) {
+        return array_filter($value->getConfig()->getFields(), function($field) use ($args) {
             /** @var $field Field */
             if (in_array($field->getName(), ['__type', '__schema']) || (!$args['includeDeprecated'] && $field->isDeprecated())) {
                 return false;

src/Execution/Processor.php

Doc Comments +6 added lines, -3 removed lines

@@ -111,7 +111,7 @@ 
     }
 
     /**
-     * @param Query|Field        $query
+     * @param Query        $query
      * @param AbstractObjectType $currentLevelSchema
      * @return array|bool|mixed
      */
@@ -260,6 +260,9 @@ 
         }
     }
 
+    /**
+     * @param AbstractField $field
+     */
     protected function createResolveInfo($field, $fields) {
         return new ResolveInfo($field, $fields, $this->executionContext);
     }
@@ -322,7 +325,7 @@ 
     }
 
     /**
-     * @param $query         Query|FragmentInterface
+     * @param Query $query         Query|FragmentInterface
      * @param $queryType     AbstractObjectType|TypeInterface|Field|AbstractType
      * @param $resolvedValue mixed
      * @param $value         array
@@ -494,7 +497,7 @@ 
      * Fragments (anonymous and named), and Fields.  The core of the function is simple: recurse until we hit the base
      * case of a Field and yield that back up to the visitor up in `doVisit`.
      *
-     * @param Query|Field|FragmentInterface $queryNode
+     * @param Query $queryNode
      * @param AbstractField                 $currentLevelAST
      *
      * @return \Generator

Braces +6 added lines, -2 removed lines

@@ -173,8 +173,12 @@
             $kind === TypeMap::KIND_LIST ||
             ($kind === TypeMap::KIND_NON_NULL && $fieldType->getNamedType()->getKind() === TypeMap::KIND_LIST)
         ) {
-            if ($kind === TypeMap::KIND_NON_NULL) $fieldType = $fieldType->getNamedType();
-            if (!$this->resolveValidator->hasArrayAccess($resolvedValue)) return null;
+            if ($kind === TypeMap::KIND_NON_NULL) {
+                $fieldType = $fieldType->getNamedType();
+            }
+            if (!$this->resolveValidator->hasArrayAccess($resolvedValue)) {
+                return null;
+            }
 
             $namedType          = $fieldType->getNamedType();
             $isAbstract         = TypeService::isAbstractType($namedType);

Tests/Schema/ProcessorTest.php

Spacing +34 added lines, -34 removed lines

@@ -95,14 +95,14 @@ 
                 'fields' => [
                     'list' => [
                         'type'    => new ListType(new StringType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ]
                 ]
             ])
         ]));
-        $data      = $processor->processPayload(' { list }')->getResponseData();
+        $data = $processor->processPayload(' { list }')->getResponseData();
         $this->assertEquals(['data' => ['list' => null]], $data);
     }
 
@@ -115,20 +115,20 @@ 
                 'fields' => [
                     'list' => [
                         'type'    => new ListType(new StringType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ]
                 ]
             ])
         ]));
-        $data      = $processor->processPayload(' { __schema { subscriptionType { name } } }')->getResponseData();
+        $data = $processor->processPayload(' { __schema { subscriptionType { name } } }')->getResponseData();
         $this->assertEquals(['data' => ['__schema' => ['subscriptionType' => null]]], $data);
     }
 
     public function testSchemaOperations()
     {
-        $schema    = new Schema([
+        $schema = new Schema([
             'query' => new ObjectType([
                 'name'   => 'RootQuery',
                 'fields' => [
@@ -141,13 +141,13 @@ 
                                     'args'    => [
                                         'shorten' => new BooleanType()
                                     ],
-                                    'resolve' => function ($value, $args) {
+                                    'resolve' => function($value, $args) {
                                         return empty($args['shorten']) ? $value['firstName'] : $value['firstName'];
                                     }
                                 ],
                                 'id_alias'  => [
                                     'type'    => new IdType(),
-                                    'resolve' => function ($value) {
+                                    'resolve' => function($value) {
                                         return $value['id'];
                                     }
                                 ],
@@ -155,7 +155,7 @@ 
                                 'code'      => new StringType(),
                             ]
                         ]),
-                        'resolve' => function ($value, $args) {
+                        'resolve' => function($value, $args) {
                             $data = ['id' => '123', 'firstName' => 'John', 'code' => '007'];
                             if (!empty($args['upper'])) {
                                 foreach ($data as $key => $value) {
@@ -174,19 +174,19 @@ 
                     ],
                     'randomUser'        => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['invalidField' => 'John'];
                         }
                     ],
                     'invalidValueQuery' => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'stringValue';
                         }
                     ],
                     'labels'            => [
                         'type'    => new ListType(new StringType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['one', 'two'];
                         }
                     ]
@@ -217,7 +217,7 @@ 
             ->addField(new Field([
                 'name'    => 'increaseCounter',
                 'type'    => new IntType(),
-                'resolve' => function ($value, $args, ResolveInfo $info) {
+                'resolve' => function($value, $args, ResolveInfo $info) {
                     return $this->_counter += $args['amount'];
                 },
                 'args'    => [
@@ -229,13 +229,13 @@ 
             ]))->addField(new Field([
                 'name'    => 'invalidResolveTypeMutation',
                 'type'    => new NonNullType(new IntType()),
-                'resolve' => function () {
+                'resolve' => function() {
                     return null;
                 }
             ]))->addField(new Field([
                 'name'    => 'interfacedMutation',
                 'type'    => new TestInterfaceType(),
-                'resolve' => function () {
+                'resolve' => function() {
                     return ['name' => 'John'];
                 }
             ]));
@@ -296,7 +296,7 @@ 
                             ]))
                         ],
                         'type'    => new StringType(),
-                        'resolve' => function ($value, $args) {
+                        'resolve' => function($value, $args) {
                             return $args['argument1'];
                         }
                     ]
@@ -329,43 +329,43 @@ 
                 'fields' => [
                     'listQuery'                 => [
                         'type'    => new ListType(new TestEnumType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'invalid list';
                         }
                     ],
                     'listEnumQuery'             => [
                         'type'    => new ListType(new TestEnumType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['invalid enum'];
                         }
                     ],
                     'invalidEnumQuery'          => [
                         'type'    => new TestEnumType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'invalid enum';
                         }
                     ],
                     'enumQuery'                 => [
                         'type'    => new TestEnumType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 1;
                         }
                     ],
                     'invalidNonNullQuery'       => [
                         'type'    => new NonNullType(new IntType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ],
                     'invalidNonNullInsideQuery' => [
                         'type'    => new NonNullType(new IntType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'hello';
                         }
                     ],
                     'objectQuery'               => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['name' => 'John'];
                         }
                     ],
@@ -377,7 +377,7 @@ 
                                 'enum'   => new TestEnumType(),
                             ],
                         ]),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return [
                                 'object' => [
                                     'name' => 'John'
@@ -446,10 +446,10 @@ 
             ]
         ]);
 
-        $union        = new UnionType([
+        $union = new UnionType([
             'name'        => 'TestUnion',
             'types'       => [$object1, $object2],
-            'resolveType' => function ($object) use ($object1, $object2) {
+            'resolveType' => function($object) use ($object1, $object2) {
                 if (isset($object['id'])) {
                     return $object1;
                 }
@@ -460,11 +460,11 @@ 
         $invalidUnion = new UnionType([
             'name'        => 'TestUnion',
             'types'       => [$object1, $object2],
-            'resolveType' => function ($object) use ($object3) {
+            'resolveType' => function($object) use ($object3) {
                 return $object3;
             }
         ]);
-        $processor    = new Processor(new Schema([
+        $processor = new Processor(new Schema([
             'query' => new ObjectType([
                 'name'   => 'RootQuery',
                 'fields' => [
@@ -474,7 +474,7 @@ 
                             'type' => ['type' => 'string']
                         ],
                         'cost'    => 10,
-                        'resolve' => function ($value, $args) {
+                        'resolve' => function($value, $args) {
                             if ($args['type'] == 'object1') {
                                 return [
                                     'id' => 43
@@ -488,7 +488,7 @@ 
                     ],
                     'invalidUnion' => [
                         'type'    => $invalidUnion,
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['name' => 'name resolved'];
                         }
                     ],
@@ -533,7 +533,7 @@ 
 
     public function testComplexityReducer()
     {
-        $schema    = new Schema(
+        $schema = new Schema(
             [
                 'query' => new ObjectType(
                     [
@@ -549,7 +549,7 @@ 
                                                 'args'    => [
                                                     'shorten' => new BooleanType()
                                                 ],
-                                                'resolve' => function ($value, $args) {
+                                                'resolve' => function($value, $args) {
                                                     return empty($args['shorten']) ? $value : $value;
                                                 }
                                             ],
@@ -558,19 +558,19 @@ 
                                             'likes'     => [
                                                 'type'    => new IntType(),
                                                 'cost'    => 10,
-                                                'resolve' => function () {
+                                                'resolve' => function() {
                                                     return 42;
                                                 }
                                             ]
                                         ]
                                     ]
                                 ),
-                                'cost'    => function ($args, $context, $childCost) {
+                                'cost'    => function($args, $context, $childCost) {
                                     $argsCost = isset($args['cost']) ? $args['cost'] : 1;
 
                                     return 1 + $argsCost * $childCost;
                                 },
-                                'resolve' => function ($value, $args) {
+                                'resolve' => function($value, $args) {
                                     $data = ['firstName' => 'John', 'code' => '007'];
 
                                     return $data;

Tests/Schema/IntrospectionTest.php

Spacing +8 added lines, -8 removed lines

@@ -135,7 +135,7 @@ 
             'description'       => 'latest description',
             'deprecationReason' => 'for test',
             'isDeprecated'      => true,
-            'resolve'           => function () {
+            'resolve'           => function() {
                 return [
                     'id'   => 1,
                     'name' => 'Alex'
@@ -146,7 +146,7 @@ 
         $schema->addQueryField(new Field([
             'name'              => 'new',
             'type'              => TypeMap::TYPE_BOOLEAN,
-            'resolve'           => function () {
+            'resolve'           => function() {
                 return true;
             }
         ]));
@@ -206,8 +206,8 @@ 
                                 ['name' => 'Boolean', 'fields' => null],
                                 ['name' => '__Schema', 'fields' => [['name' => 'queryType'], ['name' => 'mutationType'], ['name' => 'subscriptionType'], ['name' => 'types'], ['name' => 'directives']]],
                                 ['name' => '__Type', 'fields' => [['name' => 'name'], ['name' => 'kind'], ['name' => 'description'], ['name' => 'ofType'], ['name' => 'inputFields'], ['name' => 'enumValues'], ['name' => 'fields'], ['name' => 'interfaces'], ['name' => 'possibleTypes']]],
-                                ['name' => '__InputValue', 'fields' => [['name' => 'name'], ['name' => 'description'], ['name' => 'type'], ['name' => 'defaultValue'],]],
-                                ['name' => '__EnumValue', 'fields' => [['name' => 'name'], ['name' => 'description'], ['name' => 'deprecationReason'], ['name' => 'isDeprecated'],]],
+                                ['name' => '__InputValue', 'fields' => [['name' => 'name'], ['name' => 'description'], ['name' => 'type'], ['name' => 'defaultValue'], ]],
+                                ['name' => '__EnumValue', 'fields' => [['name' => 'name'], ['name' => 'description'], ['name' => 'deprecationReason'], ['name' => 'isDeprecated'], ]],
                                 ['name' => '__Field', 'fields' => [['name' => 'name'], ['name' => 'description'], ['name' => 'isDeprecated'], ['name' => 'deprecationReason'], ['name' => 'type'], ['name' => 'args']]],
                                 ['name' => '__Subscription', 'fields' => [['name' => 'name']]],
                                 ['name' => '__Directive', 'fields' => [['name' => 'name'], ['name' => 'description'], ['name' => 'args'], ['name' => 'onOperation'], ['name' => 'onFragment'], ['name' => 'onField']]],
@@ -296,7 +296,7 @@ 
                 'id'   => ['type' => new IntType()],
                 'name' => ['type' => new IntType()],
             ],
-            'resolveType' => function ($type) {
+            'resolveType' => function($type) {
 
             }
         ]);
@@ -324,7 +324,7 @@ 
         $unionType = new UnionType([
             'name'        => 'UnionType',
             'types'       => [$object1, $object2],
-            'resolveType' => function () {
+            'resolveType' => function() {
 
             }
         ]);
@@ -335,7 +335,7 @@ 
             'args'    => [
                 'id' => ['type' => TypeMap::TYPE_INT]
             ],
-            'resolve' => function () {
+            'resolve' => function() {
                 return [
                     'id'   => 1,
                     'name' => 'Alex'
@@ -361,7 +361,7 @@ 
                     ]
                 ])
             ],
-            'resolve' => function () {
+            'resolve' => function() {
                 return null;
             }
         ]));

src/Type/Object/AbstractObjectType.php

Doc Comments +3 added lines

@@ -87,6 +87,9 @@
         return $this->getConfigValue('interfaces', []);
     }
 
+    /**
+     * @param ObjectType|null $value
+     */
     public function isValidValue($value)
     {
         return is_array($value) || is_null($value) || is_object($value);

src/Field/AbstractField.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
             $config['type'] = $this->getType();
             $config['name'] = $this->getName();
             if (empty($config['name'])) {
-                $config['name'] =$this->getAutoName();
+                $config['name'] = $this->getAutoName();
             }
         }