CharacterInterface::getName() - Code Metrics - Inspection of "TypeMap instead of string literals in definition c..." - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e8c337...7f89eb )

by Alexandr

created 2015-12-07 05:02 UTC

CharacterInterface::getName() A

↳ Parent: CharacterInterface

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php
/*
* This file is a part of GraphQL project.
*
* @author Alexandr Viniychuk <[email protected]>
* created: 12/6/15 11:15 PM
*/

namespace Youshido\Tests\Schema;


use Youshido\GraphQL\Type\Config\Object\InterfaceTypeConfig;
use Youshido\GraphQL\Type\Config\TypeConfigInterface;
use Youshido\GraphQL\Type\ListType\ListType;
use Youshido\GraphQL\Type\Object\InterfaceType;
use Youshido\GraphQL\Type\TypeMap;

class CharacterInterface extends InterfaceType
{
    protected function build(TypeConfigInterface $config)
    {
        /** @var InterfaceTypeConfig $config */
//        $config->addField('id', TypeMap::TYPE_ID, ['description' => 'ID of the character'])

//            ->addField('name', TypeMap::TYPE_STRING, ['description' => 'The name of the character'])
//            ;
        $config->addFields([

                               'id'   => ['type'        => TypeMap::TYPE_ID,
                                          'required'    => true,
                                          'description' => 'ID of the character'],
                               'name' => ['type'        => TypeMap::TYPE_STRING,
                                          'description' => 'The name of the character'],
                               'friends'   => new ListType(['item' => new CharacterInterface()])
                           ]);
    }

    public function getDescription()
    {
        return 'A character in the Star Wars Trilogy';
    }

    public function getName()
    {
        return 'Character';
    }

}

1			<?php
2			/*
3			* This file is a part of GraphQL project.
4			*
5			* @author Alexandr Viniychuk <[email protected]>
6			* created: 12/6/15 11:15 PM
7			*/
8
9			namespace Youshido\Tests\Schema;
10
11
12			use Youshido\GraphQL\Type\Config\Object\InterfaceTypeConfig;
13			use Youshido\GraphQL\Type\Config\TypeConfigInterface;
14			use Youshido\GraphQL\Type\ListType\ListType;
15			use Youshido\GraphQL\Type\Object\InterfaceType;
16			use Youshido\GraphQL\Type\TypeMap;
17
18			class CharacterInterface extends InterfaceType
19			{
20			protected function build(TypeConfigInterface $config)
21			{
22			/** @var InterfaceTypeConfig $config */
23			// $config->addField('id', TypeMap::TYPE_ID, ['description' => 'ID of the character'])
			0 ignored issues – show Unused Code Comprehensibility introduced 2015-12-07 05:04 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
24			// ->addField('name', TypeMap::TYPE_STRING, ['description' => 'The name of the character'])
25			// ;
26			$config->addFields([
			0 ignored issues – show Bug introduced 2015-12-07 05:04 UTC by Report Bug Copy Issue Report The method `addFields()` does not exist on `Youshido\GraphQL\Type\Config\TypeConfigInterface`. Did you maybe mean `addField()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
27			'id' => ['type' => TypeMap::TYPE_ID,
28			'required' => true,
29			'description' => 'ID of the character'],
30			'name' => ['type' => TypeMap::TYPE_STRING,
31			'description' => 'The name of the character'],
32			'friends' => new ListType(['item' => new CharacterInterface()])
33			]);
34			}
35
36			public function getDescription()
37			{
38			return 'A character in the Star Wars Trilogy';
39			}
40
41			public function getName()
42			{
43			return 'Character';
44			}
45
46			}

Youshido / GraphQL

Push — master ( e8c337...7f89eb )

CharacterInterface::getName() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like