Youshido / GraphQL

src/Type/InterfaceType/InterfaceType.php

Doc Comments +3 added lines

@@ -25,6 +25,9 @@
     {
     }
 
+    /**
+     * @param \Youshido\GraphQL\Type\Object\ObjectType $object
+     */
     public function resolveType($object)
     {
         return $this->getConfig()->resolveType($object);

src/Type/NonNullType.php

Doc Comments +3 added lines

@@ -50,6 +50,9 @@
         return $value;
     }
 
+    /**
+     * @param null|Scalar\StringType $value
+     */
     public function isValidValue($value)
     {
         return $value !== null;

src/Validator/SchemaValidator/SchemaValidator.php

Doc Comments +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
      * @param Field                 $objField
      * @param AbstractInterfaceType $interface
      *
-     * @return bool
+     * @return boolean|null
      *
      * @throws ConfigurationException
      */

Tests/DataProvider/TestField.php

Doc Comments +4 added lines, -1 removed lines

@@ -16,13 +16,16 @@
 {
 
     /**
-     * @return AbstractObjectType
+     * @return IntType
      */
     public function getType()
     {
         return new IntType();
     }
 
+    /**
+     * @param string $value
+     */
     public function resolve($value, array $args, ResolveInfo $info)
     {
         return $value;

Tests/DataProvider/TestInputField.php

Doc Comments +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
 {
 
     /**
-     * @return AbstractInputObjectType
+     * @return IntType
      */
     public function getType()
     {

Tests/StarWars/Schema/QueryType.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 
 
 use Youshido\GraphQL\Field\Field;
-use Youshido\GraphQL\Field\FieldFactory;
 use Youshido\GraphQL\Type\Object\AbstractObjectType;
 use Youshido\GraphQL\Type\Scalar\IdType;
 

Spacing +3 added lines, -3 removed lines

@@ -36,7 +36,7 @@ 
                 'args'    => [
                     'episode' => ['type' => new EpisodeEnum()]
                 ],
-                'resolve' => function ($root, $args) {
+                'resolve' => function($root, $args) {
                     return StarWarsData::getHero(isset($args['episode']) ? $args['episode'] : null);
                 },
             ])
@@ -46,7 +46,7 @@ 
                 'args'    => [
                     'id' => new IdType()
                 ],
-                'resolve' => function ($value = null, $args = []) {
+                'resolve' => function($value = null, $args = []) {
                     $humans = StarWarsData::humans();
 
                     return isset($humans[$args['id']]) ? $humans[$args['id']] : null;
@@ -58,7 +58,7 @@ 
                 'args'    => [
                     'id' => new IdType()
                 ],
-                'resolve' => function ($value = null, $args = []) {
+                'resolve' => function($value = null, $args = []) {
                     $droids = StarWarsData::droids();
 
                     return isset($droids[$args['id']]) ? $droids[$args['id']] : null;

Tests/Schema/ProcessorTest.php

Spacing +22 added lines, -22 removed lines

@@ -96,7 +96,7 @@ 
 
     public function testSchemaOperations()
     {
-        $schema    = new Schema([
+        $schema = new Schema([
             'query' => new ObjectType([
                 'name'   => 'RootQuery',
                 'fields' => [
@@ -109,7 +109,7 @@ 
                                     'args'    => [
                                         'shorten' => new BooleanType()
                                     ],
-                                    'resolve' => function ($value, $args) {
+                                    'resolve' => function($value, $args) {
                                         return empty($args['shorten']) ? $value : $value;
                                     }
                                 ],
@@ -117,7 +117,7 @@ 
                                 'code'      => new StringType(),
                             ]
                         ]),
-                        'resolve' => function ($value, $args) {
+                        'resolve' => function($value, $args) {
                             $data = ['firstName' => 'John', 'code' => '007'];
                             if (!empty($args['upper'])) {
                                 foreach ($data as $key => $value) {
@@ -136,13 +136,13 @@ 
                     ],
                     'randomUser'        => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['invalidField' => 'John'];
                         }
                     ],
                     'invalidValueQuery' => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'stringValue';
                         }
                     ],
@@ -167,7 +167,7 @@ 
                ->addField(new Field([
                    'name'    => 'increaseCounter',
                    'type'    => new IntType(),
-                   'resolve' => function ($value, $args, ResolveInfo $info) {
+                   'resolve' => function($value, $args, ResolveInfo $info) {
                        return $this->_counter += $args['amount'];
                    },
                    'args'    => [
@@ -179,13 +179,13 @@ 
                ]))->addField(new Field([
                 'name'    => 'invalidResolveTypeMutation',
                 'type'    => new NonNullType(new IntType()),
-                'resolve' => function () {
+                'resolve' => function() {
                     return null;
                 }
             ]))->addField(new Field([
                 'name'    => 'interfacedMutation',
                 'type'    => new TestInterfaceType(),
-                'resolve' => function () {
+                'resolve' => function() {
                     return ['name' => 'John'];
                 }
             ]));
@@ -231,43 +231,43 @@ 
                 'fields' => [
                     'listQuery'                 => [
                         'type'    => new ListType(new TestEnumType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'invalid list';
                         }
                     ],
                     'listEnumQuery'             => [
                         'type'    => new ListType(new TestEnumType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['invalid enum'];
                         }
                     ],
                     'invalidEnumQuery'          => [
                         'type'    => new TestEnumType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'invalid enum';
                         }
                     ],
                     'enumQuery'                 => [
                         'type'    => new TestEnumType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 1;
                         }
                     ],
                     'invalidNonNullQuery'       => [
                         'type'    => new NonNullType(new IntType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ],
                     'invalidNonNullInsideQuery' => [
                         'type'    => new NonNullType(new IntType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'hello';
                         }
                     ],
                     'objectQuery'               => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['name' => 'John'];
                         }
                     ],
@@ -279,7 +279,7 @@ 
                                 'enum'   => new TestEnumType(),
                             ],
                         ]),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return [
                                 'object' => [
                                     'name' => 'John'
@@ -348,10 +348,10 @@ 
             ]
         ]);
 
-        $union        = new UnionType([
+        $union = new UnionType([
             'name'        => 'TestUnion',
             'types'       => [$object1, $object2],
-            'resolveType' => function ($object) use ($object1, $object2) {
+            'resolveType' => function($object) use ($object1, $object2) {
                 if (isset($object['id'])) {
                     return $object1;
                 }
@@ -362,11 +362,11 @@ 
         $invalidUnion = new UnionType([
             'name'        => 'TestUnion',
             'types'       => [$object1, $object2],
-            'resolveType' => function ($object) use ($object3) {
+            'resolveType' => function($object) use ($object3) {
                 return $object3;
             }
         ]);
-        $processor    = new Processor(new Schema([
+        $processor = new Processor(new Schema([
             'query' => new ObjectType([
                 'name'   => 'RootQuery',
                 'fields' => [
@@ -375,7 +375,7 @@ 
                         'args'    => [
                             'type' => ['type' => 'string']
                         ],
-                        'resolve' => function ($value, $args) {
+                        'resolve' => function($value, $args) {
                             if ($args['type'] == 'object1') {
                                 return [
                                     'id' => 43
@@ -389,7 +389,7 @@ 
                     ],
                     'invalidUnion' => [
                         'type'    => $invalidUnion,
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['name' => 'name resolved'];
                         }
                     ],

Indentation +15 added lines, -15 removed lines

@@ -55,7 +55,7 @@ 
 
     }
 
-  public function testNestedVariables() {
+    public function testNestedVariables() {
     $processor = new Processor(new TestSchema());
     $noArgsQuery = '{ me { echo(value:"foo") } }';
     $expectedData = ['data' => ['me' => ['echo' => 'foo']]];
@@ -81,7 +81,7 @@ 
         }';
     $processor->processPayload($parameterizedQueryQuery, ['value' => 1]);
     $this->assertArrayNotHasKey('errors', $processor->getResponseData());
-  }
+    }
 
     public function testListNullResponse()
     {
@@ -192,19 +192,19 @@ 
         $this->assertEquals(['data' => ['me' => ['firstName' => 'JOHN']]], $processor->getResponseData());
 
         $schema->getMutationType()
-               ->addField(new Field([
-                   'name'    => 'increaseCounter',
-                   'type'    => new IntType(),
-                   'resolve' => function ($value, $args, ResolveInfo $info) {
-                       return $this->_counter += $args['amount'];
-                   },
-                   'args'    => [
-                       'amount' => [
-                           'type'    => new IntType(),
-                           'default' => 1
-                       ]
-                   ]
-               ]))->addField(new Field([
+                ->addField(new Field([
+                    'name'    => 'increaseCounter',
+                    'type'    => new IntType(),
+                    'resolve' => function ($value, $args, ResolveInfo $info) {
+                        return $this->_counter += $args['amount'];
+                    },
+                    'args'    => [
+                        'amount' => [
+                            'type'    => new IntType(),
+                            'default' => 1
+                        ]
+                    ]
+                ]))->addField(new Field([
                 'name'    => 'invalidResolveTypeMutation',
                 'type'    => new NonNullType(new IntType()),
                 'resolve' => function () {

Tests/Schema/IntrospectionTest.php

Spacing +7 added lines, -7 removed lines

@@ -135,7 +135,7 @@ 
             'description'       => 'latest description',
             'deprecationReason' => 'for test',
             'isDeprecated'      => true,
-            'resolve'           => function () {
+            'resolve'           => function() {
                 return [
                     'id'   => 1,
                     'name' => 'Alex'
@@ -197,8 +197,8 @@ 
                                 ['name' => 'String', 'fields' => null],
                                 ['name' => '__Schema', 'fields' => [['name' => 'queryType'], ['name' => 'mutationType'], ['name' => 'subscriptionType'], ['name' => 'types'], ['name' => 'directives']]],
                                 ['name' => '__Type', 'fields' => [['name' => 'name'], ['name' => 'kind'], ['name' => 'description'], ['name' => 'ofType'], ['name' => 'inputFields'], ['name' => 'enumValues'], ['name' => 'fields'], ['name' => 'interfaces'], ['name' => 'possibleTypes']]],
-                                ['name' => '__InputValue', 'fields' => [['name' => 'name'], ['name' => 'description'], ['name' => 'type'], ['name' => 'defaultValue'],]],
-                                ['name' => '__EnumValue', 'fields' => [['name' => 'name'], ['name' => 'description'], ['name' => 'deprecationReason'], ['name' => 'isDeprecated'],]],
+                                ['name' => '__InputValue', 'fields' => [['name' => 'name'], ['name' => 'description'], ['name' => 'type'], ['name' => 'defaultValue'], ]],
+                                ['name' => '__EnumValue', 'fields' => [['name' => 'name'], ['name' => 'description'], ['name' => 'deprecationReason'], ['name' => 'isDeprecated'], ]],
                                 ['name' => 'Boolean', 'fields' => null],
                                 ['name' => '__Field', 'fields' => [['name' => 'name'], ['name' => 'description'], ['name' => 'isDeprecated'], ['name' => 'deprecationReason'], ['name' => 'type'], ['name' => 'args']]],
                                 ['name' => '__Subscription', 'fields' => [['name' => 'name']]],
@@ -287,7 +287,7 @@ 
                 'id'   => ['type' => new IntType()],
                 'name' => ['type' => new IntType()],
             ],
-            'resolveType' => function ($type) {
+            'resolveType' => function($type) {
 
             }
         ]);
@@ -315,7 +315,7 @@ 
         $unionType = new UnionType([
             'name'        => 'UnionType',
             'types'       => [$object1, $object2],
-            'resolveType' => function () {
+            'resolveType' => function() {
 
             }
         ]);
@@ -326,7 +326,7 @@ 
             'args'    => [
                 'id' => ['type' => TypeMap::TYPE_INT]
             ],
-            'resolve' => function () {
+            'resolve' => function() {
                 return [
                     'id'   => 1,
                     'name' => 'Alex'
@@ -352,7 +352,7 @@ 
                     ]
                 ])
             ],
-            'resolve' => function () {
+            'resolve' => function() {
                 return null;
             }
         ]));

Tests/Schema/SchemaTest.php

Spacing +2 added lines, -2 removed lines

@@ -26,7 +26,7 @@ 
             'fields' => [
                 'currentTime' => [
                     'type'    => new StringType(),
-                    'resolve' => function ($value, $args, $type) {
+                    'resolve' => function($value, $args, $type) {
                         return 'May 5, 9:00am';
                     },
                     'args'    => [
@@ -55,7 +55,7 @@ 
 
         $this->assertEquals(1, count($schema->getMutationType()->getFields()));
 
-        $schema->addMutationField('changeUser', ['type' => new TestObjectType(), 'resolve' => function () { }]);
+        $schema->addMutationField('changeUser', ['type' => new TestObjectType(), 'resolve' => function() { }]);
         $this->assertEquals(2, count($schema->getMutationType()->getFields()));
 
     }