Completed
Pull Request — master (#112)
by Phil
02:21
created
Tests/Library/Validator/RequestValidatorTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@
 block discarded – undo
111 111
                             new Argument('test2', new VariableReference('test2', $variable2, new Location(1, 1)), new Location(1, 1)),
112 112
                         ], [
113 113
                             new Field('test', null, [], new Location(1, 1))
114
-                        ], new Location(1,1))
114
+                        ], new Location(1, 1))
115 115
                     ],
116 116
                     'variables'          => [
117 117
                         $variable1,
Please login to merge, or discard this patch.
Tests/Schema/FragmentsTest.php 2 patches
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -2,14 +2,10 @@
 block discarded – undo
2 2
 
3 3
 namespace Youshido\Tests\Schema;
4 4
 
5
-use Youshido\GraphQL\Config\Object\InterfaceTypeConfig;
6
-use Youshido\GraphQL\Config\Object\ObjectTypeConfig;
7 5
 use Youshido\GraphQL\Execution\Processor;
8 6
 use Youshido\GraphQL\Schema\Schema;
9 7
 use Youshido\GraphQL\Type\InterfaceType\AbstractInterfaceType;
10
-use Youshido\GraphQL\Type\InterfaceType\InterfaceType;
11 8
 use Youshido\GraphQL\Type\ListType\ListType;
12
-use Youshido\GraphQL\Type\NonNullType;
13 9
 use Youshido\GraphQL\Type\Object\AbstractObjectType;
14 10
 use Youshido\GraphQL\Type\Object\ObjectType;
15 11
 use Youshido\GraphQL\Type\Scalar\IdType;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
                 'fields' => [
104 104
                     'user' => [
105 105
                         'type'    => new UserType(),
106
-                        'resolve' => function ($args) {
106
+                        'resolve' => function($args) {
107 107
                             return [
108 108
                                 'id'           => 'user-id-1',
109 109
                                 'fullName'     => 'Alex',
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
                 'fields' => [
218 218
                     'user' => [
219 219
                         'type'    => new UserType(),
220
-                        'resolve' => function ($args) {
220
+                        'resolve' => function($args) {
221 221
                             return [
222 222
                                 'id'       => 'user-id-1',
223 223
                                 'fullName' => 'Alex',
Please login to merge, or discard this patch.
Tests/Schema/NonNullableTest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -48,13 +48,13 @@  discard block
 block discarded – undo
48 48
                 'fields' => [
49 49
                     'nonNullScalar'        => [
50 50
                         'type'    => new NonNullType(new IntType()),
51
-                        'resolve' => function () {
51
+                        'resolve' => function() {
52 52
                             return null;
53 53
                         },
54 54
                     ],
55 55
                     'nonNullList'          => [
56 56
                         'type'    => new NonNullType(new ListType(new IntType())),
57
-                        'resolve' => function () {
57
+                        'resolve' => function() {
58 58
                             return null;
59 59
                         }
60 60
                     ],
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
                                 'name' => new StringType(),
67 67
                             ]
68 68
                         ])),
69
-                        'resolve' => function () {
69
+                        'resolve' => function() {
70 70
                             return [
71 71
                                 'id'   => new uid('6cfb044c-9c0a-4ddd-9ef8-a0b940818db3'),
72 72
                                 'name' => 'Alex'
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
                     ],
76 76
                     'nonNullListOfNpnNull' => [
77 77
                         'type'    => new NonNullType(new ListType(new NonNullType(new IntType()))),
78
-                        'resolve' => function () {
78
+                        'resolve' => function() {
79 79
                             return [1, null];
80 80
                         }
81 81
                     ],
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
                             'ids' => new NonNullType(new ListType(new IntType()))
85 85
                         ],
86 86
                         'type'    => new IntType(),
87
-                        'resolve' => function () {
87
+                        'resolve' => function() {
88 88
                             return 1;
89 89
                         }
90 90
                     ],
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
                             'ids' => new NonNullType(new ListType(new NonNullType(new IntType())))
94 94
                         ],
95 95
                         'type'    => new IntType(),
96
-                        'resolve' => function () {
96
+                        'resolve' => function() {
97 97
                             return 1;
98 98
                         }
99 99
                     ],
Please login to merge, or discard this patch.
src/Config/Schema/SchemaConfig.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,6 +23,9 @@  discard block
 block discarded – undo
23 23
      */
24 24
     private $typesList;
25 25
 
26
+    /**
27
+     * @param \Youshido\GraphQL\Schema\AbstractSchema $contextObject
28
+     */
26 29
     public function __construct(array $configData, $contextObject = null, $finalClass = false)
27 30
     {
28 31
         $this->typesList = new SchemaTypesList();
@@ -78,7 +81,7 @@  discard block
 block discarded – undo
78 81
     }
79 82
 
80 83
     /**
81
-     * @param $query AbstractObjectType
84
+     * @param ObjectType $query AbstractObjectType
82 85
      *
83 86
      * @return SchemaConfig
84 87
      */
Please login to merge, or discard this patch.
src/Field/AbstractField.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
     }
27 27
     protected $isFinal = false;
28 28
 
29
-    private $nameCache            = null;
29
+    private $nameCache = null;
30 30
 
31 31
     public function __construct(array $config = [])
32 32
     {
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
             $config['type'] = $this->getType();
35 35
             $config['name'] = $this->getName();
36 36
             if (empty($config['name'])) {
37
-                $config['name'] =$this->getAutoName();
37
+                $config['name'] = $this->getAutoName();
38 38
             }
39 39
         }
40 40
 
Please login to merge, or discard this patch.
src/Type/Enum/AbstractEnumType.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,9 @@
 block discarded – undo
48 48
      */
49 49
     public function isValidValue($value)
50 50
     {
51
-        if (is_null($value)) return true;
51
+        if (is_null($value)) {
52
+            return true;
53
+        }
52 54
         foreach ($this->getConfig()->get('values') as $item) {
53 55
             if ($value === $item['name'] || $value === $item['value']) {
54 56
                 return true;
Please login to merge, or discard this patch.
Tests/Schema/InputObjectDefaultValuesTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
                 ],
32 32
             ]
33 33
         ]);
34
-        $schema   = new Schema([
34
+        $schema = new Schema([
35 35
             'query' => new ObjectType([
36 36
                 'name'   => 'RootQuery',
37 37
                 'fields' => [
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
                                 ]
50 50
                             ])
51 51
                         ],
52
-                        'resolve'    => function ($source, $args) {
52
+                        'resolve'    => function($source, $args) {
53 53
                             return sprintf('Result with level %s and status %s',
54 54
                                 $args['statObject']['level'], $args['statObject']['status']
55 55
                             );
Please login to merge, or discard this patch.
Tests/Issues/Issue90/Issue90Schema.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
                         'args'    => [
21 21
                             'date' => new DateTimeType('Y-m-d H:ia')
22 22
                         ],
23
-                        'resolve' => function ($value, $args, $info) {
23
+                        'resolve' => function($value, $args, $info) {
24 24
 
25 25
                             if (isset($args['date'])) {
26 26
                                 return $args['date'];
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
                         'args'    => [
43 43
                             'date' => new DateTimeType('Y-m-d H:ia')
44 44
                         ],
45
-                        'resolve' => function ($value, $args, $info) {
45
+                        'resolve' => function($value, $args, $info) {
46 46
 
47 47
                             if (isset($args['date'])) {
48 48
                                 return $args['date'];
Please login to merge, or discard this patch.
src/Config/Traits/FieldsAwareConfigTrait.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
     }
91 91
 
92 92
     /**
93
-     * @param $name
93
+     * @param string $name
94 94
      *
95 95
      * @return Field
96 96
      */
@@ -122,6 +122,9 @@  discard block
 block discarded – undo
122 122
         return $this->fields;
123 123
     }
124 124
 
125
+    /**
126
+     * @param string $name
127
+     */
125 128
     public function removeField($name)
126 129
     {
127 130
         if ($this->hasField($name)) {
Please login to merge, or discard this patch.