Youshido / GraphQL

src/Execution/Visitor/AbstractQueryVisitor.php

Indentation +28 added lines, -28 removed lines

@@ -29,38 +29,38 @@
 
 abstract class AbstractQueryVisitor {
 
-  /**
-   * @var int initial value of $this->memo
-   */
-  protected $initialValue = 0;
+    /**
+     * @var int initial value of $this->memo
+     */
+    protected $initialValue = 0;
 
-  /**
-   * @var mixed the accumulator
-   */
-  protected $memo;
+    /**
+     * @var mixed the accumulator
+     */
+    protected $memo;
 
-  /**
-   * AbstractQueryVisitor constructor.
-   */
-  public function __construct() {
+    /**
+     * AbstractQueryVisitor constructor.
+     */
+    public function __construct() {
     $this->memo = $this->initialValue;
-  }
+    }
 
-  /**
-   * @return mixed getter for the memo, in case callers want to inspect it after a process run
-   */
-  public function getMemo() {
+    /**
+     * @return mixed getter for the memo, in case callers want to inspect it after a process run
+     */
+    public function getMemo() {
     return $this->memo;
-  }
+    }
 
-  /**
-   * Visit a query node.  See class docstring.
-   *
-   * @param array       $args
-   * @param FieldConfig $fieldConfig
-   * @param int         $childScore
-   *
-   * @return int|null
-   */
-  abstract public function visit(array $args, FieldConfig $fieldConfig, $childScore = 0);
+    /**
+     * Visit a query node.  See class docstring.
+     *
+     * @param array       $args
+     * @param FieldConfig $fieldConfig
+     * @param int         $childScore
+     *
+     * @return int|null
+     */
+    abstract public function visit(array $args, FieldConfig $fieldConfig, $childScore = 0);
 }
\ No newline at end of file

Tests/Performance/LoadTest.php

Spacing +3 added lines, -3 removed lines

@@ -43,12 +43,12 @@ 
             $authors = [];
             while (count($authors) < rand(1, 4)) {
                 $authors[] = [
-                    'name' => 'Author ' . substr(md5(time()), 0, 4)
+                    'name' => 'Author '.substr(md5(time()), 0, 4)
                 ];
             }
             $data[] = [
                 'id'      => $i,
-                'title'   => 'Title of ' . $i,
+                'title'   => 'Title of '.$i,
                 'authors' => $authors,
             ];
         }
@@ -69,7 +69,7 @@ 
 //        return true;
         $p->processPayload('{ posts { id, title, authors { name } } }');
         $res = $p->getResponseData();
-        echo "Count: " . count($res['data']['posts']) . "\n";
+        echo "Count: ".count($res['data']['posts'])."\n";
         printf("Test Time: %04f\n", microtime(true) - $time);
 //        $p->getResponseData();
     }

Tests/Library/Type/InputObjectTypeTest.php

Unused Use Statements -7 removed lines

@@ -9,13 +9,7 @@ 
 namespace Youshido\Tests\Library\Type;
 
 
-use Youshido\GraphQL\Execution\Context\ExecutionContext;
 use Youshido\GraphQL\Execution\Processor;
-use Youshido\GraphQL\Execution\Request;
-use Youshido\GraphQL\Field\Field;
-use Youshido\GraphQL\Parser\Ast\Argument;
-use Youshido\GraphQL\Parser\Ast\ArgumentValue\Literal;
-use Youshido\GraphQL\Parser\Ast\Query;
 use Youshido\GraphQL\Schema\Schema;
 use Youshido\GraphQL\Type\InputObject\InputObjectType;
 use Youshido\GraphQL\Type\ListType\ListType;
@@ -24,7 +18,6 @@ 
 use Youshido\GraphQL\Type\Scalar\BooleanType;
 use Youshido\GraphQL\Type\Scalar\StringType;
 use Youshido\GraphQL\Type\TypeMap;
-use Youshido\GraphQL\Validator\ResolveValidator\ResolveValidator;
 use Youshido\Tests\DataProvider\TestInputObjectType;
 
 class InputObjectTypeTest extends \PHPUnit_Framework_TestCase

Spacing +4 added lines, -4 removed lines

@@ -60,7 +60,7 @@ 
                 'fields' => [
                     'empty' => [
                         'type'    => new StringType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ]
@@ -79,7 +79,7 @@ 
                             ]))
                         ],
                         'type'    => new BooleanType(),
-                        'resolve' => function ($object, $args) {
+                        'resolve' => function($object, $args) {
                             return true;
                         }
                     ]
@@ -100,7 +100,7 @@ 
                 'fields' => [
                     'empty' => [
                         'type'    => new StringType(),
-                        'resolve' => function () { }
+                        'resolve' => function() { }
                     ],
                 ]
             ]),
@@ -122,7 +122,7 @@ 
                                 ]
                             ])
                         ],
-                        'resolve' => function () { return 'success message'; }
+                        'resolve' => function() { return 'success message'; }
                     ]
                 ]
             ])

src/Type/ListType/AbstractListType.php

Braces +3 added lines, -1 removed lines

@@ -37,7 +37,9 @@
         if ($isValid && $itemType->isInputType()) {
             foreach($value as $item) {
                 $isValid = $itemType->isValidValue($item);
-                if (!$isValid) return false;
+                if (!$isValid) {
+                    return false;
+                }
             }
         }
         return $isValid;

Spacing +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@ 
         $isValid = is_null($value) || is_array($value) || $this->isIterableObject($value);
         $itemType = $this->config->get('itemType');
         if ($isValid && $itemType->isInputType()) {
-            foreach($value as $item) {
+            foreach ($value as $item) {
                 $isValid = $itemType->isValidValue($item);
                 if (!$isValid) return false;
             }
@@ -45,7 +45,7 @@ 
 
     private function isIterableObject($value)
     {
-        if(is_object($value)) {
+        if (is_object($value)) {
             $implements = class_implements($value);
             return isset($implements['Iterator']) || isset($implements['IteratorAggregate']);
         }

src/Introspection/QueryType.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
         if ($value && $value->getKind() == TypeMap::KIND_ENUM) {
             $data = [];
             foreach ($value->getValues() as $enumValue) {
-                if(!$args['includeDeprecated'] && (isset($enumValue['isDeprecated']) && $enumValue['isDeprecated'])) {
+                if (!$args['includeDeprecated'] && (isset($enumValue['isDeprecated']) && $enumValue['isDeprecated'])) {
                     continue;
                 }
 
@@ -91,7 +91,7 @@ 
         }
 
         /** @var AbstractObjectType $value */
-        return array_filter($value->getConfig()->getFields(), function ($field) use ($args) {
+        return array_filter($value->getConfig()->getFields(), function($field) use ($args) {
             /** @var $field Field */
             if (in_array($field->getName(), ['__type', '__schema']) || (!$args['includeDeprecated'] && $field->isDeprecated())) {
                 return false;

src/Validator/ResolveValidator/ResolveValidator.php

Braces +3 added lines, -1 removed lines

@@ -149,7 +149,9 @@
     {
         $unionTypes = $unionType->getTypes();
         $valid      = false;
-        if (empty($unionTypes)) return false;
+        if (empty($unionTypes)) {
+            return false;
+        }
 
         foreach ($unionTypes as $unionType) {
             if ($unionType->getName() == $type->getName()) {

Doc Comments +6 added lines, -2 removed lines

@@ -45,9 +45,9 @@ 
 
     /**
      * @param AbstractObjectType      $objectType
-     * @param Mutation|Query|AstField $field
+     * @param AstField $field
      *
-     * @return null
+     * @return boolean
      */
     public function objectHasField($objectType, $field)
     {
@@ -62,6 +62,7 @@ 
 
     /**
      * @inheritdoc
+     * @param Query $query
      */
     public function validateArguments(FieldInterface $field, $query, Request $request)
     {
@@ -138,6 +139,9 @@ 
         return true;
     }
 
+    /**
+     * @param Request $request
+     */
     private function processInputObject(InputObject $astObject, AbstractInputObjectType $inputObjectType, $request)
     {
         foreach ($astObject->getValue() as $name => $value) {

Spacing +5 added lines, -5 removed lines

@@ -65,11 +65,11 @@ 
      */
     public function validateArguments(FieldInterface $field, $query, Request $request)
     {
-        $requiredArguments = array_filter($field->getArguments(), function (InputField $argument) {
+        $requiredArguments = array_filter($field->getArguments(), function(InputField $argument) {
             return $argument->getType()->getKind() == TypeMap::KIND_NON_NULL;
         });
 
-        $withDefaultArguments = array_filter($field->getArguments(), function (InputField $argument) {
+        $withDefaultArguments = array_filter($field->getArguments(), function(InputField $argument) {
             return $argument->getConfig()->get('default') !== null;
         });
 
@@ -94,7 +94,7 @@ 
                     }
 
                     foreach ($argument->getValue()->getValue() as $item) {
-                        if(!$this->processInputObject($item, $argumentType, $request)) {
+                        if (!$this->processInputObject($item, $argumentType, $request)) {
                             return false;
                         }
                     }
@@ -186,7 +186,7 @@ 
     public function assertTypeImplementsInterface(AbstractType $type, AbstractInterfaceType $interface)
     {
         if (!$interface->isValidValue($type)) {
-            throw new ResolveException('Type ' . $type->getName() . ' does not implement ' . $interface->getName());
+            throw new ResolveException('Type '.$type->getName().' does not implement '.$interface->getName());
         }
     }
 
@@ -205,7 +205,7 @@ 
         }
 
         if (!$valid) {
-            throw new ResolveException('Type ' . $type->getName() . ' not exist in types of ' . $unionType->getName());
+            throw new ResolveException('Type '.$type->getName().' not exist in types of '.$unionType->getName());
         }
     }
 

Tests/Schema/IntrospectionTest.php

Spacing +7 added lines, -7 removed lines

@@ -136,7 +136,7 @@ 
             'description'       => 'latest description',
             'deprecationReason' => 'for test',
             'isDeprecated'      => true,
-            'resolve'           => function () {
+            'resolve'           => function() {
                 return [
                     'id'   => 1,
                     'name' => 'Alex'
@@ -201,9 +201,9 @@ 
                                 ['name' => 'String', 'fields' => null],
                                 ['name' => '__Schema', 'fields' => [['name' => 'queryType', 'args' => []], ['name' => 'mutationType', 'args' => []], ['name' => 'subscriptionType', 'args' => []], ['name' => 'types', 'args' => []], ['name' => 'directives', 'args' => []]]],
                                 ['name' => '__Type', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'kind', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'ofType', 'args' => []], ['name' => 'inputFields', 'args' => []], ['name' => 'enumValues', 'args' => [['defaultValue' => 'false']]], ['name' => 'fields', 'args' => [['defaultValue' => 'false']]], ['name' => 'interfaces', 'args' => []], ['name' => 'possibleTypes', 'args' => []]]],
-                                ['name' => '__InputValue', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'type', 'args' => []], ['name' => 'defaultValue', 'args' => []],]],
+                                ['name' => '__InputValue', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'type', 'args' => []], ['name' => 'defaultValue', 'args' => []], ]],
                                 ['name' => 'Boolean', 'fields' => null],
-                                ['name' => '__EnumValue', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'deprecationReason', 'args' => []], ['name' => 'isDeprecated', 'args' => []],]],
+                                ['name' => '__EnumValue', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'deprecationReason', 'args' => []], ['name' => 'isDeprecated', 'args' => []], ]],
                                 ['name' => '__Field', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'isDeprecated', 'args' => []], ['name' => 'deprecationReason', 'args' => []], ['name' => 'type', 'args' => []], ['name' => 'args', 'args' => []]]],
                                 ['name' => '__Subscription', 'fields' => [['name' => 'name', 'args' => []]]],
                                 ['name' => '__Directive', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'args', 'args' => []], ['name' => 'onOperation', 'args' => []], ['name' => 'onFragment', 'args' => []], ['name' => 'onField', 'args' => []]]],
@@ -291,7 +291,7 @@ 
                 'id'   => ['type' => new IntType()],
                 'name' => ['type' => new IntType()],
             ],
-            'resolveType' => function ($type) {
+            'resolveType' => function($type) {
 
             }
         ]);
@@ -319,7 +319,7 @@ 
         $unionType = new UnionType([
             'name'        => 'UnionType',
             'types'       => [$object1, $object2],
-            'resolveType' => function () {
+            'resolveType' => function() {
 
             }
         ]);
@@ -330,7 +330,7 @@ 
             'args'    => [
                 'id' => ['type' => TypeMap::TYPE_INT]
             ],
-            'resolve' => function () {
+            'resolve' => function() {
                 return [
                     'id'   => 1,
                     'name' => 'Alex'
@@ -356,7 +356,7 @@ 
                     ]
                 ])
             ],
-            'resolve' => function () {
+            'resolve' => function() {
                 return null;
             }
         ]));

src/Type/Object/AbstractObjectType.php

Doc Comments +3 added lines

@@ -87,6 +87,9 @@
         return $this->getConfigValue('interfaces', []);
     }
 
+    /**
+     * @param ObjectType|null $value
+     */
     public function isValidValue($value)
     {
         return is_array($value) || is_null($value) || is_object($value);

src/Field/AbstractField.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
             $config['type'] = $this->getType();
             $config['name'] = $this->getName();
             if (empty($config['name'])) {
-                $config['name'] =$this->getAutoName();
+                $config['name'] = $this->getAutoName();
             }
         }