| Conditions | 1 |
| Paths | 1 |
| Total Lines | 133 |
| Code Lines | 49 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 36 | public function dataProvider() |
||
| 37 | { |
||
| 38 | return [ |
||
| 39 | [ |
||
| 40 | 'query { |
||
| 41 | hero { |
||
| 42 | name |
||
| 43 | } |
||
| 44 | }', |
||
| 45 | ['data' => [ |
||
| 46 | 'hero' => [ |
||
| 47 | 'name' => 'R2-D2' |
||
| 48 | ] |
||
| 49 | ]], |
||
| 50 | [] |
||
| 51 | ], |
||
| 52 | [ |
||
| 53 | 'query { |
||
| 54 | hero { |
||
| 55 | id, |
||
| 56 | name, |
||
| 57 | friends { |
||
| 58 | name |
||
| 59 | } |
||
| 60 | } |
||
| 61 | }', |
||
| 62 | ['data' => [ |
||
| 63 | 'hero' => [ |
||
| 64 | 'id' => '2001', |
||
| 65 | 'name' => 'R2-D2', |
||
| 66 | 'friends' => [ |
||
| 67 | [ |
||
| 68 | 'name' => 'Luke Skywalker', |
||
| 69 | ], |
||
| 70 | [ |
||
| 71 | 'name' => 'Han Solo', |
||
| 72 | ], |
||
| 73 | [ |
||
| 74 | 'name' => 'Leia Organa', |
||
| 75 | ], |
||
| 76 | ] |
||
| 77 | ] |
||
| 78 | ]], |
||
| 79 | [] |
||
| 80 | ], |
||
| 81 | [ |
||
| 82 | '{ |
||
| 83 | hero { |
||
| 84 | name, |
||
| 85 | friends { |
||
| 86 | name, |
||
| 87 | appearsIn, |
||
| 88 | friends { |
||
| 89 | name |
||
| 90 | } |
||
| 91 | } |
||
| 92 | } |
||
| 93 | }', |
||
| 94 | [ |
||
| 95 | 'data' => [ |
||
| 96 | 'hero' => [ |
||
| 97 | 'name' => 'R2-D2', |
||
| 98 | 'friends' => [ |
||
| 99 | [ |
||
| 100 | 'name' => 'Luke Skywalker', |
||
| 101 | 'appearsIn' => ['NEWHOPE', 'EMPIRE', 'JEDI',], |
||
| 102 | 'friends' => [ |
||
| 103 | ['name' => 'Han Solo',], |
||
| 104 | ['name' => 'Leia Organa',], |
||
| 105 | ['name' => 'C-3PO',], |
||
| 106 | ['name' => 'R2-D2',], |
||
| 107 | ], |
||
| 108 | ], |
||
| 109 | [ |
||
| 110 | 'name' => 'Han Solo', |
||
| 111 | 'appearsIn' => ['NEWHOPE', 'EMPIRE', 'JEDI'], |
||
| 112 | 'friends' => [ |
||
| 113 | ['name' => 'Luke Skywalker',], |
||
| 114 | ['name' => 'Leia Organa'], |
||
| 115 | ['name' => 'R2-D2',], |
||
| 116 | ] |
||
| 117 | ], |
||
| 118 | [ |
||
| 119 | 'name' => 'Leia Organa', |
||
| 120 | 'appearsIn' => ['NEWHOPE', 'EMPIRE', 'JEDI'], |
||
| 121 | 'friends' => |
||
| 122 | [ |
||
| 123 | ['name' => 'Luke Skywalker',], |
||
| 124 | ['name' => 'Han Solo',], |
||
| 125 | ['name' => 'C-3PO',], |
||
| 126 | ['name' => 'R2-D2',], |
||
| 127 | ], |
||
| 128 | ], |
||
| 129 | ], |
||
| 130 | ] |
||
| 131 | ] |
||
| 132 | ], |
||
| 133 | [] |
||
| 134 | ], |
||
| 135 | [ |
||
| 136 | '{ |
||
| 137 | human(id: "1000") { |
||
| 138 | name |
||
| 139 | } |
||
| 140 | }', |
||
| 141 | [ |
||
| 142 | 'data' => [ |
||
| 143 | 'human' => [ |
||
| 144 | 'name' => 'Luke Skywalker' |
||
| 145 | ] |
||
| 146 | ] |
||
| 147 | ], |
||
| 148 | [] |
||
| 149 | ], |
||
| 150 | [ |
||
| 151 | '{ |
||
| 152 | human(id: $someId) { |
||
| 153 | name |
||
| 154 | } |
||
| 155 | }', |
||
| 156 | [ |
||
| 157 | 'data' => [ |
||
| 158 | 'human' => [ |
||
| 159 | 'name' => 'Luke Skywalker' |
||
| 160 | ] |
||
| 161 | ] |
||
| 162 | ], |
||
| 163 | [ |
||
| 164 | 'someId' => '1000' |
||
| 165 | ] |
||
| 166 | ] |
||
| 167 | ]; |
||
| 168 | } |
||
| 169 | } |