AbstractInterfaceType - Code Metrics - Inspection of "star wars data fixtures and test" - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d01340...7e7fa7 )

by Portey

created 2015-12-07 16:16 UTC

AbstractInterfaceType A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

70%

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
wmc	8
c	2
b	0
f	1
lcom	1
cbo	3
dl	0
loc	48
ccs	14
cts	20
cp	0.7
rs	10

7 Methods

Rating	Name	Size	Complexity
A	__construct()	8	2
A	checkBuild()	7	2
	build()	1	?
A	resolveType()	4	1
A	getName()	4	1
A	getKind()	4	1
A	isValidValue()	4	1

<?php
/*
* This file is a part of GraphQL project.
*
* @author Alexandr Viniychuk <[email protected]>
* created: 12/5/15 12:12 AM
*/

namespace Youshido\GraphQL\Type\Object;


use Youshido\GraphQL\Type\AbstractType;
use Youshido\GraphQL\Type\Config\Object\InterfaceTypeConfig;
use Youshido\GraphQL\Type\TypeMap;

abstract class AbstractInterfaceType extends AbstractType
{


    /**
     * ObjectType constructor.
     * @param $config
     */
    public function __construct($config = [])
    {
        if (empty($config)) {
            $config['name'] = $this->getName();
        }

        $this->config = new InterfaceTypeConfig($config, $this);

    }

    abstract protected function build(InterfaceTypeConfig $config);

    public function resolveType($object)
    {
        return $object;
    }

    public function checkBuild()
    {
        if (!$this->isBuild) {
            $this->isBuild = true;
            $this->build($this->config);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }

    public function getName()
    {
        return $this->getConfig()->get('name', 'InterfaceType');
    }

    public function getKind()
    {
        return TypeMap::KIND_INTERFACE;
    }

    public function isValidValue($value)
    {
        return true;
    }

}

1		<?php
2		/*
3		* This file is a part of GraphQL project.
4		*
5		* @author Alexandr Viniychuk <[email protected]>
6		* created: 12/5/15 12:12 AM
7		*/
8
9		namespace Youshido\GraphQL\Type\Object;
10
11
12		use Youshido\GraphQL\Type\AbstractType;
13		use Youshido\GraphQL\Type\Config\Object\InterfaceTypeConfig;
14		use Youshido\GraphQL\Type\TypeMap;
15
16		abstract class AbstractInterfaceType extends AbstractType
17		{
18
19
20		/**
21		* ObjectType constructor.
22		* @param $config
23		*/
24	6	public function __construct($config = [])
25		{
26	6	if (empty($config)) {
27	6	$config['name'] = $this->getName();
28	6	}
29
30	6	$this->config = new InterfaceTypeConfig($config, $this);
		0 ignored issues – show Documentation Bug introduced 2015-12-05 05:39 UTC by Report Bug Copy Issue Report It seems like `new \Youshido\GraphQL\Ty...eConfig($config, $this)` of type `object<Youshido\GraphQL\...ct\InterfaceTypeConfig>` is incompatible with the declared type `object<Youshido\GraphQL\...\InputObjectTypeConfig>` of property `$config`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
31	6	}
32
33		abstract protected function build(InterfaceTypeConfig $config);
34
35		public function resolveType($object)
36		{
37		return $object;
38		}
39
40	4	public function checkBuild()
41		{
42	4	if (!$this->isBuild) {
43	4	$this->isBuild = true;
44	4	$this->build($this->config);
		0 ignored issues – show Documentation introduced 2015-12-07 11:40 UTC by Report Bug Copy Issue Report `$this->config` is of type `object<Youshido\GraphQL\...\InputObjectTypeConfig>`, but the function expects a `object<Youshido\GraphQL\...ct\InterfaceTypeConfig>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
45	4	}
46	4	}
47
48		public function getName()
49		{
50		return $this->getConfig()->get('name', 'InterfaceType');
51		}
52
53	4	public function getKind()
54		{
55	4	return TypeMap::KIND_INTERFACE;
56		}
57
58		public function isValidValue($value)
59		{
60		return true;
61		}
62
63		}

Youshido / GraphQL

Push — master ( d01340...7e7fa7 )

AbstractInterfaceType A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like