| Conditions | 1 |
| Paths | 1 |
| Total Lines | 94 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 36 | public function invalidRequestProvider() |
||
| 37 | { |
||
| 38 | $variable1 = (new Variable('test', 'Int', false, false, true, new Location(1, 1)))->setUsed(true); |
||
| 39 | $variable2 = (new Variable('test2', 'Int', false, false, true, new Location(1, 1)))->setUsed(true); |
||
| 40 | $variable3 = (new Variable('test3', 'Int', false, false, true, new Location(1, 1)))->setUsed(false); |
||
| 41 | |||
| 42 | return [ |
||
| 43 | [ |
||
| 44 | new Request([ |
||
| 45 | 'queries' => [ |
||
| 46 | new Query('test', null, [], [ |
||
| 47 | new FragmentReference('reference', new Location(1, 1)) |
||
| 48 | ], [], new Location(1, 1)) |
||
| 49 | ], |
||
| 50 | 'fragmentReferences' => [ |
||
| 51 | new FragmentReference('reference', new Location(1, 1)) |
||
| 52 | ] |
||
| 53 | ]) |
||
| 54 | ], |
||
| 55 | [ |
||
| 56 | new Request([ |
||
| 57 | 'queries' => [ |
||
| 58 | new Query('test', null, [], [ |
||
| 59 | new FragmentReference('reference', new Location(1, 1)), |
||
| 60 | new FragmentReference('reference2', new Location(1, 1)), |
||
| 61 | ], [], new Location(1, 1)) |
||
| 62 | ], |
||
| 63 | 'fragments' => [ |
||
| 64 | new Fragment('reference', 'TestType', [], [], new Location(1, 1)) |
||
| 65 | ], |
||
| 66 | 'fragmentReferences' => [ |
||
| 67 | new FragmentReference('reference', new Location(1, 1)), |
||
| 68 | new FragmentReference('reference2', new Location(1, 1)) |
||
| 69 | ] |
||
| 70 | ]) |
||
| 71 | ], |
||
| 72 | [ |
||
| 73 | new Request([ |
||
| 74 | 'queries' => [ |
||
| 75 | new Query('test', null, [], [ |
||
| 76 | new FragmentReference('reference', new Location(1, 1)), |
||
| 77 | ], [], new Location(1, 1)) |
||
| 78 | ], |
||
| 79 | 'fragments' => [ |
||
| 80 | new Fragment('reference', 'TestType', [], [], new Location(1, 1)), |
||
| 81 | new Fragment('reference2', 'TestType', [], [], new Location(1, 1)) |
||
| 82 | ], |
||
| 83 | 'fragmentReferences' => [ |
||
| 84 | new FragmentReference('reference', new Location(1, 1)) |
||
| 85 | ] |
||
| 86 | ]) |
||
| 87 | ], |
||
| 88 | [ |
||
| 89 | new Request([ |
||
| 90 | 'queries' => [ |
||
| 91 | new Query('test', null, |
||
| 92 | [ |
||
| 93 | new Argument('test', new VariableReference('test', null, new Location(1, 1)), new Location(1, 1)) |
||
| 94 | ], |
||
| 95 | [ |
||
| 96 | new Field('test', null, [], [], new Location(1, 1)) |
||
| 97 | ], |
||
| 98 | [], |
||
| 99 | new Location(1, 1) |
||
| 100 | ) |
||
| 101 | ], |
||
| 102 | 'variableReferences' => [ |
||
| 103 | new VariableReference('test', null, new Location(1, 1)) |
||
| 104 | ] |
||
| 105 | ], ['test' => 1]) |
||
| 106 | ], |
||
| 107 | [ |
||
| 108 | new Request([ |
||
| 109 | 'queries' => [ |
||
| 110 | new Query('test', null, [ |
||
| 111 | new Argument('test', new VariableReference('test', $variable1, new Location(1, 1)), new Location(1, 1)), |
||
| 112 | new Argument('test2', new VariableReference('test2', $variable2, new Location(1, 1)), new Location(1, 1)), |
||
| 113 | ], [ |
||
| 114 | new Field('test', null, [], [], new Location(1, 1)) |
||
| 115 | ], [], new Location(1,1)) |
||
| 116 | ], |
||
| 117 | 'variables' => [ |
||
| 118 | $variable1, |
||
| 119 | $variable2, |
||
| 120 | $variable3 |
||
| 121 | ], |
||
| 122 | 'variableReferences' => [ |
||
| 123 | new VariableReference('test', $variable1, new Location(1, 1)), |
||
| 124 | new VariableReference('test2', $variable2, new Location(1, 1)) |
||
| 125 | ] |
||
| 126 | ], ['test' => 1, 'test2' => 2]) |
||
| 127 | ] |
||
| 128 | ]; |
||
| 129 | } |
||
| 130 | |||
| 132 |