AbstractInputObjectType - Code Metrics - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

AbstractInputObjectType A
last analyzed 2018-07-11 14:00 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	108
Duplicated Lines	8.33 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

86.67%

Importance

Changes

Metric	Value
wmc	23
lcom	1
cbo	8
dl	9
loc	108
ccs	52
cts	60
cp	0.8667
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Duplication	Size	Complexity
	build()	0	1	?
A	getKind()	0	4	1
A	isInputType()	0	4	1
A	getConfig()	9	9	2
A	__construct()	0	9	2
B	isValidValue()	0	42	11
B	parseValue()	0	21	6

How to fix Duplicated Code

<?php
/*
* This file is a part of graphql-youshido project.
*
* @author Alexandr Viniychuk <[email protected]>
* created: 12/2/15 9:00 PM
*/

namespace Youshido\GraphQL\Type\InputObject;


use Youshido\GraphQL\Config\Object\InputObjectTypeConfig;
use Youshido\GraphQL\Field\InputFieldInterface;
use Youshido\GraphQL\Parser\Ast\ArgumentValue\InputObject;
use Youshido\GraphQL\Parser\Ast\ArgumentValue\Variable;
use Youshido\GraphQL\Type\AbstractType;
use Youshido\GraphQL\Type\Traits\AutoNameTrait;
use Youshido\GraphQL\Type\Traits\FieldsAwareObjectTrait;
use Youshido\GraphQL\Type\TypeMap;

abstract class AbstractInputObjectType extends AbstractType
{

    use AutoNameTrait, FieldsAwareObjectTrait;

    protected $isBuilt = false;

    public function getConfig()

    {
        if (!$this->isBuilt) {
            $this->isBuilt = true;
            $this->build($this->config);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $this->config;
    }

    public function __construct($config = [])
    {
        if (empty($config)) {
            $config = [
                'name' => $this->getName()
            ];
        }
        $this->config = new InputObjectTypeConfig($config, $this);
    }

    /**
     * @param InputObjectTypeConfig $config
     */
    abstract public function build($config);

    public function isValidValue($value)
    {
        if ($value instanceof InputObject) {
            $value = $value->getValue();
        }

        if (empty($value)) {
            return true;
        }

        if (!is_array($value)) {
            return false;
        }

        $typeConfig     = $this->getConfig();
        $requiredFields = array_filter($typeConfig->getFields(), function (InputFieldInterface $field) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return $field->getType()->getKind() == TypeMap::KIND_NON_NULL;
        });

        foreach ($value as $valueKey => $valueItem) {
            if (!$typeConfig->hasField($valueKey)) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                // Schema validation will generate the error message for us.
                return false;
            }

            $field = $typeConfig->getField($valueKey);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if (!$field->getType()->isValidValue($valueItem)) {
                $error                     = $field->getType()->getValidationError($valueItem) ?: '(no details available)';
                $this->lastValidationError = sprintf('Not valid type for field "%s" in input type "%s": %s', $field->getName(), $this->getName(), $error);
                return false;
            }

            if (array_key_exists($valueKey, $requiredFields)) {
                unset($requiredFields[$valueKey]);
            }
        }
        if (count($requiredFields)) {
            $this->lastValidationError = sprintf('%s %s required on %s', implode(', ', array_keys($requiredFields)), count($requiredFields) > 1 ? 'are' : 'is', $typeConfig->getName());
        }

        return !(count($requiredFields) > 0);
    }

    public function getKind()
    {
        return TypeMap::KIND_INPUT_OBJECT;
    }

    public function isInputType()
    {
        return true;
    }

    public function parseValue($value)
    {
        if (is_null($value)) return null;
        if($value instanceof InputObject) {
            $value = $value->getValue();
        }

        $typeConfig = $this->getConfig();
        foreach ($value as $valueKey => $item) {
            if ($item instanceof Variable) {
                $item = $item->getValue();
            }

            if (!($inputField = $typeConfig->getField($valueKey))) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                throw new \Exception(sprintf('Invalid field "%s" on %s', $valueKey, $typeConfig->getName()));
            }
            $value[$valueKey] = $inputField->getType()->parseValue($item);
        }

        return $value;
    }

}


1			<?php
2			/*
3			* This file is a part of graphql-youshido project.
4			*
5			* @author Alexandr Viniychuk <[email protected]>
6			* created: 12/2/15 9:00 PM
7			*/
8
9			namespace Youshido\GraphQL\Type\InputObject;
10
11
12			use Youshido\GraphQL\Config\Object\InputObjectTypeConfig;
13			use Youshido\GraphQL\Field\InputFieldInterface;
14			use Youshido\GraphQL\Parser\Ast\ArgumentValue\InputObject;
15			use Youshido\GraphQL\Parser\Ast\ArgumentValue\Variable;
16			use Youshido\GraphQL\Type\AbstractType;
17			use Youshido\GraphQL\Type\Traits\AutoNameTrait;
18			use Youshido\GraphQL\Type\Traits\FieldsAwareObjectTrait;
19			use Youshido\GraphQL\Type\TypeMap;
20
21			abstract class AbstractInputObjectType extends AbstractType
22			{
23
24			use AutoNameTrait, FieldsAwareObjectTrait;
25
26			protected $isBuilt = false;
27
28	8	View Code Duplication	public function getConfig()
			0 ignored issues – show Duplication introduced 2018-05-02 09:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29			{
30	8		if (!$this->isBuilt) {
31	8		$this->isBuilt = true;
32	8		$this->build($this->config);
			0 ignored issues – show Documentation introduced 2017-04-25 04:28 UTC by Report Bug Copy Issue Report `$this->config` is of type `object<Youshido\GraphQL\...Field\InputFieldConfig>`, but the function expects a `object<Youshido\GraphQL\...\InputObjectTypeConfig>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33	8		}
34
35	8		return $this->config;
36			}
37
38	1		public function __construct($config = [])
39			{
40	1		if (empty($config)) {
41			$config = [
42	1		'name' => $this->getName()
43	1		];
44	1		}
45	1		$this->config = new InputObjectTypeConfig($config, $this);
46	1		}
47
48			/**
49			* @param InputObjectTypeConfig $config
50			*/
51			abstract public function build($config);
52
53	7		public function isValidValue($value)
54			{
55	7		if ($value instanceof InputObject) {
56			$value = $value->getValue();
57			}
58
59	7		if (empty($value)) {
60	1		return true;
61			}
62
63	6		if (!is_array($value)) {
64	1		return false;
65			}
66
67	6		$typeConfig = $this->getConfig();
68	6		$requiredFields = array_filter($typeConfig->getFields(), function (InputFieldInterface $field) {
			0 ignored issues – show Documentation Bug introduced 2017-04-25 04:28 UTC by Report Bug Copy Issue Report The method `getFields` does not exist on `object<Youshido\GraphQL\Config\AbstractConfig>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
69	6		return $field->getType()->getKind() == TypeMap::KIND_NON_NULL;
70	6		});
71
72	6		foreach ($value as $valueKey => $valueItem) {
73	6		if (!$typeConfig->hasField($valueKey)) {
			0 ignored issues – show Documentation Bug introduced 2017-06-30 09:31 UTC by Report Bug Copy Issue Report The method `hasField` does not exist on `object<Youshido\GraphQL\Config\AbstractConfig>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
74			// Schema validation will generate the error message for us.
75			return false;
76			}
77
78	6		$field = $typeConfig->getField($valueKey);
			0 ignored issues – show Documentation Bug introduced 2017-06-30 09:31 UTC by Report Bug Copy Issue Report The method `getField` does not exist on `object<Youshido\GraphQL\Config\AbstractConfig>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
79	6		if (!$field->getType()->isValidValue($valueItem)) {
80	3		$error = $field->getType()->getValidationError($valueItem) ?: '(no details available)';
81	3		$this->lastValidationError = sprintf('Not valid type for field "%s" in input type "%s": %s', $field->getName(), $this->getName(), $error);
82	3		return false;
83			}
84
85	5		if (array_key_exists($valueKey, $requiredFields)) {
86	5		unset($requiredFields[$valueKey]);
87	5		}
88	5		}
89	5		if (count($requiredFields)) {
90	1		$this->lastValidationError = sprintf('%s %s required on %s', implode(', ', array_keys($requiredFields)), count($requiredFields) > 1 ? 'are' : 'is', $typeConfig->getName());
91	1		}
92
93	5		return !(count($requiredFields) > 0);
94			}
95
96	9		public function getKind()
97			{
98	9		return TypeMap::KIND_INPUT_OBJECT;
99			}
100
101	2		public function isInputType()
102			{
103	2		return true;
104			}
105
106	4		public function parseValue($value)
107			{
108	4		if (is_null($value)) return null;
109	4		if($value instanceof InputObject) {
110			$value = $value->getValue();
111			}
112
113	4		$typeConfig = $this->getConfig();
114	4		foreach ($value as $valueKey => $item) {
115	3		if ($item instanceof Variable) {
116			$item = $item->getValue();
117			}
118
119	3		if (!($inputField = $typeConfig->getField($valueKey))) {
			0 ignored issues – show Documentation Bug introduced 2017-04-25 04:28 UTC by Report Bug Copy Issue Report The method `getField` does not exist on `object<Youshido\GraphQL\Config\AbstractConfig>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
120			throw new \Exception(sprintf('Invalid field "%s" on %s', $valueKey, $typeConfig->getName()));
121			}
122	3		$value[$valueKey] = $inputField->getType()->parseValue($item);
123	4		}
124
125	4		return $value;
126			}
127
128			}
129

Youshido / GraphQL

AbstractInputObjectType A last analyzed 2018-07-11 14:00 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

AbstractInputObjectType A
last analyzed 2018-07-11 14:00 UTC