FieldsAwareConfigTrait - Code Metrics - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

FieldsAwareConfigTrait A
last analyzed 2018-07-11 14:00 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	117
Duplicated Lines	11.11 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	19
lcom	1
cbo	4
dl	13
loc	117
ccs	47
cts	47
cp	1
rs	10
c	0
b	0
f	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	applyInterface()	0	6	1
A	getField()	0	4	2
A	hasField()	0	4	1
A	hasFields()	0	4	1
A	getFields()	0	4	1
A	buildFields()	0	6	2
A	addFields()	0	17	4
A	addField()	0	10	2
A	buildFieldConfig()	13	13	3
A	removeField()	0	8	2

How to fix Duplicated Code

<?php
/*
* This file is a part of graphql-youshido project.
*
* @author Alexandr Viniychuk <[email protected]>
* created: 12/1/15 11:05 PM
*/

namespace Youshido\GraphQL\Config\Traits;


use Youshido\GraphQL\Field\Field;
use Youshido\GraphQL\Field\FieldInterface;
use Youshido\GraphQL\Field\InputFieldInterface;
use Youshido\GraphQL\Type\InterfaceType\AbstractInterfaceType;

/**
 * Class FieldsAwareTrait
 * @package Youshido\GraphQL\Config\Traits
 */
trait FieldsAwareConfigTrait
{
    protected $fields = [];

    public function buildFields()
    {
        if (!empty($this->data['fields'])) {
            $this->addFields($this->data['fields']);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
    }

    /**
     * Add fields from passed interface
     * @param AbstractInterfaceType $interfaceType
     * @return $this
     */
    public function applyInterface(AbstractInterfaceType $interfaceType)
    {
        $this->addFields($interfaceType->getFields());

        return $this;
    }

    /**
     * @param array $fieldsList
     * @return $this
     */
    public function addFields($fieldsList)
    {
        foreach ($fieldsList as $fieldName => $fieldConfig) {

            if ($fieldConfig instanceof FieldInterface) {
                $this->fields[$fieldConfig->getName()] = $fieldConfig;
                continue;
            } elseif($fieldConfig instanceof InputFieldInterface) {
                $this->fields[$fieldConfig->getName()] = $fieldConfig;
                continue;
            } else {
                $this->addField($fieldName, $this->buildFieldConfig($fieldName, $fieldConfig));
            }
        }

        return $this;
    }

    /**
     * @param FieldInterface|string $field     Field name or Field Object
     * @param mixed                $fieldInfo Field Type or Field Config array
     * @return $this
     */
    public function addField($field, $fieldInfo = null)
    {
        if (!($field instanceof FieldInterface)) {
            $field = new Field($this->buildFieldConfig($field, $fieldInfo));
        }

        $this->fields[$field->getName()] = $field;

        return $this;
    }

    protected function buildFieldConfig($name, $info = null)

    {
        if (!is_array($info)) {
            $info = [
                'type' => $info,
                'name' => $name,
            ];
        } elseif (empty($info['name'])) {
            $info['name'] = $name;
        }

        return $info;
    }

    /**
     * @param $name
     *
     * @return Field
     */
    public function getField($name)
    {
        return $this->hasField($name) ? $this->fields[$name] : null;
    }

    /**
     * @param $name
     *
     * @return bool
     */
    public function hasField($name)
    {
        return array_key_exists($name, $this->fields);
    }

    public function hasFields()
    {
        return !empty($this->fields);
    }

    /**
     * @return Field[]
     */
    public function getFields()
    {
        return $this->fields;
    }

    public function removeField($name)
    {
        if ($this->hasField($name)) {
            unset($this->fields[$name]);
        }

        return $this;
    }
}


1			<?php
2			/*
3			* This file is a part of graphql-youshido project.
4			*
5			* @author Alexandr Viniychuk <[email protected]>
6			* created: 12/1/15 11:05 PM
7			*/
8
9			namespace Youshido\GraphQL\Config\Traits;
10
11
12			use Youshido\GraphQL\Field\Field;
13			use Youshido\GraphQL\Field\FieldInterface;
14			use Youshido\GraphQL\Field\InputFieldInterface;
15			use Youshido\GraphQL\Type\InterfaceType\AbstractInterfaceType;
16
17			/**
18			* Class FieldsAwareTrait
19			* @package Youshido\GraphQL\Config\Traits
20			*/
21			trait FieldsAwareConfigTrait
22			{
23			protected $fields = [];
24
25	121		public function buildFields()
26			{
27	121		if (!empty($this->data['fields'])) {
28	85		$this->addFields($this->data['fields']);
			0 ignored issues – show Bug introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report The property `data` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29	85		}
30	121		}
31
32			/**
33			* Add fields from passed interface
34			* @param AbstractInterfaceType $interfaceType
35			* @return $this
36			*/
37	1		public function applyInterface(AbstractInterfaceType $interfaceType)
38			{
39	1		$this->addFields($interfaceType->getFields());
40
41	1		return $this;
42			}
43
44			/**
45			* @param array $fieldsList
46			* @return $this
47			*/
48	88		public function addFields($fieldsList)
49			{
50	88		foreach ($fieldsList as $fieldName => $fieldConfig) {
51
52	88		if ($fieldConfig instanceof FieldInterface) {
53	9		$this->fields[$fieldConfig->getName()] = $fieldConfig;
54	9		continue;
55	82		} elseif($fieldConfig instanceof InputFieldInterface) {
56	2		$this->fields[$fieldConfig->getName()] = $fieldConfig;
57	2		continue;
58			} else {
59	82		$this->addField($fieldName, $this->buildFieldConfig($fieldName, $fieldConfig));
60			}
61	88		}
62
63	88		return $this;
64			}
65
66			/**
67			* @param FieldInterface\|string $field Field name or Field Object
68			* @param mixed $fieldInfo Field Type or Field Config array
69			* @return $this
70			*/
71	98		public function addField($field, $fieldInfo = null)
72			{
73	98		if (!($field instanceof FieldInterface)) {
74	92		$field = new Field($this->buildFieldConfig($field, $fieldInfo));
75	92		}
76
77	98		$this->fields[$field->getName()] = $field;
78
79	98		return $this;
80			}
81
82	92	View Code Duplication	protected function buildFieldConfig($name, $info = null)
			0 ignored issues – show Duplication introduced 2017-07-31 11:08 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
83			{
84	92		if (!is_array($info)) {
85			$info = [
86	68		'type' => $info,
87	68		'name' => $name,
88	68		];
89	92		} elseif (empty($info['name'])) {
90	76		$info['name'] = $name;
91	76		}
92
93	92		return $info;
94			}
95
96			/**
97			* @param $name
98			*
99			* @return Field
100			*/
101	76		public function getField($name)
102			{
103	76		return $this->hasField($name) ? $this->fields[$name] : null;
104			}
105
106			/**
107			* @param $name
108			*
109			* @return bool
110			*/
111	80		public function hasField($name)
112			{
113	80		return array_key_exists($name, $this->fields);
114			}
115
116	84		public function hasFields()
117			{
118	84		return !empty($this->fields);
119			}
120
121			/**
122			* @return Field[]
123			*/
124	84		public function getFields()
125			{
126	84		return $this->fields;
127			}
128
129	1		public function removeField($name)
130			{
131	1		if ($this->hasField($name)) {
132	1		unset($this->fields[$name]);
133	1		}
134
135	1		return $this;
136			}
137			}
138

Youshido / GraphQL

FieldsAwareConfigTrait A last analyzed 2018-07-11 14:00 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

FieldsAwareConfigTrait A
last analyzed 2018-07-11 14:00 UTC