Yoshi2889 / SMF2.1

Sources/tasks/Birthday-Notify.php

<?php

/**
 * This file contains background notification code
 *
 * Simple Machines Forum (SMF)
 *
 * @package SMF
 * @author Simple Machines https://www.simplemachines.org
 * @copyright 2020 Simple Machines and individual contributors
 * @license https://www.simplemachines.org/about/smf/license.php BSD
 *
 * @version 2.1 RC2
 */

/**
 * Class Birthday_Notify_Background
 */
class Birthday_Notify_Background extends SMF_BackgroundTask
{
    /**
     * This executes the task. It loads up the birthdays, figures out the greeting, etc.
     * @return bool Always returns true
     */
	public function execute()
 	{
		global $txt, $smcFunc, $txtBirthdayEmails, $modSettings, $sourcedir;

		$greeting = isset($modSettings['birthday_email']) ? $modSettings['birthday_email'] : 'happy_birthday';

		// Get the month and day of today.
		$month = date('n'); // Month without leading zeros.
		$day = date('j'); // Day without leading zeros.

		// So who are the lucky ones?  Don't include those who are banned and those who don't want them.
		$result = $smcFunc['db_query']('', '
			SELECT id_member, real_name, lngfile, email_address
			FROM {db_prefix}members
			WHERE is_activated < 10
				AND MONTH(birthdate) = {int:month}
				AND DAYOFMONTH(birthdate) = {int:day}
				AND YEAR(birthdate) > {int:year}
				' . ($smcFunc['db_title'] === POSTGRE_TITLE ? 'AND indexable_month_day(birthdate) = indexable_month_day({date:bdate})' : ''),
			array(
				'year' => 1004,
				'month' => $month,
				'day' => $day,
				'bdate' => '1004-' . $month . '-' . $day, // a random leap year is here needed
			)
		);

		// Group them by languages.
		$birthdays = array();
		while ($row = $smcFunc['db_fetch_assoc']($result))
		{
			if (!isset($birthdays[$row['lngfile']]))
				$birthdays[$row['lngfile']] = array();
			$birthdays[$row['lngfile']][$row['id_member']] = array(
				'name' => $row['real_name'],
				'email' => $row['email_address']
			);
		}
		$smcFunc['db_free_result']($result);

		if (!empty($birthdays))
		{
			require_once($sourcedir . '/ScheduledTasks.php');
			loadEssentialThemeData();
			// We need this for sendmail and AddMailQueue
			require_once($sourcedir . '/Subs-Post.php');

			// Send out the greetings!
			foreach ($birthdays as $lang => $members)
			{
				// We need to do some shuffling to make this work properly.
				loadLanguage('EmailTemplates', $lang);
				$txt['happy_birthday_subject'] = $txtBirthdayEmails[$greeting . '_subject'];
				$txt['happy_birthday_body'] = $txtBirthdayEmails[$greeting . '_body'];
				require_once($sourcedir . '/Subs-Notify.php');

				$prefs = getNotifyPrefs(array_keys($members), array('birthday'), true);

				foreach ($members as $member_id => $member)
				{
					$pref = !empty($prefs[$member_id]['birthday']) ? $prefs[$member_id]['birthday'] : 0;

					// Let's load replacements ahead
					$replacements = array(
						'REALNAME' => $member['name'],
					);

					if ($pref & self::RECEIVE_NOTIFY_ALERT)
					{
						$alertdata = loadEmailTemplate('happy_birthday', $replacements, $lang, false);
						// For the alerts, we need to replace \n line breaks with <br> line breaks.
						// For space saving sake, we'll be removing extra line breaks
						$alertdata['body'] = preg_replace("~\s*[\r\n]+\s*~", '<br>', $alertdata['body']);
						$alert_rows[] = array(
							'alert_time' => time(),
							'id_member' => $member_id,
							'content_type' => 'birthday',
							'content_id' => 0,
							'content_action' => 'msg',
							'is_read' => 0,
							'extra' => $smcFunc['json_encode'](array('happy_birthday' => $alertdata['body'])),
						);
					}

					if ($pref & self::RECEIVE_NOTIFY_EMAIL)
					{
						$emaildata = loadEmailTemplate('happy_birthday', $replacements, $lang, false);
						sendmail($member['email'], $emaildata['subject'], $emaildata['body'], null, 'birthday', $emaildata['is_html'], 4);
					}
				}
			}

			// Flush the mail queue, just in case.
			AddMailQueue(true);

			// Insert the alerts if any
			if (!empty($alert_rows))
			{
				$smcFunc['db_insert']('',
					'{db_prefix}user_alerts',
					array(
						'alert_time' => 'int', 'id_member' => 'int', 'content_type' => 'string',
						'content_id' => 'int', 'content_action' => 'string', 'is_read' => 'int', 'extra' => 'string',
					),
					$alert_rows,
					array()
				);

				updateMemberData(array_keys($members), array('alerts' => '+'));

The variable $members seems to be defined by a foreach iteration on line 73. Are you sure the iterator is never empty, otherwise this variable is not defined?

			}
		}

		return true;
	}
}

?>