ListView::process() - Code Metrics - Inspection of "ListView" - YetiForceCompany/YetiForcePortal2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — developer ( a79ea2...2ba598 )

by Mariusz

created 2021-05-13 09:05 UTC

ListView::process() A

↳ Parent: ListView

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.6333
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php
/**
 * List view action file.
 *
 * @package Action
 *
 * @copyright YetiForce Sp. z o.o.
 * @license   YetiForce Public License 3.0 (licenses/LicenseEN.txt or yetiforce.com)
 * @author Mariusz Krzaczkowski <[email protected]>
 */

namespace YF\Modules\Base\Action;

use App\Purifier;

/**
 * List view action class.
 */
class ListView extends \App\Controller\Action
{
	/** {@inheritdoc} */
	public function process(): void
	{
		$moduleName = $this->request->getModule();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$record = $this->request->getByType('record', Purifier::INTEGER);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$templates = $this->request->getArray('templates', Purifier::INTEGER);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		$count = $logsCountAll = 0;
		$rows = $columns = [];
		foreach ($this->request->getArray('columns') as $key => $value) {
			$columns[$key] = $value['name'];
		}
		header('content-type: text/json; charset=UTF-8');
		echo \App\Json::encode([
			'draw' => $this->request->getInteger('draw'),
			'iTotalRecords' => $logsCountAll,
			'iTotalDisplayRecords' => $count,
			'aaData' => $rows
		]);
	}
}


1			<?php
2			/**
3			* List view action file.
4			*
5			* @package Action
6			*
7			* @copyright YetiForce Sp. z o.o.
8			* @license YetiForce Public License 3.0 (licenses/LicenseEN.txt or yetiforce.com)
9			* @author Mariusz Krzaczkowski <[email protected]>
10			*/
11
12			namespace YF\Modules\Base\Action;
13
14			use App\Purifier;
15
16			/**
17			* List view action class.
18			*/
19			class ListView extends \App\Controller\Action
20			{
21			/** {@inheritdoc} */
22			public function process(): void
23			{
24			$moduleName = $this->request->getModule();
			0 ignored issues – show Unused Code introduced 2021-05-13 12:55 UTC by Report Bug Copy Issue Report `$moduleName` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
25			$record = $this->request->getByType('record', Purifier::INTEGER);
			0 ignored issues – show Unused Code introduced 2021-05-13 12:55 UTC by Report Bug Copy Issue Report `$record` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
26			$templates = $this->request->getArray('templates', Purifier::INTEGER);
			0 ignored issues – show Unused Code introduced 2021-05-13 12:55 UTC by Report Bug Copy Issue Report `$templates` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
27
28			$count = $logsCountAll = 0;
29			$rows = $columns = [];
30			foreach ($this->request->getArray('columns') as $key => $value) {
31			$columns[$key] = $value['name'];
32			}
33			header('content-type: text/json; charset=UTF-8');
34			echo \App\Json::encode([
35			'draw' => $this->request->getInteger('draw'),
36			'iTotalRecords' => $logsCountAll,
37			'iTotalDisplayRecords' => $count,
38			'aaData' => $rows
39			]);
40			}
41			}
42

YetiForceCompany / YetiForcePortal2

Push — developer ( a79ea2...2ba598 )

ListView::process() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like