YetiForceCompany / YetiForceCRM

modules/Emails/Emails.php

Doc Comments +6 added lines

@@ -519,6 +519,9 @@ 
 		return $query;
 	}
 
+	/**
+	 * @param string $tableName
+	 */
 	protected function setupTemporaryTable($tableName, $tabId, $user, $parentRole, $userGroups)
 	{
 		$module = null;
@@ -619,6 +622,9 @@ 
 }
 
 //added for attach the generated pdf with email
+/**
+ * @param Emails $obj
+ */
 function pdfAttach($obj, $module, $file_name, $id)
 {
 	$log = vglobal('log');

Spacing +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
 				$mysql = 'insert into vtiger_seactivityrel values(?,?)';
 				$adb->pquery($mysql, array($parentid, $actid));
 			} else {
-				$myids = explode("|", $parentid);  //2@71|
+				$myids = explode("|", $parentid); //2@71|
 				for ($i = 0; $i < (count($myids) - 1); $i++) {
 					$realid = explode("@", $myids[$i]);
 					$mycrmid = $realid[0];

Braces +45 added lines, -32 removed lines

@@ -180,16 +180,18 @@ 
 		$filepart = $file_details['part'];
 		$transfer = $file_details['transfer'];
 		$file = imap_fetchbody($mail, $_REQUEST['mailid'], $filepart);
-		if ($transfer == 'BASE64')
-			$file = imap_base64($file);
-		elseif ($transfer == 'QUOTED-PRINTABLE')
-			$file = imap_qprint($file);
+		if ($transfer == 'BASE64') {
+					$file = imap_base64($file);
+		} elseif ($transfer == 'QUOTED-PRINTABLE') {
+					$file = imap_qprint($file);
+		}
 		$current_id = $adb->getUniqueID("vtiger_crmentity");
 		$date_var = date('Y-m-d H:i:s');
 		//to get the owner id
 		$ownerid = $this->column_fields['assigned_user_id'];
-		if (!isset($ownerid) || $ownerid == '')
-			$ownerid = $current_user->id;
+		if (!isset($ownerid) || $ownerid == '') {
+					$ownerid = $current_user->id;
+		}
 		$upload_file_path = \vtlib\Functions::initStorageFileDirectory();
 		file_put_contents($upload_file_path . $current_id . "_" . $filename, $file);
 
@@ -239,8 +241,9 @@ 
 		$button = '';
 
 		if ($actions) {
-			if (is_string($actions))
-				$actions = explode(',', strtoupper($actions));
+			if (is_string($actions)) {
+							$actions = explode(',', strtoupper($actions));
+			}
 			if (in_array('SELECT', $actions) && isPermitted($related_module, 4, '') == 'yes') {
 				$button .= "<input title='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "' class='crmbutton small edit' type='button' onclick=\"return window.open('index.php?module=$related_module&return_module=$currentModule&action=Popup&popuptype=detailview&select=enable&form=EditView&form_submit=false&recordid=$id','test','width=640,height=602,resizable=0,scrollbars=0');\" value='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "'>&nbsp;";
 			}
@@ -277,8 +280,9 @@ 
 
 		$return_value = GetRelatedList($this_module, $related_module, $other, $query, $button, $returnset);
 
-		if ($return_value == null)
-			$return_value = Array();
+		if ($return_value == null) {
+					$return_value = Array();
+		}
 		$return_value['CUSTOM_BUTTON'] = $button;
 
 		$log->debug("Exiting get_contacts method ...");
@@ -294,10 +298,11 @@ 
 	{
 		$log = vglobal('log');
 		$log->debug("Entering getSortOrder() method ...");
-		if (isset($_REQUEST['sorder']))
-			$sorder = $this->db->sql_escape_string($_REQUEST['sorder']);
-		else
-			$sorder = (($_SESSION['EMAILS_SORT_ORDER'] != '') ? ($_SESSION['EMAILS_SORT_ORDER']) : ($this->default_sort_order));
+		if (isset($_REQUEST['sorder'])) {
+					$sorder = $this->db->sql_escape_string($_REQUEST['sorder']);
+		} else {
+					$sorder = (($_SESSION['EMAILS_SORT_ORDER'] != '') ? ($_SESSION['EMAILS_SORT_ORDER']) : ($this->default_sort_order));
+		}
 
 		$log->debug("Exiting getSortOrder method ...");
 		return $sorder;
@@ -318,10 +323,11 @@ 
 			$use_default_order_by = $this->default_order_by;
 		}
 
-		if (isset($_REQUEST['order_by']))
-			$order_by = $this->db->sql_escape_string($_REQUEST['order_by']);
-		else
-			$order_by = (($_SESSION['EMAILS_ORDER_BY'] != '') ? ($_SESSION['EMAILS_ORDER_BY']) : ($use_default_order_by));
+		if (isset($_REQUEST['order_by'])) {
+					$order_by = $this->db->sql_escape_string($_REQUEST['order_by']);
+		} else {
+					$order_by = (($_SESSION['EMAILS_ORDER_BY'] != '') ? ($_SESSION['EMAILS_ORDER_BY']) : ($use_default_order_by));
+		}
 
 		$log->debug("Exiting getOrderBy method ...");
 		return $order_by;
@@ -376,25 +382,31 @@ 
 			$entries[] = $row['user_name'];
 			$entries[] = $row['email1'];
 			$entries[] = $row['phone_home'];
-			if ($phone == '')
-				$phone = $row['phone_work'];
-			if ($phone == '')
-				$phone = $row['phone_mobile'];
-			if ($phone == '')
-				$phone = $row['phone_other'];
-			if ($phone == '')
-				$phone = $row['phone_fax'];
+			if ($phone == '') {
+							$phone = $row['phone_work'];
+			}
+			if ($phone == '') {
+							$phone = $row['phone_mobile'];
+			}
+			if ($phone == '') {
+							$phone = $row['phone_other'];
+			}
+			if ($phone == '') {
+							$phone = $row['phone_fax'];
+			}
 
 			//Adding Security Check for User
 
 			$entries_list[] = $entries;
 		}
 
-		if ($entries_list != '')
-			$return_data = array("header" => $header, "entries" => $entries);
+		if ($entries_list != '') {
+					$return_data = array("header" => $header, "entries" => $entries);
+		}
 
-		if ($return_data == null)
-			$return_data = Array();
+		if ($return_data == null) {
+					$return_data = Array();
+		}
 		$return_data['CUSTOM_BUTTON'] = $button;
 
 		$log->debug("Exiting get_users method ...");
@@ -630,8 +642,9 @@ 
 	$date_var = date('Y-m-d H:i:s');
 
 	$ownerid = $obj->column_fields['assigned_user_id'];
-	if (!isset($ownerid) || $ownerid == '')
-		$ownerid = $current_user->id;
+	if (!isset($ownerid) || $ownerid == '') {
+			$ownerid = $current_user->id;
+	}
 
 	$current_id = $adb->getUniqueID("vtiger_crmentity");
 

modules/Emails/mail.php

Doc Comments +10 added lines

@@ -103,6 +103,7 @@ 
 /** 	Function to get the user Email id based on column name and column value
  * 	$name -- column name of the vtiger_users vtiger_table
  * 	$val  -- column value
+ * @param string $name
  */
 function getUserEmailId($name, $val)
 {
@@ -162,6 +163,8 @@ 
  * 	$attachment	-- whether we want to attach the currently selected file or all vtiger_files.
   [values = current,all] - optional
  * 	$emailid	-- id of the email object which will be used to get the vtiger_attachments - optional
+ * @param PHPMailer $mail
+ * @param string $to_email
  */
 function setMailerProperties($mail, $subject, $contents, $fromEmail, $fromName, $to_email, $attachment = '', $emailid = '', $module = '', $logo = '')
 {
@@ -297,6 +300,7 @@ 
  * 	$mail -- reference of the mail object
  * 	$filename -- filename which is going to added with the mail
  * 	$record -- id of the record - optional
+ * @param string $record
  */
 function addAttachment($mail, $filename, $record)
 {
@@ -313,6 +317,7 @@ 
 /**     Function to add all the vtiger_files as attachment with the mail object
  *     $mail -- reference of the mail object
  *     $record -- email id ie., record id which is used to get the all vtiger_attachments from database
+ * @param string $record
  */
 function addAllAttachments($mail, $record)
 {
@@ -347,6 +352,9 @@ 
  * 	$mail -- reference of the mail object
  * 	$cc_mod -- mode to set the address ie., cc or bcc
  * 	$cc_val -- addresss with comma seperated to set as CC or BCC in the mail
+ * @param PHPMailer $mail
+ * @param string $cc_mod
+ * @param string $cc_val
  */
 function setCCAddress($mail, $cc_mod, $cc_val)
 {
@@ -375,6 +383,7 @@ 
 
 /** 	Function to send the mail which will be called after set all the mail object values
  * 	$mail -- reference of the mail object
+ * @param PHPMailer $mail
  */
 function MailSend($mail)
 {
@@ -423,6 +432,7 @@ 
  * 	$mail_status -- status of the mail which is sent or not
  * 	$to -- the email address to whom we sent the mail and failes
  * 	return -- Mail error occured during the mail sending process
+ * @param PHPMailer $mail
  */
 function getMailError($mail, $mail_status, $to)
 {

Spacing +5 added lines, -5 removed lines

@@ -179,7 +179,7 @@ 
 	$mail->Body = decode_html($contents);
 	$mail->AltBody = strip_tags(preg_replace(array("/<p>/i", "/<br>/i", "/<br \/>/i"), array("\n", "\n", "\n"), $contents));
 
-	$mail->IsSMTP();  //set mailer to use SMTP
+	$mail->IsSMTP(); //set mailer to use SMTP
 
 	setMailServerProperties($mail);
 
@@ -230,7 +230,7 @@ 
 		addAllAttachments($mail, $emailid);
 	}
 
-	$mail->IsHTML(true);  // set email format to HTML
+	$mail->IsHTML(true); // set email format to HTML
 
 	return;
 }
@@ -278,7 +278,7 @@ 
 	if ($smtp_auth) {
 		$mail->SMTPAuth = true; // turn on SMTP authentication
 	}
-	$mail->Host = $server;  // specify main and backup server
+	$mail->Host = $server; // specify main and backup server
 	$mail->Username = $username; // SMTP username
 	$mail->Password = $password; // SMTP password
 	// To Support TLS
@@ -525,8 +525,8 @@ 
 
 function isUserInitiated()
 {
-	return ( AppRequest::get('module') == 'Emails' &&
-		( AppRequest::get('action') == 'mailsend' || AppRequest::get('action') == 'Save'));
+	return (AppRequest::get('module') == 'Emails' &&
+		(AppRequest::get('action') == 'mailsend' || AppRequest::get('action') == 'Save'));
 }
 
 /**

Braces +31 added lines, -24 removed lines

@@ -245,27 +245,30 @@ 
 	$log->debug('Inside the function setMailServerProperties');
 
 	$res = $adb->pquery('select * from vtiger_systems where server_type=?', array('email'));
-	if (AppRequest::has('server'))
-		$server = AppRequest::get('server');
-	else
-		$server = $adb->query_result_raw($res, 0, 'server');
-	if (AppRequest::has('server_username'))
-		$username = AppRequest::get('server_username');
-	else
-		$username = $adb->query_result_raw($res, 0, 'server_username');
-
-	if (AppRequest::has('server_password'))
-		$password = AppRequest::get('server_password');
-	else
-		$password = $adb->query_result_raw($res, 0, 'server_password');
+	if (AppRequest::has('server')) {
+			$server = AppRequest::get('server');
+	} else {
+			$server = $adb->query_result_raw($res, 0, 'server');
+	}
+	if (AppRequest::has('server_username')) {
+			$username = AppRequest::get('server_username');
+	} else {
+			$username = $adb->query_result_raw($res, 0, 'server_username');
+	}
+
+	if (AppRequest::has('server_password')) {
+			$password = AppRequest::get('server_password');
+	} else {
+			$password = $adb->query_result_raw($res, 0, 'server_password');
+	}
 
 	// Define default state
 	$smtp_auth = false;
 
 	// Prasad: First time read smtp_auth from the request
-	if (AppRequest::get('smtp_auth') == 'on')
-		$smtp_auth = true;
-	else if (AppRequest::get('module') == 'Settings' && (!AppRequest::has('smtp_auth'))) {
+	if (AppRequest::get('smtp_auth') == 'on') {
+			$smtp_auth = true;
+	} else if (AppRequest::get('module') == 'Settings' && (!AppRequest::has('smtp_auth'))) {
 		//added to avoid issue while editing the values in the outgoing mail server.
 		$smtp_auth = false;
 	} else {
@@ -353,10 +356,12 @@ 
 	$log = LoggerManager::getInstance();
 	$log->debug('Inside the functin setCCAddress');
 
-	if ($cc_mod == 'cc')
-		$method = 'AddCC';
-	if ($cc_mod == 'bcc')
-		$method = 'AddBCC';
+	if ($cc_mod == 'cc') {
+			$method = 'AddCC';
+	}
+	if ($cc_mod == 'bcc') {
+			$method = 'AddBCC';
+	}
 	if ($cc_val != '') {
 		$ccmail = explode(",", trim($cc_val, ","));
 		for ($i = 0; $i < count($ccmail); $i++) {
@@ -367,8 +372,9 @@ 
 				$cc_name = $name_addr_pair[0];
 				$addr = trim($name_addr_pair[1], ">");
 			}
-			if ($ccmail[$i] != '')
-				$mail->$method($addr, $cc_name);
+			if ($ccmail[$i] != '') {
+							$mail->$method($addr, $cc_name);
+			}
 		}
 	}
 }
@@ -541,8 +547,9 @@ 
 		$userGroups = new GetGroupUsers();
 		$userGroups->getAllUsersInGroup($groupId);
 
-		if (count($userGroups->group_users) == 0)
-			return [];
+		if (count($userGroups->group_users) == 0) {
+					return [];
+		}
 
 		$query = sprintf('SELECT 
 					email1 

modules/HelpDesk/dashboards/TicketsByStatus.php

Doc Comments -1 removed lines

@@ -27,7 +27,6 @@
 
 	/**
 	 * Function returns Tickets grouped by Status
-	 * @param type $data
 	 * @return <Array>
 	 */
 	public function getTicketsByStatus($owner)

Braces +17 added lines, -12 removed lines

@@ -19,8 +19,9 @@ 
 
 		$listSearchParams = [];
 		$conditions = array(array('ticketstatus', 'e', $value));
-		if (!empty($assignedto))
-			array_push($conditions, array('assigned_user_id', 'e', $assignedto));
+		if (!empty($assignedto)) {
+					array_push($conditions, array('assigned_user_id', 'e', $assignedto));
+		}
 		$listSearchParams[] = $conditions;
 		return '&viewname=All&search_params=' . json_encode($listSearchParams);
 	}
@@ -62,8 +63,9 @@ 
 			$sql .= " && vtiger_troubletickets.status NOT IN ('$ticketStatusSearch')";
 			$this->conditions = ['vtiger_troubletickets.status', "'$ticketStatusSearch'", 'nin', QueryGenerator::$AND];
 		}
-		if (!empty($securityParameter))
-			$sql .= $securityParameter;
+		if (!empty($securityParameter)) {
+					$sql .= $securityParameter;
+		}
 
 
 		$sql .= ' GROUP BY statusvalue, priority ORDER BY vtiger_ticketstatus.sortorderid';
@@ -78,8 +80,9 @@ 
 				$priorities[$row['priority']] = $counter++;
 				$colors[$row['priority']] = $row['color'];
 			}
-			if (!in_array($row['statusvalue'], $status))
-				$status[] = $row['statusvalue'];
+			if (!in_array($row['statusvalue'], $status)) {
+							$status[] = $row['statusvalue'];
+			}
 		}
 		if (!empty($tickets)) {
 			$counter = 0;
@@ -123,13 +126,15 @@ 
 		$data = $request->get('data');
 		$createdTime = $request->get('createdtime');
 		$widget = Vtiger_Widget_Model::getInstance($linkId, $currentUser->getId());
-		if (!$request->has('owner'))
-			$owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget, $moduleName);
-		else
-			$owner = $request->get('owner');
+		if (!$request->has('owner')) {
+					$owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget, $moduleName);
+		} else {
+					$owner = $request->get('owner');
+		}
 		$ownerForwarded = $owner;
-		if ($owner == 'all')
-			$owner = '';
+		if ($owner == 'all') {
+					$owner = '';
+		}
 
 		//Date conversion from user to database format
 		if (!empty($createdTime)) {

modules/Import/views/Main.php

Doc Comments +9 added lines

@@ -27,6 +27,9 @@ 
 		$this->user = $user;
 	}
 
+	/**
+	 * @param Vtiger_Request $request
+	 */
 	public static function import($request, $user)
 	{
 		$importController = new Import_Main_View($request, $user);
@@ -100,6 +103,9 @@ 
 		}
 	}
 
+	/**
+	 * @param boolean $continueImport
+	 */
 	public static function showCurrentStatus($importInfo, $importStatusCount, $continueImport)
 	{
 		$moduleName = $importInfo['module'];
@@ -210,6 +216,9 @@ 
 		Import_Queue_Action::add($this->request, $this->user);
 	}
 
+	/**
+	 * @param Vtiger_Request $request
+	 */
 	public static function deleteMap($request)
 	{
 		$moduleName = $request->getModule();

modules/ModComments/ModComments.php

Doc Comments +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
 
 	/**
 	 * Add widget to other module.
-	 * @param unknown_type $moduleNames
+	 * @param string[] $moduleNames
 	 * @return unknown_type
 	 */
 	static function addWidgetTo($moduleNames, $widgetType = 'DETAILVIEWWIDGET', $widgetName = 'DetailViewBlockCommentWidget')

Braces +12 added lines, -8 removed lines

@@ -64,11 +64,13 @@ 
 	 */
 	static function addWidgetTo($moduleNames, $widgetType = 'DETAILVIEWWIDGET', $widgetName = 'DetailViewBlockCommentWidget')
 	{
-		if (empty($moduleNames))
-			return;
+		if (empty($moduleNames)) {
+					return;
+		}
 
-		if (is_string($moduleNames))
-			$moduleNames = array($moduleNames);
+		if (is_string($moduleNames)) {
+					$moduleNames = array($moduleNames);
+		}
 
 		$commentWidgetModules = array();
 		foreach ($moduleNames as $moduleName) {
@@ -95,11 +97,13 @@ 
 	 */
 	static function removeWidgetFrom($moduleNames, $widgetType = 'DETAILVIEWWIDGET', $widgetName = 'DetailViewBlockCommentWidget')
 	{
-		if (empty($moduleNames))
-			return;
+		if (empty($moduleNames)) {
+					return;
+		}
 
-		if (is_string($moduleNames))
-			$moduleNames = array($moduleNames);
+		if (is_string($moduleNames)) {
+					$moduleNames = array($moduleNames);
+		}
 
 		$commentWidgetModules = array();
 		foreach ($moduleNames as $moduleName) {

modules/OSSEmployees/OSSEmployees.php

Doc Comments +7 added lines

@@ -149,6 +149,10 @@ 
 		return $hierarchy;
 	}
 
+	/**
+	 * @param integer $id
+	 * @param integer[] $encountered_accounts
+	 */
 	public function __getParentEmployees($id, &$parent_accounts, &$encountered_accounts)
 	{
 		$adb = PearDatabase::getInstance();
@@ -200,6 +204,9 @@ 
 		return $parent_accounts;
 	}
 
+	/**
+	 * @param integer $id
+	 */
 	public function __getChildEmployees($id, &$child_accounts, $depth)
 	{
 		$adb = PearDatabase::getInstance();

Braces +14 added lines, -10 removed lines

@@ -284,16 +284,18 @@ 
 
 
 
-		if ($singlepane_view == 'true')
-			$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
-		else
-			$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		if ($singlepane_view == 'true') {
+					$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
+		} else {
+					$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		}
 
 		$button = '';
 
 		if ($actions && getFieldVisibilityPermission($related_module, $current_user->id, 'parent_id', 'readwrite') == '0') {
-			if (is_string($actions))
-				$actions = explode(',', strtoupper($actions));
+			if (is_string($actions)) {
+							$actions = explode(',', strtoupper($actions));
+			}
 			if (in_array('SELECT', $actions) && isPermitted($related_module, 4, '') == 'yes') {
 				$button .= "<input title='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "' class='crmbutton small edit' type='button' onclick=\"return window.open('index.php?module=$related_module&return_module=$currentModule&action=Popup&popuptype=detailview&select=enable&form=EditView&form_submit=false&recordid=$id','test','width=640,height=602,resizable=0,scrollbars=0');\" value='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "'>&nbsp;";
 			}
@@ -316,8 +318,9 @@ 
 				WHERE  vtiger_crmentity.deleted = 0 && vtiger_crmentity.`smownerid`= " . $userId;
 
 		$return_value = GetRelatedList($this_module, $related_module, $other, $query, $button, $returnset);
-		if ($return_value == null)
-			$return_value = Array();
+		if ($return_value == null) {
+					$return_value = Array();
+		}
 		$return_value['CUSTOM_BUTTON'] = $button;
 		$log->debug("Exiting get_osstimecontrol method ...");
 		return $return_value;
@@ -336,8 +339,9 @@ 
 			$modcommentsModuleInstance = vtlib\Module::getInstance('ModComments');
 			if ($modcommentsModuleInstance && file_exists('modules/ModComments/ModComments.php')) {
 				include_once 'modules/ModComments/ModComments.php';
-				if (class_exists('ModComments'))
-					ModComments::addWidgetTo(array('OSSEmployees'));
+				if (class_exists('ModComments')) {
+									ModComments::addWidgetTo(array('OSSEmployees'));
+				}
 			}
 			// blok EH
 		} else if ($event_type == 'module.disabled') {

modules/PaymentsIn/helpers/mt940.php

Doc Comments +15 added lines

@@ -50,6 +50,9 @@ 
 		return $xml;
 	}
 
+	/**
+	 * @param integer $level
+	 */
 	protected function createXML($key, $value, $level)
 	{
 		$indent = '';
@@ -69,6 +72,9 @@ 
 		return $xml;
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -114,6 +120,9 @@ 
 		$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(
@@ -124,6 +133,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseBalance($value)
 	{
 		return array(
@@ -134,6 +146,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseTransaction($value)
 	{
 		$transaction = array(

Braces +19 added lines, -14 removed lines

@@ -34,8 +34,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	public function getXML()
@@ -53,13 +54,15 @@ 
 	protected function createXML($key, $value, $level)
 	{
 		$indent = '';
-		for ($i = 0; $i <= $level; $i++)
-			$indent .= "\t";
+		for ($i = 0; $i <= $level; $i++) {
+					$indent .= "\t";
+		}
 		if (is_array($value)) {
 			$xml = "$indent<$key>\n";
 			foreach ($value as $subKey => $subVal) {
-				if (is_numeric($subKey))
-					$subKey = substr($key, 0, -1);
+				if (is_numeric($subKey)) {
+									$subKey = substr($key, 0, -1);
+				}
 				$xml .= $this->createXML($subKey, $subVal, $level + 1);
 			}
 			$xml .= "$indent</$key>\n";
@@ -85,10 +88,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -103,10 +107,11 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == '61')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == '61') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;

modules/PaymentsIn/helpers/subclass/mt940_Milenium.php

Doc Comments +6 added lines

@@ -20,6 +20,9 @@ 
 			$this->parseLine($line);
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -65,6 +68,9 @@ 
 		$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(

Braces +13 added lines, -10 removed lines

@@ -16,8 +16,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	protected function parseLine($line)
@@ -36,10 +37,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -54,10 +56,11 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == '61')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == '61') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;

modules/PaymentsIn/helpers/subclass/mt940_WBK.php

Doc Comments +9 added lines

@@ -20,6 +20,9 @@ 
 			$this->parseLine($line);
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -65,6 +68,9 @@ 
 		$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseTransaction($value)
 	{
 		$transaction = array(
@@ -109,6 +115,9 @@ 
 		$this->operations[count($this->operations) - 1]['details'] = $transaction;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(

Braces +13 added lines, -10 removed lines

@@ -16,8 +16,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	protected function parseLine($line)
@@ -36,10 +37,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -54,10 +56,11 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == '61')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == '61') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;