YetiForceCompany / YetiForceCRM

include/QueryGenerator/QueryGenerator.php

Braces +44 added lines, -30 removed lines

@@ -306,8 +306,9 @@ 
 
 	public function parseAdvFilterList($advFilterList, $glue = '')
 	{
-		if (!empty($glue))
-			$this->addConditionGlue($glue);
+		if (!empty($glue)) {
+					$this->addConditionGlue($glue);
+		}
 
 		$customView = new CustomView($this->module);
 		$dateSpecificConditions = $customView->getStdFilterConditions();
@@ -318,8 +319,9 @@ 
 				foreach ($filtercolumns as $index => $filter) {
 					$nameComponents = explode(':', $filter['columnname']);
 					// For Events "End Date & Time" field datatype should be DT. But, db will give D for due_date field
-					if ($nameComponents[2] == 'due_date' && $nameComponents[3] == 'Events_End_Date_&_Time')
-						$nameComponents[4] = 'DT';
+					if ($nameComponents[2] == 'due_date' && $nameComponents[3] == 'Events_End_Date_&_Time') {
+											$nameComponents[4] = 'DT';
+					}
 					if (empty($nameComponents[2]) && $nameComponents[1] == 'crmid' && $nameComponents[0] == 'vtiger_crmentity') {
 						$name = $this->getSQLColumn('id');
 					} else {
@@ -343,13 +345,15 @@ 
 						// If datatype is DT then we should append time also
 						if ($nameComponents[4] == 'DT') {
 							$startdate = explode(' ', $dateFilterResolvedList['startdate']);
-							if ($startdate[1] == '')
-								$startdate[1] = '00:00:00';
+							if ($startdate[1] == '') {
+															$startdate[1] = '00:00:00';
+							}
 							$dateFilterResolvedList['startdate'] = $startdate[0] . ' ' . $startdate[1];
 
 							$enddate = explode(' ', $dateFilterResolvedList['enddate']);
-							if ($enddate[1] == '')
-								$enddate[1] = '23:59:59';
+							if ($enddate[1] == '') {
+															$enddate[1] = '23:59:59';
+							}
 							$dateFilterResolvedList['enddate'] = $enddate[0] . ' ' . $enddate[1];
 						}
 						$value = [];
@@ -367,12 +371,14 @@ 
 
 						$value = [];
 						$start = explode(' ', $startDate);
-						if ($start[1] == "")
-							$startDate = $start[0] . ' ' . '00:00:00';
+						if ($start[1] == "") {
+													$startDate = $start[0] . ' ' . '00:00:00';
+						}
 
 						$end = explode(' ', $endDate);
-						if ($end[1] == "")
-							$endDate = $end[0] . ' ' . '23:59:59';
+						if ($end[1] == "") {
+													$endDate = $end[0] . ' ' . '23:59:59';
+						}
 
 						$value[] = $startDate;
 						$value[] = $endDate;
@@ -405,8 +411,9 @@ 
 				}
 				$this->endGroup();
 				$groupConditionGlue = $groupcolumns['condition'];
-				if (!empty($groupConditionGlue))
-					$this->addConditionGlue($groupConditionGlue);
+				if (!empty($groupConditionGlue)) {
+									$this->addConditionGlue($groupConditionGlue);
+				}
 			}
 		}
 	}
@@ -696,8 +703,9 @@ 
 				$fields = $meta->getModuleFields();
 				$fieldObject = $fields[$fieldName];
 
-				if (empty($fieldObject))
-					continue;
+				if (empty($fieldObject)) {
+									continue;
+				}
 
 				$tableName = $fieldObject->getTableName();
 				if (!in_array($tableName, $referenceFieldTableList)) {
@@ -756,8 +764,9 @@ 
 			$operator = strtolower($conditionInfo['operator']);
 			if ($operator == 'between' && $this->isDateType($field->getFieldDataType())) {
 				$start = explode(' ', $conditionInfo['value'][0]);
-				if (count($start) == 2)
-					$conditionInfo['value'][0] = getValidDBInsertDateTimeValue($start[0] . ' ' . $start[1]);
+				if (count($start) == 2) {
+									$conditionInfo['value'][0] = getValidDBInsertDateTimeValue($start[0] . ' ' . $start[1]);
+				}
 
 				$end = explode(' ', $conditionInfo['values'][1]);
 				// Dates will be equal for Today, Tomorrow, Yesterday.
@@ -918,8 +927,9 @@ 
 						$conditionGlue = ' && ';
 						if ($conditionInfo['operator'] == 'n') {
 							$specialCondition = ' || ' . $field->getTableName() . '.' . $field->getColumnName() . ' IS NULL ';
-							if (!empty($otherField))
-								$specialConditionForOtherField = ' || ' . $otherField->getTableName() . '.' . $otherField->getColumnName() . ' IS NULL ';
+							if (!empty($otherField)) {
+															$specialConditionForOtherField = ' || ' . $otherField->getTableName() . '.' . $otherField->getColumnName() . ' IS NULL ';
+							}
 						}
 					}
 
@@ -929,10 +939,11 @@ 
 					}
 
 					$fieldSql .= "$fieldGlue ((" . $field->getTableName() . '.' . $field->getColumnName() . ' ' . $valueSql . " $specialCondition) ";
-					if (!empty($otherField))
-						$fieldSql .= $conditionGlue . '(' . $otherField->getTableName() . '.' . $otherField->getColumnName() . ' ' . $otherFieldValueSql . ' ' . $specialConditionForOtherField . '))';
-					else
-						$fieldSql .= ')';
+					if (!empty($otherField)) {
+											$fieldSql .= $conditionGlue . '(' . $otherField->getTableName() . '.' . $otherField->getColumnName() . ' ' . $otherFieldValueSql . ' ' . $specialConditionForOtherField . '))';
+					} else {
+											$fieldSql .= ')';
+					}
 				} elseif ($conditionInfo['custom']) {
 					$fieldSql .= $fieldGlue . 'vtiger_crmentity.crmid ' . $valueSql;
 				} else {
@@ -1304,8 +1315,9 @@ 
 	public function addCondition($fieldname, $value, $operator, $glue = null, $custom = false, $newGroupType = null, $ignoreComma = false)
 	{
 		$conditionNumber = $this->conditionInstanceCount++;
-		if ($glue !== null && $conditionNumber > 0)
-			$this->addConditionGlue($glue);
+		if ($glue !== null && $conditionNumber > 0) {
+					$this->addConditionGlue($glue);
+		}
 
 		$this->groupInfo .= "$conditionNumber ";
 		$this->whereFields[] = $fieldname;
@@ -1326,8 +1338,9 @@ 
 	public function addReferenceModuleFieldCondition($relatedModule, $referenceField, $fieldName, $value, $SQLOperator, $glue = null)
 	{
 		$conditionNumber = $this->conditionInstanceCount++;
-		if ($glue !== null && $conditionNumber > 0)
-			$this->addConditionGlue($glue);
+		if ($glue !== null && $conditionNumber > 0) {
+					$this->addConditionGlue($glue);
+		}
 
 		$this->groupInfo .= "$conditionNumber ";
 		$this->referenceModuleField[$conditionNumber] = array('relatedModule' => $relatedModule, 'referenceField' => $referenceField, 'fieldName' => $fieldName, 'value' => $value,
@@ -1401,8 +1414,9 @@ 
 					}
 					$this->endGroup();
 					$groupConditionGlue = $groupcolumns['condition'];
-					if (!empty($groupConditionGlue))
-						$this->addConditionGlue($groupConditionGlue);
+					if (!empty($groupConditionGlue)) {
+											$this->addConditionGlue($groupConditionGlue);
+					}
 				}
 			}
 			$this->endGroup();

modules/PaymentsIn/views/PaymentsImport.php

Braces +6 added lines, -4 removed lines

@@ -31,11 +31,13 @@
 					$banks = explode('_', str_replace(".php", "", $file->getFilename()));
 					$status = false;
 					for ($i = 0; $i < count($bank); $i++) {
-						if ($bank[$i] == $banks[1])
-							$status = true;
+						if ($bank[$i] == $banks[1]) {
+													$status = true;
+						}
+					}
+					if ($status !== true) {
+											$bank[] = $banks[1];
 					}
-					if ($status !== true)
-						$bank[] = $banks[1];
 				}
 			}
 		}

modules/Webforms/Webforms.php

Braces +6 added lines, -4 removed lines

@@ -57,8 +57,9 @@ 
 		$seq_res = $adb->pquery("SELECT max(sequence) AS max_seq FROM vtiger_settings_field WHERE blockid = ?", array($blockid));
 		if ($adb->num_rows($seq_res) > 0) {
 			$cur_seq = $adb->query_result($seq_res, 0, 'max_seq');
-			if ($cur_seq !== null)
-				$seq = $cur_seq + 1;
+			if ($cur_seq !== null) {
+							$seq = $cur_seq + 1;
+			}
 		}
 
 		$result = $adb->pquery('SELECT 1 FROM vtiger_settings_field WHERE name=?', array($this->LBL_WEBFORMS));
@@ -70,8 +71,9 @@ 
 
 	static function checkAdminAccess($user)
 	{
-		if (\vtlib\Functions::userIsAdministrator($user))
-			return;
+		if (\vtlib\Functions::userIsAdministrator($user)) {
+					return;
+		}
 
 		echo "<table border='0' cellpadding='5' cellspacing='0' width='100%' height='450px'><tr><td align='center'>";
 		echo "<div style='border: 3px solid rgb(153, 153, 153); background-color: rgb(255, 255, 255); width: 55%; position: relative; z-index: 10000000;'>

modules/PaymentsOut/views/PaymentsImport.php

Braces +6 added lines, -4 removed lines

@@ -31,11 +31,13 @@
 					$banks = explode('_', str_replace(".php", "", $file->getFilename()));
 					$status = false;
 					for ($i = 0; $i < count($bank); $i++) {
-						if ($bank[$i] == $banks[1])
-							$status = true;
+						if ($bank[$i] == $banks[1]) {
+													$status = true;
+						}
+					}
+					if ($status !== true) {
+											$bank[] = $banks[1];
 					}
-					if ($status !== true)
-						$bank[] = $banks[1];
 				}
 			}
 		}

modules/ModTracker/ModTracker.php

Braces +32 added lines, -22 removed lines

@@ -59,8 +59,9 @@ 
 			$seq_res = $adb->pquery("SELECT max(sequence) AS max_seq FROM vtiger_settings_field WHERE blockid = ?", array($blockid));
 			if ($adb->num_rows($seq_res) > 0) {
 				$cur_seq = $adb->query_result($seq_res, 0, 'max_seq');
-				if ($cur_seq !== null)
-					$seq = $cur_seq + 1;
+				if ($cur_seq !== null) {
+									$seq = $cur_seq + 1;
+				}
 			}
 
 			$adb->pquery('INSERT INTO vtiger_settings_field(fieldid, blockid, name, iconpath, description, linkto, sequence)
@@ -189,10 +190,12 @@ 
 				$visible = $adb->query_result($query, 0, 'visible');
 				self::updateCache($tabid, $visible);
 				return true;
-			} else
-				return false;
-		} else
-			return true;
+			} else {
+							return false;
+			}
+		} else {
+					return true;
+		}
 	}
 
 	/**
@@ -205,10 +208,11 @@ 
 		$query1 = $adb->pquery("SELECT * FROM vtiger_links WHERE linktype='DETAILVIEWBASIC' AND
 							  linklabel = 'View History' && tabid = ?", array($tabid));
 		$row = $adb->num_rows($query1);
-		if ($row >= 1)
-			return true;
-		else
-			return false;
+		if ($row >= 1) {
+					return true;
+		} else {
+					return false;
+		}
 	}
 
 	/**
@@ -232,8 +236,9 @@ 
 	{
 		if (isset(self::$__cache_modtracker[$tabid])) {
 			return true;
-		} else
-			return false;
+		} else {
+					return false;
+		}
 	}
 
 	/**
@@ -262,8 +267,9 @@ 
 
 		$accessibleModules = $this->getModTrackerEnabledModules();
 
-		if (empty($accessibleModules))
-			throw new Exception('Modtracker not enabled for any modules');
+		if (empty($accessibleModules)) {
+					throw new Exception('Modtracker not enabled for any modules');
+		}
 
 		$query = sprintf('SELECT id, module, modifiedtime, vtiger_crmentity.crmid, smownerid, vtiger_modtracker_basic.status
                 FROM vtiger_modtracker_basic
@@ -277,8 +283,9 @@ 
 			$params[] = $entityModule;
 		}
 
-		if ($limit !== false)
-			$query .=" LIMIT $limit";
+		if ($limit !== false) {
+					$query .=" LIMIT $limit";
+		}
 
 		$result = $adb->pquery($query, $params);
 
@@ -306,8 +313,9 @@ 
 			$uniqueIds[] = $record['uniqueid'];
 		}
 
-		if (!empty($uniqueIds))
-			$maxUniqueId = max($uniqueIds);
+		if (!empty($uniqueIds)) {
+					$maxUniqueId = max($uniqueIds);
+		}
 
 		if (empty($maxUniqueId)) {
 			$maxUniqueId = $uniqueId;
@@ -367,8 +375,9 @@ 
 		for ($i = 0; $i < $adb->num_rows($fieldResult); $i++) {
 			$fieldName = $adb->query_result($fieldResult, $i, 'fieldname');
 			if ($fieldName == 'record_id' || $fieldName == 'record_module' ||
-				$fieldName == 'createdtime')
-				continue;
+				$fieldName == 'createdtime') {
+							continue;
+			}
 
 			$field['postvalue'] = $adb->query_result($fieldResult, $i, 'postvalue');
 			$field['prevalue'] = $adb->query_result($fieldResult, $i, 'prevalue');
@@ -416,8 +425,9 @@ 
 		]);
 		$isMyRecord = $adb->pquery('SELECT crmid FROM vtiger_crmentity WHERE smownerid <> ? && crmid = ?', array($currentUser->getRealId(), $sourceId));
 
-		if ($adb->num_rows($isMyRecord) > 0)
-			$adb->pquery("UPDATE vtiger_crmentity SET was_read = 0 WHERE crmid = ?;", array($sourceId));
+		if ($adb->num_rows($isMyRecord) > 0) {
+					$adb->pquery("UPDATE vtiger_crmentity SET was_read = 0 WHERE crmid = ?;", array($sourceId));
+		}
 	}
 
 	static function linkRelation($sourceModule, $sourceId, $targetModule, $targetId)

modules/CustomerPortal/CustomerPortal.php

Braces +3 added lines, -2 removed lines

@@ -52,8 +52,9 @@
 			$seq_res = $adb->pquery("SELECT max(sequence) AS max_seq FROM vtiger_settings_field WHERE blockid = ?", array($blockid));
 			if ($adb->num_rows($seq_res) > 0) {
 				$cur_seq = $adb->query_result($seq_res, 0, 'max_seq');
-				if ($cur_seq !== null)
-					$seq = $cur_seq + 1;
+				if ($cur_seq !== null) {
+									$seq = $cur_seq + 1;
+				}
 			}
 
 			$adb->pquery('INSERT INTO vtiger_settings_field(fieldid, blockid, name, iconpath, description, linkto, sequence)