YetiForceCompany / YetiForceCRM

modules/Vtiger/actions/Save.php

Doc Comments +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
 
 	/**
 	 * Function to save record
-	 * @param <Vtiger_Request> $request - values of the record
+	 * @param Vtiger_Request $request - values of the record
 	 * @return <RecordModel> - record Model of saved record
 	 */
 	public function saveRecord($request)

Braces +6 added lines, -4 removed lines

@@ -87,8 +87,9 @@ 
 			$relatedRecordId = $recordModel->getId();
 
 			$relationModel = Vtiger_Relation_Model::getInstance($parentModuleModel, $relatedModule);
-			if ($relationModel)
-				$relationModel->addRelation($parentRecordId, $relatedRecordId);
+			if ($relationModel) {
+							$relationModel->addRelation($parentRecordId, $relatedRecordId);
+			}
 		}
 		if ($request->get('imgDeleted')) {
 			$imageIds = $request->get('imageid');
@@ -144,8 +145,9 @@ 
 					$fieldValue = trim($fieldValue);
 				}
 				$recordModel->set($fieldName, $fieldValue);
-			} else
-				$recordModel->set($fieldName, null);
+			} else {
+							$recordModel->set($fieldName, null);
+			}
 		}
 		return $recordModel;
 	}

modules/Vtiger/models/ChartFilter.php

Doc Comments +6 added lines

@@ -113,6 +113,9 @@ 
 		return [];
 	}
 
+	/**
+	 * @param Vtiger_Widget_Model $widgetModel
+	 */
 	public function setWidgetModel($widgetModel)
 	{
 		$this->widgetModel = $widgetModel;
@@ -127,6 +130,9 @@ 
 		}
 	}
 
+	/**
+	 * @return string
+	 */
 	public function getType()
 	{
 		return $this->extraData['chartType'];

Spacing +8 added lines, -8 removed lines

@@ -112,7 +112,7 @@ 
 					if (!isset($groupData[$displayValue]['count'])) {
 						$groupData[$displayValue]['count'] = 1;
 					} else {
-						$groupData[$displayValue]['count'] ++;
+						$groupData[$displayValue]['count']++;
 					}
 					if (!isset($groupData[$displayValue]['link'])) {
 						$moduleModel = $this->getTargetModuleModel();
@@ -125,7 +125,7 @@ 
 			$count = [];
 			while ($row = $db->getRow($result)) {
 				$sectorId = $this->getSector($sectors, $row[$groupField]);
-				if($sectorId !== false){
+				if ($sectorId !== false) {
 					if (!isset($count[$sectorId])) {
 						$count[$sectorId] = 1;
 					} else {
@@ -134,15 +134,15 @@ 
 				}
 				
 			}
-			foreach($sectors as $sectorId => $sectorValue){
+			foreach ($sectors as $sectorId => $sectorValue) {
 				$moduleModel = $this->getTargetModuleModel();
 				$displayValue = $groupFieldModel->getDisplayValue($sectorValue);
-				$displayValue .= ' - (' . (int)$count[$sectorId] .')';
-				$groupData[$displayValue]['count'] = (int)$sectorValue ;
-				if($sectorId == 0){
-					$groupData[$displayValue]['link'] = $moduleModel->getListViewUrl() . "&viewname=$filterId" . '&search_params=' . json_encode([[[$fieldName, 'm', $sectorValue]]]);;
+				$displayValue .= ' - (' . (int) $count[$sectorId] . ')';
+				$groupData[$displayValue]['count'] = (int) $sectorValue;
+				if ($sectorId == 0) {
+					$groupData[$displayValue]['link'] = $moduleModel->getListViewUrl() . "&viewname=$filterId" . '&search_params=' . json_encode([[[$fieldName, 'm', $sectorValue]]]); ;
 				} else {
-					$groupData[$displayValue]['link'] = $moduleModel->getListViewUrl() . "&viewname=$filterId" . '&search_params=' . json_encode([[[$fieldName, 'm', $sectorValue],[$fieldName, 'g', $sectors[$sectorId - 1]]]]);;
+					$groupData[$displayValue]['link'] = $moduleModel->getListViewUrl() . "&viewname=$filterId" . '&search_params=' . json_encode([[[$fieldName, 'm', $sectorValue], [$fieldName, 'g', $sectors[$sectorId - 1]]]]); ;
 				}
 			}
 		}

modules/Vtiger/models/ExportToXml.php

Doc Comments +6 added lines

@@ -122,6 +122,9 @@ 
 		return html_entity_decode($value);
 	}
 
+	/**
+	 * @param string $fileName
+	 */
 	public function outputFile($fileName)
 	{
 		header("Content-Disposition:attachment;filename=$fileName.xml");
@@ -133,6 +136,9 @@ 
 		readfile($this->tmpXmlPath);
 	}
 
+	/**
+	 * @param string $fileName
+	 */
 	protected function outputZipFile($fileName)
 	{
 

modules/Vtiger/models/InventoryField.php

Doc Comments -5 removed lines

@@ -16,8 +16,6 @@ 
 
 	/**
 	 * Create the name of the Inventory data table
-	 * @param string $module Module name
-	 * @param string $prefix Prefix table
 	 * @return string Table name
 	 */
 	public function getTableName($type = 'data')
@@ -118,8 +116,6 @@ 
 
 	/**
 	 * Get inventory columns
-	 * @param string $module Module name
-	 * @param boolean $returnInBlock Should the result be divided into blocks
 	 * @return array Inventory columns
 	 */
 	public function getColumns()
@@ -164,7 +160,6 @@ 
 
 	/**
 	 * Retrieve list of all fields
-	 * @param string $moduleName Module name
 	 * @return array Fields instance Vtiger_Basic_InventoryField
 	 */
 	public function getAllFields()

Spacing +2 added lines, -2 removed lines

@@ -497,9 +497,9 @@
 		$db = PearDatabase::getInstance();
 		$query = sprintf('UPDATE `%s` SET sequence = CASE id ', $this->getTableName('fields'));
 		foreach ($sequenceList as $sequence => $id) {
-			$query .=' WHEN ' . $id . ' THEN ' . $sequence;
+			$query .= ' WHEN ' . $id . ' THEN ' . $sequence;
 		}
-		$query .=' END ';
+		$query .= ' END ';
 		$query .= sprintf(' WHERE id IN (%s)', generateQuestionMarks($sequenceList));
 		return $db->pquery($query, array_values($sequenceList));
 	}

Braces +6 added lines, -4 removed lines

@@ -133,8 +133,9 @@ 
 		$columns = [];
 		foreach ($this->getFields() as $key => $field) {
 			$column = $field->getColumnName();
-			if (!empty($column) && $column != '-')
-				$columns[] = $column;
+			if (!empty($column) && $column != '-') {
+							$columns[] = $column;
+			}
 			foreach ($field->getCustomColumn() as $name => $field) {
 				$columns[] = $name;
 			}
@@ -187,8 +188,9 @@ 
 		}
 		$fields = [];
 		foreach ($fieldPaths as $fieldPath) {
-			if (!is_dir($fieldPath))
-				continue;
+			if (!is_dir($fieldPath)) {
+							continue;
+			}
 			foreach (new DirectoryIterator($fieldPath) as $fileinfo) {
 				if ($fileinfo->isFile() && $fileinfo->getFilename() != 'Basic.php') {
 					$fieldName = str_replace('.php', '', $fileinfo->getFilename());

modules/Vtiger/models/ListView.php

Doc Comments -1 removed lines

@@ -332,7 +332,6 @@
 
 	/**
 	 * Function to get the list view entries
-	 * @param Vtiger_Paging_Model $pagingModel
 	 * @return <Array> - Associative array of record id mapped to Vtiger_Record_Model instance.
 	 */
 	public function getListViewCount()

Braces +3 added lines, -2 removed lines

@@ -169,8 +169,9 @@
 		$headerFieldModels = [];
 		$headerFields = $listViewContoller->getListViewHeaderFields();
 		foreach ($headerFields as $fieldName => $webserviceField) {
-			if ($webserviceField && !in_array($webserviceField->getPresence(), [0, 2]))
-				continue;
+			if ($webserviceField && !in_array($webserviceField->getPresence(), [0, 2])) {
+							continue;
+			}
 			$headerFieldModels[$fieldName] = Vtiger_Field_Model::getInstance($fieldName, $module);
 		}
 		return $headerFieldModels;

modules/Vtiger/models/MappedFields.php

Doc Comments +16 added lines

@@ -24,6 +24,9 @@ 
 		return $this->get('id');
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public function get($key)
 	{
 		if (in_array($key, ['conditions', 'params']) && !is_array(parent::get($key))) {
@@ -33,16 +36,25 @@ 
 		}
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public function getRaw($key)
 	{
 		return parent::get($key);
 	}
 
+	/**
+	 * @return boolean
+	 */
 	public function getModule()
 	{
 		return Vtiger_Module_Model::getInstance($this->getName());
 	}
 
+	/**
+	 * @return boolean
+	 */
 	public function getRelatedModule()
 	{
 		return Vtiger_Module_Model::getInstance($this->getRelatedName());
@@ -66,6 +78,10 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $recordId
+	 * @param string $view
+	 */
 	public function getActiveTemplatesForRecord($recordId, $view, $moduleName = false)
 	{
 		$log = LoggerManager::getInstance();

modules/Vtiger/models/MiniList.php

Doc Comments +3 added lines

@@ -20,6 +20,9 @@
 	protected $listviewRecords;
 	protected $targetModuleModel;
 
+	/**
+	 * @param Vtiger_Widget_Model $widgetModel
+	 */
 	public function setWidgetModel($widgetModel)
 	{
 		$this->widgetModel = $widgetModel;

Braces +3 added lines, -2 removed lines

@@ -42,8 +42,9 @@
 	public function getTargetFields()
 	{
 		$fields = $this->extraData['fields'];
-		if (!in_array("id", $fields))
-			$fields[] = "id";
+		if (!in_array("id", $fields)) {
+					$fields[] = "id";
+		}
 		return $fields;
 	}
 

Spacing +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
 			$targetModuleFocus = CRMEntity::getInstance($targetModuleName);
 			$filterId = $this->widgetModel->get('filterid');
 			$filterModel = CustomView_Record_Model::getInstanceById($filterId);
-			if(!empty($filterModel->get('sort'))){
+			if (!empty($filterModel->get('sort'))) {
 				$sort = $filterModel->get('sort');
 				$query .= sprintf(' ORDER BY %s ', str_replace(',', ' ', $sort));
 			} else if ($targetModuleFocus->default_order_by && $targetModuleFocus->default_sort_order) {

modules/Vtiger/models/ModuleMeta.php

Doc Comments +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
 
 	/**
 	 * Functions returns webservices meta object
-	 * @return webservices meta
+	 * @return boolean meta
 	 */
 	public function getMeta()
 	{

modules/Vtiger/models/Record.php

Doc Comments +4 added lines, -4 removed lines

@@ -69,7 +69,7 @@ 
 
 	/**
 	 * Function to get the Module to which the record belongs
-	 * @return Vtiger_Module_Model
+	 * @return boolean
 	 */
 	public function getModule()
 	{
@@ -219,7 +219,7 @@ 
 	/**
 	 * Function to retieve display value for a field
 	 * @param <String> $fieldName - field name for which values need to get
-	 * @return <String>
+	 * @return string
 	 */
 	public function getDisplayValue($fieldName, $recordId = false, $rawText = false)
 	{
@@ -325,7 +325,7 @@ 
 	/**
 	 * Static Function to get the instance of the Vtiger Record Model given the recordid and the module name
 	 * @param <Number> $recordId
-	 * @param <String> $moduleName
+	 * @param <String> $module
 	 * @return Vtiger_Record_Model or Module Specific Record Model instance
 	 */
 	public static function getInstanceById($recordId, $module = null)
@@ -493,7 +493,6 @@ 
 
 	/**
 	 * Function to get Display value for RelatedList
-	 * @param <String> $value
 	 * @return <String>
 	 */
 	public function getRelatedListDisplayValue($fieldName)
@@ -596,6 +595,7 @@ 
 	/**
 	 * Function to set record module field values
 	 * @param parent record model
+	 * @param Vtiger_Record_Model $parentRecordModel
 	 */
 	public function setRecordFieldValues($parentRecordModel)
 	{