Completed
Push — developer ( 31cfdf...98a6c9 )
by Błażej
70:35 queued 28:41
created
libraries/nusoap/nusoap.php 2 patches
Spacing   +11 added lines, -13 removed lines patch added patch discarded remove patch
@@ -2235,8 +2235,8 @@  discard block
 block discarded – undo
2235 2235
 	var $persistentConnection = false;
2236 2236
 	var $ch = false; // cURL handle
2237 2237
 	var $ch_options = array(); // cURL custom options
2238
-	var $use_curl = false;  // force cURL use
2239
-	var $proxy = null;   // proxy information (associative array)
2238
+	var $use_curl = false; // force cURL use
2239
+	var $proxy = null; // proxy information (associative array)
2240 2240
 	var $username = '';
2241 2241
 	var $password = '';
2242 2242
 	var $authtype = '';
@@ -2684,7 +2684,7 @@  discard block
 block discarded – undo
2684 2684
 			$this->setHeader('Authorization', 'Basic ' . base64_encode(str_replace(':', '', $username) . ':' . $password));
2685 2685
 		} elseif ($authtype == 'digest') {
2686 2686
 			if (isset($digestRequest['nonce'])) {
2687
-				$digestRequest['nc'] = isset($digestRequest['nc']) ? $digestRequest['nc'] ++ : 1;
2687
+				$digestRequest['nc'] = isset($digestRequest['nc']) ? $digestRequest['nc']++ : 1;
2688 2688
 
2689 2689
 				// calculate the Digest hashes (calculate code based on digest implementation found at: http://www.rassoc.com/gregr/weblog/stories/2002/07/09/webServicesSecurityHttpDigestAuthenticationWithoutActiveDirectory.html)
2690 2690
 				// A1 = unq(username-value) ":" unq(realm-value) ":" passwd
@@ -4140,7 +4140,7 @@  discard block
 block discarded – undo
4140 4140
 			$call_arg = array($class, $method);
4141 4141
 		} else {
4142 4142
 			$this->debug('in invoke_method, calling instance method using call_user_func_array()');
4143
-			$instance = new $class ();
4143
+			$instance = new $class();
4144 4144
 			$call_arg = array(&$instance, $method);
4145 4145
 		}
4146 4146
 		if (is_array($this->methodparams)) {
@@ -4700,12 +4700,12 @@  discard block
 block discarded – undo
4700 4700
 	var $timeout = 0;
4701 4701
 	var $response_timeout = 30;
4702 4702
 	var $curl_options = array(); // User-specified cURL options
4703
-	var $use_curl = false;   // whether to always try to use cURL
4703
+	var $use_curl = false; // whether to always try to use cURL
4704 4704
 	// for HTTP authentication
4705 4705
 	var $username = ''; // Username for HTTP authentication
4706 4706
 	var $password = ''; // Password for HTTP authentication
4707 4707
 	var $authtype = ''; // Type of HTTP authentication
4708
-	var $certRequest = array();  // Certificate for HTTP SSL authentication
4708
+	var $certRequest = array(); // Certificate for HTTP SSL authentication
4709 4709
 
4710 4710
 	/**
4711 4711
 	 * constructor
@@ -4821,11 +4821,9 @@  discard block
 block discarded – undo
4821 4821
 				foreach ($bindingData['operations'] as $operation => $data) {
4822 4822
 					$this->debug('post-parse data gathering for ' . $operation);
4823 4823
 					$this->bindings[$binding]['operations'][$operation]['input'] = isset($this->bindings[$binding]['operations'][$operation]['input']) ?
4824
-						array_merge($this->bindings[$binding]['operations'][$operation]['input'], $this->portTypes[$bindingData['portType']][$operation]['input']) :
4825
-						$this->portTypes[$bindingData['portType']][$operation]['input'];
4824
+						array_merge($this->bindings[$binding]['operations'][$operation]['input'], $this->portTypes[$bindingData['portType']][$operation]['input']) : $this->portTypes[$bindingData['portType']][$operation]['input'];
4826 4825
 					$this->bindings[$binding]['operations'][$operation]['output'] = isset($this->bindings[$binding]['operations'][$operation]['output']) ?
4827
-						array_merge($this->bindings[$binding]['operations'][$operation]['output'], $this->portTypes[$bindingData['portType']][$operation]['output']) :
4828
-						$this->portTypes[$bindingData['portType']][$operation]['output'];
4826
+						array_merge($this->bindings[$binding]['operations'][$operation]['output'], $this->portTypes[$bindingData['portType']][$operation]['output']) : $this->portTypes[$bindingData['portType']][$operation]['output'];
4829 4827
 					if (isset($this->messages[$this->bindings[$binding]['operations'][$operation]['input']['message']])) {
4830 4828
 						$this->bindings[$binding]['operations'][$operation]['input']['parts'] = $this->messages[$this->bindings[$binding]['operations'][$operation]['input']['message']];
4831 4829
 					}
@@ -6369,7 +6367,7 @@  discard block
 block discarded – undo
6369 6367
 					}
6370 6368
 				}
6371 6369
 				// if user took advantage of a minOccurs=0, then only serialize named parameters
6372
-				if (isset($optionals) && (!isset($xvalue[$eName])) && ( (!isset($attrs['nillable'])) || $attrs['nillable'] != 'true')
6370
+				if (isset($optionals) && (!isset($xvalue[$eName])) && ((!isset($attrs['nillable'])) || $attrs['nillable'] != 'true')
6373 6371
 				) {
6374 6372
 					if (isset($attrs['minOccurs']) && $attrs['minOccurs'] <> '0') {
6375 6373
 						$this->debug("apparent error: no value provided for element $eName with minOccurs=" . $attrs['minOccurs']);
@@ -6614,7 +6612,7 @@  discard block
 block discarded – undo
6614 6612
 	var $root_struct_name = '';
6615 6613
 	var $root_struct_namespace = '';
6616 6614
 	var $root_header = '';
6617
-	var $document = '';   // incoming SOAP body (text)
6615
+	var $document = ''; // incoming SOAP body (text)
6618 6616
 	// determines where in the message we are (envelope,header,body,method)
6619 6617
 	var $status = '';
6620 6618
 	var $position = 0;
@@ -6630,7 +6628,7 @@  discard block
 block discarded – undo
6630 6628
 	var $depth_array = array();
6631 6629
 	var $debug_flag = true;
6632 6630
 	var $soapresponse = NULL; // parsed SOAP Body
6633
-	var $soapheader = NULL;  // parsed SOAP Header
6631
+	var $soapheader = NULL; // parsed SOAP Header
6634 6632
 	var $responseHeaders = ''; // incoming SOAP headers (text)
6635 6633
 	var $body_position = 0;
6636 6634
 	// for multiref parsing:
Please login to merge, or discard this patch.
Doc Comments   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
 	/**
327 327
 	 * gets the current debug data for this instance
328 328
 	 *
329
-	 * @return   debug data
329
+	 * @return   string data
330 330
 	 * @access   public
331 331
 	 */
332 332
 	public function &getDebug()
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
 	 * gets the current debug data for this instance as an XML comment
341 341
 	 * this may change the contents of the debug data
342 342
 	 *
343
-	 * @return   debug data as an XML comment
343
+	 * @return   string data as an XML comment
344 344
 	 * @access   public
345 345
 	 */
346 346
 	public function &getDebugAsXMLComment()
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
 	/**
376 376
 	 * returns error string if present
377 377
 	 *
378
-	 * @return   mixed error string or false
378
+	 * @return   string|false error string or false
379 379
 	 * @access   public
380 380
 	 */
381 381
 	public function getError()
@@ -389,7 +389,7 @@  discard block
 block discarded – undo
389 389
 	/**
390 390
 	 * sets error string
391 391
 	 *
392
-	 * @return   boolean $string error string
392
+	 * @return   boolean|null $string error string
393 393
 	 * @access   private
394 394
 	 */
395 395
 	public function setError($str)
@@ -825,7 +825,7 @@  discard block
 block discarded – undo
825 825
 	 * returns false, if not prefixed
826 826
 	 *
827 827
 	 * @param string $str The prefixed string
828
-	 * @return mixed The prefix or false if there is no prefix
828
+	 * @return string|false The prefix or false if there is no prefix
829 829
 	 * @access public
830 830
 	 */
831 831
 	public function getPrefix($str)
@@ -857,7 +857,7 @@  discard block
 block discarded – undo
857 857
 	 * or false if no prefixes registered for the given namespace
858 858
 	 *
859 859
 	 * @param string $ns The namespace
860
-	 * @return mixed The prefix, false if the namespace has no prefixes
860
+	 * @return string The prefix, false if the namespace has no prefixes
861 861
 	 * @access public
862 862
 	 */
863 863
 	public function getPrefixFromNamespace($ns)
@@ -926,7 +926,7 @@  discard block
 block discarded – undo
926 926
  *
927 927
  * @param    int $timestamp Unix time stamp
928 928
  * @param	boolean $utc Whether the time stamp is UTC or local
929
- * @return	mixed ISO 8601 date string or false
929
+ * @return	string|false ISO 8601 date string or false
930 930
  * @access   public
931 931
  */
932 932
 function timestamp_to_iso8601($timestamp, $utc = true)
@@ -1066,7 +1066,7 @@  discard block
 block discarded – undo
1066 1066
 	 * @param string $faultcode (SOAP-ENV:Client | SOAP-ENV:Server)
1067 1067
 	 * @param string $faultactor only used when msg routed between multiple actors
1068 1068
 	 * @param string $faultstring human readable error message
1069
-	 * @param mixed $faultdetail detail, typically a string or array of string
1069
+	 * @param string $faultdetail detail, typically a string or array of string
1070 1070
 	 */
1071 1071
 	public function nusoap_fault($faultcode, $faultactor = '', $faultstring = '', $faultdetail = '')
1072 1072
 	{
@@ -1888,7 +1888,7 @@  discard block
 block discarded – undo
1888 1888
 	 * returns a sample serialization of a given type, or false if no type by the given name
1889 1889
 	 *
1890 1890
 	 * @param string $type name of type
1891
-	 * @return mixed
1891
+	 * @return string|false
1892 1892
 	 * @access public
1893 1893
 	 * @deprecated
1894 1894
 	 */
@@ -2142,7 +2142,7 @@  discard block
 block discarded – undo
2142 2142
 	 *
2143 2143
 	 * @param    string $name optional name
2144 2144
 	 * @param    mixed $type optional type name
2145
-	 * @param	mixed $value optional value
2145
+	 * @param	integer $value optional value
2146 2146
 	 * @param	mixed $element_ns optional namespace of value
2147 2147
 	 * @param	mixed $type_ns optional namespace of type
2148 2148
 	 * @param	mixed $attributes associative array of attributes to add to element serialization
@@ -2359,7 +2359,6 @@  discard block
 block discarded – undo
2359 2359
 	/**
2360 2360
 	 * establish an HTTP connection
2361 2361
 	 *
2362
-	 * @param    integer $timeout set connection timeout in seconds
2363 2362
 	 * @param	integer $response_timeout set response timeout in seconds
2364 2363
 	 * @return	boolean true if connected, false if not
2365 2364
 	 * @access   private
@@ -2914,7 +2913,7 @@  discard block
 block discarded – undo
2914 2913
 	 *
2915 2914
 	 * @param    string $data message data
2916 2915
 	 * @param	array $cookies cookies to send
2917
-	 * @return	boolean	true if OK, false if problem
2916
+	 * @return	boolean|null	true if OK, false if problem
2918 2917
 	 * @access   private
2919 2918
 	 */
2920 2919
 	public function sendRequest($data, $cookies = NULL)
@@ -4320,7 +4319,7 @@  discard block
 block discarded – undo
4320 4319
 	 *
4321 4320
 	 * @param	array	$headers	The HTTP headers
4322 4321
 	 * @param	string	$data		unprocessed request data from client
4323
-	 * @return	mixed	value of the message, decoded into a PHP type
4322
+	 * @return	false|null	value of the message, decoded into a PHP type
4324 4323
 	 * @access   private
4325 4324
 	 */
4326 4325
 	public function parseRequest($headers, $data)
@@ -4702,6 +4701,7 @@  discard block
 block discarded – undo
4702 4701
 	 * fetches the WSDL document and parses it
4703 4702
 	 *
4704 4703
 	 * @access public
4704
+	 * @param string $wsdl
4705 4705
 	 */
4706 4706
 	public function fetchWSDL($wsdl)
4707 4707
 	{
@@ -5496,7 +5496,7 @@  discard block
 block discarded – undo
5496 5496
 	/**
5497 5497
 	 * serialize the parsed wsdl
5498 5498
 	 *
5499
-	 * @param mixed $debug whether to put debug=1 in endpoint URL
5499
+	 * @param integer $debug whether to put debug=1 in endpoint URL
5500 5500
 	 * @return string serialization of WSDL
5501 5501
 	 * @access public 
5502 5502
 	 */
@@ -5715,7 +5715,7 @@  discard block
 block discarded – undo
5715 5715
 	 * @param string $direction (input|output)
5716 5716
 	 * @param mixed $parameters parameter value(s)
5717 5717
 	 * @param string $bindingType (soap|soap12)
5718
-	 * @return mixed parameters serialized as XML or false on error (e.g. operation not found)
5718
+	 * @return false|string parameters serialized as XML or false on error (e.g. operation not found)
5719 5719
 	 * @access public
5720 5720
 	 */
5721 5721
 	public function serializeRPCParameters($operation, $direction, $parameters, $bindingType = 'soap')
@@ -5810,7 +5810,7 @@  discard block
 block discarded – undo
5810 5810
 	 * @param string $operation operation name
5811 5811
 	 * @param string $direction (input|output)
5812 5812
 	 * @param mixed $parameters parameter value(s)
5813
-	 * @return mixed parameters serialized as XML or false on error (e.g. operation not found)
5813
+	 * @return false|string parameters serialized as XML or false on error (e.g. operation not found)
5814 5814
 	 * @access public
5815 5815
 	 * @deprecated
5816 5816
 	 */
Please login to merge, or discard this patch.
include/fields/CurrencyField.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 	 * Function that converts the Number into Users Currency along with currency symbol
170 170
 	 * @param Users $user
171 171
 	 * @param Boolean $skipConversion
172
-	 * @return Formatted Currency
172
+	 * @return string Currency
173 173
 	 */
174 174
 	public function getDisplayValueWithSymbol($user = null, $skipConversion = false)
175 175
 	{
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 	 * @param Number $currencyValue
183 183
 	 * @param String $currencySymbol
184 184
 	 * @param String $currencySymbolPlacement
185
-	 * @return Currency value appended with the currency symbol
185
+	 * @return string value appended with the currency symbol
186 186
 	 */
187 187
 	public static function appendCurrencySymbol($currencyValue, $currencySymbol, $currencySymbolPlacement = '')
188 188
 	{
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
 	 * @global Users $current_user
359 359
 	 * @param Users $user
360 360
 	 * @param Boolean $skipConversion
361
-	 * @return Number
361
+	 * @return string
362 362
 	 */
363 363
 	public function getDBInsertedValue($user = null, $skipConversion = false)
364 364
 	{
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
 	 * @param Number $value
394 394
 	 * @param Users $user
395 395
 	 * @param Boolean $skipConversion
396
-	 * @return Number
396
+	 * @return string
397 397
 	 */
398 398
 	public static function convertToDBFormat($value, $user = null, $skipConversion = false)
399 399
 	{
@@ -417,6 +417,9 @@  discard block
 block discarded – undo
417 417
 		return null;
418 418
 	}
419 419
 
420
+	/**
421
+	 * @param string $amount
422
+	 */
420 423
 	public static function convertToDollar($amount, $conversionRate)
421 424
 	{
422 425
 		if ($conversionRate == 0)
Please login to merge, or discard this patch.
include/ListView/RelatedListViewSession.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -67,6 +67,9 @@  discard block
 block discarded – undo
67 67
 		return $moduleList;
68 68
 	}
69 69
 
70
+	/**
71
+	 * @param double $start
72
+	 */
70 73
 	public static function saveRelatedModuleStartPage($relationId, $start)
71 74
 	{
72 75
 		$currentModule = vglobal('currentModule');
@@ -97,6 +100,9 @@  discard block
 block discarded – undo
97 100
 		return $start;
98 101
 	}
99 102
 
103
+	/**
104
+	 * @param string $query
105
+	 */
100 106
 	public static function getRequestCurrentPage($relationId, $query)
101 107
 	{
102 108
 		$listMaxEntriesPerPage = AppConfig::main('list_max_entries_per_page');
Please login to merge, or discard this patch.
modules/Calendar/iCal/ical-parser-class.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -10,12 +10,18 @@
 block discarded – undo
10 10
 		$this->folders = 'cache/import/';
11 11
 	}
12 12
 
13
+	/**
14
+	 * @param string $filename
15
+	 */
13 16
 	public function iCalReader($filename, $rootDirectory = '')
14 17
 	{
15 18
 		$iCaltoArray = $this->iCalDecoder($filename, $rootDirectory);
16 19
 		return $iCaltoArray;
17 20
 	}
18 21
 
22
+	/**
23
+	 * @param string $rootDirectory
24
+	 */
19 25
 	public function iCalDecoder($file, $rootDirectory)
20 26
 	{
21 27
 		$ical = file_get_contents($rootDirectory . $this->folders . $file);
Please login to merge, or discard this patch.
modules/Calendar/iCal/iCalendar_properties.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -27,6 +27,10 @@  discard block
 block discarded – undo
27 27
 
28 28
 	// If some property needs extra care with its parameters, override this
29 29
 	// IMPORTANT: the parameter name MUST BE CAPITALIZED!
30
+
31
+	/**
32
+	 * @param string $parameter
33
+	 */
30 34
 	public function is_valid_parameter($parameter, $value)
31 35
 	{
32 36
 
@@ -1218,6 +1222,9 @@  discard block
 block discarded – undo
1218 1222
 		);
1219 1223
 	}
1220 1224
 
1225
+	/**
1226
+	 * @param string $name
1227
+	 */
1221 1228
 	public function set_name($name)
1222 1229
 	{
1223 1230
 
Please login to merge, or discard this patch.
modules/Faq/Faq.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@
 block discarded – undo
76 76
 	}
77 77
 
78 78
 	/** Function to insert values in vtiger_faqcomments table for the specified module,
79
-	 * @param $table_name -- table name:: Type varchar
79
+	 * @param string $table_name -- table name:: Type varchar
80 80
 	 * @param $module -- module:: Type varchar
81 81
 	 */
82 82
 	public function insertIntoFAQCommentTable($table_name, $module)
Please login to merge, or discard this patch.
modules/Import/models/Map.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -59,6 +59,9 @@
 block discarded – undo
59 59
 		return $this->map;
60 60
 	}
61 61
 
62
+	/**
63
+	 * @param string $key
64
+	 */
62 65
 	public function getValue($key)
63 66
 	{
64 67
 		$map = $this->map;
Please login to merge, or discard this patch.
modules/IStorages/data_access/checkHierarchy.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 	 * Checks if chosen parent is record child
45 45
 	 * @param type $parentId
46 46
 	 * @param type $childArray
47
-	 * @return true if parent can be set
47
+	 * @return boolean if parent can be set
48 48
 	 */
49 49
 	public function checkChildren($parentId, $childArray)
50 50
 	{
Please login to merge, or discard this patch.
modules/IStorages/IStorages.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -201,6 +201,7 @@  discard block
 block discarded – undo
201 201
 	 * @param integer $id - istorageid
202 202
 	 * @param array $parentIStorages - Array of all the parent storages
203 203
 	 * returns All the parent Storages of the given istorageid in array format
204
+	 * @param integer[] $encounteredIStorages
204 205
 	 */
205 206
 	public function getParentIStorages($id, &$parentIStorages, &$encounteredIStorages, $depthBase = 0)
206 207
 	{
@@ -266,7 +267,7 @@  discard block
 block discarded – undo
266 267
 	 * Function to Recursively get all the child storages of a given Storage
267 268
 	 * @param integer $id - istorageid
268 269
 	 * @param array $childIStorages - Array of all the child storages
269
-	 * @param integer $depth - Depth at which the particular storage has to be placed in the hierarchy
270
+	 * @param integer $depthBase - Depth at which the particular storage has to be placed in the hierarchy
270 271
 	 * returns All the child storages of the given istorageid in array format
271 272
 	 */
272 273
 	public function getChildIStorages($id, &$childIStorages, $depthBase)
Please login to merge, or discard this patch.