PaymentsIn_FinvoiceProformaPaymentStatus_Model::canUpdatePaymentStatus() - Code Metrics - Inspection of "Improved updating payment status (#16327)" - YetiForceCompany/YetiForceCRM - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — developer ( 6d71b3...948c6c )

by Radosław

created 2022-08-11 10:20 UTC

canUpdatePaymentStatus() A

↳ Parent: PaymentsIn_FinvoiceProformaPaymentStatus_Model

Complexity

Conditions	4
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	5
c	0
b	0
f	0
dl	0
loc	9
rs	10
cc	4
nc	2
nop	1

<?php
/**
 * The file contains: Class to change the payment status of a proforma invoice.
 *
 * @package Model
 *
 * @copyright YetiForce S.A.
 * @license YetiForce Public License 5.0 (licenses/LicenseEN.txt or yetiforce.com)
 * @author Arkadiusz Dudek <[email protected]>
 */

/**
 * Class to change the payment status of a proforma invoice.
 */
class PaymentsIn_FinvoiceProformaPaymentStatus_Model extends PaymentsIn_PaymentStatus_Model
{
	/** {@inheritdoc} */
	protected static $moduleName = 'FInvoiceProforma';

	/** {@inheritdoc} */
	protected static $fieldPaymentStatusName = 'payment_status';

	/** {@inheritdoc} */
	protected static $fieldPaymentSumName = 'payment_sum';

	/** {@inheritdoc} */
	protected static $relatedRecordIdName = 'finvoiceproformaid';

	/** {@inheritdoc} */
	protected static function canUpdatePaymentStatus(Vtiger_Record_Model $recordModel): bool
	{
		$returnValue = parent::canUpdatePaymentStatus($recordModel);
		if (($returnValue || false !== $recordModel->getPreviousValue(static::$relatedRecordIdName)) && (int) $recordModel->get('currency_id') !== \App\Record::getCurrencyIdFromInventory($recordModel->get(static::$relatedRecordIdName), static::$moduleName)
		) {
			\App\Log::warning('The payment is in a different currency than the related record: ' . $recordModel->get(static::$relatedRecordIdName));
			$returnValue = false;
		}
		return $returnValue;
	}
}


1			<?php
2			/**
3			* The file contains: Class to change the payment status of a proforma invoice.
4			*
5			* @package Model
6			*
7			* @copyright YetiForce S.A.
8			* @license YetiForce Public License 5.0 (licenses/LicenseEN.txt or yetiforce.com)
9			* @author Arkadiusz Dudek <[email protected]>
10			*/
11
12			/**
13			* Class to change the payment status of a proforma invoice.
14			*/
15			class PaymentsIn_FinvoiceProformaPaymentStatus_Model extends PaymentsIn_PaymentStatus_Model
16			{
17			/** {@inheritdoc} */
18			protected static $moduleName = 'FInvoiceProforma';
19
20			/** {@inheritdoc} */
21			protected static $fieldPaymentStatusName = 'payment_status';
22
23			/** {@inheritdoc} */
24			protected static $fieldPaymentSumName = 'payment_sum';
25
26			/** {@inheritdoc} */
27			protected static $relatedRecordIdName = 'finvoiceproformaid';
28
29			/** {@inheritdoc} */
30			protected static function canUpdatePaymentStatus(Vtiger_Record_Model $recordModel): bool
31			{
32			$returnValue = parent::canUpdatePaymentStatus($recordModel);
33			if (($returnValue \|\| false !== $recordModel->getPreviousValue(static::$relatedRecordIdName)) && (int) $recordModel->get('currency_id') !== \App\Record::getCurrencyIdFromInventory($recordModel->get(static::$relatedRecordIdName), static::$moduleName)
34			) {
35			\App\Log::warning('The payment is in a different currency than the related record: ' . $recordModel->get(static::$relatedRecordIdName));
36			$returnValue = false;
37			}
38			return $returnValue;
39			}
40			}
41

YetiForceCompany / YetiForceCRM

Push — developer ( 6d71b3...948c6c )

canUpdatePaymentStatus() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like