YetiForceCompany / YetiForceCRM

include/utils/EmailTemplate.php

Spacing +2 added lines, -2 removed lines

@@ -120,7 +120,7 @@ 
 				$moduleTableIndexList = $meta->getEntityTableIndexList();
 				foreach ($tableList as $index => $tableName) {
 					if ($tableName != $tableList[0]) {
-						$sql .=' INNER JOIN ' . $tableName . ' ON ' . $tableList[0] . '.' .
+						$sql .= ' INNER JOIN ' . $tableName . ' ON ' . $tableList[0] . '.' .
 							$moduleTableIndexList[$tableList[0]] . '=' . $tableName . '.' .
 							$moduleTableIndexList[$tableName];
 					}
@@ -128,7 +128,7 @@ 
 				//If module is Leads and if you are not selected any leads fields then query failure is happening.
 				//By default we are checking where condition on base table.
 				if ($module == 'Leads' && !in_array('vtiger_leaddetails', $tableList)) {
-					$sql .=' INNER JOIN vtiger_leaddetails ON vtiger_leaddetails.leadid = vtiger_crmentity.crmid';
+					$sql .= ' INNER JOIN vtiger_leaddetails ON vtiger_leaddetails.leadid = vtiger_crmentity.crmid';
 				}
 
 				$sql .= ' WHERE';

Braces +6 added lines, -4 removed lines

@@ -209,8 +209,9 @@ 
 						$needle = '$' . strtolower($this->module) . '-' . $parentFieldColumnMapping[$params['field']] . ':' . $column . '$';
 						$this->processedDescription = str_replace($needle, $values[array_search($column, $fieldColumnMapping)], $this->processedDescription);
 					}
-					if (!$params['owner'])
-						$this->processedmodules[$module] = true;
+					if (!$params['owner']) {
+											$this->processedmodules[$module] = true;
+					}
 				}
 			}
 		}
@@ -253,7 +254,8 @@ 
 		$rows = $adb->num_rows($res);
 		if ($rows > 0) {
 			return true;
-		} else
-			return false;
+		} else {
+					return false;
+		}
 	}
 }

include/utils/ConfigReader.php

Braces +6 added lines, -4 removed lines

@@ -37,8 +37,9 @@ 
 
 	public function setConfig($key, $value)
 	{
-		if (empty($key))
-			return;
+		if (empty($key)) {
+					return;
+		}
 		$this->properties[$key] = $value;
 		//not neccessary for php5.x versions
 		self::$propertiesCache[$this->name] = $this->properties;
@@ -46,8 +47,9 @@ 
 
 	public function getConfig($key)
 	{
-		if (empty($key))
-			return '';
+		if (empty($key)) {
+					return '';
+		}
 		return $this->properties[$key];
 	}
 }

Doc Comments +7 added lines

@@ -15,6 +15,10 @@ 
 	protected $name;
 	static $propertiesCache = [];
 
+	/**
+	 * @param string $path
+	 * @param string $name
+	 */
 	public function __construct($path, $name, $force = false)
 	{
 		$this->load($path, $name, $force);
@@ -41,6 +45,9 @@ 
 		self::$propertiesCache[$this->name] = $this->properties;
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public function getConfig($key)
 	{
 		if (empty($key))

include/utils/ExportUtils.php

Braces +3 added lines, -2 removed lines

@@ -28,8 +28,9 @@
 	$blockid_list = '(';
 	for ($i = 0; $i < $noofrows; $i++) {
 		$blockid = $adb->query_result($result, $i, "blockid");
-		if ($i != 0)
-			$blockid_list .= ', ';
+		if ($i != 0) {
+					$blockid_list .= ', ';
+		}
 		$blockid_list .= $blockid;
 		$block_label[$blockid] = $adb->query_result($result, $i, "blocklabel");
 	}

include/utils/RecurringType.php

Braces +30 added lines, -26 removed lines

@@ -69,8 +69,9 @@ 
 		}
 		$this->dayofweek_to_rpt = $repeat_arr['dayofweek_to_repeat'];
 		$this->repeat_monthby = $repeat_arr['repeatmonth_type'];
-		if (isset($repeat_arr['repeatmonth_date']))
-			$this->rptmonth_datevalue = $repeat_arr['repeatmonth_date'];
+		if (isset($repeat_arr['repeatmonth_date'])) {
+					$this->rptmonth_datevalue = $repeat_arr['repeatmonth_date'];
+		}
 		$this->rptmonth_daytype = $repeat_arr['repeatmonth_daytype'];
 
 		$this->recurringdates = $this->_getRecurringDates();
@@ -409,13 +410,13 @@ 
 					if ($this->rptmonth_datevalue <= $date) {
 						$index = $this->rptmonth_datevalue - 1;
 						$day = $this->rptmonth_datevalue;
-						if (isset($this->recur_freq))
-							$month = $month + $this->recur_freq;
-						else
-							$month = $month + 1;
+						if (isset($this->recur_freq)) {
+													$month = $month + $this->recur_freq;
+						} else {
+													$month = $month + 1;
+						}
 						$tempdateObj = $tempdateObj->getThismonthDaysbyIndex($index, $day, $month, $year);
-					}
-					else {
+					} else {
 						$index = $this->rptmonth_datevalue - 1;
 						$day = $this->rptmonth_datevalue;
 						$tempdateObj = $tempdateObj->getThismonthDaysbyIndex($index, $day, $month, $year);
@@ -430,10 +431,11 @@ 
 						$tempdateObj = new vt_DateTime($date_arr, true);
 						$firstdayofmonthObj = $this->getFistdayofmonth($this->dayofweek_to_rpt[0], $tempdateObj);
 						if ($firstdayofmonthObj->get_DB_formatted_date() <= $tempdate) {
-							if (isset($this->recur_freq))
-								$month = $firstdayofmonthObj->getMonth() + $this->recur_freq;
-							else
-								$month = $firstdayofmonthObj->getMonth() + 1;
+							if (isset($this->recur_freq)) {
+															$month = $firstdayofmonthObj->getMonth() + $this->recur_freq;
+							} else {
+															$month = $firstdayofmonthObj->getMonth() + 1;
+							}
 							$dateObj = $firstdayofmonthObj->getThismonthDaysbyIndex(0, 1, $month, $firstdayofmonthObj->getYear());
 							$nextmonthObj = $this->getFistdayofmonth($this->dayofweek_to_rpt[0], $dateObj);
 							$tempdateObj = $nextmonthObj;
@@ -449,16 +451,16 @@ 
 						$tempdateObj = new vt_DateTime($date_arr, true);
 						$lastdayofmonthObj = $this->getLastdayofmonth($this->dayofweek_to_rpt[0], $tempdateObj);
 						if ($lastdayofmonthObj->get_DB_formatted_date() <= $tempdate) {
-							if (isset($this->recur_freq))
-								$month = $lastdayofmonthObj->getMonth() + $this->recur_freq;
-							else
-								$month = $lastdayofmonthObj->getMonth() + 1;
+							if (isset($this->recur_freq)) {
+															$month = $lastdayofmonthObj->getMonth() + $this->recur_freq;
+							} else {
+															$month = $lastdayofmonthObj->getMonth() + 1;
+							}
 							$dateObj = $lastdayofmonthObj->getThismonthDaysbyIndex(0, 1, $month, $lastdayofmonthObj->getYear());
 							$dateObj = $dateObj->getThismonthDaysbyIndex($dateObj->getDaysInMonth() - 1, $dateObj->getDaysInMonth(), $month, $lastdayofmonthObj->getYear());
 							$nextmonthObj = $this->getLastdayofmonth($this->dayofweek_to_rpt[0], $dateObj);
 							$tempdateObj = $nextmonthObj;
-						}
-						else {
+						} else {
 							$tempdateObj = $lastdayofmonthObj;
 						}
 					}
@@ -476,10 +478,11 @@ 
 				}
 			} elseif ($this->recur_type == 'Yearly') {
 
-				if (isset($this->recur_freq))
-					$index = $year + $this->recur_freq;
-				else
-					$index = $year + 1;
+				if (isset($this->recur_freq)) {
+									$index = $year + $this->recur_freq;
+				} else {
+									$index = $year + 1;
+				}
 				if ($index > 2037 || $index < 1970) {
 					print("<font color='red'>" . \includes\Language::translate('LBL_CAL_LIMIT_MSG') . "</font>");
 					exit;
@@ -534,10 +537,11 @@ 
 		if ($dayofweek == $dateObj->dayofweek) {
 			return $dateObj;
 		} else {
-			if ($dayofweek > $dateObj->dayofweek)
-				$day = $dateObj->day - 7 + ($dayofweek - $dateObj->dayofweek);
-			else
-				$day = $dateObj->day - ($dateObj->dayofweek - $dayofweek);
+			if ($dayofweek > $dateObj->dayofweek) {
+							$day = $dateObj->day - 7 + ($dayofweek - $dateObj->dayofweek);
+			} else {
+							$day = $dateObj->day - ($dateObj->dayofweek - $dayofweek);
+			}
 			$index = $day - 1;
 			$month = $dateObj->month;
 			$year = $dateObj->year;

include/utils/utils.php

Spacing +1 added lines, -1 removed lines

@@ -1401,7 +1401,7 @@
 function isRecordExists($recordId, $cache = true)
 {
 	$recordMetaData = vtlib\Functions::getCRMRecordMetadata($recordId);
-	return (isset($recordMetaData) && $recordMetaData['deleted'] == 0 ) ? true : false;
+	return (isset($recordMetaData) && $recordMetaData['deleted'] == 0) ? true : false;
 }
 
 /** Function to set date values compatible to database (YY_MM_DD)

Doc Comments +3 added lines

@@ -367,6 +367,7 @@ 
 
 /**
  * Function to find the UI type of a field based on the uitype id
+ * @param string $reqtype
  */
 function is_uitype($uitype, $reqtype)
 {
@@ -752,6 +753,8 @@ 
 
 /**
  * Function to get the approximate difference between two date time values as string
+ * @param integer $d1
+ * @param integer $d2
  */
 function dateDiffAsString($d1, $d2)
 {

Braces +35 added lines, -25 removed lines

@@ -289,13 +289,15 @@ 
 		while (($i--) > 0) {
 			if ($data != ($a = $data % ($p = pow(64, $i)))) {
 				$ret = chr(base_convert(str_pad(str_repeat(1, $i + 1), 8, "0"), 2, 10) + (($data - $a) / $p));
-				for ($i; $i > 0; $i--)
-					$ret .= chr(128 + ((($data % pow(64, $i)) - ($data % ($p = pow(64, $i - 1)))) / $p));
+				for ($i; $i > 0; $i--) {
+									$ret .= chr(128 + ((($data % pow(64, $i)) - ($data % ($p = pow(64, $i - 1)))) / $p));
+				}
 				break;
 			}
 		}
-	} else
-		$ret = "&#$data;";
+	} else {
+			$ret = "&#$data;";
+	}
 	return $ret;
 }
 
@@ -344,8 +346,9 @@ 
  */
 function escape_single_quotes($value)
 {
-	if (isset($value))
-		$value = str_replace("'", "\'", $value);
+	if (isset($value)) {
+			$value = str_replace("'", "\'", $value);
+	}
 	return $value;
 }
 
@@ -366,10 +369,11 @@ 
 			$str = str_replace('_', '\_', $str);
 			if ($flag == 0) {
 				// If value what to search is null then we should not add % which will fail
-				if (empty($str))
-					$str = '' . $str . '';
-				else
-					$str = '%' . $str . '%';
+				if (empty($str)) {
+									$str = '' . $str . '';
+				} else {
+									$str = '%' . $str . '%';
+				}
 			} elseif ($flag == 1) {
 				$str = '%' . $str;
 			} elseif ($flag == 2) {
@@ -402,8 +406,9 @@ 
 
 		$ret_str .= " ifnull($tbl_name.$col_name,'null') = ifnull(temp.$col_name,'null')";
 
-		if (count($field_array) != $i)
-			$ret_str .= " and ";
+		if (count($field_array) != $i) {
+					$ret_str .= " and ";
+		}
 		$i++;
 	}
 	return $ret_str;
@@ -430,8 +435,9 @@ 
 	foreach ($name as $module) {
 		$focus = CRMEntity::getInstance($module);
 		$query = $focus->buildSearchQueryForFieldTypes(11, $number);
-		if (empty($query))
-			return;
+		if (empty($query)) {
+					return;
+		}
 
 		$result = $adb->pquery($query, []);
 		if ($adb->num_rows($result) > 0) {
@@ -569,8 +575,9 @@ 
 	//require_once('modules/com_vtiger_workflow/VTEntityCache.php');
 	$em = new VTEventsManager($adb);
 	$em->initTriggerCache();
-	if (!is_array($destinationRecordIds))
-		$destinationRecordIds = [$destinationRecordIds];
+	if (!is_array($destinationRecordIds)) {
+			$destinationRecordIds = [$destinationRecordIds];
+	}
 
 	$data = [];
 	$data['CRMEntity'] = $focus;
@@ -626,20 +633,23 @@ 
 	$delim = array('/', '.');
 	foreach ($delim as $delimiter) {
 		$x = strpos($value, $delimiter);
-		if ($x === false)
-			continue;
-		else {
+		if ($x === false) {
+					continue;
+		} else {
 			$value = str_replace($delimiter, '-', $value);
 			break;
 		}
 	}
 	list($y, $m, $d) = explode('-', $value);
-	if (strlen($y) == 1)
-		$y = '0' . $y;
-	if (strlen($m) == 1)
-		$m = '0' . $m;
-	if (strlen($d) == 1)
-		$d = '0' . $d;
+	if (strlen($y) == 1) {
+			$y = '0' . $y;
+	}
+	if (strlen($m) == 1) {
+			$m = '0' . $m;
+	}
+	if (strlen($d) == 1) {
+			$d = '0' . $d;
+	}
 	$value = implode('-', array($y, $m, $d));
 
 	if (strlen($y) < 4) {

include/ConfigUtils.php

Braces +3 added lines, -2 removed lines

@@ -61,8 +61,9 @@
 		self::$modules[$module] = $CONFIG;
 		switch ($argsLength) {
 			case 2:
-				if (!isset($CONFIG[$key]))
-					return false;
+				if (!isset($CONFIG[$key])) {
+									return false;
+				}
 				return $CONFIG[$key];
 				break;
 			default:

Doc Comments +36 added lines

@@ -16,11 +16,17 @@ 
 	protected static $sounds = [];
 	protected static $search = [];
 
+	/**
+	 * @param string $key
+	 */
 	public static function load($key, $config)
 	{
 		self::$$key = $config;
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function main($key, $value = false)
 	{
 		if (isset(self::$main[$key])) {
@@ -75,11 +81,17 @@ 
 		}
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function api($key, $defvalue = false)
 	{
 		return self::$api[$key];
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function debug($key, $defvalue = false)
 	{
 		if (empty(self::$debug)) {
@@ -89,6 +101,9 @@ 
 		return self::$debug[$key];
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function developer($key, $defvalue = false)
 	{
 		if (empty(self::$developer)) {
@@ -98,6 +113,9 @@ 
 		return self::$developer[$key];
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function security($key, $defvalue = false)
 	{
 		if (empty(self::$security)) {
@@ -107,6 +125,9 @@ 
 		return self::$security[$key];
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function securityKeys($key, $defvalue = false)
 	{
 		if (empty(self::$securityKeys)) {
@@ -116,6 +137,11 @@ 
 		return self::$securityKeys[$key];
 	}
 
+	/**
+	 * @param string $key
+	 *
+	 * @return integer
+	 */
 	public static function performance($key, $defvalue = false)
 	{
 		if (empty(self::$performance)) {
@@ -125,6 +151,9 @@ 
 		return self::$performance[$key];
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function relation($key, $defvalue = false)
 	{
 		if (empty(self::$relation)) {
@@ -147,6 +176,9 @@ 
 		return self::$sounds[$key];
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function search($key, $defvalue = false)
 	{
 		if (empty(self::$search)) {
@@ -156,6 +188,10 @@ 
 		return self::$search[$key];
 	}
 
+	/**
+	 * @param string $key
+	 * @param integer $value
+	 */
 	public static function iniSet($key, $value)
 	{
 		@ini_set($key, $value);

include/Webservices/GetUpdates.php

Braces +25 added lines, -18 removed lines

@@ -73,14 +73,16 @@ 
 	$modulesInformation = $modulesDetails["information"];
 
 	foreach ($modulesInformation as $moduleName => $entityInformation) {
-		if ($entityInformation["isEntity"])
-			$entityModules[] = $moduleName;
+		if ($entityInformation["isEntity"]) {
+					$entityModules[] = $moduleName;
+		}
 	}
 	if (!$typed) {
 		$accessableModules = $entityModules;
 	} else {
-		if (!in_array($elementType, $entityModules))
-			throw new WebServiceException(WebServiceErrorCode::$ACCESSDENIED, "Permission to perform the operation is denied");
+		if (!in_array($elementType, $entityModules)) {
+					throw new WebServiceException(WebServiceErrorCode::$ACCESSDENIED, "Permission to perform the operation is denied");
+		}
 		$accessableModules[] = $elementType;
 	}
 
@@ -101,15 +103,17 @@ 
 		if ($elementType == "Calendar" || $elementType == "Events") {
 			$baseCRMTable = getSyncQueryBaseTable($elementType);
 		}
-	} else
-		$baseCRMTable = " vtiger_crmentity ";
+	} else {
+			$baseCRMTable = " vtiger_crmentity ";
+	}
 
 	//modifiedtime - next token
 	$q = "SELECT modifiedtime FROM $baseCRMTable WHERE  modifiedtime>? and setype IN(" . generateQuestionMarks($accessableModules) . ") ";
 	$params = array($datetime);
 	foreach ($accessableModules as $entityModule) {
-		if ($entityModule == "Events")
-			$entityModule = "Calendar";
+		if ($entityModule == "Events") {
+					$entityModule = "Calendar";
+		}
 		$params[] = $entityModule;
 	}
 	if (!$applicationSync) {
@@ -159,10 +163,11 @@ 
 				$selectClause .=", " . $table_fieldName;
 			}
 		}
-		if ($elementType == "Emails")
-			$fromClause = vtws_getEmailFromClause();
-		else
-			$fromClause = $queryGenerator->getFromClause();
+		if ($elementType == "Emails") {
+					$fromClause = vtws_getEmailFromClause();
+		} else {
+					$fromClause = $queryGenerator->getFromClause();
+		}
 
 		$fromClause .= " INNER JOIN (select modifiedtime, crmid,deleted,setype FROM $baseCRMTable WHERE setype=? and modifiedtime >? and modifiedtime<=?";
 		if (!$applicationSync) {
@@ -201,8 +206,9 @@ 
 	$params = array($maxModifiedTime);
 
 	foreach ($accessableModules as $entityModule) {
-		if ($entityModule == "Events")
-			$entityModule = "Calendar";
+		if ($entityModule == "Events") {
+					$entityModule = "Calendar";
+		}
 		$params[] = $entityModule;
 	}
 	if (!$applicationSync) {
@@ -285,10 +291,11 @@ 
 
 function getCalendarTypeCondition($elementType)
 {
-	if ($elementType == "Events")
-		$activityCondition = "vtiger_activity.activitytype !='Task' and vtiger_activity.activitytype !='Emails'";
-	else
-		$activityCondition = "vtiger_activity.activitytype ='Task'";
+	if ($elementType == "Events") {
+			$activityCondition = "vtiger_activity.activitytype !='Task' and vtiger_activity.activitytype !='Emails'";
+	} else {
+			$activityCondition = "vtiger_activity.activitytype ='Task'";
+	}
 	return $activityCondition;
 }
 

Doc Comments +9 added lines

@@ -13,6 +13,9 @@ 
 require_once 'include/utils/CommonUtils.php';
 require_once 'include/Webservices/DescribeObject.php';
 
+/**
+ * @param string $syncType
+ */
 function vtws_sync($mtime, $elementType, $syncType, $user)
 {
 	return 'Currently not supported';
@@ -246,6 +249,9 @@ 
 	return strtotime($mtimeString);
 }
 
+/**
+ * @param string[] $deletedValues
+ */
 function vtws_isRecordDeleted($recordDetails, $deleteColumnDetails, $deletedValues)
 {
 	$deletedRecord = false;
@@ -294,6 +300,9 @@ 
 	return $activityCondition;
 }
 
+/**
+ * @param Users $user
+ */
 function getSelectClauseFields($module, $moduleMeta, $user)
 {
 	$moduleFieldNames = $moduleMeta->getModuleFields();

include/Webservices/VtigerCRMObjectMeta.php

Braces +6 added lines, -4 removed lines

@@ -212,8 +212,9 @@ 
 		$adb = PearDatabase::getInstance();
 
 		// administrator's have assign privilege
-		if (\vtlib\Functions::userIsAdministrator($this->user))
-			return true;
+		if (\vtlib\Functions::userIsAdministrator($this->user)) {
+					return true;
+		}
 
 		$idComponents = vtws_getIdComponents($webserviceId);
 		$userId = $idComponents[1];
@@ -353,8 +354,9 @@ 
 		$theme = vtws_preserveGlobal('theme', $this->user->theme);
 		$default_language = AppConfig::main('default_language');
 		$current_language = vglobal('current_language');
-		if (empty($current_language))
-			$current_language = $default_language;
+		if (empty($current_language)) {
+					$current_language = $default_language;
+		}
 		$current_language = vtws_preserveGlobal('current_language', $current_language);
 
 		$this->computeAccess();

include/Webservices/History.php

Braces +7 added lines, -4 removed lines

@@ -31,8 +31,9 @@ 
 	$page = empty($element['page']) ? 0 : intval($element['page']); // Page to start
 
 	$acrossAllModule = false;
-	if ($moduleName == 'Home')
-		$acrossAllModule = true;
+	if ($moduleName == 'Home') {
+			$acrossAllModule = true;
+	}
 
 	// Pre-condition check
 	if (empty($moduleName)) {
@@ -71,8 +72,10 @@ 
 
 	// Get most recently tracked changes with limit
 	$start = $page * $MAXLIMIT;
-	if ($start > 0)
-		$start = $start + 1; // Adjust the start range
+	if ($start > 0) {
+			$start = $start + 1;
+	}
+	// Adjust the start range
 	$sql .= sprintf(' ORDER BY vtiger_modtracker_basic.id DESC LIMIT %s,%s', $start, $MAXLIMIT);
 
 	$result = $adb->pquery($sql, $params);