YetiForceCompany / YetiForceCRM

include/utils/InventoryUtils.php

Spacing +8 added lines, -8 removed lines

@@ -313,7 +313,7 @@ 
 	$moduleName = $entity->getModuleName();
 
 	$statusChanged = false;
-	$vtEntityDelta = new VTEntityDelta ();
+	$vtEntityDelta = new VTEntityDelta();
 	$oldEntity = $vtEntityDelta->getOldValue($moduleName, $entity_id, $statusFieldName);
 	$recordDetails = $entity->getData();
 	$statusChanged = $vtEntityDelta->hasChanged($moduleName, $entity_id, $statusFieldName);
@@ -941,19 +941,19 @@ 
 		for ($i = 0; $i < $noOfRows; ++$i) {
 			$status = $adb->query_result($result, $i, 'temp_status');
 			if ($obj->getImportRecordStatus('none') == $status) {
-				$statusCount['PENDING'] ++;
+				$statusCount['PENDING']++;
 			} elseif ($obj->getImportRecordStatus('failed') == $status) {
-				$statusCount['FAILED'] ++;
+				$statusCount['FAILED']++;
 			} else {
-				$statusCount['IMPORTED'] ++;
+				$statusCount['IMPORTED']++;
 				switch ($status) {
-					case $obj->getImportRecordStatus('created') : $statusCount['CREATED'] ++;
+					case $obj->getImportRecordStatus('created') : $statusCount['CREATED']++;
 						break;
-					case $obj->getImportRecordStatus('skipped') : $statusCount['SKIPPED'] ++;
+					case $obj->getImportRecordStatus('skipped') : $statusCount['SKIPPED']++;
 						break;
-					case $obj->getImportRecordStatus('updated') : $statusCount['UPDATED'] ++;
+					case $obj->getImportRecordStatus('updated') : $statusCount['UPDATED']++;
 						break;
-					case $obj->getImportRecordStatus('merged') : $statusCount['MERGED'] ++;
+					case $obj->getImportRecordStatus('merged') : $statusCount['MERGED']++;
 						break;
 				}
 			}

Doc Comments +1 added lines, -3 removed lines

@@ -17,6 +17,7 @@ 
  * Param $ext_prod_arr - existing vtiger_products
  * Param $module - module name
  * return type void
+ * @param string $mode
  */
 function updateStk($product_id, $qty, $mode, $ext_prod_arr, $module)
 {
@@ -250,9 +251,6 @@ 
 }
 
 /** 	Function used to delete the Inventory product details for the passed entity
- * 	@param int $objectid - entity id to which we want to delete the product details from REQUEST values where as the entity will be Purchase Order or Invoice
- * 	@param string $return_old_values - string which contains the string return_old_values or may be empty, if the string is return_old_values then before delete old values will be retrieved
- * 	@return array $ext_prod_arr - if the second input parameter is 'return_old_values' then the array which contains the productid and quantity which will be retrieved before delete the product details will be returned otherwise return empty
  */
 function deleteInventoryProductDetails($focus)
 {

Braces +27 added lines, -19 removed lines

@@ -128,16 +128,18 @@ 
 	$taxpercentage = $adb->query_result($res, 0, 'taxpercentage');
 
 	//This is to retrive the default configured value if the taxpercentage related to product is empty
-	if ($taxpercentage == '' && $default == 'default')
-		$taxpercentage = getTaxPercentage($type);
+	if ($taxpercentage == '' && $default == 'default') {
+			$taxpercentage = getTaxPercentage($type);
+	}
 
 
 	$log->debug("Exiting from getProductTaxPercentage($productid,$type) function. return value=$taxpercentage");
-	if ($current_user->truncate_trailing_zeros === true)
-		return \vtlib\Functions::formatDecimal($taxpercentage);
-	else
-		return $taxpercentage;
-}
+	if ($current_user->truncate_trailing_zeros === true) {
+			return \vtlib\Functions::formatDecimal($taxpercentage);
+	} else {
+			return $taxpercentage;
+	}
+	}
 
 /** 	Function used to get the list of Tax types as a array
  * 	@param string $available - available or empty where as default is all, if available then the taxes which are available now will be returned otherwise all taxes will be returned
@@ -229,8 +231,9 @@ 
 		$params = array($productid);
 
 		//Postgres 8 fixes
-		if ($adb->isPostgres())
-			$query = fixPostgresQuery($query, $log, 0);
+		if ($adb->isPostgres()) {
+					$query = fixPostgresQuery($query, $log, 0);
+		}
 
 		$res = $adb->pquery($query, $params);
 		for ($i = 0; $i < $adb->num_rows($res); $i++) {
@@ -372,8 +375,9 @@ 
 
 	$inv_table_array = [];
 	$inv_id_array = [];
-	if (!array_key_exists($module, $inv_table_array))
-		return '';
+	if (!array_key_exists($module, $inv_table_array)) {
+			return '';
+	}
 
 	$res = $adb->pquery("select taxtype from $inv_table_array[$module] where $inv_id_array[$module]=?", array($id));
 
@@ -428,8 +432,9 @@ 
 	$res = $adb->pquery("select $taxname from vtiger_inventoryproductrel where id = ? and productid = ?", array($id, $productid));
 	$taxvalue = $adb->query_result($res, 0, $taxname);
 
-	if ($taxvalue == '')
-		$taxvalue = '0';
+	if ($taxvalue == '') {
+			$taxvalue = '0';
+	}
 
 	$log->debug("Exit from function getInventoryProductTaxValue($id, $productid, $taxname).");
 
@@ -477,8 +482,9 @@ 
 		}
 
 		//Postgres 8 fixes
-		if ($adb->isPostgres())
-			$query = fixPostgresQuery($query, $log, 0);
+		if ($adb->isPostgres()) {
+					$query = fixPostgresQuery($query, $log, 0);
+		}
 
 		$res = $adb->pquery($query, $params);
 		for ($i = 0; $i < $adb->num_rows($res); $i++) {
@@ -775,8 +781,9 @@ 
 		$subject = $row['subject'];
 		$sql = 'SELECT * FROM %s WHERE temp_status = %s';
 		$sql = sprintf($sql, $tableName, Import_Data_Action::$IMPORT_RECORD_NONE);
-		if (!empty($subject))
-			$sql .= ' && subject = "' . str_replace("\"", "\\\"", $subject) . '"';
+		if (!empty($subject)) {
+					$sql .= ' && subject = "' . str_replace("\"", "\\\"", $subject) . '"';
+		}
 		$subjectResult = $adb->query($sql);
 		$count = $adb->num_rows($subjectResult);
 		$subjectRowIDs = [];
@@ -893,8 +900,9 @@ 
 			foreach ($fieldMapping as $fieldName => $index) {
 				if ($moduleFields[$fieldName]->getTableName() == 'vtiger_inventoryproductrel') {
 					$lineItemData[$fieldName] = $lineItemFieldData[$fieldName];
-					if ($fieldName != 'productid')
-						$inventoryFieldData[$fieldName] = '';
+					if ($fieldName != 'productid') {
+											$inventoryFieldData[$fieldName] = '';
+					}
 				}
 			}
 			array_push($lineItems, $lineItemData);

include/utils/EditViewUtils.php

Braces +25 added lines, -15 removed lines

@@ -111,10 +111,12 @@ 
 			$product_Detail[$i]['entityType' . $i] = $entitytype;
 		}
 
-		if ($listprice == '')
-			$listprice = $unitprice;
-		if ($qty == '')
-			$qty = 1;
+		if ($listprice == '') {
+					$listprice = $unitprice;
+		}
+		if ($qty == '') {
+					$qty = 1;
+		}
 
 		//calculate productTotal
 		$productTotal = $qty * $listprice;
@@ -136,8 +138,9 @@ 
 				$sprod_id = $adb->query_result($sub_prod_query, $j, 'prod_id');
 				$sprod_name = $subProductArray[] = \vtlib\Functions::getCRMRecordLabel($sprod_id);
 				$str_sep = "";
-				if ($j > 0)
-					$str_sep = ":";
+				if ($j > 0) {
+									$str_sep = ":";
+				}
 				$subprodid_str .= $str_sep . $sprod_id;
 				if (isset($sprod_name)) {
 					$subprodname_str .= $str_sep . " - " . $sprod_name;
@@ -219,12 +222,17 @@ 
 
 			//condition to avoid this function call when create new PO/Invoice from Product module
 			if ($focus->id != '') {
-				if ($taxtype == 'individual')//if individual then show the entered tax percentage
+				if ($taxtype == 'individual') {
+					//if individual then show the entered tax percentage
 					$tax_value = getInventoryProductTaxValue($focus->id, $hdnProductId, $tax_name);
-				else//if group tax then we have to show the default value when change to individual tax
+				} else {
+					//if group tax then we have to show the default value when change to individual tax
 					$tax_value = $tax_details[$tax_count]['percentage'];
-			} else//if the above function not called then assign the default associated value of the product
+				}
+			} else {
+				//if the above function not called then assign the default associated value of the product
 				$tax_value = $tax_details[$tax_count]['percentage'];
+			}
 
 
 			$product_Detail[$i]['taxes'][$tax_count]['taxname'] = $tax_name;
@@ -310,13 +318,15 @@ 
 
 		//if taxtype is individual and want to change to group during edit time then we have to show the all available taxes and their default values
 		//Also taxtype is group and want to change to individual during edit time then we have to provide the asspciated taxes and their default tax values for individual products
-		if ($taxtype == 'group')
-			$tax_percent = $adb->query_result($result, 0, $tax_name);
-		else
-			$tax_percent = $allTaxes[$tax_count]['percentage'];
+		if ($taxtype == 'group') {
+					$tax_percent = $adb->query_result($result, 0, $tax_name);
+		} else {
+					$tax_percent = $allTaxes[$tax_count]['percentage'];
+		}
 
-		if ($tax_percent == '' || $tax_percent == 'NULL')
-			$tax_percent = '0';
+		if ($tax_percent == '' || $tax_percent == 'NULL') {
+					$tax_percent = '0';
+		}
 		$taxamount = ($subTotal - $finalDiscount) * $tax_percent / 100;
 		$taxamount = number_format($taxamount, $no_of_decimal_places, '.', '');
 		$product_Detail[1]['final_details']['taxes'][$tax_count]['taxname'] = $tax_name;

include/utils/RecurringType.php

Braces +30 added lines, -26 removed lines

@@ -69,8 +69,9 @@ 
 		}
 		$this->dayofweek_to_rpt = $repeat_arr['dayofweek_to_repeat'];
 		$this->repeat_monthby = $repeat_arr['repeatmonth_type'];
-		if (isset($repeat_arr['repeatmonth_date']))
-			$this->rptmonth_datevalue = $repeat_arr['repeatmonth_date'];
+		if (isset($repeat_arr['repeatmonth_date'])) {
+					$this->rptmonth_datevalue = $repeat_arr['repeatmonth_date'];
+		}
 		$this->rptmonth_daytype = $repeat_arr['repeatmonth_daytype'];
 
 		$this->recurringdates = $this->_getRecurringDates();
@@ -409,13 +410,13 @@ 
 					if ($this->rptmonth_datevalue <= $date) {
 						$index = $this->rptmonth_datevalue - 1;
 						$day = $this->rptmonth_datevalue;
-						if (isset($this->recur_freq))
-							$month = $month + $this->recur_freq;
-						else
-							$month = $month + 1;
+						if (isset($this->recur_freq)) {
+													$month = $month + $this->recur_freq;
+						} else {
+													$month = $month + 1;
+						}
 						$tempdateObj = $tempdateObj->getThismonthDaysbyIndex($index, $day, $month, $year);
-					}
-					else {
+					} else {
 						$index = $this->rptmonth_datevalue - 1;
 						$day = $this->rptmonth_datevalue;
 						$tempdateObj = $tempdateObj->getThismonthDaysbyIndex($index, $day, $month, $year);
@@ -430,10 +431,11 @@ 
 						$tempdateObj = new vt_DateTime($date_arr, true);
 						$firstdayofmonthObj = $this->getFistdayofmonth($this->dayofweek_to_rpt[0], $tempdateObj);
 						if ($firstdayofmonthObj->get_DB_formatted_date() <= $tempdate) {
-							if (isset($this->recur_freq))
-								$month = $firstdayofmonthObj->getMonth() + $this->recur_freq;
-							else
-								$month = $firstdayofmonthObj->getMonth() + 1;
+							if (isset($this->recur_freq)) {
+															$month = $firstdayofmonthObj->getMonth() + $this->recur_freq;
+							} else {
+															$month = $firstdayofmonthObj->getMonth() + 1;
+							}
 							$dateObj = $firstdayofmonthObj->getThismonthDaysbyIndex(0, 1, $month, $firstdayofmonthObj->getYear());
 							$nextmonthObj = $this->getFistdayofmonth($this->dayofweek_to_rpt[0], $dateObj);
 							$tempdateObj = $nextmonthObj;
@@ -449,16 +451,16 @@ 
 						$tempdateObj = new vt_DateTime($date_arr, true);
 						$lastdayofmonthObj = $this->getLastdayofmonth($this->dayofweek_to_rpt[0], $tempdateObj);
 						if ($lastdayofmonthObj->get_DB_formatted_date() <= $tempdate) {
-							if (isset($this->recur_freq))
-								$month = $lastdayofmonthObj->getMonth() + $this->recur_freq;
-							else
-								$month = $lastdayofmonthObj->getMonth() + 1;
+							if (isset($this->recur_freq)) {
+															$month = $lastdayofmonthObj->getMonth() + $this->recur_freq;
+							} else {
+															$month = $lastdayofmonthObj->getMonth() + 1;
+							}
 							$dateObj = $lastdayofmonthObj->getThismonthDaysbyIndex(0, 1, $month, $lastdayofmonthObj->getYear());
 							$dateObj = $dateObj->getThismonthDaysbyIndex($dateObj->getDaysInMonth() - 1, $dateObj->getDaysInMonth(), $month, $lastdayofmonthObj->getYear());
 							$nextmonthObj = $this->getLastdayofmonth($this->dayofweek_to_rpt[0], $dateObj);
 							$tempdateObj = $nextmonthObj;
-						}
-						else {
+						} else {
 							$tempdateObj = $lastdayofmonthObj;
 						}
 					}
@@ -476,10 +478,11 @@ 
 				}
 			} elseif ($this->recur_type == 'Yearly') {
 
-				if (isset($this->recur_freq))
-					$index = $year + $this->recur_freq;
-				else
-					$index = $year + 1;
+				if (isset($this->recur_freq)) {
+									$index = $year + $this->recur_freq;
+				} else {
+									$index = $year + 1;
+				}
 				if ($index > 2037 || $index < 1970) {
 					print("<font color='red'>" . \includes\Language::translate('LBL_CAL_LIMIT_MSG') . "</font>");
 					exit;
@@ -534,10 +537,11 @@ 
 		if ($dayofweek == $dateObj->dayofweek) {
 			return $dateObj;
 		} else {
-			if ($dayofweek > $dateObj->dayofweek)
-				$day = $dateObj->day - 7 + ($dayofweek - $dateObj->dayofweek);
-			else
-				$day = $dateObj->day - ($dateObj->dayofweek - $dayofweek);
+			if ($dayofweek > $dateObj->dayofweek) {
+							$day = $dateObj->day - 7 + ($dayofweek - $dateObj->dayofweek);
+			} else {
+							$day = $dateObj->day - ($dateObj->dayofweek - $dayofweek);
+			}
 			$index = $day - 1;
 			$month = $dateObj->month;
 			$year = $dateObj->year;

include/utils/Icon.php

Braces +9 added lines, -6 removed lines

@@ -46,12 +46,15 @@
 	public static function getIconByFileType($exntension)
 	{
 		$explodeExtension = reset(explode("/", $exntension));
-		if (isset(self::$extensionIcon[$explodeExtension]))
-			$fileIcon = self::$extensionIcon[$explodeExtension];
-		if (isset(self::$extensionIcon[$exntension]))
-			$fileIcon = self::$extensionIcon[$exntension];
-		if (!$fileIcon)
-			$fileIcon = 'userIcon-Documents';
+		if (isset(self::$extensionIcon[$explodeExtension])) {
+					$fileIcon = self::$extensionIcon[$explodeExtension];
+		}
+		if (isset(self::$extensionIcon[$exntension])) {
+					$fileIcon = self::$extensionIcon[$exntension];
+		}
+		if (!$fileIcon) {
+					$fileIcon = 'userIcon-Documents';
+		}
 		return $fileIcon;
 	}
 }

include/utils/utils.php

Spacing +1 added lines, -1 removed lines

@@ -1401,7 +1401,7 @@
 function isRecordExists($recordId, $cache = true)
 {
 	$recordMetaData = vtlib\Functions::getCRMRecordMetadata($recordId);
-	return (isset($recordMetaData) && $recordMetaData['deleted'] == 0 ) ? true : false;
+	return (isset($recordMetaData) && $recordMetaData['deleted'] == 0) ? true : false;
 }
 
 /** Function to set date values compatible to database (YY_MM_DD)

Braces +81 added lines, -59 removed lines

@@ -201,8 +201,9 @@ 
 		$inUTF8 = (strtoupper($default_charset) == 'UTF-8');
 	}
 
-	if (AppRequest::has('module') && AppRequest::has('file') && AppRequest::get('module') != 'Settings' && AppRequest::get('file') != 'ListView' && AppRequest::get('module') != 'Portal' && AppRequest::get('module') != 'Reports')
-		$ajaxAction = AppRequest::get('module') . 'Ajax';
+	if (AppRequest::has('module') && AppRequest::has('file') && AppRequest::get('module') != 'Settings' && AppRequest::get('file') != 'ListView' && AppRequest::get('module') != 'Portal' && AppRequest::get('module') != 'Reports') {
+			$ajaxAction = AppRequest::get('module') . 'Ajax';
+	}
 
 	if (is_string($string)) {
 		if ($action != 'CustomView' && $action != 'Export' && $action != $ajaxAction && $action != 'LeadConvertToEntities' && $action != 'CreatePDF' && $action != 'ConvertAsFAQ' && AppRequest::get('module') != 'Dashboard' && $action != 'CreateSOPDF' && $action != 'SendPDFMail' && (!AppRequest::has('submode'))) {
@@ -214,10 +215,11 @@ 
 
 		// In vtiger5 ajax request are treated specially and the data is encoded
 		if ($doconvert == true) {
-			if ($inUTF8)
-				$string = htmlentities($string, ENT_QUOTES, $default_charset);
-			else
-				$string = preg_replace(['/</', '/>/', '/"/'], ['&lt;', '&gt;', '&quot;'], $string);
+			if ($inUTF8) {
+							$string = htmlentities($string, ENT_QUOTES, $default_charset);
+			} else {
+							$string = preg_replace(['/</', '/>/', '/"/'], ['&lt;', '&gt;', '&quot;'], $string);
+			}
 		}
 	}
 	Vtiger_Cache::set('to_html', $oginalString, $string);
@@ -273,10 +275,11 @@ 
 	if ($module == 'Calendar') {
 		$cachedEventsFields = VTCacheUtils::lookupFieldInfo_Module('Events');
 		if ($cachedEventsFields) {
-			if (empty($cachedModuleFields))
-				$cachedModuleFields = $cachedEventsFields;
-			else
-				$cachedModuleFields = array_merge($cachedModuleFields, $cachedEventsFields);
+			if (empty($cachedModuleFields)) {
+							$cachedModuleFields = $cachedEventsFields;
+			} else {
+							$cachedModuleFields = array_merge($cachedModuleFields, $cachedEventsFields);
+			}
 		}
 	}
 
@@ -704,10 +707,11 @@ 
 			$pos++;
 		}
 	}
-	if (strtolower($default_charset) == 'utf-8')
-		return html_to_utf8($decodedStr);
-	else
-		return $decodedStr;
+	if (strtolower($default_charset) == 'utf-8') {
+			return html_to_utf8($decodedStr);
+	} else {
+			return $decodedStr;
+	}
 	//return html_to_utf8($decodedStr);
 }
 
@@ -726,13 +730,15 @@ 
 		while (($i--) > 0) {
 			if ($data != ($a = $data % ($p = pow(64, $i)))) {
 				$ret = chr(base_convert(str_pad(str_repeat(1, $i + 1), 8, "0"), 2, 10) + (($data - $a) / $p));
-				for ($i; $i > 0; $i--)
-					$ret .= chr(128 + ((($data % pow(64, $i)) - ($data % ($p = pow(64, $i - 1)))) / $p));
+				for ($i; $i > 0; $i--) {
+									$ret .= chr(128 + ((($data % pow(64, $i)) - ($data % ($p = pow(64, $i - 1)))) / $p));
+				}
 				break;
 			}
 		}
-	} else
-		$ret = "&#$data;";
+	} else {
+			$ret = "&#$data;";
+	}
 	return $ret;
 }
 
@@ -781,8 +787,9 @@ 
  */
 function escape_single_quotes($value)
 {
-	if (isset($value))
-		$value = str_replace("'", "\'", $value);
+	if (isset($value)) {
+			$value = str_replace("'", "\'", $value);
+	}
 	return $value;
 }
 
@@ -803,10 +810,11 @@ 
 			$str = str_replace('_', '\_', $str);
 			if ($flag == 0) {
 				// If value what to search is null then we should not add % which will fail
-				if (empty($str))
-					$str = '' . $str . '';
-				else
-					$str = '%' . $str . '%';
+				if (empty($str)) {
+									$str = '' . $str . '';
+				} else {
+									$str = '%' . $str . '%';
+				}
 			} elseif ($flag == 1) {
 				$str = '%' . $str;
 			} elseif ($flag == 2) {
@@ -865,8 +873,9 @@ 
 		} else {
 			$mulsel = "select distinct $fieldname from vtiger_$fieldname inner join vtiger_role2picklist on vtiger_role2picklist.picklistvalueid = vtiger_$fieldname.picklist_valueid where roleid ='" . $roleid . "' and picklistid in (select picklistid from vtiger_$fieldname) order by sortid asc";
 		}
-		if ($fieldname != 'firstname')
-			$mulselresult = $adb->query($mulsel);
+		if ($fieldname != 'firstname') {
+					$mulselresult = $adb->query($mulsel);
+		}
 		for ($j = 0; $j < $adb->num_rows($mulselresult); $j++) {
 			$fieldvalues[] = $adb->query_result($mulselresult, $j, $fieldname);
 		}
@@ -878,15 +887,17 @@ 
 					$temp_status[$keyvalue][($temp_count + $t)] = $fieldvalues[$t];
 				}
 				$fieldvalues = $temp_status[$keyvalue];
-			} else
-				$temp_status[$keyvalue] = $fieldvalues;
+			} else {
+							$temp_status[$keyvalue] = $fieldvalues;
+			}
+		}
+		if ($uitype == 33) {
+					$fieldlists[1][$keyvalue] = $fieldvalues;
+		} else if ($uitype == 55 && $fieldname == 'salutationtype') {
+					$fieldlists[$keyvalue] = $fieldvalues;
+		} else if ($uitype == 15) {
+					$fieldlists[$keyvalue] = $fieldvalues;
 		}
-		if ($uitype == 33)
-			$fieldlists[1][$keyvalue] = $fieldvalues;
-		else if ($uitype == 55 && $fieldname == 'salutationtype')
-			$fieldlists[$keyvalue] = $fieldvalues;
-		else if ($uitype == 15)
-			$fieldlists[$keyvalue] = $fieldvalues;
 	}
 	$log->debug("Exit from function getAccessPickListValues($module)");
 
@@ -907,8 +918,9 @@ 
 
 		$ret_str .= " ifnull($tbl_name.$col_name,'null') = ifnull(temp.$col_name,'null')";
 
-		if (count($field_array) != $i)
-			$ret_str .= " and ";
+		if (count($field_array) != $i) {
+					$ret_str .= " and ";
+		}
 		$i++;
 	}
 	return $ret_str;
@@ -1021,8 +1033,9 @@ 
 	foreach ($name as $module) {
 		$focus = CRMEntity::getInstance($module);
 		$query = $focus->buildSearchQueryForFieldTypes(11, $number);
-		if (empty($query))
-			return;
+		if (empty($query)) {
+					return;
+		}
 
 		$result = $adb->pquery($query, []);
 		if ($adb->num_rows($result) > 0) {
@@ -1229,8 +1242,9 @@ 
 	//require_once('modules/com_vtiger_workflow/VTEntityCache.inc');
 	$em = new VTEventsManager($adb);
 	$em->initTriggerCache();
-	if (!is_array($destinationRecordIds))
-		$destinationRecordIds = [$destinationRecordIds];
+	if (!is_array($destinationRecordIds)) {
+			$destinationRecordIds = [$destinationRecordIds];
+	}
 
 	$data = [];
 	$data['CRMEntity'] = $focus;
@@ -1277,11 +1291,13 @@ 
 {
 	global $Vtiger_Utils_Log, $_installOrUpdateVtlibModule;
 	$log = LoggerManager::getInstance();
-	if (!file_exists($packagepath))
-		return;
+	if (!file_exists($packagepath)) {
+			return;
+	}
 
-	if (isset($_installOrUpdateVtlibModule[$packagename . $packagepath]))
-		return;
+	if (isset($_installOrUpdateVtlibModule[$packagename . $packagepath])) {
+			return;
+	}
 	$_installOrUpdateVtlibModule[$packagename . $packagepath] = 'install';
 
 	$Vtiger_Utils_Log = defined('INSTALLATION_MODE_DEBUG') ? INSTALLATION_MODE_DEBUG : true;
@@ -1328,11 +1344,13 @@ 
 {
 	global $_installOrUpdateVtlibModule;
 	$log = LoggerManager::getInstance();
-	if (!file_exists($packagepath))
-		return;
+	if (!file_exists($packagepath)) {
+			return;
+	}
 
-	if (isset($_installOrUpdateVtlibModule[$module . $packagepath]))
-		return;
+	if (isset($_installOrUpdateVtlibModule[$module . $packagepath])) {
+			return;
+	}
 	$_installOrUpdateVtlibModule[$module . $packagepath] = 'update';
 
 	$Vtiger_Utils_Log = defined('INSTALLATION_MODE_DEBUG') ? INSTALLATION_MODE_DEBUG : true;
@@ -1416,20 +1434,23 @@ 
 	$delim = array('/', '.');
 	foreach ($delim as $delimiter) {
 		$x = strpos($value, $delimiter);
-		if ($x === false)
-			continue;
-		else {
+		if ($x === false) {
+					continue;
+		} else {
 			$value = str_replace($delimiter, '-', $value);
 			break;
 		}
 	}
 	list($y, $m, $d) = explode('-', $value);
-	if (strlen($y) == 1)
-		$y = '0' . $y;
-	if (strlen($m) == 1)
-		$m = '0' . $m;
-	if (strlen($d) == 1)
-		$d = '0' . $d;
+	if (strlen($y) == 1) {
+			$y = '0' . $y;
+	}
+	if (strlen($m) == 1) {
+			$m = '0' . $m;
+	}
+	if (strlen($d) == 1) {
+			$d = '0' . $d;
+	}
 	$value = implode('-', array($y, $m, $d));
 
 	if (strlen($y) < 4) {
@@ -1821,8 +1842,9 @@ 
 		$query = $queryGenerator->getQuery();
 		$current_page = ListViewSession::getCurrentPage($moduleName, $viewid);
 		$limit_start_rec = ($current_page - 1) * $list_max_entries_per_page;
-		if ($limit_start_rec < 0)
-			$limit_start_rec = 0;
+		if ($limit_start_rec < 0) {
+					$limit_start_rec = 0;
+		}
 		$query .= sprintf(' LIMIT %s,%s', $limit_start_rec, $list_max_entries_per_page);
 
 		$result = $adb->pquery($query, []);

Doc Comments +6 added lines, -2 removed lines

@@ -56,8 +56,8 @@ 
 
 /** Function to return a full name
  * @param $row -- row:: Type integer
- * @param $first_column -- first column:: Type string
- * @param $last_column -- last column:: Type string
+ * @param string $first_column -- first column:: Type string
+ * @param string $last_column -- last column:: Type string
  * @returns $fullname -- fullname:: Type string
  *
  */
@@ -713,6 +713,7 @@ 
 
 /**
  * simple HTML to UTF-8 conversion:
+ * @param string $data
  */
 function html_to_utf8($data)
 {
@@ -757,6 +758,7 @@ 
 
 /**
  * Function to find the UI type of a field based on the uitype id
+ * @param string $reqtype
  */
 function is_uitype($uitype, $reqtype)
 {
@@ -1539,6 +1541,8 @@ 
 
 /**
  * Function to get the approximate difference between two date time values as string
+ * @param integer $d1
+ * @param integer $d2
  */
 function dateDiffAsString($d1, $d2)
 {

include/utils/GraphUtils.php

Braces +9 added lines, -6 removed lines

@@ -69,10 +69,12 @@ 
 	$log = vglobal('log');
 	$log->debug("Entering color_generator(" . $count . "," . $start . "," . $step . ") method ...");
 	// explode color strings to RGB array
-	if ($start{0} == "#")
-		$start = substr($start, 1);
-	if ($step{0} == "#")
-		$step = substr($step, 1);
+	if ($start{0} == "#") {
+			$start = substr($start, 1);
+	}
+	if ($step{0} == "#") {
+			$step = substr($step, 1);
+	}
 	// pad shorter strings with 0
 	$start = substr($start . "000000", 0, 6);
 	$step = substr($step . "000000", 0, 6);
@@ -84,8 +86,9 @@ 
 		array_push($result, "#" . dechex($colors[0]) . dechex($colors[1]) . dechex($colors[2]));
 		for ($j = 0; $j < 3; $j++) {
 			$colors[$j] += $steps[$j];
-			if ($colors[$j] > 0xFF)
-				$colors[$j] -= 0xFF;
+			if ($colors[$j] > 0xFF) {
+							$colors[$j] -= 0xFF;
+			}
 		}
 	}
 	$log->debug("Exiting color_generator method ...");

include/ConfigUtils.php

Braces +3 added lines, -2 removed lines

@@ -61,8 +61,9 @@
 		self::$modules[$module] = $CONFIG;
 		switch ($argsLength) {
 			case 2:
-				if (!isset($CONFIG[$key]))
-					return false;
+				if (!isset($CONFIG[$key])) {
+									return false;
+				}
 				return $CONFIG[$key];
 				break;
 			default:

Doc Comments +36 added lines

@@ -16,11 +16,17 @@ 
 	protected static $sounds = [];
 	protected static $search = [];
 
+	/**
+	 * @param string $key
+	 */
 	public static function load($key, $config)
 	{
 		self::$$key = $config;
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function main($key, $value = false)
 	{
 		if (isset(self::$main[$key])) {
@@ -71,11 +77,17 @@ 
 		}
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function api($key, $defvalue = false)
 	{
 		return self::$api[$key];
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function debug($key, $defvalue = false)
 	{
 		if (empty(self::$debug)) {
@@ -85,6 +97,9 @@ 
 		return self::$debug[$key];
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function developer($key, $defvalue = false)
 	{
 		if (empty(self::$developer)) {
@@ -94,6 +109,9 @@ 
 		return self::$developer[$key];
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function security($key, $defvalue = false)
 	{
 		if (empty(self::$security)) {
@@ -103,6 +121,9 @@ 
 		return self::$security[$key];
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function securityKeys($key, $defvalue = false)
 	{
 		if (empty(self::$securityKeys)) {
@@ -112,6 +133,9 @@ 
 		return self::$securityKeys[$key];
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function performance($key, $defvalue = false)
 	{
 		if (empty(self::$performance)) {
@@ -121,6 +145,11 @@ 
 		return self::$performance[$key];
 	}
 
+	/**
+	 * @param string $key
+	 *
+	 * @return boolean
+	 */
 	public static function relation($key, $defvalue = false)
 	{
 		if (empty(self::$relation)) {
@@ -143,6 +172,9 @@ 
 		return self::$sounds[$key];
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public static function search($key, $defvalue = false)
 	{
 		if (empty(self::$search)) {
@@ -152,6 +184,10 @@ 
 		return self::$search[$key];
 	}
 
+	/**
+	 * @param string $key
+	 * @param integer $value
+	 */
 	public static function iniSet($key, $value)
 	{
 		@ini_set($key, $value);

include/Record.php

Spacing +2 added lines, -2 removed lines

@@ -184,7 +184,7 @@ 
 								$labelSearch[] = $row[$columnName];
 						}
 						$entityDisplay[$row['id']] = ['name' => implode(' ', $labelName), 'search' => implode(' ', $labelSearch)];
-					}else {
+					} else {
 						$entityDisplay[$row['id']] = trim(implode(' ', $labelName));
 					}
 				}
@@ -237,7 +237,7 @@ 
 	public static function isExists($recordId)
 	{
 		$recordMetaData = Functions::getCRMRecordMetadata($recordId);
-		return (isset($recordMetaData) && $recordMetaData['deleted'] == 0 ) ? true : false;
+		return (isset($recordMetaData) && $recordMetaData['deleted'] == 0) ? true : false;
 	}
 
 	public static function getType($recordId)

Braces +14 added lines, -11 removed lines

@@ -104,8 +104,9 @@ 
 	public static function computeLabels($moduleName, $ids, $search = false)
 	{
 		$adb = \PearDatabase::getInstance();
-		if (!is_array($ids))
-			$ids = [$ids];
+		if (!is_array($ids)) {
+					$ids = [$ids];
+		}
 		if ($moduleName == 'Events') {
 			$moduleName = 'Calendar';
 		}
@@ -171,20 +172,22 @@ 
 				while ($row = $adb->getRow($result)) {
 					$labelSearch = $labelName = [];
 					foreach ($columnsName as $columnName) {
-						if ($moduleInfoExtend && in_array($moduleInfoExtend[$columnName]['uitype'], [10, 51, 75, 81]))
-							$labelName[] = self::getLabel($row[$columnName]);
-						else
-							$labelName[] = $row[$columnName];
+						if ($moduleInfoExtend && in_array($moduleInfoExtend[$columnName]['uitype'], [10, 51, 75, 81])) {
+													$labelName[] = self::getLabel($row[$columnName]);
+						} else {
+													$labelName[] = $row[$columnName];
+						}
 					}
 					if ($search) {
 						foreach ($columnsSearch as $columnName) {
-							if ($moduleInfoExtend && in_array($moduleInfoExtend[$columnName]['uitype'], [10, 51, 75, 81]))
-								$labelSearch[] = self::getLabel($row[$columnName]);
-							else
-								$labelSearch[] = $row[$columnName];
+							if ($moduleInfoExtend && in_array($moduleInfoExtend[$columnName]['uitype'], [10, 51, 75, 81])) {
+															$labelSearch[] = self::getLabel($row[$columnName]);
+							} else {
+															$labelSearch[] = $row[$columnName];
+							}
 						}
 						$entityDisplay[$row['id']] = ['name' => implode(' ', $labelName), 'search' => implode(' ', $labelSearch)];
-					}else {
+					} else {
 						$entityDisplay[$row['id']] = trim(implode(' ', $labelName));
 					}
 				}

include/QueryGenerator/QueryGenerator.php

Braces +44 added lines, -30 removed lines

@@ -306,8 +306,9 @@ 
 
 	public function parseAdvFilterList($advFilterList, $glue = '')
 	{
-		if (!empty($glue))
-			$this->addConditionGlue($glue);
+		if (!empty($glue)) {
+					$this->addConditionGlue($glue);
+		}
 
 		$customView = new CustomView($this->module);
 		$dateSpecificConditions = $customView->getStdFilterConditions();
@@ -318,8 +319,9 @@ 
 				foreach ($filtercolumns as $index => $filter) {
 					$nameComponents = explode(':', $filter['columnname']);
 					// For Events "End Date & Time" field datatype should be DT. But, db will give D for due_date field
-					if ($nameComponents[2] == 'due_date' && $nameComponents[3] == 'Events_End_Date_&_Time')
-						$nameComponents[4] = 'DT';
+					if ($nameComponents[2] == 'due_date' && $nameComponents[3] == 'Events_End_Date_&_Time') {
+											$nameComponents[4] = 'DT';
+					}
 					if (empty($nameComponents[2]) && $nameComponents[1] == 'crmid' && $nameComponents[0] == 'vtiger_crmentity') {
 						$name = $this->getSQLColumn('id');
 					} else {
@@ -343,13 +345,15 @@ 
 						// If datatype is DT then we should append time also
 						if ($nameComponents[4] == 'DT') {
 							$startdate = explode(' ', $dateFilterResolvedList['startdate']);
-							if ($startdate[1] == '')
-								$startdate[1] = '00:00:00';
+							if ($startdate[1] == '') {
+															$startdate[1] = '00:00:00';
+							}
 							$dateFilterResolvedList['startdate'] = $startdate[0] . ' ' . $startdate[1];
 
 							$enddate = explode(' ', $dateFilterResolvedList['enddate']);
-							if ($enddate[1] == '')
-								$enddate[1] = '23:59:59';
+							if ($enddate[1] == '') {
+															$enddate[1] = '23:59:59';
+							}
 							$dateFilterResolvedList['enddate'] = $enddate[0] . ' ' . $enddate[1];
 						}
 						$value = [];
@@ -367,12 +371,14 @@ 
 
 						$value = [];
 						$start = explode(' ', $startDate);
-						if ($start[1] == "")
-							$startDate = $start[0] . ' ' . '00:00:00';
+						if ($start[1] == "") {
+													$startDate = $start[0] . ' ' . '00:00:00';
+						}
 
 						$end = explode(' ', $endDate);
-						if ($end[1] == "")
-							$endDate = $end[0] . ' ' . '23:59:59';
+						if ($end[1] == "") {
+													$endDate = $end[0] . ' ' . '23:59:59';
+						}
 
 						$value[] = $startDate;
 						$value[] = $endDate;
@@ -405,8 +411,9 @@ 
 				}
 				$this->endGroup();
 				$groupConditionGlue = $groupcolumns['condition'];
-				if (!empty($groupConditionGlue))
-					$this->addConditionGlue($groupConditionGlue);
+				if (!empty($groupConditionGlue)) {
+									$this->addConditionGlue($groupConditionGlue);
+				}
 			}
 		}
 	}
@@ -698,8 +705,9 @@ 
 				$fields = $meta->getModuleFields();
 				$fieldObject = $fields[$fieldName];
 
-				if (empty($fieldObject))
-					continue;
+				if (empty($fieldObject)) {
+									continue;
+				}
 
 				$tableName = $fieldObject->getTableName();
 				if (!in_array($tableName, $referenceFieldTableList)) {
@@ -758,8 +766,9 @@ 
 			$operator = strtolower($conditionInfo['operator']);
 			if ($operator == 'between' && $this->isDateType($field->getFieldDataType())) {
 				$start = explode(' ', $conditionInfo['value'][0]);
-				if (count($start) == 2)
-					$conditionInfo['value'][0] = getValidDBInsertDateTimeValue($start[0] . ' ' . $start[1]);
+				if (count($start) == 2) {
+									$conditionInfo['value'][0] = getValidDBInsertDateTimeValue($start[0] . ' ' . $start[1]);
+				}
 
 				$end = explode(' ', $conditionInfo['values'][1]);
 				// Dates will be equal for Today, Tomorrow, Yesterday.
@@ -920,8 +929,9 @@ 
 						$conditionGlue = ' && ';
 						if ($conditionInfo['operator'] == 'n') {
 							$specialCondition = ' || ' . $field->getTableName() . '.' . $field->getColumnName() . ' IS NULL ';
-							if (!empty($otherField))
-								$specialConditionForOtherField = ' || ' . $otherField->getTableName() . '.' . $otherField->getColumnName() . ' IS NULL ';
+							if (!empty($otherField)) {
+															$specialConditionForOtherField = ' || ' . $otherField->getTableName() . '.' . $otherField->getColumnName() . ' IS NULL ';
+							}
 						}
 					}
 
@@ -931,10 +941,11 @@ 
 					}
 
 					$fieldSql .= "$fieldGlue ((" . $field->getTableName() . '.' . $field->getColumnName() . ' ' . $valueSql . " $specialCondition) ";
-					if (!empty($otherField))
-						$fieldSql .= $conditionGlue . '(' . $otherField->getTableName() . '.' . $otherField->getColumnName() . ' ' . $otherFieldValueSql . ' ' . $specialConditionForOtherField . '))';
-					else
-						$fieldSql .= ')';
+					if (!empty($otherField)) {
+											$fieldSql .= $conditionGlue . '(' . $otherField->getTableName() . '.' . $otherField->getColumnName() . ' ' . $otherFieldValueSql . ' ' . $specialConditionForOtherField . '))';
+					} else {
+											$fieldSql .= ')';
+					}
 				} elseif ($conditionInfo['custom']) {
 					$fieldSql .= $fieldGlue . 'vtiger_crmentity.crmid ' . $valueSql;
 				} else {
@@ -1306,8 +1317,9 @@ 
 	public function addCondition($fieldname, $value, $operator, $glue = null, $custom = false, $newGroupType = null, $ignoreComma = false)
 	{
 		$conditionNumber = $this->conditionInstanceCount++;
-		if ($glue != null && $conditionNumber > 0)
-			$this->addConditionGlue($glue);
+		if ($glue != null && $conditionNumber > 0) {
+					$this->addConditionGlue($glue);
+		}
 
 		$this->groupInfo .= "$conditionNumber ";
 		$this->whereFields[] = $fieldname;
@@ -1328,8 +1340,9 @@ 
 	public function addReferenceModuleFieldCondition($relatedModule, $referenceField, $fieldName, $value, $SQLOperator, $glue = null)
 	{
 		$conditionNumber = $this->conditionInstanceCount++;
-		if ($glue != null && $conditionNumber > 0)
-			$this->addConditionGlue($glue);
+		if ($glue != null && $conditionNumber > 0) {
+					$this->addConditionGlue($glue);
+		}
 
 		$this->groupInfo .= "$conditionNumber ";
 		$this->referenceModuleField[$conditionNumber] = array('relatedModule' => $relatedModule, 'referenceField' => $referenceField, 'fieldName' => $fieldName, 'value' => $value,
@@ -1403,8 +1416,9 @@ 
 					}
 					$this->endGroup();
 					$groupConditionGlue = $groupcolumns['condition'];
-					if (!empty($groupConditionGlue))
-						$this->addConditionGlue($groupConditionGlue);
+					if (!empty($groupConditionGlue)) {
+											$this->addConditionGlue($groupConditionGlue);
+					}
 				}
 			}
 			$this->endGroup();

Doc Comments +19 added lines

@@ -153,6 +153,9 @@ 
 		return $this->whereFields;
 	}
 
+	/**
+	 * @param string $columns
+	 */
 	public function setCustomColumn($columns)
 	{
 		$this->columnsCustom[] = $columns;
@@ -193,6 +196,9 @@ 
 		return $this->ownerFields;
 	}
 
+	/**
+	 * @return string
+	 */
 	public function getModuleNameFields($module)
 	{
 		return $this->moduleNameFields[$module];
@@ -1249,6 +1255,9 @@ 
 		return $sql;
 	}
 
+	/**
+	 * @param string $groupSql
+	 */
 	private function makeGroupSqlReplacements($fieldSqlList, $groupSql)
 	{
 		$pos = 0;
@@ -1286,6 +1295,9 @@ 
 		return ($type == 'date' || $type == 'datetime');
 	}
 
+	/**
+	 * @return string
+	 */
 	public function fixDateTimeValue($name, $value, $first = true)
 	{
 		$moduleFields = $this->getModuleFields();
@@ -1303,6 +1315,10 @@ 
 		return $value;
 	}
 
+	/**
+	 * @param string $glue
+	 * @param string $newGroupType
+	 */
 	public function addCondition($fieldname, $value, $operator, $glue = null, $custom = false, $newGroupType = null, $ignoreComma = false)
 	{
 		$conditionNumber = $this->conditionInstanceCount++;
@@ -1346,6 +1362,9 @@ 
 		return array('name' => $fieldname, 'value' => $value, 'operator' => $operator, 'custom' => $custom);
 	}
 
+	/**
+	 * @param string $groupType
+	 */
 	public function startGroup($groupType)
 	{
 		$this->groupInfo .= " $groupType (";