YetiForceCompany / YetiForceCRM

vtlib/Vtiger/Link.php

Doc Comments +3 added lines

@@ -132,6 +132,7 @@ 
 	/**
 	 * Delete all links related to module
 	 * @param Integer Module ID.
+	 * @param boolean $tabid
 	 */
 	static function deleteAll($tabid)
 	{
@@ -143,6 +144,7 @@ 
 	/**
 	 * Get all the links related to module
 	 * @param Integer Module ID.
+	 * @param boolean $tabid
 	 */
 	static function getAll($tabid)
 	{
@@ -234,6 +236,7 @@ 
 
 	/**
 	 * Extract the links of module for export.
+	 * @param boolean $tabid
 	 */
 	static function getAllForExport($tabid)
 	{

Spacing +1 added lines, -1 removed lines

@@ -172,7 +172,7 @@
 					$params = $type;
 					$permittedTabIdList = getPermittedModuleIdList();
 					if (count($permittedTabIdList) > 0 && $current_user->is_admin !== 'on') {
-						array_push($permittedTabIdList, 0);  // Added to support one link for all modules
+						array_push($permittedTabIdList, 0); // Added to support one link for all modules
 						$sql .= ' and tabid IN (' .
 							Utils::implodestr('?', count($permittedTabIdList), ',') . ')';
 						$params[] = $permittedTabIdList;

Braces +6 added lines, -4 removed lines

@@ -196,14 +196,16 @@
 
 		$strtemplate = new \Vtiger_StringTemplate();
 		if ($parameters) {
-			foreach ($parameters as $key => $value)
-				$strtemplate->assign($key, $value);
+			foreach ($parameters as $key => $value) {
+							$strtemplate->assign($key, $value);
+			}
 		}
 
 		$instances = [];
 		if ($multitype) {
-			foreach ($type as $t)
-				$instances[$t] = [];
+			foreach ($type as $t) {
+							$instances[$t] = [];
+			}
 		}
 
 		while ($row = $adb->fetch_array($result)) {

vtlib/Vtiger/LinkData.php

Doc Comments +3 added lines

@@ -23,6 +23,9 @@
 	protected $user;
 	protected $module;
 
+	/**
+	 * @param Link $link
+	 */
 	public function __construct($link, $user, $input = null)
 	{
 		$this->link = $link;

vtlib/Vtiger/Mailer.php

Doc Comments +3 added lines, -1 removed lines

@@ -89,6 +89,7 @@ 
 	/**
 	 * Initialize this instance using mail template
 	 * @access private
+	 * @param boolean $emailtemplate
 	 */
 	public function initFromTemplate($emailtemplate)
 	{
@@ -187,6 +188,7 @@ 
 
 	/**
 	 * Add this mail to queue
+	 * @param boolean $linktoid
 	 */
 	public function __AddToQueue($linktoid)
 	{
@@ -225,7 +227,7 @@ 
 
 	/**
 	 * Function to prepares email as string
-	 * @return type
+	 * @return string
 	 */
 	public function getMailString()
 	{

Braces +45 added lines, -32 removed lines

@@ -63,8 +63,9 @@ 
 			}
 			// End
 
-			if (empty($this->SMTPAuth))
-				$this->SMTPAuth = false;
+			if (empty($this->SMTPAuth)) {
+							$this->SMTPAuth = false;
+			}
 
 			$this->ConfigSenderInfo($adb->query_result($result, 0, 'from_email_field'));
 
@@ -121,8 +122,9 @@ 
 	 */
 	public function ConfigSenderInfo($fromemail, $fromname = '', $replyto = '')
 	{
-		if (empty($fromname))
-			$fromname = $fromemail;
+		if (empty($fromname)) {
+					$fromname = $fromemail;
+		}
 
 		$this->From = $fromemail;
 		//fix for (http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/8001)
@@ -135,11 +137,13 @@ 
 	 */
 	public function Send($sync = false, $linktoid = false)
 	{
-		if (!$this->_serverConfigured)
-			return;
+		if (!$this->_serverConfigured) {
+					return;
+		}
 
-		if ($sync)
-			return parent::Send();
+		if ($sync) {
+					return parent::Send();
+		}
 
 		$this->__AddToQueue($linktoid);
 		return true;
@@ -153,11 +157,13 @@ 
 	 */
 	public function SendTo($toemail, $toname = '', $emailtemplate = false, $linktoid = false, $sync = false)
 	{
-		if (empty($toname))
-			$toname = $toemail;
+		if (empty($toname)) {
+					$toname = $toemail;
+		}
 		$this->AddAddress($toemail, $toname);
-		if ($emailtemplate)
-			$this->initFromTemplate($emailtemplate);
+		if ($emailtemplate) {
+					$this->initFromTemplate($emailtemplate);
+		}
 		return $this->Send($sync, $linktoid);
 	}
 
@@ -196,28 +202,33 @@ 
 			$adb->pquery('INSERT INTO vtiger_mailer_queue(id,fromname,fromemail,content_type,subject,body,mailer,relcrmid) VALUES(?,?,?,?,?,?,?,?)', Array($uniqueid, $this->FromName, $this->From, $this->ContentType, $this->Subject, $this->Body, $this->Mailer, $linktoid));
 			$queueid = $adb->database->Insert_ID();
 			foreach ($this->to as $toinfo) {
-				if (empty($toinfo[0]))
-					continue;
+				if (empty($toinfo[0])) {
+									continue;
+				}
 				$adb->pquery('INSERT INTO vtiger_mailer_queueinfo(id, name, email, type) VALUES(?,?,?,?)', Array($queueid, $toinfo[1], $toinfo[0], 'TO'));
 			}
 			foreach ($this->cc as $ccinfo) {
-				if (empty($ccinfo[0]))
-					continue;
+				if (empty($ccinfo[0])) {
+									continue;
+				}
 				$adb->pquery('INSERT INTO vtiger_mailer_queueinfo(id, name, email, type) VALUES(?,?,?,?)', Array($queueid, $ccinfo[1], $ccinfo[0], 'CC'));
 			}
 			foreach ($this->bcc as $bccinfo) {
-				if (empty($bccinfo[0]))
-					continue;
+				if (empty($bccinfo[0])) {
+									continue;
+				}
 				$adb->pquery('INSERT INTO vtiger_mailer_queueinfo(id, name, email, type) VALUES(?,?,?,?)', Array($queueid, $bccinfo[1], $bccinfo[0], 'BCC'));
 			}
 			foreach ($this->ReplyTo as $rtoinfo) {
-				if (empty($rtoinfo[0]))
-					continue;
+				if (empty($rtoinfo[0])) {
+									continue;
+				}
 				$adb->pquery('INSERT INTO vtiger_mailer_queueinfo(id, name, email, type) VALUES(?,?,?,?)', Array($queueid, $rtoinfo[1], $rtoinfo[0], 'RPLYTO'));
 			}
 			foreach ($this->attachment as $attachmentinfo) {
-				if (empty($attachmentinfo[0]))
-					continue;
+				if (empty($attachmentinfo[0])) {
+									continue;
+				}
 				$adb->pquery('INSERT INTO vtiger_mailer_queueattachments(id, path, name, encoding, type) VALUES(?,?,?,?,?)', Array($queueid, $attachmentinfo[0], $attachmentinfo[2], $attachmentinfo[3], $attachmentinfo[4]));
 			}
 		}
@@ -238,8 +249,9 @@ 
 	static function dispatchQueue(Vtiger_Mailer_Listener $listener = null)
 	{
 		$adb = \PearDatabase::getInstance();
-		if (!Utils::CheckTable('vtiger_mailer_queue'))
-			return;
+		if (!Utils::CheckTable('vtiger_mailer_queue')) {
+					return;
+		}
 
 		$mailer = new self();
 		$queue = $adb->pquery('SELECT * FROM vtiger_mailer_queue WHERE failed != ?', array(1));
@@ -261,14 +273,15 @@ 
 				$emails = $adb->pquery('SELECT * FROM vtiger_mailer_queueinfo WHERE id=?', Array($queueid));
 				for ($eidx = 0; $eidx < $adb->num_rows($emails); ++$eidx) {
 					$email_record = $adb->fetch_array($emails, $eidx);
-					if ($email_record[type] == 'TO')
-						$mailer->AddAddress($email_record[email], $email_record[name]);
-					else if ($email_record[type] == 'CC')
-						$mailer->AddCC($email_record[email], $email_record[name]);
-					else if ($email_record[type] == 'BCC')
-						$mailer->AddBCC($email_record[email], $email_record[name]);
-					else if ($email_record[type] == 'RPLYTO')
-						$mailer->AddReplyTo($email_record[email], $email_record[name]);
+					if ($email_record[type] == 'TO') {
+											$mailer->AddAddress($email_record[email], $email_record[name]);
+					} else if ($email_record[type] == 'CC') {
+											$mailer->AddCC($email_record[email], $email_record[name]);
+					} else if ($email_record[type] == 'BCC') {
+											$mailer->AddBCC($email_record[email], $email_record[name]);
+					} else if ($email_record[type] == 'RPLYTO') {
+											$mailer->AddReplyTo($email_record[email], $email_record[name]);
+					}
 				}
 
 				$attachments = $adb->pquery('SELECT * FROM vtiger_mailer_queueattachments WHERE id=?', Array($queueid));

vtlib/Vtiger/ModuleBasic.php

Doc Comments +4 added lines, -1 removed lines

@@ -321,6 +321,7 @@ 
 	/**
 	 * Set entity identifier field for this module
 	 * @param Field Instance of field to use
+	 * @param Field $fieldInstance
 	 */
 	public function setEntityIdentifier($fieldInstance)
 	{
@@ -397,6 +398,7 @@ 
 	/**
 	 * Disable tools for this module
 	 * @param mixed String or Array with value ['Import', 'Export', 'Merge']
+	 * @param string $tools
 	 */
 	public function disableTools($tools)
 	{
@@ -411,6 +413,7 @@ 
 	/**
 	 * Add block to this module
 	 * @param vtlib\Block Instance of block to add
+	 * @param Block $blockInstance
 	 */
 	public function addBlock($blockInstance)
 	{
@@ -421,6 +424,7 @@ 
 	/**
 	 * Add filter to this module
 	 * @param vtlib\Filter Instance of filter to add
+	 * @param Filter $filterInstance
 	 */
 	public function addFilter($filterInstance)
 	{
@@ -552,7 +556,6 @@ 
 
 	/**
 	 * Function to remove files related to a module
-	 * @param  string $path - dir path
 	 */
 	public function deleteDir($moduleInstance)
 	{

Braces +31 added lines, -22 removed lines

@@ -131,10 +131,12 @@ 
 		self::log("Creating Module $this->name ... STARTED");
 
 		$this->id = $this->__getUniqueId();
-		if (!$this->tabsequence)
-			$this->tabsequence = $this->__getNextSequence();
-		if (!$this->label)
-			$this->label = $this->name;
+		if (!$this->tabsequence) {
+					$this->tabsequence = $this->__getNextSequence();
+		}
+		if (!$this->label) {
+					$this->label = $this->name;
+		}
 
 		$customized = 1; // To indicate this is a Custom Module
 
@@ -237,10 +239,11 @@ 
 	 */
 	public function save()
 	{
-		if ($this->id)
-			$this->__update();
-		else
-			$this->__create();
+		if ($this->id) {
+					$this->__update();
+		} else {
+					$this->__create();
+		}
 		return $this->id;
 	}
 
@@ -300,13 +303,16 @@ 
 
 		// Initialize tablename and index column names
 		$lcasemodname = strtolower($this->name);
-		if (!$this->basetable)
-			$this->basetable = "vtiger_$lcasemodname";
-		if (!$this->basetableid)
-			$this->basetableid = $lcasemodname . 'id';
+		if (!$this->basetable) {
+					$this->basetable = "vtiger_$lcasemodname";
+		}
+		if (!$this->basetableid) {
+					$this->basetableid = $lcasemodname . 'id';
+		}
 
-		if (!$this->customtable)
-			$this->customtable = $this->basetable . 'cf';
+		if (!$this->customtable) {
+					$this->customtable = $this->basetable . 'cf';
+		}
 
 		Utils::CreateTable($this->basetable, "($this->basetableid int(19) PRIMARY KEY, CONSTRAINT `fk_1_$this->basetable` FOREIGN KEY (`$this->basetableid`) REFERENCES `vtiger_crmentity` (`crmid`) ON DELETE CASCADE)", true);
 		Utils::CreateTable($this->customtable, "($this->basetableid int(19) PRIMARY KEY, CONSTRAINT `fk_1_$this->customtable` FOREIGN KEY (`$this->basetableid`) REFERENCES `$this->basetable` (`$this->basetableid`) ON DELETE CASCADE)", true);
@@ -327,10 +333,12 @@ 
 		$adb = \PearDatabase::getInstance();
 
 		if ($this->basetableid) {
-			if (!$this->entityidfield)
-				$this->entityidfield = $this->basetableid;
-			if (!$this->entityidcolumn)
-				$this->entityidcolumn = $this->basetableid;
+			if (!$this->entityidfield) {
+							$this->entityidfield = $this->basetableid;
+			}
+			if (!$this->entityidcolumn) {
+							$this->entityidcolumn = $this->basetableid;
+			}
 		}
 		if ($this->entityidfield && $this->entityidcolumn) {
 			$result = $adb->pquery('SELECT tabid FROM vtiger_entityname WHERE tablename=? && tabid=?', array($fieldInstance->table, $this->id));
@@ -435,10 +443,11 @@ 
 	public function getFields($blockInstance = false)
 	{
 		$fields = false;
-		if ($blockInstance)
-			$fields = Field::getAllForBlock($blockInstance, $this);
-		else
-			$fields = Field::getAllForModule($this);
+		if ($blockInstance) {
+					$fields = Field::getAllForBlock($blockInstance, $this);
+		} else {
+					$fields = Field::getAllForModule($this);
+		}
 		return $fields;
 	}
 

vtlib/Vtiger/Net/Client.php

Doc Comments +1 added lines

@@ -25,6 +25,7 @@
 	 * @param String URL of the site
 	 * Example: 
 	 * $client = new Vtiger_New_Client('http://www.vtiger.com');
+	 * @param string|false $url
 	 */
 	public function __construct($url)
 	{

Braces +15 added lines, -11 removed lines

@@ -77,14 +77,16 @@ 
 	 */
 	public function doGet($params = false, $timeout = null)
 	{
-		if ($timeout)
-			$this->client->_timeout = $timeout;
+		if ($timeout) {
+					$this->client->_timeout = $timeout;
+		}
 		$this->client->setURL($this->url);
 		$this->client->setMethod(HTTP_REQUEST_METHOD_GET);
 
 		if ($params) {
-			foreach ($params as $key => $value)
-				$this->client->addQueryString($key, $value);
+			foreach ($params as $key => $value) {
+							$this->client->addQueryString($key, $value);
+			}
 		}
 		$this->response = $this->client->sendRequest();
 
@@ -103,17 +105,19 @@ 
 	 */
 	public function doPost($params = false, $timeout = null)
 	{
-		if ($timeout)
-			$this->client->_timeout = $timeout;
+		if ($timeout) {
+					$this->client->_timeout = $timeout;
+		}
 		$this->client->setURL($this->url);
 		$this->client->setMethod(HTTP_REQUEST_METHOD_POST);
 
 		if ($params) {
-			if (is_string($params))
-				$this->client->addRawPostData($params);
-			else {
-				foreach ($params as $key => $value)
-					$this->client->addPostData($key, $value);
+			if (is_string($params)) {
+							$this->client->addRawPostData($params);
+			} else {
+				foreach ($params as $key => $value) {
+									$this->client->addPostData($key, $value);
+				}
 			}
 		}
 		$this->response = $this->client->sendRequest();

vtlib/Vtiger/PackageImport.php

Doc Comments +19 added lines

@@ -53,6 +53,7 @@ 
 
 	/**
 	 * Get type of package (as specified in manifest)
+	 * @return string
 	 */
 	public function type()
 	{
@@ -393,6 +394,7 @@ 
 	/**
 	 * Cache the field instance for re-use
 	 * @access private
+	 * @param Field $fieldInstance
 	 */
 	public function __AddModuleFieldToCache($moduleInstance, $fieldname, $fieldInstance)
 	{
@@ -674,6 +676,8 @@ 
 	/**
 	 * Import Blocks of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
+	 * @param Module $moduleInstance
 	 */
 	public function import_Blocks($modulenode, $moduleInstance)
 	{
@@ -717,6 +721,7 @@ 
 	/**
 	 * Import Fields of the module
 	 * @access private
+	 * @param Block $blockInstance
 	 */
 	public function import_Fields($blocknode, $blockInstance, $moduleInstance)
 	{
@@ -807,6 +812,8 @@ 
 	/**
 	 * Import Custom views of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
+	 * @param Module $moduleInstance
 	 */
 	public function import_CustomViews($modulenode, $moduleInstance)
 	{
@@ -851,6 +858,8 @@ 
 	/**
 	 * Import Sharing Access of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
+	 * @param Module $moduleInstance
 	 */
 	public function import_SharingAccess($modulenode, $moduleInstance)
 	{
@@ -867,6 +876,8 @@ 
 	/**
 	 * Import Events of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
+	 * @param Module $moduleInstance
 	 */
 	public function import_Events($modulenode, $moduleInstance)
 	{
@@ -899,6 +910,8 @@ 
 	/**
 	 * Import actions of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
+	 * @param Module $moduleInstance
 	 */
 	public function import_Actions($modulenode, $moduleInstance)
 	{
@@ -925,6 +938,8 @@ 
 	/**
 	 * Import related lists of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
+	 * @param Module $moduleInstance
 	 */
 	public function import_RelatedLists($modulenode, $moduleInstance)
 	{
@@ -1004,6 +1019,7 @@ 
 	/**
 	 * Import cron jobs of the module.
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
 	 */
 	public function import_CronTasks($modulenode)
 	{
@@ -1022,6 +1038,9 @@ 
 		}
 	}
 
+	/**
+	 * @param \SimpleXMLElement $modulenode
+	 */
 	public function import_update($modulenode)
 	{
 		$dirName = 'cache/updates';

Braces +98 added lines, -66 removed lines

@@ -101,8 +101,9 @@ 
 	{
 		$xpathres = $this->xpath($path);
 		foreach ($xpathres as $pathkey => $pathvalue) {
-			if ($pathkey == $path)
-				return $pathvalue;
+			if ($pathkey == $path) {
+							return $pathvalue;
+			}
 		}
 		return false;
 	}
@@ -121,13 +122,15 @@ 
 
 		if ($packagetype) {
 			$lcasetype = strtolower($packagetype);
-			if ($lcasetype == 'language')
-				return true;
+			if ($lcasetype == 'language') {
+							return true;
+			}
 		}
 		if ($packagetype) {
 			$lcasetype = strtolower($packagetype);
-			if ($lcasetype == 'layout')
-				return true;
+			if ($lcasetype == 'layout') {
+							return true;
+			}
 		}
 		return false;
 	}
@@ -146,8 +149,9 @@ 
 
 		if ($packagetype) {
 			$lcasetype = strtolower($packagetype);
-			if ($lcasetype == 'extension')
-				return true;
+			if ($lcasetype == 'extension') {
+							return true;
+			}
 		}
 		return false;
 	}
@@ -163,8 +167,9 @@ 
 
 		if ($packagetype) {
 			$lcasetype = strtolower($packagetype);
-			if ($lcasetype == 'update')
-				return true;
+			if ($lcasetype == 'update') {
+							return true;
+			}
 		}
 		return false;
 	}
@@ -183,8 +188,9 @@ 
 
 		if ($packagetype) {
 			$lcasetype = strtolower($packagetype);
-			if ($lcasetype == 'layout')
-				return true;
+			if ($lcasetype == 'layout') {
+							return true;
+			}
 		}
 		return false;
 	}
@@ -227,8 +233,9 @@ 
 	public function getParameters()
 	{
 		$parameters = [];
-		if (empty($this->_modulexml->parameters))
-			return $parameters;
+		if (empty($this->_modulexml->parameters)) {
+					return $parameters;
+		}
 		foreach ($this->_modulexml->parameters->parameter as $parameter) {
 			$parameters[] = $parameter;
 		}
@@ -338,17 +345,21 @@ 
 		}
 
 		$validzip = false;
-		if ($manifestxml_found && $languagefile_found && $moduleVersionFound)
-			$validzip = true;
+		if ($manifestxml_found && $languagefile_found && $moduleVersionFound) {
+					$validzip = true;
+		}
 
-		if ($manifestxml_found && $layoutfile_found && $moduleVersionFound)
-			$validzip = true;
+		if ($manifestxml_found && $layoutfile_found && $moduleVersionFound) {
+					$validzip = true;
+		}
 
-		if ($manifestxml_found && $languagefile_found && $extensionfile_found && $moduleVersionFound)
-			$validzip = true;
+		if ($manifestxml_found && $languagefile_found && $extensionfile_found && $moduleVersionFound) {
+					$validzip = true;
+		}
 
-		if ($manifestxml_found && $updatefile_found && $moduleVersionFound)
-			$validzip = true;
+		if ($manifestxml_found && $updatefile_found && $moduleVersionFound) {
+					$validzip = true;
+		}
 
 		if ($validzip) {
 			if (!empty($this->_modulexml->license)) {
@@ -365,8 +376,9 @@ 
 				}
 			}
 		}
-		if ($unzip)
-			$unzip->close();
+		if ($unzip) {
+					$unzip->close();
+		}
 		return $validzip;
 	}
 
@@ -376,8 +388,9 @@ 
 	 */
 	public function getModuleNameFromZip($zipfile)
 	{
-		if (!$this->checkZip($zipfile))
-			return null;
+		if (!$this->checkZip($zipfile)) {
+					return null;
+		}
 		return (string) $this->_modulexml->name;
 	}
 
@@ -453,8 +466,9 @@ 
 				$unzip->unzip("$module.png", 'layouts/' . \Vtiger_Viewer::getDefaultLayoutName() . "/skins/images/$module.png");
 			}
 
-			if ($unzip)
-				$unzip->close();
+			if ($unzip) {
+							$unzip->close();
+			}
 		}
 		return $module;
 	}
@@ -642,8 +656,9 @@ 
 	 */
 	public function import_Tables($modulenode)
 	{
-		if (empty($modulenode->tables) || empty($modulenode->tables->table))
-			return;
+		if (empty($modulenode->tables) || empty($modulenode->tables->table)) {
+					return;
+		}
 		$adb = \PearDatabase::getInstance();
 		$adb->query('SET FOREIGN_KEY_CHECKS = 0;');
 
@@ -677,8 +692,9 @@ 
 	 */
 	public function import_Blocks($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->blocks) || empty($modulenode->blocks->block))
-			return;
+		if (empty($modulenode->blocks) || empty($modulenode->blocks->block)) {
+					return;
+		}
 		foreach ($modulenode->blocks->block as $blocknode) {
 			$blockInstance = $this->import_Block($modulenode, $moduleInstance, $blocknode);
 			$this->import_Fields($blocknode, $blockInstance, $moduleInstance);
@@ -697,8 +713,9 @@ 
 		$blockInstance->label = $blocklabel;
 		if (isset($blocknode->sequence) && isset($blocknode->display_status)) {
 			$blockInstance->sequence = strval($blocknode->sequence);
-			if ($blockInstance->sequence = "")
-				$blockInstance->sequence = NULL;
+			if ($blockInstance->sequence = "") {
+							$blockInstance->sequence = NULL;
+			}
 			$blockInstance->showtitle = strval($blocknode->show_title);
 			$blockInstance->visible = strval($blocknode->visible);
 			$blockInstance->increateview = strval($blocknode->create_view);
@@ -720,8 +737,9 @@ 
 	 */
 	public function import_Fields($blocknode, $blockInstance, $moduleInstance)
 	{
-		if (empty($blocknode->fields) || empty($blocknode->fields->field))
-			return;
+		if (empty($blocknode->fields) || empty($blocknode->fields->field)) {
+					return;
+		}
 
 		foreach ($blocknode->fields->field as $fieldnode) {
 			$fieldInstance = $this->import_Field($blocknode, $blockInstance, $moduleInstance, $fieldnode);
@@ -752,17 +770,21 @@ 
 		$fieldInstance->displaytype = $fieldnode->displaytype;
 		$fieldInstance->info_type = $fieldnode->info_type;
 
-		if (!empty($fieldnode->fieldparams))
-			$fieldInstance->fieldparams = $fieldnode->fieldparams;
+		if (!empty($fieldnode->fieldparams)) {
+					$fieldInstance->fieldparams = $fieldnode->fieldparams;
+		}
 
-		if (!empty($fieldnode->helpinfo))
-			$fieldInstance->helpinfo = $fieldnode->helpinfo;
+		if (!empty($fieldnode->helpinfo)) {
+					$fieldInstance->helpinfo = $fieldnode->helpinfo;
+		}
 
-		if (isset($fieldnode->masseditable))
-			$fieldInstance->masseditable = $fieldnode->masseditable;
+		if (isset($fieldnode->masseditable)) {
+					$fieldInstance->masseditable = $fieldnode->masseditable;
+		}
 
-		if (isset($fieldnode->columntype) && !empty($fieldnode->columntype))
-			$fieldInstance->columntype = strval($fieldnode->columntype);
+		if (isset($fieldnode->columntype) && !empty($fieldnode->columntype)) {
+					$fieldInstance->columntype = strval($fieldnode->columntype);
+		}
 
 		if (!empty($fieldnode->tree_template)) {
 			$templateid = $fieldInstance->setTreeTemplate($fieldnode->tree_template, $moduleInstance);
@@ -810,8 +832,9 @@ 
 	 */
 	public function import_CustomViews($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->customviews) || empty($modulenode->customviews->customview))
-			return;
+		if (empty($modulenode->customviews) || empty($modulenode->customviews->customview)) {
+					return;
+		}
 		foreach ($modulenode->customviews->customview as $customviewnode) {
 			$this->import_CustomView($modulenode, $moduleInstance, $customviewnode);
 		}
@@ -854,8 +877,9 @@ 
 	 */
 	public function import_SharingAccess($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->sharingaccess))
-			return;
+		if (empty($modulenode->sharingaccess)) {
+					return;
+		}
 
 		if (!empty($modulenode->sharingaccess->default)) {
 			foreach ($modulenode->sharingaccess->default as $defaultnode) {
@@ -870,8 +894,9 @@ 
 	 */
 	public function import_Events($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->events) || empty($modulenode->events->event))
-			return;
+		if (empty($modulenode->events) || empty($modulenode->events->event)) {
+					return;
+		}
 
 		if (Event::hasSupport()) {
 			foreach ($modulenode->events->event as $eventnode) {
@@ -888,10 +913,12 @@ 
 	{
 		$event_condition = '';
 		$event_dependent = '[]';
-		if (!empty($eventnode->condition))
-			$event_condition = "$eventnode->condition";
-		if (!empty($eventnode->dependent))
-			$event_dependent = "$eventnode->dependent";
+		if (!empty($eventnode->condition)) {
+					$event_condition = "$eventnode->condition";
+		}
+		if (!empty($eventnode->dependent)) {
+					$event_dependent = "$eventnode->dependent";
+		}
 		Event::register($moduleInstance, (string) $eventnode->eventname, (string) $eventnode->classname, (string) $eventnode->filename, (string) $event_condition, (string) $event_dependent
 		);
 	}
@@ -902,8 +929,9 @@ 
 	 */
 	public function import_Actions($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->actions) || empty($modulenode->actions->action))
-			return;
+		if (empty($modulenode->actions) || empty($modulenode->actions->action)) {
+					return;
+		}
 		foreach ($modulenode->actions->action as $actionnode) {
 			$this->import_Action($modulenode, $moduleInstance, $actionnode);
 		}
@@ -916,10 +944,11 @@ 
 	public function import_Action($modulenode, $moduleInstance, $actionnode)
 	{
 		$actionstatus = $actionnode->status;
-		if ($actionstatus == 'enabled')
-			$moduleInstance->enableTools($actionnode->name);
-		else
-			$moduleInstance->disableTools($actionnode->name);
+		if ($actionstatus == 'enabled') {
+					$moduleInstance->enableTools($actionnode->name);
+		} else {
+					$moduleInstance->disableTools($actionnode->name);
+		}
 	}
 
 	/**
@@ -984,8 +1013,9 @@ 
 	 */
 	public function import_CustomLinks($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->customlinks) || empty($modulenode->customlinks->customlink))
-			return;
+		if (empty($modulenode->customlinks) || empty($modulenode->customlinks->customlink)) {
+					return;
+		}
 
 		foreach ($modulenode->customlinks->customlink as $customlinknode) {
 			$handlerInfo = null;
@@ -1007,8 +1037,9 @@ 
 	 */
 	public function import_CronTasks($modulenode)
 	{
-		if (empty($modulenode->crons) || empty($modulenode->crons->cron))
-			return;
+		if (empty($modulenode->crons) || empty($modulenode->crons->cron)) {
+					return;
+		}
 		foreach ($modulenode->crons->cron as $cronTask) {
 			if (empty($cronTask->status)) {
 				$cronTask->status = Cron::$STATUS_DISABLED;
@@ -1069,8 +1100,9 @@ 
 	 */
 	public function importInventory()
 	{
-		if (empty($this->_modulexml->inventory) || empty($this->_modulexml->inventory->fields->field))
-			return false;
+		if (empty($this->_modulexml->inventory) || empty($this->_modulexml->inventory->fields->field)) {
+					return false;
+		}
 		$module = (string) $this->moduleInstance->name;
 
 		$inventoryInstance = \Vtiger_Inventory_Model::getInstance($module);

vtlib/Vtiger/PackageUpdate.php

Doc Comments +17 added lines

@@ -23,6 +23,7 @@ 
 	/**
 	 * Initialize Update
 	 * @access private
+	 * @param boolean $overwrite
 	 */
 	public function initUpdate($moduleInstance, $zipfile, $overwrite)
 	{
@@ -185,6 +186,7 @@ 
 	/**
 	 * Handle migration of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
 	 */
 	public function handle_Migration($modulenode, $moduleInstance)
 	{
@@ -218,6 +220,7 @@ 
 	/**
 	 * Update Tables of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
 	 */
 	public function update_Tables($modulenode)
 	{
@@ -227,6 +230,7 @@ 
 	/**
 	 * Update Blocks of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
 	 */
 	public function update_Blocks($modulenode, $moduleInstance)
 	{
@@ -308,6 +312,7 @@ 
 	/**
 	 * Update Field of the module
 	 * @access private
+	 * @param Field $fieldInstance
 	 */
 	public function update_Field($blocknode, $blockInstance, $moduleInstance, $fieldnode, $fieldInstance)
 	{
@@ -387,6 +392,7 @@ 
 	/**
 	 * Import Custom views of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
 	 */
 	public function update_CustomViews($modulenode, $moduleInstance)
 	{
@@ -405,6 +411,7 @@ 
 	/**
 	 * Update Custom View of the module
 	 * @access private
+	 * @param Filter $filterInstance
 	 */
 	public function update_CustomView($modulenode, $moduleInstance, $customviewnode, $filterInstance)
 	{
@@ -416,6 +423,7 @@ 
 	/**
 	 * Update Sharing Access of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
 	 */
 	public function update_SharingAccess($modulenode, $moduleInstance)
 	{
@@ -428,6 +436,7 @@ 
 	/**
 	 * Update Events of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
 	 */
 	public function update_Events($modulenode, $moduleInstance)
 	{
@@ -460,6 +469,7 @@ 
 	/**
 	 * Update actions of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
 	 */
 	public function update_Actions($modulenode, $moduleInstance)
 	{
@@ -482,6 +492,7 @@ 
 	/**
 	 * Update related lists of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
 	 */
 	public function update_RelatedLists($modulenode, $moduleInstance)
 	{
@@ -538,6 +549,9 @@ 
 		return $inRelModuleInstance;
 	}
 
+	/**
+	 * @param \SimpleXMLElement $modulenode
+	 */
 	public function update_CustomLinks($modulenode, $moduleInstance)
 	{
 		if (empty($modulenode->customlinks) || empty($modulenode->customlinks->customlink))
@@ -546,6 +560,9 @@ 
 		$this->import_CustomLinks($modulenode, $moduleInstance);
 	}
 
+	/**
+	 * @param \SimpleXMLElement $modulenode
+	 */
 	public function update_CronTasks($modulenode)
 	{
 		if (empty($modulenode->crons) || empty($modulenode->crons->cron))

Braces +42 added lines, -28 removed lines

@@ -65,8 +65,9 @@ 
 				$this->__parseManifestFile($unzip);
 			}
 
-			if ($unzip)
-				$unzip->close();
+			if ($unzip) {
+							$unzip->close();
+			}
 		}
 		return $module;
 	}
@@ -136,8 +137,9 @@ 
 		$isextension = false;
 		if (!empty($this->_modulexml->type)) {
 			$type = strtolower($this->_modulexml->type);
-			if ($type == 'extension' || $type == 'language')
-				$isextension = true;
+			if ($type == 'extension' || $type == 'language') {
+							$isextension = true;
+			}
 		}
 
 		Module::fireEvent($moduleInstance->name, Module::EVENT_MODULE_PREUPDATE);
@@ -230,8 +232,9 @@ 
 	 */
 	public function update_Blocks($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->blocks) || empty($modulenode->blocks->block))
-			return;
+		if (empty($modulenode->blocks) || empty($modulenode->blocks->block)) {
+					return;
+		}
 
 		foreach ($modulenode->blocks->block as $blocknode) {
 			$this->listBlocks[] = strval($blocknode->label);
@@ -283,8 +286,9 @@ 
 	 */
 	public function update_Fields($blocknode, $blockInstance, $moduleInstance)
 	{
-		if (empty($blocknode->fields) || empty($blocknode->fields->field))
-			return;
+		if (empty($blocknode->fields) || empty($blocknode->fields->field)) {
+					return;
+		}
 
 		foreach ($blocknode->fields->field as $fieldnode) {
 			$this->listFields[] = strval($fieldnode->fieldname);
@@ -331,8 +335,9 @@ 
 		$fieldInstance->info_type = strval($fieldnode->info_type);
 		$fieldInstance->fieldparams = strval($fieldnode->fieldparams);
 
-		if (!empty($fieldnode->fieldparams))
-			$fieldInstance->fieldparams = strval($fieldnode->fieldparams);
+		if (!empty($fieldnode->fieldparams)) {
+					$fieldInstance->fieldparams = strval($fieldnode->fieldparams);
+		}
 
 		// Check if new parameters are defined
 		if (isset($fieldnode->columntype)) {
@@ -341,12 +346,15 @@ 
 			$fieldInstance->columntype = NULL;
 		}
 
-		if (!empty($fieldnode->helpinfo))
-			$fieldInstance->setHelpInfo($fieldnode->helpinfo);
-		if (!empty($fieldnode->masseditable))
-			$fieldInstance->setMassEditable($fieldnode->masseditable);
-		if (!empty($fieldnode->summaryfield))
-			$fieldInstance->setSummaryField($fieldnode->summaryfield);
+		if (!empty($fieldnode->helpinfo)) {
+					$fieldInstance->setHelpInfo($fieldnode->helpinfo);
+		}
+		if (!empty($fieldnode->masseditable)) {
+					$fieldInstance->setMassEditable($fieldnode->masseditable);
+		}
+		if (!empty($fieldnode->summaryfield)) {
+					$fieldInstance->setSummaryField($fieldnode->summaryfield);
+		}
 
 		$fieldInstance->block = $blockInstance;
 		$fieldInstance->save();
@@ -390,8 +398,9 @@ 
 	 */
 	public function update_CustomViews($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->customviews) || empty($modulenode->customviews->customview))
-			return;
+		if (empty($modulenode->customviews) || empty($modulenode->customviews->customview)) {
+					return;
+		}
 		foreach ($modulenode->customviews->customview as $customviewnode) {
 			$filterInstance = Filter::getInstance($customviewnode->viewname, $moduleInstance);
 			if (!$filterInstance) {
@@ -419,8 +428,9 @@ 
 	 */
 	public function update_SharingAccess($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->sharingaccess))
-			return;
+		if (empty($modulenode->sharingaccess)) {
+					return;
+		}
 
 		// TODO Handle sharing access property update
 	}
@@ -431,8 +441,9 @@ 
 	 */
 	public function update_Events($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->events) || empty($modulenode->events->event))
-			return;
+		if (empty($modulenode->events) || empty($modulenode->events->event)) {
+					return;
+		}
 
 		$adb = \PearDatabase::getInstance();
 
@@ -463,8 +474,9 @@ 
 	 */
 	public function update_Actions($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->actions) || empty($modulenode->actions->action))
-			return;
+		if (empty($modulenode->actions) || empty($modulenode->actions->action)) {
+					return;
+		}
 		foreach ($modulenode->actions->action as $actionnode) {
 			$this->update_Action($modulenode, $moduleInstance, $actionnode);
 		}
@@ -540,16 +552,18 @@ 
 
 	public function update_CustomLinks($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->customlinks) || empty($modulenode->customlinks->customlink))
-			return;
+		if (empty($modulenode->customlinks) || empty($modulenode->customlinks->customlink)) {
+					return;
+		}
 		$moduleInstance->deleteLinks();
 		$this->import_CustomLinks($modulenode, $moduleInstance);
 	}
 
 	public function update_CronTasks($modulenode)
 	{
-		if (empty($modulenode->crons) || empty($modulenode->crons->cron))
-			return;
+		if (empty($modulenode->crons) || empty($modulenode->crons->cron)) {
+					return;
+		}
 		$cronTasks = Cron::listAllInstancesByModule($modulenode->name);
 		foreach ($modulenode->crons->cron as $importCronTask) {
 			foreach ($cronTasks as $cronTask) {

vtlib/Vtiger/Profile.php

Doc Comments +4 added lines

@@ -66,6 +66,7 @@ 
 	 * Helper function to log messages
 	 * @param String Message to log
 	 * @param Boolean true appends linebreak, false to avoid it
+	 * @param string $message
 	 * @access private
 	 */
 	static function log($message, $delimit = true)
@@ -76,6 +77,7 @@ 
 	/**
 	 * Initialize profile setup for Field
 	 * @param Field Instance of the field
+	 * @param FieldBasic $fieldInstance
 	 * @access private
 	 */
 	static function initForField($fieldInstance)
@@ -94,6 +96,7 @@ 
 	/**
 	 * Delete profile information related with field.
 	 * @param Field Instance of the field
+	 * @param FieldBasic $fieldInstance
 	 * @access private
 	 */
 	static function deleteForField($fieldInstance)
@@ -122,6 +125,7 @@ 
 	/**
 	 * Initialize profile setup for the module
 	 * @param Module Instance of module
+	 * @param ModuleBasic $moduleInstance
 	 * @access private
 	 */
 	static function initForModule($moduleInstance)

vtlib/Vtiger/ThemeImport.php

Doc Comments +1 added lines

@@ -28,6 +28,7 @@
 	/**
 	 * Initialize Import
 	 * @access private
+	 * @param boolean $overwrite
 	 */
 	public function initImport($zipfile, $overwrite)
 	{

Braces +6 added lines, -4 removed lines

@@ -84,8 +84,9 @@ 
 		foreach ($filelist as $filename => $fileinfo) {
 			if (!$unzip->isdir($filename)) {
 
-				if (strpos($filename, '/') === false)
-					continue;
+				if (strpos($filename, '/') === false) {
+									continue;
+				}
 
 				$targetdir = substr($filename, 0, strripos($filename, '/'));
 				$targetfile = basename($filename);
@@ -146,8 +147,9 @@ 
 				}
 			}
 		}
-		if ($unzip)
-			$unzip->close();
+		if ($unzip) {
+					$unzip->close();
+		}
 
 		self::register($prefix, $label, $name);