YetiForceCompany / YetiForceCRM

modules/PaymentsIn/helpers/subclass/mt940_SGB.php

Braces +16 added lines, -12 removed lines

@@ -18,8 +18,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	protected function parseLine($line)
@@ -38,10 +39,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -56,16 +58,18 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == '61')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == '61') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;
 		}
-		if ($tag)
-			$this->_lastTag = $tag;
+		if ($tag) {
+					$this->_lastTag = $tag;
+		}
 	}
 
 	protected function parseTransaction($value)

Doc Comments +9 added lines

@@ -20,6 +20,9 @@ 
 			$this->parseLine($line);
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -66,6 +69,9 @@ 
 			$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseTransaction($value)
 	{
 		$transaction = array(
@@ -84,6 +90,9 @@ 
 		$this->operations[count($this->operations) - 1]['details'] = $transaction;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(

modules/PaymentsIn/helpers/subclass/mt940_Pekao.php

Braces +13 added lines, -10 removed lines

@@ -16,8 +16,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	protected function parseLine($line)
@@ -36,10 +37,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -54,10 +56,11 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == '61')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == '61') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;

Doc Comments +9 added lines

@@ -20,6 +20,9 @@ 
 			$this->parseLine($line);
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -65,6 +68,9 @@ 
 		$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseTransaction($value)
 	{
 		$transaction = array(
@@ -129,6 +135,9 @@ 
 		$this->operations[count($this->operations) - 1]['details'] = $transaction;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(

modules/PaymentsIn/helpers/subclass/mt940_BPH.php

Braces +13 added lines, -10 removed lines

@@ -16,8 +16,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	protected function parseLine($line)
@@ -36,10 +37,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -54,10 +56,11 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == 'NS')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == 'NS') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;

Doc Comments +9 added lines

@@ -20,6 +20,9 @@ 
 			$this->parseLine($line);
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -65,6 +68,9 @@ 
 		$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseTransaction($value)
 	{
 		$transaction = array(
@@ -129,6 +135,9 @@ 
 		$this->operations[count($this->operations) - 1]['details'] = $transaction;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(

modules/PBXManager/connectors/PBXManager.php

Braces +8 added lines, -6 removed lines

@@ -239,10 +239,11 @@ 
 		$recordModel = PBXManager_Record_Model::getCleanInstance();
 		$recordModel->saveRecordWithArrray($params);
 
-		if ($direction == self::INCOMING_TYPE)
-			$this->respondToIncomingCall($details);
-		else
-			$this->respondToOutgoingCall($params['CustomerNumber']);
+		if ($direction == self::INCOMING_TYPE) {
+					$this->respondToIncomingCall($details);
+		} else {
+					$this->respondToOutgoingCall($params['CustomerNumber']);
+		}
 	}
 
 	/**
@@ -312,8 +313,9 @@ 
 		} else {
 			$response .= '<Number>SIP/';
 			$response .= $to;
-			if ($numberLength > 5)
-				$response .= '@' . $this->getOutboundTrunk();
+			if ($numberLength > 5) {
+							$response .= '@' . $this->getOutboundTrunk();
+			}
 			$response .= '</Number>';
 		}
 

Doc Comments +9 added lines, -2 removed lines

@@ -53,6 +53,9 @@ 
 		return $this->webappurl;
 	}
 
+	/**
+	 * @return string
+	 */
 	public function getOutboundContext()
 	{
 		return $this->outboundcontext;
@@ -81,6 +84,7 @@ 
 	/**
 	 * Function to set server parameters
 	 * @param <array>  authdetails
+	 * @param PBXManager_Server_Model $serverModel
 	 */
 	public function setServerParameters($serverModel)
 	{
@@ -99,6 +103,10 @@ 
 		return self::$SETTINGS_REQUIRED_PARAMETERS;
 	}
 
+	/**
+	 * @param App\Request $details
+	 * @param string $type
+	 */
 	protected function prepareParameters($details, $type)
 	{
 		switch ($type) {
@@ -293,7 +301,6 @@ 
 
 	/**
 	 * Function to respond for outgoing calls
-	 * @param \App\Request $details 
 	 */
 	public function respondToOutgoingCall($to)
 	{
@@ -323,7 +330,7 @@ 
 	/**
 	 * Function to make outbound call 
 	 * @param string $number (Customer)
-	 * @param string $recordid
+	 * @param string $record
 	 */
 	public function call($number, $record)
 	{

modules/Accounts/data_access/unique_account.php

Braces +9 added lines, -7 removed lines

@@ -28,23 +28,25 @@
 			$recordModel = Vtiger_Record_Model::getInstanceById($ID, $moduleName);
 			$vatId = $recordModel->get('vat_id');
 		} else {
-			if (array_key_exists('vat_id', $recordForm))
-				$vatId = $recordForm['vat_id'];
+			if (array_key_exists('vat_id', $recordForm)) {
+							$vatId = $recordForm['vat_id'];
+			}
 		}
 		if ($ID != 0 && $ID != '' && !array_key_exists('accountname', $recordForm)) {
 			$recordModel = Vtiger_Record_Model::getInstanceById($ID, $moduleName);
 			$accountName = $recordModel->get('accountname');
 		} else {
-			if (array_key_exists('accountname', $recordForm))
-				$accountName = $recordForm['accountname'];
+			if (array_key_exists('accountname', $recordForm)) {
+							$accountName = $recordForm['accountname'];
+			}
 		}
 
 		$moduleModel = Vtiger_Module_Model::getInstance($moduleName);
 		$hierarchyField = Vtiger_Field_Model::getInstance('account_id', $moduleModel);
 		if ($hierarchyField->isActiveField()) {
-			if (array_key_exists('account_id', $recordForm))
-				$hierarchyValue = $recordForm['account_id'];
-			elseif ($ID != 0 && $ID != '' && !array_key_exists('account_id', $recordForm)) {
+			if (array_key_exists('account_id', $recordForm)) {
+							$hierarchyValue = $recordForm['account_id'];
+			} elseif ($ID != 0 && $ID != '' && !array_key_exists('account_id', $recordForm)) {
 				$recordModel = Vtiger_Record_Model::getInstanceById($ID, $moduleName);
 				$hierarchyValue = $recordModel->get('account_id');
 			}

modules/Users/Users.php

Spacing +1 added lines, -1 removed lines

@@ -296,7 +296,7 @@
 			$buffer = fread($handle, filesize($validate));
 			if (substr_count($buffer, $authkey) < $i)
 				return -1;
-		}else {
+		} else {
 			return -1;
 		}
 	}

Doc Comments +1 added lines, -3 removed lines

@@ -201,7 +201,6 @@ 
 
 	/**
 	 * @return string encrypted password for storage in DB and comparison against DB password.
-	 * @param string $user_name - Must be non null and at least 2 characters
 	 * @param string $user_password - Must be non null and at least 1 character.
 	 * @desc Take an unencrypted username and password and return the encrypted password
 	 * Portions created by SugarCRM are Copyright (C) SugarCRM, Inc..
@@ -354,7 +353,6 @@ 
 	}
 
 	/**
-	 * @param string $user name - Must be non null and at least 1 character.
 	 * @param string $userPassword - Must be non null and at least 1 character.
 	 * @param string $newPassword - Must be non null and at least 1 character.
 	 * @return boolean - If passwords pass verification and query succeeds, return true, else return false.
@@ -479,7 +477,7 @@ 
 
 	/** Function to retreive the user info of the specifed user id The user info will be available in $this->column_fields array
 	 * @param $record -- record id:: Type integer
-	 * @param $module -- module:: Type varchar
+	 * @param string $module -- module:: Type varchar
 	 */
 	public function retrieve_entity_info($record, $module)
 	{

Braces +22 added lines, -17 removed lines

@@ -115,10 +115,11 @@ 
 	{
 
 		\App\Log::trace("Entering getSortOrder() method ...");
-		if (\App\Request::_has('sorder'))
-			$sorder = $this->db->sql_escape_string(\App\Request::_get('sorder'));
-		else
-			$sorder = (($_SESSION['USERS_SORT_ORDER'] != '') ? ($_SESSION['USERS_SORT_ORDER']) : ($this->default_sort_order));
+		if (\App\Request::_has('sorder')) {
+					$sorder = $this->db->sql_escape_string(\App\Request::_get('sorder'));
+		} else {
+					$sorder = (($_SESSION['USERS_SORT_ORDER'] != '') ? ($_SESSION['USERS_SORT_ORDER']) : ($this->default_sort_order));
+		}
 		\App\Log::trace("Exiting getSortOrder method ...");
 		return $sorder;
 	}
@@ -137,10 +138,11 @@ 
 			$use_default_order_by = $this->default_order_by;
 		}
 
-		if (\App\Request::_has('order_by'))
-			$order_by = $this->db->sql_escape_string(\App\Request::_get('order_by'));
-		else
-			$order_by = (($_SESSION['USERS_ORDER_BY'] != '') ? ($_SESSION['USERS_ORDER_BY']) : ($use_default_order_by));
+		if (\App\Request::_has('order_by')) {
+					$order_by = $this->db->sql_escape_string(\App\Request::_get('order_by'));
+		} else {
+					$order_by = (($_SESSION['USERS_ORDER_BY'] != '') ? ($_SESSION['USERS_ORDER_BY']) : ($use_default_order_by));
+		}
 		\App\Log::trace("Exiting getOrderBy method ...");
 		return $order_by;
 	}
@@ -154,10 +156,11 @@ 
 	public function setPreference($name, $value)
 	{
 		if (!isset($this->user_preferences)) {
-			if (isset($_SESSION["USER_PREFERENCES"]))
-				$this->user_preferences = $_SESSION["USER_PREFERENCES"];
-			else
-				$this->user_preferences = [];
+			if (isset($_SESSION["USER_PREFERENCES"])) {
+							$this->user_preferences = $_SESSION["USER_PREFERENCES"];
+			} else {
+							$this->user_preferences = [];
+			}
 		}
 		if (!array_key_exists($name, $this->user_preferences) || $this->user_preferences[$name] != $value) {
 			\App\Log::trace("Saving To Preferences:" . $name . "=" . $value);
@@ -257,9 +260,10 @@ 
 		$authkey = base64_decode($authkey);
 		if (file_exists($validate) && $handle = fopen($validate, 'rb', true)) {
 			$buffer = fread($handle, filesize($validate));
-			if (substr_count($buffer, $authkey) < $i)
-				return -1;
-		}else {
+			if (substr_count($buffer, $authkey) < $i) {
+							return -1;
+			}
+		} else {
 			return -1;
 		}
 	}
@@ -552,8 +556,9 @@ 
 		$db = App\Db::getInstance();
 		//to get the owner id
 		$ownerid = $this->column_fields['assigned_user_id'];
-		if (!isset($ownerid) || $ownerid == '')
-			$ownerid = $currentUserId;
+		if (!isset($ownerid) || $ownerid == '') {
+					$ownerid = $currentUserId;
+		}
 		$fileInstance = \App\Fields\File::loadFromRequest($fileDetails);
 		if (!$fileInstance->validate('image')) {
 			\App\Log::trace('Skip the save attachment process.');

modules/OSSTimeControl/actions/GetTCInfo.php

Braces +10 added lines, -8 removed lines

@@ -37,17 +37,19 @@
 			$sourceData = $entity->column_fields;
 			if ($sourceModule == 'HelpDesk') {
 				$sourceData['contact_label'] = vtlib\Functions::getCRMRecordLabel($sourceData['contact_id']);
-				if (vtlib\Functions::getCRMRecordType($sourceData['parent_id']) != 'Accounts')
-					unset($sourceData['parent_id']);
-				else
-					$sourceData['account_label'] = vtlib\Functions::getCRMRecordLabel($sourceData['parent_id']);
+				if (vtlib\Functions::getCRMRecordType($sourceData['parent_id']) != 'Accounts') {
+									unset($sourceData['parent_id']);
+				} else {
+									$sourceData['account_label'] = vtlib\Functions::getCRMRecordLabel($sourceData['parent_id']);
+				}
 			} else if ($sourceModule == 'Project') {
 				$query = sprintf("select * from vtiger_account where accountid = %s", $sourceData['linktoaccountscontacts']);
 				$ifExist = $adb->query($query, true, "Błąd podczas pobierania danych z vtiger_crmentityrel");
-				if ($adb->num_rows($ifExist) > 0)
-					$sourceData['account_label'] = vtlib\Functions::getCRMRecordLabel($sourceData['linktoaccountscontacts']);
-				else
-					$sourceData['contact_label'] = vtlib\Functions::getCRMRecordLabel($sourceData['linktoaccountscontacts']);
+				if ($adb->num_rows($ifExist) > 0) {
+									$sourceData['account_label'] = vtlib\Functions::getCRMRecordLabel($sourceData['linktoaccountscontacts']);
+				} else {
+									$sourceData['contact_label'] = vtlib\Functions::getCRMRecordLabel($sourceData['linktoaccountscontacts']);
+				}
 			}
 		}
 

modules/Settings/OSSPasswords/views/ConfigurePass.php

Braces +5 added lines, -4 removed lines

@@ -237,10 +237,11 @@
 		$viewer->assign('MODULENAME', $moduleName);
 		$viewer->assign('SAVE', 'Save');
 		$viewer->assign('CANCEL', 'Cancel');
-		if (\vtlib\Functions::userIsAdministrator($current_user))
-			$viewer->assign('ISADMIN', 1);
-		else
-			$viewer->assign('ISADMIN', 0);
+		if (\vtlib\Functions::userIsAdministrator($current_user)) {
+					$viewer->assign('ISADMIN', 1);
+		} else {
+					$viewer->assign('ISADMIN', 0);
+		}
 
 		// encryption variables
 		$viewer->assign('CONFIG', (!$config ? false : array('key' => $config['key'])));

modules/Vtiger/actions/TransferOwnership.php

Braces +5 added lines, -4 removed lines

@@ -22,10 +22,11 @@
 		$modelClassName = Vtiger_Loader::getComponentClassName('Model', 'TransferOwnership', $module);
 		$transferModel = new $modelClassName();
 
-		if (empty($record))
-			$recordIds = $this->getBaseModuleRecordIds($request);
-		else
-			$recordIds = [$record];
+		if (empty($record)) {
+					$recordIds = $this->getBaseModuleRecordIds($request);
+		} else {
+					$recordIds = [$record];
+		}
 		if (!empty($recordIds)) {
 			$transferModel->transferRecordsOwnership($module, $transferOwnerId, $recordIds);
 		}