Completed
Push — developer ( 1e92a5...487603 )
by Błażej
403:20 queued 370:53
created
modules/WSAPP/WSAPP.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -124,8 +124,9 @@
 block discarded – undo
124 124
 		$appTypehandler['handlerpath'] = "modules/WSAPP/Handlers/vtigerCRMHandler.php";
125 125
 		$handlerDetails[] = $appTypehandler;
126 126
 
127
-		foreach ($handlerDetails as $appHandlerDetails)
128
-			$adb->pquery("INSERT INTO vtiger_wsapp_handlerdetails VALUES(?,?,?)", array($appHandlerDetails['type'], $appHandlerDetails['handlerclass'], $appHandlerDetails['handlerpath']));
127
+		foreach ($handlerDetails as $appHandlerDetails) {
128
+					$adb->pquery("INSERT INTO vtiger_wsapp_handlerdetails VALUES(?,?,?)", array($appHandlerDetails['type'], $appHandlerDetails['handlerclass'], $appHandlerDetails['handlerpath']));
129
+		}
129 130
 	}
130 131
 
131 132
 	public function registerVtigerCRMApp()
Please login to merge, or discard this patch.
modules/LettersOut/LettersOut.php 1 patch
Braces   +14 added lines, -10 removed lines patch added patch discarded remove patch
@@ -114,8 +114,9 @@  discard block
 block discarded – undo
114 114
 		$joinedTables = array();
115 115
 
116 116
 		// Select Custom Field Table Columns if present
117
-		if (!empty($this->customFieldTable))
118
-			$query .= ", " . $this->customFieldTable[0] . ".* ";
117
+		if (!empty($this->customFieldTable)) {
118
+					$query .= ", " . $this->customFieldTable[0] . ".* ";
119
+		}
119 120
 
120 121
 		$query .= " FROM $this->table_name";
121 122
 
@@ -250,10 +251,11 @@  discard block
 block discarded – undo
250 251
 		$query .= $this->getNonAdminAccessControlQuery($thismodule, $current_user);
251 252
 		$where_auto = " vtiger_crmentity.deleted=0";
252 253
 
253
-		if ($where != '')
254
-			$query .= " WHERE ($where) && $where_auto";
255
-		else
256
-			$query .= " WHERE $where_auto";
254
+		if ($where != '') {
255
+					$query .= " WHERE ($where) && $where_auto";
256
+		} else {
257
+					$query .= " WHERE $where_auto";
258
+		}
257 259
 
258 260
 		return $query;
259 261
 	}
@@ -274,8 +276,9 @@  discard block
 block discarded – undo
274 276
 		$select_clause = sprintf('SELECT %s.%s AS recordid, vtiger_users_last_import.deleted, %s', $this->table_name, $this->table_index, $table_cols);
275 277
 
276 278
 		// Select Custom Field Table Columns if present
277
-		if (isset($this->customFieldTable))
278
-			$query .= ", " . $this->customFieldTable[0] . ".* ";
279
+		if (isset($this->customFieldTable)) {
280
+					$query .= ", " . $this->customFieldTable[0] . ".* ";
281
+		}
279 282
 
280 283
 		$from_clause = " FROM $this->table_name";
281 284
 
@@ -328,8 +331,9 @@  discard block
 block discarded – undo
328 331
 			$modcommentsModuleInstance = vtlib\Module::getInstance('ModComments');
329 332
 			if ($modcommentsModuleInstance && file_exists('modules/ModComments/ModComments.php')) {
330 333
 				include_once 'modules/ModComments/ModComments.php';
331
-				if (class_exists('ModComments'))
332
-					ModComments::addWidgetTo(array('LettersOut'));
334
+				if (class_exists('ModComments')) {
335
+									ModComments::addWidgetTo(array('LettersOut'));
336
+				}
333 337
 			}
334 338
 
335 339
 			$modcommentsModuleInstance = vtlib\Module::getInstance('ModTracker');
Please login to merge, or discard this patch.
modules/Assets/views/EditFieldByModal.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 		}
29 29
 		$showFields = array_keys($recordModel->getModule()->getQuickCreateFields());
30 30
 		$configureFields = AppConfig::module($moduleName, 'SHOW_FIELD_IN_MODAL');
31
-		if($configureFields){
31
+		if ($configureFields) {
32 32
 			$showFields = array_merge($showFields, $configureFields);
33 33
 		}
34 34
 
Please login to merge, or discard this patch.
modules/Reports/views/ChartSaveAjax.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,8 +44,9 @@
 block discarded – undo
44 44
 		}
45 45
 
46 46
 		$dataFields = $request->get('datafields', 'count(*)');
47
-		if (is_string($dataFields))
48
-			$dataFields = array($dataFields);
47
+		if (is_string($dataFields)) {
48
+					$dataFields = array($dataFields);
49
+		}
49 50
 
50 51
 		$reportModel->set('reporttypedata', \includes\utils\Json::encode(array(
51 52
 				'type' => $request->get('charttype', 'pieChart'),
Please login to merge, or discard this patch.
modules/Reports/views/ChartEdit.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -98,8 +98,9 @@
 block discarded – undo
98 98
 			$viewer->assign('MODE', 'edit');
99 99
 		} else {
100 100
 			$firstModuleName = reset($modulesList);
101
-			if ($firstModuleName)
102
-				$reportModel->setPrimaryModule($firstModuleName);
101
+			if ($firstModuleName) {
102
+							$reportModel->setPrimaryModule($firstModuleName);
103
+			}
103 104
 			$viewer->assign('MODE', '');
104 105
 		}
105 106
 
Please login to merge, or discard this patch.
modules/Reports/ReportUtils.php 1 patch
Braces   +8 added lines, -6 removed lines patch added patch discarded remove patch
@@ -15,8 +15,9 @@  discard block
 block discarded – undo
15 15
 function getFieldByReportLabel($module, $label)
16 16
 {
17 17
 	$cacheLabel = VTCacheUtils::getReportFieldByLabel($module, $label);
18
-	if ($cacheLabel)
19
-		return $cacheLabel;
18
+	if ($cacheLabel) {
19
+			return $cacheLabel;
20
+	}
20 21
 
21 22
 	// this is required so the internal cache is populated or reused.
22 23
 	getColumnFields($module);
@@ -27,10 +28,11 @@  discard block
 block discarded – undo
27 28
 	if ($module == 'Calendar') {
28 29
 		$cachedEventsFields = VTCacheUtils::lookupFieldInfo_Module('Events');
29 30
 		if ($cachedEventsFields) {
30
-			if (empty($cachedModuleFields))
31
-				$cachedModuleFields = $cachedEventsFields;
32
-			else
33
-				$cachedModuleFields = array_merge($cachedModuleFields, $cachedEventsFields);
31
+			if (empty($cachedModuleFields)) {
32
+							$cachedModuleFields = $cachedEventsFields;
33
+			} else {
34
+							$cachedModuleFields = array_merge($cachedModuleFields, $cachedEventsFields);
35
+			}
34 36
 		}
35 37
 		if ($label == 'Start_Date_and_Time') {
36 38
 			$label = 'Start_Date_&_Time';
Please login to merge, or discard this patch.
modules/OSSPasswords/OSSPasswords.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -336,7 +336,7 @@
 block discarded – undo
336 336
 		} else if ($eventType == 'module.preuninstall') {
337 337
 			// TODO Handle actions when this module is about to be deleted.
338 338
 			$this->log->debug('Before starting uninstall script...');
339
-			require_once( 'modules/Settings/' . $moduleName . '/views/uninstall.php' );
339
+			require_once('modules/Settings/' . $moduleName . '/views/uninstall.php');
340 340
 			$this->log->debug('After uninstall script.');
341 341
 
342 342
 			header('Location: index.php?module=Vtiger&parent=Settings&view=Index');
Please login to merge, or discard this patch.
Braces   +14 added lines, -10 removed lines patch added patch discarded remove patch
@@ -115,8 +115,9 @@  discard block
 block discarded – undo
115 115
 		$query = "SELECT vtiger_crmentity.*, $this->table_name.*";
116 116
 
117 117
 		// Select Custom Field Table Columns if present
118
-		if (!empty($this->customFieldTable))
119
-			$query .= ", " . $this->customFieldTable[0] . ".* ";
118
+		if (!empty($this->customFieldTable)) {
119
+					$query .= ", " . $this->customFieldTable[0] . ".* ";
120
+		}
120 121
 
121 122
 		$query .= " FROM $this->table_name";
122 123
 
@@ -224,10 +225,11 @@  discard block
 block discarded – undo
224 225
 
225 226
 		$where_auto = " vtiger_crmentity.deleted=0";
226 227
 
227
-		if ($where != '')
228
-			$query .= " WHERE ($where) && $where_auto";
229
-		else
230
-			$query .= " WHERE $where_auto";
228
+		if ($where != '') {
229
+					$query .= " WHERE ($where) && $where_auto";
230
+		} else {
231
+					$query .= " WHERE $where_auto";
232
+		}
231 233
 
232 234
 		require('user_privileges/user_privileges_' . $current_user->id . '.php');
233 235
 		require('user_privileges/sharing_privileges_' . $current_user->id . '.php');
@@ -245,8 +247,9 @@  discard block
 block discarded – undo
245 247
 	 */
246 248
 	public function transform_export_value($key, $value)
247 249
 	{
248
-		if ($key == 'owner')
249
-			return \App\Fields\Owner::getLabel($value);
250
+		if ($key == 'owner') {
251
+					return \App\Fields\Owner::getLabel($value);
252
+		}
250 253
 		return parent::transform_export_value($key, $value);
251 254
 	}
252 255
 
@@ -258,8 +261,9 @@  discard block
 block discarded – undo
258 261
 		$select_clause = sprintf('SELECT %s.%s AS recordid, vtiger_users_last_import.deleted, %s', $this->table_name, $this->table_index, $table_cols);
259 262
 
260 263
 		// Select Custom Field Table Columns if present
261
-		if (isset($this->customFieldTable))
262
-			$query .= ", " . $this->customFieldTable[0] . ".* ";
264
+		if (isset($this->customFieldTable)) {
265
+					$query .= ", " . $this->customFieldTable[0] . ".* ";
266
+		}
263 267
 
264 268
 		$from_clause = " FROM $this->table_name";
265 269
 
Please login to merge, or discard this patch.
modules/PaymentsIn/PaymentsIn.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -105,8 +105,9 @@
 block discarded – undo
105 105
 			$modcommentsModuleInstance = vtlib\Module::getInstance('ModComments');
106 106
 			if ($modcommentsModuleInstance && file_exists('modules/ModComments/ModComments.php')) {
107 107
 				include_once 'modules/ModComments/ModComments.php';
108
-				if (class_exists('ModComments'))
109
-					ModComments::addWidgetTo(array('Payments'));
108
+				if (class_exists('ModComments')) {
109
+									ModComments::addWidgetTo(array('Payments'));
110
+				}
110 111
 			}
111 112
 			$adb->pquery('UPDATE vtiger_tab SET customized=0 WHERE name=?', array($modulename));
112 113
 			$tabid = vtlib\Functions::getModuleId($modulename);
Please login to merge, or discard this patch.
modules/PaymentsIn/helpers/subclass/mt940_BGK.php 2 patches
Braces   +11 added lines, -8 removed lines patch added patch discarded remove patch
@@ -16,8 +16,9 @@  discard block
 block discarded – undo
16 16
 	public function parse()
17 17
 	{
18 18
 		$tab = $this->prepareFile();
19
-		foreach ($tab as $line)
20
-			$this->parseLine($line);
19
+		foreach ($tab as $line) {
20
+					$this->parseLine($line);
21
+		}
21 22
 	}
22 23
 
23 24
 	protected function parseLine($line)
@@ -36,10 +37,11 @@  discard block
 block discarded – undo
36 37
 				break;
37 38
 			case 'NS':
38 39
 				$code = substr($value, 0, 2);
39
-				if ($code == '22')
40
-					$this->ownerName = substr($value, 2);
41
-				else if ($code == '23')
42
-					$this->accountName = substr($value, 2);
40
+				if ($code == '22') {
41
+									$this->ownerName = substr($value, 2);
42
+				} else if ($code == '23') {
43
+									$this->accountName = substr($value, 2);
44
+				}
43 45
 				break;
44 46
 			case '60F':
45 47
 				$this->openBalance = $this->parseBalance($value);
@@ -62,8 +64,9 @@  discard block
 block discarded – undo
62 64
 			default:
63 65
 				break;
64 66
 		}
65
-		if ($tag)
66
-			$this->_lastTag = $tag;
67
+		if ($tag) {
68
+					$this->_lastTag = $tag;
69
+		}
67 70
 	}
68 71
 
69 72
 	protected function parseTransaction($value)
Please login to merge, or discard this patch.
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -20,6 +20,9 @@  discard block
 block discarded – undo
20 20
 			$this->parseLine($line);
21 21
 	}
22 22
 
23
+	/**
24
+	 * @param string $line
25
+	 */
23 26
 	protected function parseLine($line)
24 27
 	{
25 28
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -65,6 +68,9 @@  discard block
 block discarded – undo
65 68
 		$this->_lastTag = $tag;
66 69
 	}
67 70
 
71
+	/**
72
+	 * @param string $value
73
+	 */
68 74
 	protected function parseTransaction($value)
69 75
 	{
70 76
 		$transaction = array(
@@ -109,6 +115,9 @@  discard block
 block discarded – undo
109 115
 		$this->operations[count($this->operations) - 1]['details'] = $transaction;
110 116
 	}
111 117
 
118
+	/**
119
+	 * @param string $value
120
+	 */
112 121
 	protected function parseOperation($value)
113 122
 	{
114 123
 		$this->operations[] = array(
Please login to merge, or discard this patch.