YetiForceCompany / YetiForceCRM

libraries/SabreDAV/DAVACL/Xml/Request/PrincipalSearchPropertySetReport.php

Doc Comments +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
      * the next element.
      *
      * @param Reader $reader
-     * @return mixed
+     * @return PrincipalSearchPropertySetReport
      */
     static function xmlDeserialize(Reader $reader) {
 

Indentation +34 added lines, -34 removed lines

@@ -20,39 +20,39 @@
  */
 class PrincipalSearchPropertySetReport implements XmlDeserializable {
 
-    /**
-     * The deserialize method is called during xml parsing.
-     *
-     * This method is called statictly, this is because in theory this method
-     * may be used as a type of constructor, or factory method.
-     *
-     * Often you want to return an instance of the current class, but you are
-     * free to return other data as well.
-     *
-     * You are responsible for advancing the reader to the next element. Not
-     * doing anything will result in a never-ending loop.
-     *
-     * If you just want to skip parsing for this element altogether, you can
-     * just call $reader->next();
-     *
-     * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
-     * the next element.
-     *
-     * @param Reader $reader
-     * @return mixed
-     */
-    static function xmlDeserialize(Reader $reader) {
-
-        if (!$reader->isEmptyElement) {
-            throw new BadRequest('The {DAV:}principal-search-property-set element must be empty');
-        }
-
-        // The element is actually empty, so there's not much to do.
-        $reader->next();
-
-        $self = new self();
-        return $self;
-
-    }
+	/**
+	 * The deserialize method is called during xml parsing.
+	 *
+	 * This method is called statictly, this is because in theory this method
+	 * may be used as a type of constructor, or factory method.
+	 *
+	 * Often you want to return an instance of the current class, but you are
+	 * free to return other data as well.
+	 *
+	 * You are responsible for advancing the reader to the next element. Not
+	 * doing anything will result in a never-ending loop.
+	 *
+	 * If you just want to skip parsing for this element altogether, you can
+	 * just call $reader->next();
+	 *
+	 * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
+	 * the next element.
+	 *
+	 * @param Reader $reader
+	 * @return mixed
+	 */
+	static function xmlDeserialize(Reader $reader) {
+
+		if (!$reader->isEmptyElement) {
+			throw new BadRequest('The {DAV:}principal-search-property-set element must be empty');
+		}
+
+		// The element is actually empty, so there's not much to do.
+		$reader->next();
+
+		$self = new self();
+		return $self;
+
+	}
 
 }

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,9 +2,9 @@
 
 namespace Sabre\DAVACL\Xml\Request;
 
+use Sabre\DAV\Exception\BadRequest;
 use Sabre\Xml\Reader;
 use Sabre\Xml\XmlDeserializable;
-use Sabre\DAV\Exception\BadRequest;
 
 /**
  * PrincipalSearchPropertySetReport request parser.

modules/Accounts/Accounts.php

Doc Comments +2 added lines, -1 removed lines

@@ -611,6 +611,7 @@ 
 	 * @param  integer   $id      		- accountid
 	 * @param  array   $parent_accounts   - Array of all the parent accounts
 	 * returns All the parent accounts of the given accountid in array format
+	 * @param integer[] $encountered_accounts
 	 */
 	public function __getParentAccounts($id, &$parent_accounts, &$encountered_accounts, $depthBase = 0)
 	{
@@ -673,7 +674,7 @@ 
 	 * Function to Recursively get all the child accounts of a given Account
 	 * @param  integer   $id      		- accountid
 	 * @param  array   $child_accounts   - Array of all the child accounts
-	 * @param  integer   $depth          - Depth at which the particular account has to be placed in the hierarchy
+	 * @param  integer   $depthBase          - Depth at which the particular account has to be placed in the hierarchy
 	 * returns All the child accounts of the given accountid in array format
 	 */
 	public function __getChildAccounts($id, &$child_accounts, $depthBase)

Braces +23 added lines, -16 removed lines

@@ -113,10 +113,11 @@ 
 		$query .= $this->getNonAdminAccessControlQuery('Accounts', $current_user);
 		$where_auto = " vtiger_crmentity.deleted = 0 ";
 
-		if ($where != '')
-			$query .= sprintf(' where (%s) && %s', $where, $where_auto);
-		else
-			$query .= sprintf(' where %s', $where_auto);
+		if ($where != '') {
+					$query .= sprintf(' where (%s) && %s', $where, $where_auto);
+		} else {
+					$query .= sprintf(' where %s', $where_auto);
+		}
 
 		\App\Log::trace("Exiting create_export_query method ...");
 		return $query;
@@ -435,8 +436,9 @@ 
 	public function unlinkRelationship($id, $return_module, $return_id, $relatedName = false)
 	{
 
-		if (empty($return_module) || empty($return_id))
-			return;
+		if (empty($return_module) || empty($return_id)) {
+					return;
+		}
 
 		if ($return_module == 'Campaigns') {
 			$this->db->delete('vtiger_campaign_records', 'crmid=? && campaignid=?', [$id, $return_id]);
@@ -451,8 +453,9 @@ 
 	public function save_related_module($module, $crmid, $with_module, $with_crmids, $relatedName = false)
 	{
 		$db = PearDatabase::getInstance();
-		if (!is_array($with_crmids))
-			$with_crmids = [$with_crmids];
+		if (!is_array($with_crmids)) {
+					$with_crmids = [$with_crmids];
+		}
 		if (!in_array($with_module, ['Products', 'Campaigns'])) {
 			parent::save_related_module($module, $crmid, $with_module, $with_crmids, $relatedName);
 		} else {
@@ -502,10 +505,12 @@ 
 					continue;
 				}
 				// Setup the default JOIN conditions if not specified
-				if (empty($relmap[1]))
-					$relmap[1] = $other->table_name;
-				if (empty($relmap[2]))
-					$relmap[2] = $relmap[0];
+				if (empty($relmap[1])) {
+									$relmap[1] = $other->table_name;
+				}
+				if (empty($relmap[2])) {
+									$relmap[2] = $relmap[0];
+				}
 				$join .= " LEFT JOIN $tname ON $tname.$relmap[0] = $relmap[1].$relmap[2]";
 			}
 		}
@@ -530,14 +535,16 @@ 
 	public function getRelatedContactsIds($id = null)
 	{
 
-		if ($id === null)
-			$id = $this->id;
+		if ($id === null) {
+					$id = $this->id;
+		}
 		$query = (new \App\Db\Query())->select('contactid')->from('vtiger_contactdetails')
 			->innerJoin('vtiger_crmentity', 'vtiger_contactdetails.contactid = vtiger_crmentity.crmid')
 			->where(['vtiger_contactdetails.parentid' => $id, 'vtiger_crmentity.deleted' => 0]);
 		$entityIds = $query->column();
-		if (empty($entityIds))
-			$entityIds = [];
+		if (empty($entityIds)) {
+					$entityIds = [];
+		}
 
 		return $entityIds;
 	}

modules/Assets/dashboards/ExpiringSoldProducts.php

Doc Comments +3 added lines

@@ -36,6 +36,9 @@
 		}
 	}
 
+	/**
+	 * @param Vtiger_Widget_Model $widget
+	 */
 	public function getData(Vtiger_Request $request, $widget)
 	{
 		$db = PearDatabase::getInstance();

modules/Calendar/Appointment.php

Doc Comments +4 added lines, -1 removed lines

@@ -56,7 +56,7 @@ 
 	 * @param $userid -- The user Id:: Type integer
 	 * @param $from_datetime -- The start date Obj :: Type Array
 	 * @param $to_datetime -- The end date Obj :: Type Array
-	 * @param $view -- The calendar view :: Type String
+	 * @param string $view -- The calendar view :: Type String
 	 * @returns $list :: Type Array
 	 */
 	public function readAppointment($userid, &$from_datetime, &$to_datetime, $view)
@@ -286,6 +286,9 @@ 
 	return ($a->start_time->ts < $b->start_time->ts) ? -1 : 1;
 }
 
+/**
+ * @param string $fldname
+ */
 function getRoleBasesdPickList($fldname, $exist_val)
 {
 	$adb = PearDatabase::getInstance();

Braces +16 added lines, -11 removed lines

@@ -222,13 +222,15 @@ 
 				$que = "select * from vtiger_sharedcalendar where sharedid=? and userid=?";
 				$row = $adb->pquery($que, array($currentUser->id, $act_array["smownerid"]));
 				$no = $adb->getRowCount($row);
-				if ($no > 0)
-					$this->shared = true;
+				if ($no > 0) {
+									$this->shared = true;
+				}
 			}
 		}
 		$this->image_name = $act_array["activitytype"] . ".gif";
-		if (!empty($act_array["recurringid"]) && !empty($act_array["recurringtype"]))
-			$this->recurring = "Recurring.gif";
+		if (!empty($act_array["recurringid"]) && !empty($act_array["recurringtype"])) {
+					$this->recurring = "Recurring.gif";
+		}
 
 		$this->record = $act_array["activityid"];
 		$date = new DateTimeField($act_array["date_start"] . ' ' . $act_array['time_start']);
@@ -296,8 +298,9 @@ 
 		$roleid = $currentUser->roleid;
 		$roleids = Array();
 		$subrole = getRoleSubordinates($roleid);
-		if (count($subrole) > 0)
-			$roleids = $subrole;
+		if (count($subrole) > 0) {
+					$roleids = $subrole;
+		}
 		array_push($roleids, $roleid);
 
 		//here we are checking wheather the table contains the sortorder column .If  sortorder is present in the main picklist table, then the role2picklist will be applicable for this table...
@@ -311,12 +314,14 @@ 
 			$res_val = $adb->pquery($pick_query, array($roleids));
 			$num_val = $adb->num_rows($res_val);
 		}
-		if ($num_val > 0)
+		if ($num_val > 0) {
+					$pick_val = $exist_val;
+		} else {
+					$pick_val = \App\Language::translate('LBL_NOT_ACCESSIBLE');
+		}
+	} else {
 			$pick_val = $exist_val;
-		else
-			$pick_val = \App\Language::translate('LBL_NOT_ACCESSIBLE');
-	} else
-		$pick_val = $exist_val;
+	}
 
 	return $pick_val;
 }

modules/Calendar/Date.php

Doc Comments +1 added lines, -5 removed lines

@@ -384,7 +384,7 @@ 
 
 	/**
 	 *
-	 * @return Date
+	 * @return string
 	 */
 	public function get_DB_formatted_date()
 	{
@@ -529,10 +529,6 @@ 
 	 * This should be used whereever possible
 	 *
 	 * @param integer       $index - number between 0 to 42
-	 * @param string        $day   - date
-	 * @param string        $month - month
-	 * @param string        $year  - year
-	 * return vt_DateTime obj  $datetimevalue
 	 */
 	public function getThisMonthsDayByIndex($index)
 	{

Braces +37 added lines, -26 removed lines

@@ -87,12 +87,15 @@ 
 	 */
 	public function getTodayDatetimebyIndex($index, $day = '', $month = '', $year = '')
 	{
-		if ($day === '')
-			$day = $this->day;
-		if ($month === '')
-			$month = $this->month;
-		if ($year === '')
-			$year = $this->year;
+		if ($day === '') {
+					$day = $this->day;
+		}
+		if ($month === '') {
+					$month = $this->month;
+		}
+		if ($year === '') {
+					$year = $this->year;
+		}
 		$day_array = array();
 
 		if ($index < 0 || $index > 23) {
@@ -140,12 +143,15 @@ 
 	 */
 	public function getThismonthDaysbyIndex($index, $day = '', $month = '', $year = '')
 	{
-		if ($day == '')
-			$day = $index + 1;
-		if ($month == '')
-			$month = $this->month;
-		if ($year == '')
-			$year = $this->year;
+		if ($day == '') {
+					$day = $index + 1;
+		}
+		if ($month == '') {
+					$month = $this->month;
+		}
+		if ($year == '') {
+					$year = $this->year;
+		}
 		$month_array = array();
 		$month_array['day'] = $day;
 		$month_array['month'] = $month;
@@ -356,8 +362,9 @@ 
 		} else {
 			die("year was not set");
 		}
-		if (empty($hour) && $hour !== 0)
-			$hour = 0;
+		if (empty($hour) && $hour !== 0) {
+					$hour = 0;
+		}
 		$this->ts = mktime($hour, $minute, $second, $month, $day, $year);
 		$this->setDateTime($this->ts);
 	}
@@ -399,10 +406,12 @@ 
 	{
 		$hour = $this->z_hour;
 		$min = $this->minute;
-		if (empty($hour))
-			$hour = '00';
-		if (empty($min))
-			$min = '00';
+		if (empty($hour)) {
+					$hour = '00';
+		}
+		if (empty($min)) {
+					$min = '00';
+		}
 		return $hour . ':' . $min;
 	}
 
@@ -413,10 +422,11 @@ 
 	 */
 	public function get_changed_day($mode)
 	{
-		if ($mode == 'increment')
-			$day = $this->day + 1;
-		else
-			$day = $this->day - 1;
+		if ($mode == 'increment') {
+					$day = $this->day + 1;
+		} else {
+					$day = $this->day - 1;
+		}
 		$date_data = array('day' => $day,
 			'month' => $this->month,
 			'year' => $this->year
@@ -432,10 +442,11 @@ 
 	public function get_first_day_of_changed_week($mode)
 	{
 		$first_day = $this->getThisweekDaysbyIndex(1);
-		if ($mode == 'increment')
-			$day = $first_day->day + 7;
-		else
-			$day = $first_day->day - 7;
+		if ($mode == 'increment') {
+					$day = $first_day->day + 7;
+		} else {
+					$day = $first_day->day - 7;
+		}
 		$date_data = array('day' => $day,
 			'month' => $first_day->month,
 			'year' => $first_day->year

modules/Calendar/RepeatEvents.php

Doc Comments +2 added lines

@@ -28,6 +28,7 @@ 
 
 	/**
 	 * Increment the time by interval and return value in YYYY-MM-DD HH:MM format.
+	 * @param integer $basetiming
 	 */
 	static function nexttime($basetiming, $interval)
 	{
@@ -146,6 +147,7 @@ 
 
 	/**
 	 * Repeat Activity instance till given limit.
+	 * @param RecurringType|null $recurObj
 	 */
 	static function repeat($focus, $recurObj)
 	{

Braces +3 added lines, -2 removed lines

@@ -175,8 +175,9 @@
 			$endDate = date('Y-m-d', $endDateTime);
 
 			// Reset the new_focus and prepare for reuse
-			if (isset($new_focus->id))
-				unset($new_focus->id);
+			if (isset($new_focus->id)) {
+							unset($new_focus->id);
+			}
 			$new_focus->column_fields = array();
 
 			foreach ($base_focus->column_fields as $key => $value) {

modules/HelpDesk/dashboards/TicketsByStatus.php

Doc Comments -1 removed lines

@@ -27,7 +27,6 @@
 
 	/**
 	 * Function returns Tickets grouped by Status
-	 * @param type $data
 	 * @return <Array>
 	 */
 	public function getTicketsByStatus($owner)

Braces +14 added lines, -10 removed lines

@@ -19,8 +19,9 @@ 
 
 		$listSearchParams = [];
 		$conditions = array(array('ticketstatus', 'e', $value));
-		if (!empty($assignedto))
-			array_push($conditions, array('assigned_user_id', 'e', $assignedto));
+		if (!empty($assignedto)) {
+					array_push($conditions, array('assigned_user_id', 'e', $assignedto));
+		}
 		$listSearchParams[] = $conditions;
 		return '&viewname=All&search_params=' . json_encode($listSearchParams);
 	}
@@ -72,8 +73,9 @@ 
 				$priorities[$row['priority']] = $counter++;
 				$colors[$row['priority']] = $row['color'];
 			}
-			if (!in_array($row['statusvalue'], $status))
-				$status[] = $row['statusvalue'];
+			if (!in_array($row['statusvalue'], $status)) {
+							$status[] = $row['statusvalue'];
+			}
 		}
 		if (!empty($tickets)) {
 			$counter = 0;
@@ -117,13 +119,15 @@ 
 		$data = $request->get('data');
 		$createdTime = $request->get('createdtime');
 		$widget = Vtiger_Widget_Model::getInstance($linkId, $currentUser->getId());
-		if (!$request->has('owner'))
-			$owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget, $moduleName);
-		else
-			$owner = $request->get('owner');
+		if (!$request->has('owner')) {
+					$owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget, $moduleName);
+		} else {
+					$owner = $request->get('owner');
+		}
 		$ownerForwarded = $owner;
-		if ($owner == 'all')
-			$owner = '';
+		if ($owner == 'all') {
+					$owner = '';
+		}
 
 		//Date conversion from user to database format
 		if (!empty($createdTime)) {

modules/Import/views/Main.php

Doc Comments +9 added lines

@@ -27,6 +27,9 @@ 
 		$this->user = $user;
 	}
 
+	/**
+	 * @param Vtiger_Request $request
+	 */
 	public static function import($request, $user)
 	{
 		$importController = new Import_Main_View($request, $user);
@@ -100,6 +103,9 @@ 
 		}
 	}
 
+	/**
+	 * @param boolean $continueImport
+	 */
 	public static function showCurrentStatus($importInfo, $importStatusCount, $continueImport)
 	{
 		$moduleName = $importInfo['module'];
@@ -210,6 +216,9 @@ 
 		Import_Queue_Action::add($this->request, $this->user);
 	}
 
+	/**
+	 * @param Vtiger_Request $request
+	 */
 	public static function deleteMap($request)
 	{
 		$moduleName = $request->getModule();

modules/ModComments/ModComments.php

Doc Comments +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
 
 	/**
 	 * Add widget to other module.
-	 * @param unknown_type $moduleNames
+	 * @param string[] $moduleNames
 	 * @return unknown_type
 	 */
 	static function addWidgetTo($moduleNames, $widgetType = 'DETAILVIEWWIDGET', $widgetName = 'DetailViewBlockCommentWidget')

Braces +12 added lines, -8 removed lines

@@ -64,11 +64,13 @@ 
 	 */
 	static function addWidgetTo($moduleNames, $widgetType = 'DETAILVIEWWIDGET', $widgetName = 'DetailViewBlockCommentWidget')
 	{
-		if (empty($moduleNames))
-			return;
+		if (empty($moduleNames)) {
+					return;
+		}
 
-		if (is_string($moduleNames))
-			$moduleNames = array($moduleNames);
+		if (is_string($moduleNames)) {
+					$moduleNames = array($moduleNames);
+		}
 
 		$commentWidgetModules = array();
 		foreach ($moduleNames as $moduleName) {
@@ -95,11 +97,13 @@ 
 	 */
 	static function removeWidgetFrom($moduleNames, $widgetType = 'DETAILVIEWWIDGET', $widgetName = 'DetailViewBlockCommentWidget')
 	{
-		if (empty($moduleNames))
-			return;
+		if (empty($moduleNames)) {
+					return;
+		}
 
-		if (is_string($moduleNames))
-			$moduleNames = array($moduleNames);
+		if (is_string($moduleNames)) {
+					$moduleNames = array($moduleNames);
+		}
 
 		$commentWidgetModules = array();
 		foreach ($moduleNames as $moduleName) {