Completed
Pull Request — developer (#8932)
by Sławomir
120:59 queued 101:08
created
modules/Vtiger/handlers/SocialMedia.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
 	 *
55 55
 	 * @param \App\EventHandler $eventHandler
56 56
 	 *
57
-	 * @return bool
57
+	 * @return boolean|null
58 58
 	 */
59 59
 	public function entityBeforeDelete(\App\EventHandler $eventHandler)
60 60
 	{
Please login to merge, or discard this patch.
app/Fields/RecordNumber.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
 	 * @param null|string $resetSequence 'Y'-Year, 'M'-Month, 'D'-Day
43 43
 	 * @param string      $curSequence   '201804' for example for M reset sequence
44 44
 	 *
45
-	 * @return bool
45
+	 * @return integer|null
46 46
 	 */
47 47
 	public static function setNumber($tabId, $prefix = '', $no = '', $postfix = '', $leadingZeros = 0, $resetSequence = null, $curSequence = '')
48 48
 	{
Please login to merge, or discard this patch.
modules/Settings/Currency/models/Record.php 1 patch
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -101,6 +101,7 @@  discard block
 block discarded – undo
101 101
 
102 102
 	/**
103 103
 	 * {@inheritdoc}
104
+	 * @param string $key
104 105
 	 */
105 106
 	public function set($key, $value)
106 107
 	{
@@ -167,7 +168,7 @@  discard block
 block discarded – undo
167 168
 	 *
168 169
 	 * @param int $id
169 170
 	 *
170
-	 * @return \self
171
+	 * @return Settings_Currency_Record_Model|null
171 172
 	 */
172 173
 	public static function getInstance($id)
173 174
 	{
@@ -188,7 +189,7 @@  discard block
 block discarded – undo
188 189
 	/**
189 190
 	 * Return all non mapped currences.
190 191
 	 *
191
-	 * @param array $includedIds
192
+	 * @param integer $includedIds
192 193
 	 *
193 194
 	 * @return \Settings_Currency_Record_Model[]
194 195
 	 */
@@ -220,7 +221,7 @@  discard block
 block discarded – undo
220 221
 	/**
221 222
 	 * Return currences.
222 223
 	 *
223
-	 * @param array $excludedIds
224
+	 * @param integer $excludedIds
224 225
 	 *
225 226
 	 * @return \Settings_Currency_Record_Model[]
226 227
 	 */
Please login to merge, or discard this patch.
modules/ModTracker/handlers/ModTrackerHandler.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 	 *
129 129
 	 * @param App\EventHandler $eventHandler
130 130
 	 *
131
-	 * @return bool
131
+	 * @return false|null
132 132
 	 */
133 133
 	public function entityAfterTransferLink(App\EventHandler $eventHandler)
134 134
 	{
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 	/**
143 143
 	 * @param App\EventHandler $eventHandler
144 144
 	 *
145
-	 * @return bool
145
+	 * @return false|null
146 146
 	 */
147 147
 	public function entityAfterTransferUnLink(App\EventHandler $eventHandler)
148 148
 	{
Please login to merge, or discard this patch.
include/fields/CurrencyField.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -432,7 +432,7 @@  discard block
 block discarded – undo
432 432
 	 * @param \App\User $user
433 433
 	 * @param bool      $skipConversion
434 434
 	 *
435
-	 * @return Number
435
+	 * @return string
436 436
 	 */
437 437
 	public static function convertToDBFormat($value, $user = null, $skipConversion = false)
438 438
 	{
@@ -446,7 +446,7 @@  discard block
 block discarded – undo
446 446
 	/**
447 447
 	 * Function to get the default CRM currency.
448 448
 	 *
449
-	 * @return int Default system currency id
449
+	 * @return string|null Default system currency id
450 450
 	 */
451 451
 	public static function getDBCurrencyId()
452 452
 	{
@@ -457,6 +457,9 @@  discard block
 block discarded – undo
457 457
 		return null;
458 458
 	}
459 459
 
460
+	/**
461
+	 * @param double $amount
462
+	 */
460 463
 	public static function convertToDollar($amount, $conversionRate)
461 464
 	{
462 465
 		if ($conversionRate == 0) {
Please login to merge, or discard this patch.
modules/Vtiger/uitypes/Currency.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -85,11 +85,11 @@
 block discarded – undo
85 85
 	/**
86 86
 	 * Function that converts the Number into Users Currency along with currency symbol.
87 87
 	 *
88
-	 * @param int|string $value
88
+	 * @param string $value
89 89
 	 * @param int        $recordId
90 90
 	 * @param int        $uiType
91 91
 	 *
92
-	 * @return Formatted Currency
92
+	 * @return string Currency
93 93
 	 */
94 94
 	public function getDetailViewDisplayValue($value, $recordId, $uiType)
95 95
 	{
Please login to merge, or discard this patch.
api/webservice/Portal/BaseModule/Fields.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 			$block = $field->get('block');
29 29
 			if (!isset($blocks[$block->id])) {
30 30
 				$blockProperties = get_object_vars($block);
31
-				$blocks[$block->id] = array_filter($blockProperties, function ($v) {
31
+				$blocks[$block->id] = array_filter($blockProperties, function($v) {
32 32
 					return !\is_object($v);
33 33
 				});
34 34
 				$blocks[$block->id]['name'] = \App\Language::translate($block->label, $moduleName);
Please login to merge, or discard this patch.
modules/Calendar/models/ListView.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 	 *
78 78
 	 * @param array $linkParams
79 79
 	 *
80
-	 * @return array - Associative array of Link type to List of  Vtiger_Link_Model instances for Mass Actions
80
+	 * @return Vtiger_Link_Model[] - Associative array of Link type to List of  Vtiger_Link_Model instances for Mass Actions
81 81
 	 */
82 82
 	public function getListViewMassActions($linkParams)
83 83
 	{
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	 *
145 145
 	 * @param Vtiger_Paging_Model $pagingModel
146 146
 	 *
147
-	 * @return array - Associative array of record id mapped to Vtiger_Record_Model instance
147
+	 * @return Vtiger_Record_Model[] - Associative array of record id mapped to Vtiger_Record_Model instance
148 148
 	 */
149 149
 	public function getListViewEntries(Vtiger_Paging_Model $pagingModel)
150 150
 	{
Please login to merge, or discard this patch.
modules/Vtiger/models/ListView.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 	 *
81 81
 	 * @param array $linkParams
82 82
 	 *
83
-	 * @return array List of Vtiger_Link_Model instances
83
+	 * @return Vtiger_Link_Model[] List of Vtiger_Link_Model instances
84 84
 	 */
85 85
 	public function getHederLinks($linkParams)
86 86
 	{
@@ -504,7 +504,6 @@  discard block
 block discarded – undo
504 504
 	/**
505 505
 	 * Function to get the list view entries.
506 506
 	 *
507
-	 * @param Vtiger_Paging_Model $pagingModel
508 507
 	 *
509 508
 	 * @return array - Associative array of record id mapped to Vtiger_Record_Model instance.
510 509
 	 */
Please login to merge, or discard this patch.