Completed
Pull Request — developer (#8932)
by Sławomir
120:59 queued 101:08
created
modules/SSalesProcesses/SSalesProcesses.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -195,6 +195,7 @@
 block discarded – undo
195 195
 	 * @param int   $id                    - ssalesprocessesid
196 196
 	 * @param array $parentSSalesProcesses - Array of all the parent sales
197 197
 	 *                                     returns All the parent Sales of the given ssalesprocessesid in array format
198
+	 * @param integer[] $encounteredSalesProcesses
198 199
 	 */
199 200
 	public function getParentSales($id, &$parentSSalesProcesses, &$encounteredSalesProcesses, $depthBase = 0)
200 201
 	{
Please login to merge, or discard this patch.
modules/Users/models/Module.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	 * Check mail exist.
135 135
 	 *
136 136
 	 * @param string    $email
137
-	 * @param int|false $userId
137
+	 * @param integer $userId
138 138
 	 *
139 139
 	 * @return bool
140 140
 	 */
@@ -152,9 +152,9 @@  discard block
 block discarded – undo
152 152
 	 * Validation of user name.
153 153
 	 *
154 154
 	 * @param string    $userName
155
-	 * @param int|false $userId
155
+	 * @param integer $userId
156 156
 	 *
157
-	 * @return bool
157
+	 * @return string|false
158 158
 	 */
159 159
 	public static function checkUserName($userName, $userId = false)
160 160
 	{
Please login to merge, or discard this patch.
modules/Users/models/Record.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -834,6 +834,10 @@  discard block
 block discarded – undo
834 834
 	 * to whom records should be assigned
835 835
 	 */
836 836
 
837
+	/**
838
+	 * @param integer $userId
839
+	 * @param integer $newOwnerId
840
+	 */
837 841
 	public static function deleteUserPermanently($userId, $newOwnerId)
838 842
 	{
839 843
 		$db = App\Db::getInstance();
@@ -1025,7 +1029,7 @@  discard block
 block discarded – undo
1025 1029
 	/**
1026 1030
 	 * Get authorization detail.
1027 1031
 	 *
1028
-	 * @return array
1032
+	 * @return string
1029 1033
 	 */
1030 1034
 	protected function getAuthDetail()
1031 1035
 	{
Please login to merge, or discard this patch.
modules/Vtiger/actions/GetData.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
 	 *
18 18
 	 * @throws \Exception\NoPermittedToRecord
19 19
 	 *
20
-	 * @return bool
20
+	 * @return boolean|null
21 21
 	 */
22 22
 	public function checkPermission(\App\Request $request)
23 23
 	{
Please login to merge, or discard this patch.
modules/Vtiger/actions/PDF.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -217,7 +217,7 @@
 block discarded – undo
217 217
 	 *
218 218
 	 * @param \App\Request $request
219 219
 	 *
220
-	 * @return bool true if valid template exists for this record
220
+	 * @return boolean|null true if valid template exists for this record
221 221
 	 */
222 222
 	public function hasValidTemplate(\App\Request $request)
223 223
 	{
Please login to merge, or discard this patch.
modules/Vtiger/models/DetailView.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
 	/**
20 20
 	 * Function to get Module instance.
21 21
 	 *
22
-	 * @return Vtiger_Module_Model
22
+	 * @return boolean
23 23
 	 */
24 24
 	public function getModule()
25 25
 	{
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 	/**
44 44
 	 * Function to get the Record model.
45 45
 	 *
46
-	 * @return Vtiger_Record_Model
46
+	 * @return boolean
47 47
 	 */
48 48
 	public function getRecord()
49 49
 	{
Please login to merge, or discard this patch.
modules/Vtiger/models/Field.php 1 patch
Doc Comments   +9 added lines, -8 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 	/**
94 94
 	 * Get field label.
95 95
 	 *
96
-	 * @return string
96
+	 * @return boolean
97 97
 	 */
98 98
 	public function getFieldLabel()
99 99
 	{
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
 	/**
104 104
 	 * Get table name.
105 105
 	 *
106
-	 * @return string
106
+	 * @return boolean
107 107
 	 */
108 108
 	public function getTableName()
109 109
 	{
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
 	/**
114 114
 	 * Get column label.
115 115
 	 *
116
-	 * @return string
116
+	 * @return boolean
117 117
 	 */
118 118
 	public function getColumnName()
119 119
 	{
@@ -159,6 +159,9 @@  discard block
 block discarded – undo
159 159
 		return $this->module;
160 160
 	}
161 161
 
162
+	/**
163
+	 * @param Vtiger_Module_Model $moduleInstance
164
+	 */
162 165
 	public function setModule($moduleInstance)
163 166
 	{
164 167
 		$this->module = $moduleInstance;
@@ -169,11 +172,10 @@  discard block
 block discarded – undo
169 172
 	 *
170 173
 	 * @param mixed                    $value          value which need to be converted to display value
171 174
 	 * @param bool|int                 $record
172
-	 * @param bool|Vtiger_Record_Model $recordInstance
173 175
 	 * @param bool                     $rawText
174
-	 * @param int|bool                 $length         Length of the text
176
+	 * @param boolean                 $length         Length of the text
175 177
 	 *
176
-	 * @return mixed converted display value
178
+	 * @return string converted display value
177 179
 	 */
178 180
 	public function getDisplayValue($value, $record = false, $recordModel = false, $rawText = false, $length = false)
179 181
 	{
@@ -907,7 +909,6 @@  discard block
 block discarded – undo
907 909
 	/**
908 910
 	 * Function to retrieve field model for specific block and module.
909 911
 	 *
910
-	 * @param Vtiger_Module_Model $blockModel - block instance
911 912
 	 *
912 913
 	 * @return <array> List of field model
913 914
 	 */
@@ -1070,7 +1071,7 @@  discard block
 block discarded – undo
1070 1071
 	 * @param mixed               $value
1071 1072
 	 * @param Vtiger_Record_Model $recordModel
1072 1073
 	 *
1073
-	 * @return mixed
1074
+	 * @return string
1074 1075
 	 */
1075 1076
 	public function getEditViewDisplayValue($value, $recordModel = false)
1076 1077
 	{
Please login to merge, or discard this patch.
modules/Vtiger/models/InventoryField.php 1 patch
Doc Comments   -5 removed lines patch added patch discarded remove patch
@@ -17,8 +17,6 @@  discard block
 block discarded – undo
17 17
 	/**
18 18
 	 * Create the name of the Inventory data table.
19 19
 	 *
20
-	 * @param string $module Module name
21
-	 * @param string $prefix Prefix table
22 20
 	 *
23 21
 	 * @return string Table name
24 22
 	 */
@@ -119,8 +117,6 @@  discard block
 block discarded – undo
119 117
 	/**
120 118
 	 * Get inventory columns.
121 119
 	 *
122
-	 * @param string $module        Module name
123
-	 * @param bool   $returnInBlock Should the result be divided into blocks
124 120
 	 *
125 121
 	 * @return array Inventory columns
126 122
 	 */
@@ -167,7 +163,6 @@  discard block
 block discarded – undo
167 163
 	/**
168 164
 	 * Retrieve list of all fields.
169 165
 	 *
170
-	 * @param string $moduleName Module name
171 166
 	 *
172 167
 	 * @return array Fields instance Vtiger_Basic_InventoryField
173 168
 	 */
Please login to merge, or discard this patch.
modules/Vtiger/models/Link.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 	 * Function to set the value of a given property.
38 38
 	 *
39 39
 	 * @param string   $propertyName
40
-	 * @param <Object> $propertyValue
40
+	 * @param boolean $propertyValue
41 41
 	 *
42 42
 	 * @return Vtiger_Link_Model instance
43 43
 	 */
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
 	/**
201 201
 	 * Function to check whether the link model has any child links.
202 202
 	 *
203
-	 * @return bool true/false
203
+	 * @return boolean|null true/false
204 204
 	 */
205 205
 	public function hasChild()
206 206
 	{
Please login to merge, or discard this patch.