Settings_MailSignature_DeleteAjax_Action::process()

Complexity

Conditions	4
Paths	3

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
	public function process(App\Request $request)
	{
		$result = ['success' => false];
		$recordModel = Settings_MailSignature_Record_Model::getInstanceById($request->getInteger('record'));
		if ($request->getBoolean('detailView') && $recordModel->delete()) {
			$result = Settings_Vtiger_Module_Model::getInstance($request->getModule(false))->getDefaultUrl();

The method getDefaultUrl() does not exist on Settings_Vtiger_Module_Model. It seems like you code against a sub-type of Settings_Vtiger_Module_Model such as Settings_SlaPolicy_Module_Model or Settings_Profiles_Module_Model or Settings_Roles_Module_Model or Settings_Magento_Module_Model or Settings_Companies_Module_Model or Settings_PickListDependency_Module_Model or Settings_Mail_Module_Model or Settings_MeetingServices_Module_Model or Settings_BusinessHours_Module_Model or Settings_Workflows_Module_Model or Settings_AutomaticAssignment_Module_Model or Settings_WooCommerce_Module_Model or Settings_MailSmtp_Module_Model or Settings_FieldsDependency_Module_Model or Settings_MailSignature_Module_Model or Settings_Wapro_Module_Model or Settings_AdvancedPermission_Module_Model or Settings_LoginHistory_Module_Model or Settings_PDF_Module_Model or Settings_Groups_Module_Model or Settings_MailServers_Module_Model.

		} elseif ($recordModel) {

$recordModel is of type Settings_MailSignature_Record_Model, thus it always evaluated to true.

			$result = ['success' => (bool) $recordModel->delete()];
		}
		$response = new Vtiger_Response();
		$response->setResult($result);
		$response->emit();
	}