Completed
Push — developer ( f778f3...8830e0 )
by Błażej
51:25 queued 38:36
created
app/Controller/Modal.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 	 *
59 59
 	 * @param \App\Request $request
60 60
 	 *
61
-	 * @return \Vtiger_JsScript_Model[]
61
+	 * @return Vtiger_JsScript_Model[]
62 62
 	 */
63 63
 	public function getModalScripts(\App\Request $request)
64 64
 	{
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 	 *
75 75
 	 * @param \App\Request $request
76 76
 	 *
77
-	 * @return \Vtiger_CssScript_Model[]
77
+	 * @return Vtiger_CssScript_Model[]
78 78
 	 */
79 79
 	public function getModalCss(\App\Request $request)
80 80
 	{
Please login to merge, or discard this patch.
modules/Products/models/Record.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -221,6 +221,9 @@  discard block
 block discarded – undo
221 221
 		return $status;
222 222
 	}
223 223
 
224
+	/**
225
+	 * @param integer $productId
226
+	 */
224 227
 	public function getPriceDetailsForProduct($productId, $unitPrice, $available = 'available', $itemType = 'Products')
225 228
 	{
226 229
 		\App\Log::trace('Entering into function getPriceDetailsForProduct(' . $productId . ')');
@@ -351,7 +354,7 @@  discard block
 block discarded – undo
351 354
 	/**
352 355
 	 * The function decide about mandatory save record.
353 356
 	 *
354
-	 * @return type
357
+	 * @return boolean
355 358
 	 */
356 359
 	public function isMandatorySave()
357 360
 	{
Please login to merge, or discard this patch.
modules/Vtiger/dashboards/ChartFilter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 		$widget = Vtiger_Widget_Model::getInstanceWithWidgetId($widgetId, \App\User::getCurrentUserId());
23 23
 		$chartFilterWidgetModel = Vtiger_ChartFilter_Model::getInstance();
24 24
 		$chartFilterWidgetModel->setWidgetModel($widget);
25
-		$additionalFilterFields= $chartFilterWidgetModel->getAdditionalFiltersFields();
25
+		$additionalFilterFields = $chartFilterWidgetModel->getAdditionalFiltersFields();
26 26
 		$viewer->assign('WIDGET', $widget);
27 27
 		$viewer->assign('MODULE_NAME', $moduleName);
28 28
 		$viewer->assign('CHART_MODEL', $chartFilterWidgetModel);
Please login to merge, or discard this patch.
modules/Vtiger/helpers/Util.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 	/**
204 204
 	 * Function to get the time value in user preferred hour format.
205 205
 	 *
206
-	 * @param <Time>               $time
206
+	 * @param string               $time
207 207
 	 * @param <Vtiger_Users_Model> $userObject
208 208
 	 *
209 209
 	 * @return string time with hour format
@@ -302,6 +302,9 @@  discard block
 block discarded – undo
302 302
 	 * else returns empty string
303 303
 	 */
304 304
 
305
+	/**
306
+	 * @param string $dataType
307
+	 */
305 308
 	public function getDefaultMandatoryValue($dataType)
306 309
 	{
307 310
 		switch ($dataType) {
Please login to merge, or discard this patch.
modules/Vtiger/models/ChartFilter.php 2 patches
Doc Comments   +7 added lines, -8 removed lines patch added patch discarded remove patch
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
 	 * @param int $linkId
273 273
 	 * @param int $userId
274 274
 	 *
275
-	 * @return \self
275
+	 * @return Vtiger_ChartFilter_Model
276 276
 	 */
277 277
 	public static function getInstance($linkId = 0, $userId = 0)
278 278
 	{
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
 	/**
396 396
 	 * Get filter id.
397 397
 	 *
398
-	 * @param string|int $dividingValue
398
+	 * @param integer $dividingValue
399 399
 	 *
400 400
 	 * @return int
401 401
 	 */
@@ -573,7 +573,7 @@  discard block
 block discarded – undo
573 573
 	/**
574 574
 	 * Iterate through all rows collected from db.
575 575
 	 *
576
-	 * @param {callback} $callback
576
+	 * @param Closure $callback
577 577
 	 */
578 578
 	protected function iterateAllRows($callback)
579 579
 	{
@@ -652,7 +652,7 @@  discard block
 block discarded – undo
652 652
 	/**
653 653
 	 * Set colors.
654 654
 	 *
655
-	 * @param {string} $from
655
+	 * @param string $from
656 656
 	 */
657 657
 	protected function setColorsFrom($from)
658 658
 	{
@@ -678,7 +678,7 @@  discard block
 block discarded – undo
678 678
 	/**
679 679
 	 * Add query to get picklists id (for colors).
680 680
 	 *
681
-	 * @param $query
681
+	 * @param App\Db\Query $query
682 682
 	 * @param $queryGenerator
683 683
 	 *
684 684
 	 * @return $query
@@ -710,7 +710,7 @@  discard block
 block discarded – undo
710 710
 	/**
711 711
 	 * Get query for specified filter.
712 712
 	 *
713
-	 * @param $filter
713
+	 * @param integer $filter
714 714
 	 *
715 715
 	 * @return \App\Db\Query
716 716
 	 */
@@ -866,7 +866,6 @@  discard block
 block discarded – undo
866 866
 	/**
867 867
 	 * Get current rows.
868 868
 	 *
869
-	 * @param int        $index         row index
870 869
 	 * @param string|int $groupValue
871 870
 	 * @param string|int $dividingValue
872 871
 	 */
@@ -879,7 +878,7 @@  discard block
 block discarded – undo
879 878
 	 * Get rows for dividing field chart.
880 879
 	 *
881 880
 	 * @param \App\QueryGenerator $query
882
-	 * @param string|int          $dividingValue
881
+	 * @param integer          $dividingValue
883 882
 	 *
884 883
 	 * @return array
885 884
 	 */
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -594,7 +594,7 @@  discard block
 block discarded – undo
594 594
 		$colors = \App\Fields\Picklist::getColors($fieldName);
595 595
 		$this->colorsFrom = 'picklist';
596 596
 		$this->colorsFromRow = 'picklist_id';
597
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) use ($colors) {
597
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) use ($colors) {
598 598
 			if (isset($colors[$row['picklist_id']])) {
599 599
 				$this->colors[$row['picklist_id']] = $colors[$row['picklist_id']];
600 600
 			}
@@ -609,7 +609,7 @@  discard block
 block discarded – undo
609 609
 		$this->colorsFrom = 'filters';
610 610
 		$this->colorsFromRow = 'color';
611 611
 		$colors = \App\Colors::getAllFilterColors();
612
-		$this->iterateAllRows(function (&$row, $groupValue, $dividingValue, $rowIndex) use ($colors) {
612
+		$this->iterateAllRows(function(&$row, $groupValue, $dividingValue, $rowIndex) use ($colors) {
613 613
 			$this->colors[$dividingValue] = $colors[$this->filterIds[$dividingValue]];
614 614
 		});
615 615
 	}
@@ -621,7 +621,7 @@  discard block
 block discarded – undo
621 621
 	{
622 622
 		$this->colorsFrom = 'assigned_user_id';
623 623
 		$this->colorsFromRow = 'assigned_user_id';
624
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) {
624
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) {
625 625
 			$this->colors[$row['assigned_user_id']] = \App\Fields\Owner::getColor($row['assigned_user_id']);
626 626
 		});
627 627
 	}
@@ -633,7 +633,7 @@  discard block
 block discarded – undo
633 633
 	{
634 634
 		$this->colorsFrom = 'record_id';
635 635
 		$this->colorsFromRow = 'id';
636
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) {
636
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) {
637 637
 			$this->colors[$row['id']] = \App\Colors::getRandomColor('from_id_' . $row['id']);
638 638
 		});
639 639
 	}
@@ -645,7 +645,7 @@  discard block
 block discarded – undo
645 645
 	{
646 646
 		$this->colorsFrom = 'record_number';
647 647
 		$this->colorsFromRow = 'record_number';
648
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) {
648
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) {
649 649
 			$this->colors[$groupValue] = \App\Colors::getRandomColor('generated_' . $groupValue);
650 650
 		});
651 651
 	}
@@ -938,7 +938,7 @@  discard block
 block discarded – undo
938 938
 		$this->calculateAverage();
939 939
 		$this->normalizeData();
940 940
 		$this->setColorsFrom($this->findOutColorsFromRows());
941
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) {
941
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) {
942 942
 			$this->setColorFromRow($row, $groupValue, $dividingValue);
943 943
 		});
944 944
 		return $this->data;
@@ -1183,7 +1183,7 @@  discard block
 block discarded – undo
1183 1183
 	protected function generateSectorsData()
1184 1184
 	{
1185 1185
 		// in funnel chart there is only one dividingValue 0 so it will iterate only once like flat array
1186
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) {
1186
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) {
1187 1187
 			$value = (float) $row[$this->valueName];
1188 1188
 			$sectorId = $this->getSectorForValue($value);
1189 1189
 			$sectorIndex = array_search($sectorId, $this->sectors);
Please login to merge, or discard this patch.
modules/Vtiger/actions/Mass.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
 	 *
17 17
 	 * @param \App\Request $request
18 18
 	 *
19
-	 * @return \App\QueryGenerator|bool
19
+	 * @return string[]
20 20
 	 */
21 21
 	public static function getQuery(\App\Request $request)
22 22
 	{
Please login to merge, or discard this patch.
vtlib/Vtiger/Access.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -117,6 +117,7 @@
 block discarded – undo
117 117
 	 * @param string Tool (action name) like Import, Export
118 118
 	 * @param bool true to enable tool, false to disable
119 119
 	 * @param int (optional) profile id to use, false applies to all profile
120
+	 * @param boolean $flag
120 121
 	 */
121 122
 	public static function updateTool(ModuleBasic $moduleInstance, $toolAction, $flag, $profileid = false)
122 123
 	{
Please login to merge, or discard this patch.
vtlib/Vtiger/ModuleBasic.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -385,6 +385,7 @@  discard block
 block discarded – undo
385 385
 	 * Disable tools for this module.
386 386
 	 *
387 387
 	 * @param mixed String or Array with value ['Import', 'Export']
388
+	 * @param string $tools
388 389
 	 */
389 390
 	public function disableTools($tools)
390 391
 	{
@@ -427,7 +428,7 @@  discard block
 block discarded – undo
427 428
 	/**
428 429
 	 * Function to get the Module/Tab id.
429 430
 	 *
430
-	 * @return int
431
+	 * @return boolean
431 432
 	 */
432 433
 	public function getId()
433 434
 	{
Please login to merge, or discard this patch.
app/AddressFinder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
 	/**
52 52
 	 * Get default provider.
53 53
 	 *
54
-	 * @return string[]
54
+	 * @return string|null
55 55
 	 */
56 56
 	public static function getDefaultProvider()
57 57
 	{
Please login to merge, or discard this patch.