Passed
Pull Request — developer (#16303)
by Arkadiusz
21:11 queued 05:16
created
app/Integrations/Magento/Synchronizer/Order.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
 								}
80 80
 								$dataCrm['accountid'] = $dataCrm['parent_id'];
81 81
 								$dataCrm['parent_id'] = $parentOrder;
82
-								unset($dataCrm['birthday'],$dataCrm['leadsource'],$dataCrm['mobile'],$dataCrm['mobile_extra'],$dataCrm['phone'],$dataCrm['phone_extra'],$dataCrm['salutationtype']);
82
+								unset($dataCrm['birthday'], $dataCrm['leadsource'], $dataCrm['mobile'], $dataCrm['mobile_extra'], $dataCrm['phone'], $dataCrm['phone_extra'], $dataCrm['salutationtype']);
83 83
 								$dataCrm['magento_id'] = $order['entity_id'];
84 84
 								$mapModel->setDataCrm($dataCrm);
85 85
 								$crmId = $this->createOrderInCrm($mapModel);
Please login to merge, or discard this patch.
modules/HelpDesk/ConfigTemplate.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
 		'default' => 50,
15 15
 		'description' => 'Max depth of hierarchy',
16 16
 		'validation' => '\App\Validator::naturalNumber',
17
-		'sanitization' => function () {
17
+		'sanitization' => function() {
18 18
 			return (int) func_get_arg(0);
19 19
 		}
20 20
 	],
Please login to merge, or discard this patch.
modules/Settings/CurrencyUpdate/bankmodels/ECB.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@
 block discarded – undo
118 118
 			if ($time['time'] == $dateParam) {
119 119
 				$num = \count($time->Cube);
120 120
 				for ($i = 0; $i < $num; ++$i) {
121
-					$currency = (string) $time->Cube[$i]['currency'];   // currency code
121
+					$currency = (string) $time->Cube[$i]['currency']; // currency code
122 122
 					foreach ($otherCurrencyCode as $key => $currId) {
123 123
 						if ($key == $currency && $currency != $mainCurrency) {
124 124
 							$exchange = $time->Cube[$i]['rate'];
Please login to merge, or discard this patch.
modules/Settings/CurrencyUpdate/bankmodels/NBR.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@
 block discarded – undo
116 116
 			if ($time['date'] == $dateParam) {
117 117
 				$num = \count($time->Rate);
118 118
 				for ($i = 0; $i < $num; ++$i) {
119
-					$currency = (string) $time->Rate[$i]['currency'];   // currency code
119
+					$currency = (string) $time->Rate[$i]['currency']; // currency code
120 120
 					foreach ($otherCurrencyCode as $key => $currId) {
121 121
 						if ($key == $currency && $currency != $mainCurrency) {
122 122
 							$exchange = $time->Rate[$i];
Please login to merge, or discard this patch.
modules/Settings/Roles/views/DeleteAjax.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 		$baseParentRole = $recordModel->get('parentrole') . '::';
21 21
 		$allRoles = Settings_Roles_Record_Model::getAll();
22 22
 		unset($allRoles[$recordId]);
23
-		$allRoles = array_filter($allRoles, function (Settings_Roles_Record_Model $items) use ($baseParentRole) {
23
+		$allRoles = array_filter($allRoles, function(Settings_Roles_Record_Model $items) use ($baseParentRole) {
24 24
 			return false === strpos($items->get('parentrole'), $baseParentRole);
25 25
 		});
26 26
 		$viewer->assign('MODULE', $moduleName);
Please login to merge, or discard this patch.
app/Integrations/Magento/Synchronizer/Invoice.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
 									$customerDataCrm = $customerMapModel->getDataCrm();
75 75
 									$dataCrm['accountid'] = $this->syncAccount($customerDataCrm);
76 76
 								}
77
-								unset($dataCrm['birthday'],$dataCrm['leadsource'],$dataCrm['mobile'],$dataCrm['mobile_extra'],$dataCrm['phone'],$dataCrm['phone_extra'],$dataCrm['salutationtype']);
77
+								unset($dataCrm['birthday'], $dataCrm['leadsource'], $dataCrm['mobile'], $dataCrm['mobile_extra'], $dataCrm['phone'], $dataCrm['phone_extra'], $dataCrm['salutationtype']);
78 78
 								$mapModel->setDataCrm($dataCrm);
79 79
 								$crmId = $this->createInvoiceInCrm($mapModel);
80 80
 								\App\Cache::staticSave('CrmIdByMagentoIdSSingleOrders', $invoice['entity_id'], $crmId);
Please login to merge, or discard this patch.
app/Installer/Developer.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
 	 */
24 24
 	public static function generateSwagger(): string
25 25
 	{
26
-		set_error_handler(function ($errNo, $errStr, $errFile, $errLine) {
26
+		set_error_handler(function($errNo, $errStr, $errFile, $errLine) {
27 27
 			$errorString = \App\ErrorHandler::error2string($errNo);
28 28
 			$msg = reset($errorString) . ": {$errStr}\nFile: {$errFile}\nLine: $errLine" . PHP_EOL;
29 29
 			echo "<pre>$msg</pre><hr>";
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 	public static function generateSwaggerByType(string $type, $errorHandler = true): string
47 47
 	{
48 48
 		if ($errorHandler) {
49
-			set_error_handler(function ($errNo, $errStr, $errFile, $errLine) {
49
+			set_error_handler(function($errNo, $errStr, $errFile, $errLine) {
50 50
 				$errorString = \App\ErrorHandler::error2string($errNo);
51 51
 				$msg = reset($errorString) . ": {$errStr}\nFile: {$errFile}\nLine: $errLine" . PHP_EOL;
52 52
 				echo "<pre>$msg</pre><hr>";
Please login to merge, or discard this patch.
modules/Settings/Magento/actions/Active.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 				'displaytype' => 2,
47 47
 				'maximumlength' => '255',
48 48
 				'typeofdata' => 'V~O',
49
-				'picklistValues' => ['PLL_PENDING', 'PLL_PENDING_PAYMENT', 'PLL_PENDING_PAYPAL',  'PLL_PAID', 'PLL_PROCESSING', 'PLL_ON_HOLD', 'PLL_SEND', 'PLL_FRAUD', 'PLL_PAYMENT_REVIEW', 'PLL_PAYPAL_CANCELED_REVERSAL', 'PLL_PAYPAL_REVERSED', 'PLL_CANCELLED', 'PLL_CLOSED', 'PLL_COMPLETE']
49
+				'picklistValues' => ['PLL_PENDING', 'PLL_PENDING_PAYMENT', 'PLL_PENDING_PAYPAL', 'PLL_PAID', 'PLL_PROCESSING', 'PLL_ON_HOLD', 'PLL_SEND', 'PLL_FRAUD', 'PLL_PAYMENT_REVIEW', 'PLL_PAYPAL_CANCELED_REVERSAL', 'PLL_PAYPAL_REVERSED', 'PLL_CANCELLED', 'PLL_CLOSED', 'PLL_COMPLETE']
50 50
 			]
51 51
 		];
52 52
 		$fieldsExists = (new \App\Db\Query())->select(['fieldname'])->from('vtiger_field')->where(['tabid' => $sSingleOrderTabId, 'fieldname' => array_keys($fields)])->column();
Please login to merge, or discard this patch.
modules/Vtiger/models/TransferOwnership.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
 	{
62 62
 		foreach ($relatedModuleRecordIds as $record) {
63 63
 			$recordModel = Vtiger_Record_Model::getInstanceById($record, $module);
64
-			if($recordModel->isEditable()){
64
+			if ($recordModel->isEditable()) {
65 65
 				$recordModel->set('assigned_user_id', $transferOwnerId);
66 66
 				$recordModel->save();
67 67
 			}
Please login to merge, or discard this patch.