Completed
Pull Request — developer (#8881)
by Sławomir
178:12 queued 163:40
created
app/Map/Address.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
 	/**
52 52
 	 * Get default provider.
53 53
 	 *
54
-	 * @return string[]
54
+	 * @return string|null
55 55
 	 */
56 56
 	public static function getDefaultProvider()
57 57
 	{
Please login to merge, or discard this patch.
modules/Vtiger/models/Widget.php 1 patch
Doc Comments   +8 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,7 +45,6 @@  discard block
 block discarded – undo
45 45
 	/**
46 46
 	 * Function to get the position of the widget.
47 47
 	 *
48
-	 * @param int    $defaultPosition
49 48
 	 * @param string $coordinate
50 49
 	 *
51 50
 	 * @throws \App\Exceptions\AppException
@@ -118,6 +117,9 @@  discard block
 block discarded – undo
118 117
 		return $self;
119 118
 	}
120 119
 
120
+	/**
121
+	 * @param integer $linkId
122
+	 */
121 123
 	public static function getInstance($linkId, $userId)
122 124
 	{
123 125
 		$row = (new \App\Db\Query())->from('vtiger_module_dashboard_widgets')
@@ -131,6 +133,10 @@  discard block
 block discarded – undo
131 133
 		return $self;
132 134
 	}
133 135
 
136
+	/**
137
+	 * @param null|integer $linkId
138
+	 * @param integer|null $widgetId
139
+	 */
134 140
 	public static function updateWidgetPosition($position, $linkId, $widgetId, $userId)
135 141
 	{
136 142
 		if (!$linkId && !$widgetId) {
@@ -175,7 +181,7 @@  discard block
 block discarded – undo
175 181
 	 * @param int $widgetId
176 182
 	 * @param int $userId
177 183
 	 *
178
-	 * @return \self
184
+	 * @return Vtiger_Widget_Model
179 185
 	 */
180 186
 	public static function getInstanceWithWidgetId($widgetId, $userId)
181 187
 	{
Please login to merge, or discard this patch.
app/QueryGenerator.php 1 patch
Doc Comments   +15 added lines, -16 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 	/**
139 139
 	 * Get module model.
140 140
 	 *
141
-	 * @return string
141
+	 * @return \Vtiger_Module_Model
142 142
 	 */
143 143
 	public function getModuleModel()
144 144
 	{
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
 	 *
181 181
 	 * @param string[] $fields
182 182
 	 *
183
-	 * @return \self
183
+	 * @return QueryGenerator
184 184
 	 */
185 185
 	public function setFields($fields)
186 186
 	{
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
 	 *
195 195
 	 * @param int $offset
196 196
 	 *
197
-	 * @return \self
197
+	 * @return QueryGenerator
198 198
 	 */
199 199
 	public function setOffset($offset)
200 200
 	{
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
 	 *
209 209
 	 * @param int $limit
210 210
 	 *
211
-	 * @return \self
211
+	 * @return QueryGenerator
212 212
 	 */
213 213
 	public function setLimit($limit)
214 214
 	{
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
 	 *
241 241
 	 * @param string|string[] $fields
242 242
 	 *
243
-	 * @return \self
243
+	 * @return QueryGenerator
244 244
 	 */
245 245
 	public function setField($fields)
246 246
 	{
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
 	 *
270 270
 	 * @param type $columns
271 271
 	 *
272
-	 * @return \self
272
+	 * @return QueryGenerator
273 273
 	 */
274 274
 	public function setCustomColumn($columns)
275 275
 	{
@@ -290,9 +290,8 @@  discard block
 block discarded – undo
290 290
 	/**
291 291
 	 * Set concat column.
292 292
 	 *
293
-	 * @param type $columns
294 293
 	 *
295
-	 * @return \self
294
+	 * @return QueryGenerator
296 295
 	 */
297 296
 	public function setConcatColumn($fieldName, $concat)
298 297
 	{
@@ -363,7 +362,7 @@  discard block
 block discarded – undo
363 362
 	 *
364 363
 	 * @param string[] $field
365 364
 	 *
366
-	 * @return \self
365
+	 * @return QueryGenerator
367 366
 	 */
368 367
 	public function addRelatedField($field)
369 368
 	{
@@ -431,7 +430,7 @@  discard block
 block discarded – undo
431 430
 	 * @param string $fieldName
432 431
 	 * @param string $order     ASC/DESC
433 432
 	 *
434
-	 * @return \self
433
+	 * @return QueryGenerator
435 434
 	 */
436 435
 	public function setOrder($fieldName, $order = false)
437 436
 	{
@@ -446,7 +445,7 @@  discard block
 block discarded – undo
446 445
 	 *
447 446
 	 * @param string $fieldName
448 447
 	 *
449
-	 * @return \self
448
+	 * @return QueryGenerator
450 449
 	 */
451 450
 	public function setGroup($fieldName)
452 451
 	{
@@ -459,9 +458,9 @@  discard block
 block discarded – undo
459 458
 	/**
460 459
 	 * Set custom group.
461 460
 	 *
462
-	 * @param string|array $groups
461
+	 * @param \yii\db\Expression[] $groups
463 462
 	 *
464
-	 * @return \self
463
+	 * @return QueryGenerator
465 464
 	 */
466 465
 	public function setCustomGroup($groups)
467 466
 	{
@@ -483,7 +482,7 @@  discard block
 block discarded – undo
483 482
 	 * Function sets the field for which the duplicated values will be searched.
484 483
 	 *
485 484
 	 * @param string   $fieldName
486
-	 * @param int|bool $ignoreEmptyValue
485
+	 * @param boolean $ignoreEmptyValue
487 486
 	 */
488 487
 	public function setSearchFieldsForDuplicates($fieldName, $ignoreEmptyValue = true)
489 488
 	{
@@ -716,7 +715,7 @@  discard block
 block discarded – undo
716 715
 	/**
717 716
 	 * Parsing advanced filters conditions.
718 717
 	 *
719
-	 * @return bool
718
+	 * @return false|null
720 719
 	 */
721 720
 	public function parseAdvFilter($advFilterList = false)
722 721
 	{
@@ -1220,7 +1219,7 @@  discard block
 block discarded – undo
1220 1219
 	 * Set base search condition (search_key,search_value in url).
1221 1220
 	 *
1222 1221
 	 * @param string $fieldName
1223
-	 * @param mixed  $value
1222
+	 * @param mixed  $values
1224 1223
 	 * @param string $operator
1225 1224
 	 */
1226 1225
 	public function addBaseSearchConditions($fieldName, $values, $operator = 'e')
Please login to merge, or discard this patch.
modules/Products/models/Record.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -168,7 +168,7 @@
 block discarded – undo
168 168
 	/**
169 169
 	 * The function decide about mandatory save record.
170 170
 	 *
171
-	 * @return type
171
+	 * @return boolean
172 172
 	 */
173 173
 	public function isMandatorySave()
174 174
 	{
Please login to merge, or discard this patch.
modules/Chat/views/Modal.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -85,8 +85,7 @@
 block discarded – undo
85 85
 	private function isSoundNotification(): bool
86 86
 	{
87 87
 		return isset($_COOKIE['chat-isSoundNotification']) ?
88
-			filter_var($_COOKIE['chat-isSoundNotification'], FILTER_VALIDATE_BOOLEAN) :
89
-			\AppConfig::module('Chat', 'DEFAULT_SOUND_NOTIFICATION');
88
+			filter_var($_COOKIE['chat-isSoundNotification'], FILTER_VALIDATE_BOOLEAN) : \AppConfig::module('Chat', 'DEFAULT_SOUND_NOTIFICATION');
90 89
 	}
91 90
 
92 91
 	/**
Please login to merge, or discard this patch.
config/modules/AddressFinder.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
 	'REMAPPING_OPENCAGE' => null,
11 11
 	// Function to remapping fields in countries for OpenCage. It should be function
12 12
 	'REMAPPING_OPENCAGE_FOR_COUNTRY' => [
13
-		'Australia' => function ($row) {
13
+		'Australia' => function($row) {
14 14
 			return [
15 15
 				'addresslevel1' => [$row['components']['country'] ?? '', $row['components']['ISO_3166-1_alpha-2'] ?? ''],
16 16
 				'addresslevel2' => $row['components']['state'] ?? '',
Please login to merge, or discard this patch.
modules/Users/models/Privileges.php 1 patch
Doc Comments   +7 added lines, -3 removed lines patch added patch discarded remove patch
@@ -103,8 +103,7 @@  discard block
 block discarded – undo
103 103
 	/**
104 104
 	 * Function to check whether the user has access to the specified action/operation on a given module by tabid.
105 105
 	 *
106
-	 * @param <Number>        $tabId
107
-	 * @param <String/Number> $action
106
+	 * @param string $action
108 107
 	 *
109 108
 	 * @return bool true/false
110 109
 	 */
@@ -180,6 +179,9 @@  discard block
 block discarded – undo
180 179
 
181 180
 	protected static $lockEditCache = [];
182 181
 
182
+	/**
183
+	 * @param string $moduleName
184
+	 */
183 185
 	public static function checkLockEdit($moduleName, Vtiger_Record_Model $recordModel)
184 186
 	{
185 187
 		$recordId = $recordModel->getId();
@@ -224,7 +226,7 @@  discard block
 block discarded – undo
224 226
 	/**
225 227
 	 * Clear user cache.
226 228
 	 *
227
-	 * @param int|bool $userId
229
+	 * @param integer $userId
228 230
 	 */
229 231
 	public static function clearCache($userId = false)
230 232
 	{
@@ -275,6 +277,8 @@  discard block
 block discarded – undo
275 277
 
276 278
 	/**
277 279
 	 * Function to get set Shared Owner Recursively.
280
+	 * @param integer $recordId
281
+	 * @param string $moduleName
278 282
 	 */
279 283
 	public static function getSharedRecordsRecursively($recordId, $moduleName)
280 284
 	{
Please login to merge, or discard this patch.
vtlib/Vtiger/Functions.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -158,7 +158,6 @@  discard block
 block discarded – undo
158 158
 	/**
159 159
 	 * Function get module field infos.
160 160
 	 *
161
-	 * @param int|string $mixed
162 161
 	 * @param bool       $returnByColumn
163 162
 	 *
164 163
 	 * @return mixed[]
@@ -615,6 +614,9 @@  discard block
 block discarded – undo
615 614
 	 * @return <Date> - last working y
616 615
 	 */
617 616
 
617
+	/**
618
+	 * @param string $date
619
+	 */
618 620
 	public static function getLastWorkingDay($date)
619 621
 	{
620 622
 		if (empty($date)) {
Please login to merge, or discard this patch.
modules/Settings/CurrencyUpdate/models/Module.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -47,6 +47,9 @@  discard block
 block discarded – undo
47 47
 	 * @return boolean - true if fetched new exchange rates, false otherwise
48 48
 	 */
49 49
 
50
+	/**
51
+	 * @param string $dateCur
52
+	 */
50 53
 	public function fetchCurrencyRates($dateCur, $cron = false)
51 54
 	{
52 55
 		if (!\App\RequestUtil::isNetConnection()) {
@@ -123,6 +126,9 @@  discard block
 block discarded – undo
123 126
 	 * @param <Float> $exchange - exchange rate
124 127
 	 */
125 128
 
129
+	/**
130
+	 * @param string|false $id
131
+	 */
126 132
 	public function updateCurrencyRate($id, $exchange)
127 133
 	{
128 134
 		\App\Db::getInstance()->createCommand()
@@ -172,6 +178,9 @@  discard block
 block discarded – undo
172 178
 	 * @return <Array> - array containing currency rates
173 179
 	 */
174 180
 
181
+	/**
182
+	 * @param string $dateCur
183
+	 */
175 184
 	public function getRatesHistory($bankId, $dateCur, \App\Request $request)
176 185
 	{
177 186
 		$query = (new App\Db\Query())->select(['exchange', 'currency_name', 'currency_code', 'currency_symbol', 'fetch_date', 'exchange_date'])
@@ -366,6 +375,9 @@  discard block
 block discarded – undo
366 375
 	 * @return boolean - true on success or false
367 376
 	 */
368 377
 
378
+	/**
379
+	 * @param integer $bankId
380
+	 */
369 381
 	public function setActiveBankById($bankId)
370 382
 	{
371 383
 		$db = \App\Db::getInstance();
Please login to merge, or discard this patch.