Completed
Pull Request — developer (#8881)
by Sławomir
178:12 queued 163:40
created
vtlib/Vtiger/Cron.php 1 patch
Doc Comments   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -38,7 +38,8 @@  discard block
 block discarded – undo
38 38
 	/**
39 39
 	 * set the value to the data.
40 40
 	 *
41
-	 * @param type $value ,$key
41
+	 * @param integer $value ,$key
42
+	 * @param string $key
42 43
 	 */
43 44
 	public function set($key, $value)
44 45
 	{
@@ -195,6 +196,7 @@  discard block
 block discarded – undo
195 196
 
196 197
 	/**
197 198
 	 * Helper function to check the status value.
199
+	 * @param integer $value
198 200
 	 */
199 201
 	public function statusEqual($value)
200 202
 	{
@@ -271,7 +273,7 @@  discard block
 block discarded – undo
271 273
 	/**
272 274
 	 * Mark this instance as finished.
273 275
 	 *
274
-	 * @return int
276
+	 * @return Cron
275 277
 	 */
276 278
 	public function markFinished()
277 279
 	{
Please login to merge, or discard this patch.
app/Map/Route/Base.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
 	 */
74 74
 	public function addIndirectPoint(float $lat, float $lon)
75 75
 	{
76
-		$this->indirectPoints[]= ['lat' => $lat, 'lon' => $lon];
76
+		$this->indirectPoints[] = ['lat' => $lat, 'lon' => $lon];
77 77
 	}
78 78
 
79 79
 	/**
Please login to merge, or discard this patch.
modules/Vtiger/models/SocialMedia.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,6 @@
 block discarded – undo
49 49
 	/**
50 50
 	 * Checking whether social media are available for the record.
51 51
 	 *
52
-	 * @param \Vtiger_Record_Model $recordModel
53 52
 	 *
54 53
 	 * @return bool
55 54
 	 */
Please login to merge, or discard this patch.
app/SocialMedia/Twitter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
 	/**
66 66
 	 * Get query for list records.
67 67
 	 *
68
-	 * @param string|string[] $twitterLogin
68
+	 * @param string[] $twitterLogin
69 69
 	 *
70 70
 	 * @return \App\Db\Query
71 71
 	 */
Please login to merge, or discard this patch.
modules/Calendar/models/RecuringEvents.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -276,7 +276,7 @@
 block discarded – undo
276 276
 	 *
277 277
 	 * @param type $recurrenceRule
278 278
 	 *
279
-	 * @return type
279
+	 * @return boolean
280 280
 	 */
281 281
 	public function isNeverEndingRule($recurrenceRule)
282 282
 	{
Please login to merge, or discard this patch.
modules/Settings/Picklist/models/Module.php 1 patch
Doc Comments   +8 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	/**
23 23
 	 * Function gives fields based on the type.
24 24
 	 *
25
-	 * @param string|string[] $type - field type
25
+	 * @param string[] $type - field type
26 26
 	 *
27 27
 	 * @return Settings_Picklist_Field_Model[] - list of field models
28 28
 	 */
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 	 * @param \App\Db $db
178 178
 	 * @param string  $tableName
179 179
 	 *
180
-	 * @return bool
180
+	 * @return integer
181 181
 	 */
182 182
 	public function addDescriptionColumn($db, $tableName)
183 183
 	{
@@ -214,6 +214,9 @@  discard block
 block discarded – undo
214 214
 		\App\Cache::delete('getCloseStates', $fieldModel->get('tabid'));
215 215
 	}
216 216
 
217
+	/**
218
+	 * @param string|boolean $pickListFieldName
219
+	 */
217 220
 	public function remove($pickListFieldName, $valueToDeleteId, $replaceValueId, $moduleName)
218 221
 	{
219 222
 		$dbCommand = App\Db::getInstance()->createCommand();
@@ -266,6 +269,9 @@  discard block
 block discarded – undo
266 269
 		return true;
267 270
 	}
268 271
 
272
+	/**
273
+	 * @param string|boolean $picklistFieldName
274
+	 */
269 275
 	public function enableOrDisableValuesForRole($picklistFieldName, $valuesToEnables, $valuesToDisable, $roleIdList)
270 276
 	{
271 277
 		$db = App\Db::getInstance();
Please login to merge, or discard this patch.
app/SocialMedia.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -253,7 +253,7 @@
 block discarded – undo
253 253
 	 *
254 254
 	 * @throws \App\Exceptions\AppException
255 255
 	 *
256
-	 * @return \App\SocialMedia\Base|\Generator|void
256
+	 * @return \Generator
257 257
 	 */
258 258
 	public static function getSocialMediaAccount($socialMediaType)
259 259
 	{
Please login to merge, or discard this patch.
modules/Vtiger/uitypes/Base.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 	 * @param bool                     $rawText     Return text or html
119 119
 	 * @param int|bool                 $length      Length of the text
120 120
 	 *
121
-	 * @return mixed
121
+	 * @return string
122 122
 	 */
123 123
 	public function getDisplayValue($value, $record = false, $recordModel = false, $rawText = false, $length = false)
124 124
 	{
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	 * @param mixed               $value
135 135
 	 * @param Vtiger_Record_Model $recordModel
136 136
 	 *
137
-	 * @return mixed
137
+	 * @return string
138 138
 	 */
139 139
 	public function getEditViewDisplayValue($value, $recordModel = false)
140 140
 	{
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 	 * @param Vtiger_Record_Model|bool $recordModel
150 150
 	 * @param bool                     $rawText     Return text or html
151 151
 	 *
152
-	 * @return mixed
152
+	 * @return string
153 153
 	 */
154 154
 	public function getListViewDisplayValue($value, $record = false, $recordModel = false, $rawText = false)
155 155
 	{
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 	 * @param Vtiger_Record_Model|bool $recordModel
165 165
 	 * @param bool                     $rawText     Return text or html
166 166
 	 *
167
-	 * @return mixed
167
+	 * @return string
168 168
 	 */
169 169
 	public function getRelatedListViewDisplayValue($value, $record = false, $recordModel = false, $rawText = false)
170 170
 	{
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 	 * @param                      $value
190 190
 	 * @param \Vtiger_Record_Model $recordModel
191 191
 	 *
192
-	 * @return mixed
192
+	 * @return string
193 193
 	 */
194 194
 	public function getHistoryDisplayValue($value, Vtiger_Record_Model $recordModel)
195 195
 	{
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 	 * @param \Vtiger_Record_Model $recordModel
204 204
 	 * @param string               $params
205 205
 	 *
206
-	 * @return mixed
206
+	 * @return string
207 207
 	 */
208 208
 	public function getTextParserDisplayValue($value, Vtiger_Record_Model $recordModel, $params)
209 209
 	{
Please login to merge, or discard this patch.
modules/Settings/LayoutEditor/models/Module.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -419,6 +419,9 @@
 block discarded – undo
419 419
 		];
420 420
 	}
421 421
 
422
+	/**
423
+	 * @param string $name
424
+	 */
422 425
 	public function checkFieldNameCharacters($name)
423 426
 	{
424 427
 		if (preg_match('#[^a-z0-9_]#is', $name) || !preg_match('/[a-z]/i', $name)) {
Please login to merge, or discard this patch.