Completed
Pull Request — developer (#8881)
by Sławomir
178:12 queued 163:40
created
modules/Settings/ModuleManager/models/Library.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
 	 *
96 96
 	 * @throws \Exception\NoPermitted
97 97
 	 *
98
-	 * @return bool
98
+	 * @return boolean|null
99 99
 	 */
100 100
 	public static function download($name)
101 101
 	{
Please login to merge, or discard this patch.
vtlib/Vtiger/PackageImport.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1023,7 +1023,7 @@
 block discarded – undo
1023 1023
 			$db->createCommand()->update('vtiger_version', ['current_version' => (string) $this->_modulexml->to_version])->execute();
1024 1024
 		}
1025 1025
 		Functions::recurseDelete($dirName);
1026
-		register_shutdown_function(function () {
1026
+		register_shutdown_function(function() {
1027 1027
 			$viewer = \Vtiger_Viewer::getInstance();
1028 1028
 			$viewer->clearAllCache();
1029 1029
 			Functions::recurseDelete('cache/templates_c');
Please login to merge, or discard this patch.
Doc Comments   +16 added lines patch added patch discarded remove patch
@@ -373,6 +373,7 @@  discard block
 block discarded – undo
373 373
 
374 374
 	/**
375 375
 	 * Cache the field instance for re-use.
376
+	 * @param Field $fieldInstance
376 377
 	 */
377 378
 	public function __AddModuleFieldToCache($moduleInstance, $fieldname, $fieldInstance)
378 379
 	{
@@ -381,6 +382,7 @@  discard block
 block discarded – undo
381 382
 
382 383
 	/**
383 384
 	 * Get field instance from cache.
385
+	 * @return FieldBasic
384 386
 	 */
385 387
 	public function __GetModuleFieldFromCache($moduleInstance, $fieldname)
386 388
 	{
@@ -632,6 +634,8 @@  discard block
 block discarded – undo
632 634
 
633 635
 	/**
634 636
 	 * Import Blocks of the module.
637
+	 * @param \SimpleXMLElement $modulenode
638
+	 * @param Module $moduleInstance
635 639
 	 */
636 640
 	public function importBlocks($modulenode, $moduleInstance)
637 641
 	{
@@ -676,6 +680,7 @@  discard block
 block discarded – undo
676 680
 
677 681
 	/**
678 682
 	 * Import Fields of the module.
683
+	 * @param Block $blockInstance
679 684
 	 */
680 685
 	public function importFields($blocknode, $blockInstance, $moduleInstance)
681 686
 	{
@@ -770,6 +775,8 @@  discard block
 block discarded – undo
770 775
 
771 776
 	/**
772 777
 	 * Import Custom views of the module.
778
+	 * @param \SimpleXMLElement $modulenode
779
+	 * @param Module $moduleInstance
773 780
 	 */
774 781
 	public function importCustomViews($modulenode, $moduleInstance)
775 782
 	{
@@ -813,6 +820,8 @@  discard block
 block discarded – undo
813 820
 
814 821
 	/**
815 822
 	 * Import Sharing Access of the module.
823
+	 * @param \SimpleXMLElement $modulenode
824
+	 * @param Module $moduleInstance
816 825
 	 */
817 826
 	public function importSharingAccess($modulenode, $moduleInstance)
818 827
 	{
@@ -829,6 +838,8 @@  discard block
 block discarded – undo
829 838
 
830 839
 	/**
831 840
 	 * Import Events of the module.
841
+	 * @param \SimpleXMLElement $modulenode
842
+	 * @param Module $moduleInstance
832 843
 	 */
833 844
 	public function importEvents($modulenode, $moduleInstance)
834 845
 	{
@@ -843,6 +854,8 @@  discard block
 block discarded – undo
843 854
 
844 855
 	/**
845 856
 	 * Import actions of the module.
857
+	 * @param \SimpleXMLElement $modulenode
858
+	 * @param Module $moduleInstance
846 859
 	 */
847 860
 	public function importActions($modulenode, $moduleInstance)
848 861
 	{
@@ -869,6 +882,8 @@  discard block
 block discarded – undo
869 882
 
870 883
 	/**
871 884
 	 * Import related lists of the module.
885
+	 * @param \SimpleXMLElement $modulenode
886
+	 * @param Module $moduleInstance
872 887
 	 */
873 888
 	public function importRelatedLists($modulenode, $moduleInstance)
874 889
 	{
@@ -946,6 +961,7 @@  discard block
 block discarded – undo
946 961
 
947 962
 	/**
948 963
 	 * Import cron jobs of the module.
964
+	 * @param \SimpleXMLElement $modulenode
949 965
 	 */
950 966
 	public function importCronTasks($modulenode)
951 967
 	{
Please login to merge, or discard this patch.
modules/Portal/models/Module.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -26,6 +26,9 @@  discard block
 block discarded – undo
26 26
 		return $links;
27 27
 	}
28 28
 
29
+	/**
30
+	 * @param integer $recordId
31
+	 */
29 32
 	public static function savePortalRecord($recordId, $bookmarkName, $bookmarkUrl)
30 33
 	{
31 34
 		$db = App\Db::getInstance();
@@ -64,7 +67,7 @@  discard block
 block discarded – undo
64 67
 	/**
65 68
 	 * Delete record.
66 69
 	 *
67
-	 * @param $recordId
70
+	 * @param integer $recordId
68 71
 	 *
69 72
 	 * @throws \yii\db\Exception
70 73
 	 */
@@ -76,7 +79,7 @@  discard block
 block discarded – undo
76 79
 	/**
77 80
 	 * Get website url.
78 81
 	 *
79
-	 * @param $recordId
82
+	 * @param integer $recordId
80 83
 	 *
81 84
 	 * @return false|null|string
82 85
 	 */
Please login to merge, or discard this patch.
modules/Vtiger/models/Block.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -50,6 +50,9 @@  discard block
 block discarded – undo
50 50
 		}
51 51
 	}
52 52
 
53
+	/**
54
+	 * @param string $propertyName
55
+	 */
53 56
 	public function set($propertyName, $value)
54 57
 	{
55 58
 		if (property_exists($this, $propertyName)) {
@@ -272,6 +275,7 @@  discard block
 block discarded – undo
272 275
 	 *
273 276
 	 * @param string $blockLabel
274 277
 	 * @param number ModuleId
278
+	 * @param integer $tabId
275 279
 	 *
276 280
 	 * @return bool true/false
277 281
 	 */
Please login to merge, or discard this patch.
app/QueryField/TimeField.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 	/**
15 15
 	 * Greater operator.
16 16
 	 *
17
-	 * @return array
17
+	 * @return string[]
18 18
 	 */
19 19
 	public function operatorG()
20 20
 	{
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
 	/**
25 25
 	 * Get value.
26 26
 	 *
27
-	 * @return mixed
27
+	 * @return string
28 28
 	 */
29 29
 	public function getValue()
30 30
 	{
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	/**
35 35
 	 * Lower operator.
36 36
 	 *
37
-	 * @return array
37
+	 * @return string[]
38 38
 	 */
39 39
 	public function operatorL()
40 40
 	{
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 	/**
45 45
 	 * Before operator.
46 46
 	 *
47
-	 * @return array
47
+	 * @return string[]
48 48
 	 */
49 49
 	public function operatorB()
50 50
 	{
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 	/**
55 55
 	 * After operator.
56 56
 	 *
57
-	 * @return array
57
+	 * @return string[]
58 58
 	 */
59 59
 	public function operatorA()
60 60
 	{
Please login to merge, or discard this patch.
modules/Import/actions/Data.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
 								}
329 329
 							}
330 330
 							// remove empty values - do not modify existing
331
-							$fieldData = array_filter($fieldData, function ($fieldValue) {
331
+							$fieldData = array_filter($fieldData, function($fieldValue) {
332 332
 								return $fieldValue !== '';
333 333
 							});
334 334
 							$fieldData = $this->transformForImport($fieldData);
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
 								}
351 351
 							}
352 352
 							// remove empty values - do not modify existing
353
-							$fieldData = array_filter($fieldData, function ($fieldValue) {
353
+							$fieldData = array_filter($fieldData, function($fieldValue) {
354 354
 								return $fieldValue !== '';
355 355
 							});
356 356
 							$fieldData = $this->transformForImport($fieldData);
Please login to merge, or discard this patch.
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -471,8 +471,6 @@
 block discarded – undo
471 471
 	/**
472 472
 	 * Function transforms value for reference type field.
473 473
 	 *
474
-	 * @param \Vtiger_Field_Model $fieldInstance
475
-	 * @param string              $fieldValue
476 474
 	 *
477 475
 	 * @return mixed
478 476
 	 */
Please login to merge, or discard this patch.
app/Utils/ConfReport.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -846,7 +846,7 @@  discard block
 block discarded – undo
846 846
 	 * @param string $name
847 847
 	 * @param array  $row
848 848
 	 *
849
-	 * @return array
849
+	 * @return string
850 850
 	 */
851 851
 	private static function parserAllExt(string $name, array $row)
852 852
 	{
@@ -888,7 +888,7 @@  discard block
 block discarded – undo
888 888
 	 * @param string $name
889 889
 	 * @param array  $row
890 890
 	 *
891
-	 * @return array
891
+	 * @return string
892 892
 	 */
893 893
 	private static function parserHttpMethods(string $name, array $row)
894 894
 	{
Please login to merge, or discard this patch.
modules/Vtiger/handlers/SocialMedia.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
 	 *
55 55
 	 * @param \App\EventHandler $eventHandler
56 56
 	 *
57
-	 * @return bool
57
+	 * @return boolean|null
58 58
 	 */
59 59
 	public function entityBeforeDelete(\App\EventHandler $eventHandler)
60 60
 	{
Please login to merge, or discard this patch.
app/Fields/RecordNumber.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
 	 * @param null|string $resetSequence 'Y'-Year, 'M'-Month, 'D'-Day
43 43
 	 * @param string      $curSequence   '201804' for example for M reset sequence
44 44
 	 *
45
-	 * @return bool
45
+	 * @return integer|null
46 46
 	 */
47 47
 	public static function setNumber($tabId, $prefix = '', $no = '', $postfix = '', $leadingZeros = 0, $resetSequence = null, $curSequence = '')
48 48
 	{
Please login to merge, or discard this patch.