YetiForceCompany / YetiForceCRM

config/csrf_config.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
 	{
 		//Override the default expire time of token
 		\CsrfMagic\Csrf::$expires = 259200;
-		\CsrfMagic\Csrf::$callback = function ($tokens) {
+		\CsrfMagic\Csrf::$callback = function($tokens) {
 			throw new \App\Exceptions\AppException('Invalid request - Response For Illegal Access');
 		};
 		$js = 'vendor/yetiforce/csrf-magic/src/Csrf.min.js';

modules/Vtiger/uitypes/MultiImage.php

Spacing +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
 		if (!is_array($value)) {
 			return '';
 		}
-		$value = array_map(function ($v) {
+		$value = array_map(function($v) {
 			return $v['name'];
 		}, $value);
 		$result = implode(', ', $value);

app/Encryption.php

Spacing +1 added lines, -1 removed lines

@@ -189,7 +189,7 @@
 	 */
 	public static function getMethods()
 	{
-		return array_filter(openssl_get_cipher_methods(), function ($methodName) {
+		return array_filter(openssl_get_cipher_methods(), function($methodName) {
 			return stripos($methodName, 'gcm') === false && stripos($methodName, 'ccm') === false;
 		});
 	}

app/Fields/File.php

Spacing +1 added lines, -1 removed lines

@@ -1030,7 +1030,7 @@
 	 */
 	public static function parse(array $value)
 	{
-		return array_reduce($value, function ($result, $item) {
+		return array_reduce($value, function($result, $item) {
 			$result[$item['key']] = $item;
 			return $result;
 		}, []);

Doc Comments +4 added lines, -4 removed lines

@@ -110,7 +110,7 @@ 
 	 *
 	 * @param array $fileInfo
 	 *
-	 * @return \self
+	 * @return File
 	 */
 	public static function loadFromInfo($fileInfo)
 	{
@@ -126,7 +126,7 @@ 
 	 *
 	 * @param array $file
 	 *
-	 * @return \self
+	 * @return File
 	 */
 	public static function loadFromRequest($file)
 	{
@@ -143,7 +143,7 @@ 
 	 *
 	 * @param array $path
 	 *
-	 * @return \self
+	 * @return File
 	 */
 	public static function loadFromPath($path)
 	{
@@ -699,7 +699,7 @@ 
 	/**
 	 * Create document from content.
 	 *
-	 * @param \self $file
+	 * @param File $file
 	 * @param array $params
 	 *
 	 * @throws \Exception

modules/com_vtiger_workflow/Workflow.php

Doc Comments +10 added lines, -10 removed lines

@@ -204,7 +204,7 @@ 
 	/**
 	 * Sets next trigger time.
 	 *
-	 * @param timestamp $time
+	 * @param string|null $time
 	 */
 	public function setNextTriggerTime($time)
 	{
@@ -279,7 +279,7 @@ 
 	 *
 	 * @global string $default_timezone
 	 *
-	 * @return timestamp
+	 * @return string|null
 	 */
 	public function getNextTriggerTime()
 	{
@@ -326,9 +326,9 @@ 
 	/**
 	 * get next trigger time for daily.
 	 *
-	 * @param type $schTime
+	 * @param type $scheduledTime
 	 *
-	 * @return time
+	 * @return string
 	 */
 	public function getNextTriggerTimeForDaily($scheduledTime)
 	{
@@ -346,10 +346,10 @@ 
 	/**
 	 * get next trigger Time For weekly.
 	 *
-	 * @param json $scheduledDaysOfWeek
+	 * @param integer $scheduledDaysOfWeek
 	 * @param time $scheduledTime
 	 *
-	 * @return time
+	 * @return string
 	 */
 	public function getNextTriggerTimeForWeekly($scheduledDaysOfWeek, $scheduledTime)
 	{
@@ -410,7 +410,7 @@ 
 	 * @param int $scheduledDayOfMonth
 	 * @param int $scheduledTime
 	 *
-	 * @return time
+	 * @return string
 	 */
 	public function getNextTriggerTimeForMonthlyByDate($scheduledDayOfMonth, $scheduledTime)
 	{
@@ -460,7 +460,7 @@ 
 	 * @param int       $scheduledWeekDayOfMonth
 	 * @param timestamp $scheduledTime
 	 *
-	 * @return time
+	 * @return string
 	 */
 	public function getNextTriggerTimeForMonthlyByWeekDay($scheduledWeekDayOfMonth, $scheduledTime)
 	{
@@ -485,10 +485,10 @@ 
 	/**
 	 * to get next trigger time.
 	 *
-	 * @param json      $annualDates
+	 * @param boolean      $annualDates
 	 * @param timestamp $scheduledTime
 	 *
-	 * @return time
+	 * @return string
 	 */
 	public function getNextTriggerTimeForAnnualDates($annualDates, $scheduledTime)
 	{

modules/Vtiger/helpers/AdvancedFilter.php

Doc Comments +3 added lines

@@ -165,6 +165,9 @@
 		return $wfCondition;
 	}
 
+	/**
+	 * @param string|boolean $moduleName
+	 */
 	public static function getDateFilter($moduleName)
 	{
 		foreach (\App\CustomView::getDateFilterTypes() as $comparatorKey => $comparatorInfo) {

app/Controller/Modal.php

Doc Comments +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
 	 *
 	 * @param \App\Request $request
 	 *
-	 * @return \Vtiger_JsScript_Model[]
+	 * @return Vtiger_JsScript_Model[]
 	 */
 	public function getModalScripts(\App\Request $request)
 	{
@@ -74,7 +74,7 @@ 
 	 *
 	 * @param \App\Request $request
 	 *
-	 * @return \Vtiger_CssScript_Model[]
+	 * @return Vtiger_CssScript_Model[]
 	 */
 	public function getModalCss(\App\Request $request)
 	{

modules/Vtiger/models/ChartFilter.php

Doc Comments +7 added lines, -8 removed lines

@@ -272,7 +272,7 @@ 
 	 * @param int $linkId
 	 * @param int $userId
 	 *
-	 * @return \self
+	 * @return Vtiger_ChartFilter_Model
 	 */
 	public static function getInstance($linkId = 0, $userId = 0)
 	{
@@ -395,7 +395,7 @@ 
 	/**
 	 * Get filter id.
 	 *
-	 * @param string|int $dividingValue
+	 * @param integer $dividingValue
 	 *
 	 * @return int
 	 */
@@ -573,7 +573,7 @@ 
 	/**
 	 * Iterate through all rows collected from db.
 	 *
-	 * @param {callback} $callback
+	 * @param Closure $callback
 	 */
 	protected function iterateAllRows($callback)
 	{
@@ -652,7 +652,7 @@ 
 	/**
 	 * Set colors.
 	 *
-	 * @param {string} $from
+	 * @param string $from
 	 */
 	protected function setColorsFrom($from)
 	{
@@ -678,7 +678,7 @@ 
 	/**
 	 * Add query to get picklists id (for colors).
 	 *
-	 * @param $query
+	 * @param App\Db\Query $query
 	 * @param $queryGenerator
 	 *
 	 * @return $query
@@ -710,7 +710,7 @@ 
 	/**
 	 * Get query for specified filter.
 	 *
-	 * @param $filter
+	 * @param integer $filter
 	 *
 	 * @return \App\Db\Query
 	 */
@@ -866,7 +866,6 @@ 
 	/**
 	 * Get current rows.
 	 *
-	 * @param int        $index         row index
 	 * @param string|int $groupValue
 	 * @param string|int $dividingValue
 	 */
@@ -879,7 +878,7 @@ 
 	 * Get rows for dividing field chart.
 	 *
 	 * @param \App\QueryGenerator $query
-	 * @param string|int          $dividingValue
+	 * @param integer          $dividingValue
 	 *
 	 * @return array
 	 */

Spacing +7 added lines, -7 removed lines

@@ -594,7 +594,7 @@ 
 		$colors = \App\Fields\Picklist::getColors($fieldName);
 		$this->colorsFrom = 'picklist';
 		$this->colorsFromRow = 'picklist_id';
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) use ($colors) {
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) use ($colors) {
 			if (isset($colors[$row['picklist_id']])) {
 				$this->colors[$row['picklist_id']] = $colors[$row['picklist_id']];
 			}
@@ -609,7 +609,7 @@ 
 		$this->colorsFrom = 'filters';
 		$this->colorsFromRow = 'color';
 		$colors = \App\Colors::getAllFilterColors();
-		$this->iterateAllRows(function (&$row, $groupValue, $dividingValue, $rowIndex) use ($colors) {
+		$this->iterateAllRows(function(&$row, $groupValue, $dividingValue, $rowIndex) use ($colors) {
 			$this->colors[$dividingValue] = $colors[$this->filterIds[$dividingValue]];
 		});
 	}
@@ -621,7 +621,7 @@ 
 	{
 		$this->colorsFrom = 'assigned_user_id';
 		$this->colorsFromRow = 'assigned_user_id';
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) {
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) {
 			$this->colors[$row['assigned_user_id']] = \App\Fields\Owner::getColor($row['assigned_user_id']);
 		});
 	}
@@ -633,7 +633,7 @@ 
 	{
 		$this->colorsFrom = 'record_id';
 		$this->colorsFromRow = 'id';
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) {
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) {
 			$this->colors[$row['id']] = \App\Colors::getRandomColor('from_id_' . $row['id']);
 		});
 	}
@@ -645,7 +645,7 @@ 
 	{
 		$this->colorsFrom = 'record_number';
 		$this->colorsFromRow = 'record_number';
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) {
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) {
 			$this->colors[$groupValue] = \App\Colors::getRandomColor('generated_' . $groupValue);
 		});
 	}
@@ -938,7 +938,7 @@ 
 		$this->calculateAverage();
 		$this->normalizeData();
 		$this->setColorsFrom($this->findOutColorsFromRows());
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) {
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) {
 			$this->setColorFromRow($row, $groupValue, $dividingValue);
 		});
 		return $this->data;
@@ -1183,7 +1183,7 @@ 
 	protected function generateSectorsData()
 	{
 		// in funnel chart there is only one dividingValue 0 so it will iterate only once like flat array
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) {
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) {
 			$value = (float) $row[$this->valueName];
 			$sectorId = $this->getSectorForValue($value);
 			$sectorIndex = array_search($sectorId, $this->sectors);

modules/Vtiger/actions/Mass.php

Doc Comments +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
 	 *
 	 * @param \App\Request $request
 	 *
-	 * @return \App\QueryGenerator|bool
+	 * @return string[]
 	 */
 	public static function getQuery(\App\Request $request)
 	{