Settings_WebserviceUsers_WebservicePremium_Service::getFieldInstanceByName() - Code Metrics - Inspection of "Added translation type field" - YetiForceCompany/YetiForceCRM - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — developer (#15351)

by Arkadiusz

created 2021-10-22 14:27 UTC

getFieldInstanceByName() C

↳ Parent: Settings_WebserviceUsers_WebservicePremium_Service

Complexity

Conditions	15
Paths	24

Size

Total Lines	70
Code Lines	61

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	61
dl	0
loc	70
rs	5.9166
c	0
b	0
f	0
cc	15
nc	24
nop	1

How to fix Long Method Complexity

<?php

/**
 * WebservicePremium Record Model.
 *
 * @package Settings
 *
 * @copyright YetiForce Sp. z o.o
 * @license   YetiForce Public License 4.0 (licenses/LicenseEN.txt or yetiforce.com)
 * @author    Radosław Skrzypczak <[email protected]>
 * @author  Mariusz Krzaczkowski <[email protected]>
 */

/**
 * Settings_WebserviceUsers_WebservicePremium_Service class.
 */
class Settings_WebserviceUsers_WebservicePremium_Service extends Settings_WebserviceUsers_WebserviceStandard_Service
{
	/** {@inheritdoc} */
	public $baseTable = 'w_#__portal_user';

	/** {@inheritdoc} */
	public $editFields = [
		'server_id' => 'FL_SERVER',
		'status' => 'FL_STATUS',
		'password' => 'FL_PASSWORD',
		'type' => 'FL_TYPE',
		'crmid' => 'FL_RECORD_NAME',
		'user_id' => 'FL_USER',
		'login_method' => 'FL_LOGIN_METHOD',
		'authy_methods' => 'FL_AUTHY_METHODS',
		'istorage' => 'FL_STORAGE',
		'language' => 'FL_LANGUAGE',
	];

	/** {@inheritdoc} */
	public $listFields = [
		'server_id' => 'FL_SERVER',
		'user_name' => 'FL_LOGIN',
		'crmid' => 'FL_RECORD_NAME',
		'type' => 'FL_TYPE',
		'user_id' => 'FL_USER',
		'status' => 'FL_STATUS',
		'istorage' => 'FL_STORAGE',
		'login_method' => 'FL_LOGIN_METHOD',
		'login_time' => 'FL_LOGIN_TIME',
		'custom_params' => 'FL_CUSTOM_PARAMS',
	];

	/** @var array Columns to show on the list session. */
	public $columnsToShow = [
		'time' => 'FL_LOGIN_TIME',
		'status' => 'FL_STATUS',
		'agent' => 'LBL_USER_AGENT',
		'ip' => 'LBL_IP_ADDRESS',
		'device_id' => 'LBL_DEVICE_ID',
	];

	/** {@inheritdoc} */
	public function getFieldInstanceByName($name)
	{
		$moduleName = $this->getModule()->getName(true);
		$fieldsLabel = $this->getEditFields();
		$params = ['uitype' => 1, 'column' => $name, 'name' => $name, 'label' => $fieldsLabel[$name], 'displaytype' => 1, 'typeofdata' => 'V~M', 'presence' => 0, 'isEditableReadOnly' => false];
		switch ($name) {
			case 'crmid':
				$params['uitype'] = 10;
				$params['referenceList'] = ['Contacts'];
				$params['fieldparams'] = [
					'searchParams' => '[[["email","ny",""]]]',
				];
				break;
			case 'istorage':
				$params['uitype'] = 10;
				$params['referenceList'] = ['IStorages'];
				$params['typeofdata'] = 'V~O';
				break;
			case 'status':
				$params['uitype'] = 16;
				$params['picklistValues'] = [1 => \App\Language::translate('FL_ACTIVE'), 0 => \App\Language::translate('FL_INACTIVE')];
				break;
			case 'server_id':
				$servers = Settings_WebserviceApps_Module_Model::getActiveServers($this->getModule()->typeApi);
				$params['uitype'] = 16;
				$params['picklistValues'] = [];
				foreach ($servers as $key => $value) {
					$params['picklistValues'][$key] = $value['name'];
				}
				break;
			case 'type':
				$params['uitype'] = 16;
				$params['picklistValues'] = [];
				foreach ($this->getTypeValues() as $key => $value) {

					$params['picklistValues'][$key] = \App\Language::translate($value, $moduleName);
				}
				break;
			case 'language':
				$params['typeofdata'] = 'V~O';
				$params['uitype'] = 32;
				$params['picklistValues'] = \App\Language::getAll();
				break;
			case 'user_id':
				$params['uitype'] = 16;
				$params['picklistValues'] = \App\Fields\Owner::getInstance($moduleName)->getAccessibleUsers('', 'owner');
				break;
			case 'login_method':
				$params['uitype'] = 16;
				$params['picklistValues'] = [
					'PLL_PASSWORD' => \App\Language::translate('PLL_PASSWORD', 'Users'),
					'PLL_PASSWORD_2FA' => \App\Language::translate('PLL_PASSWORD_2FA', 'Users'),
				];
				break;
			case 'authy_methods':
				$params['uitype'] = 16;
				$params['typeofdata'] = 'V~O';
				$params['picklistValues'] = [
					'-' => \App\Language::translate('LBL_NONE'),
					'PLL_AUTHY_TOTP' => \App\Language::translate('PLL_AUTHY_TOTP', 'Users'),
				];
				break;
			case 'password':
				$params['typeofdata'] = 'P~M';
				if ($this->has('id')) {
					$params = null;
				}
				break;
			default: break;
		}
		return $params ? Settings_Vtiger_Field_Model::init($moduleName, $params) : null;
	}

	/** {@inheritdoc} */
	public function setDataFromRequest(App\Request $request)
	{
		foreach (array_keys($this->getEditFields()) as $field) {
			if ($request->has($field)) {
				switch ($field) {
					case 'server_id':
					case 'status':
					case 'type':
					case 'user_id':
					case 'istorage':
						$value = $request->getInteger($field);
						break;
					case 'crmid':
						$value = $request->isEmpty('crmid') ? '' : $request->getInteger('crmid');
						break;
					case 'user_name':
					case 'language':
					case 'login_method':
					case 'authy_methods':
						$value = $request->getByType($field, 'Text');
						break;
					case 'password':
						if (!$this->isNew()) {
							throw new \App\Exceptions\Security("ERR_ILLEGAL_FIELD_VALUE||{$field}", 406);
						}
						$value = $request->getRaw($field, null);
						parent::set($field, $value);
						break;
					default:
					throw new \App\Exceptions\Security("ERR_ILLEGAL_FIELD_VALUE||{$field}", 406);
						break;
				}
				$this->set($field, $this->getValueToSave($field, $value));
			}
		}
	}

	/** {@inheritdoc} */
	public function getValueToSave($key, $value)
	{
		switch ($key) {
			case 'server_id':
			case 'istorage':
			case 'status':
			case 'type':
			case 'crmid':
			case 'user_id':
				$value = (int) $value;
				break;
			case 'password':
				$value = App\Encryption::createPasswordHash($value, 'WebservicePremium');
				break;
			default: break;
		}
		return $value;
	}
}


1			<?php
2
3			/**
4			* WebservicePremium Record Model.
5			*
6			* @package Settings
7			*
8			* @copyright YetiForce Sp. z o.o
9			* @license YetiForce Public License 4.0 (licenses/LicenseEN.txt or yetiforce.com)
10			* @author Radosław Skrzypczak <[email protected]>
11			* @author Mariusz Krzaczkowski <[email protected]>
12			*/
13
14			/**
15			* Settings_WebserviceUsers_WebservicePremium_Service class.
16			*/
17			class Settings_WebserviceUsers_WebservicePremium_Service extends Settings_WebserviceUsers_WebserviceStandard_Service
18			{
19			/** {@inheritdoc} */
20			public $baseTable = 'w_#__portal_user';
21
22			/** {@inheritdoc} */
23			public $editFields = [
24			'server_id' => 'FL_SERVER',
25			'status' => 'FL_STATUS',
26			'password' => 'FL_PASSWORD',
27			'type' => 'FL_TYPE',
28			'crmid' => 'FL_RECORD_NAME',
29			'user_id' => 'FL_USER',
30			'login_method' => 'FL_LOGIN_METHOD',
31			'authy_methods' => 'FL_AUTHY_METHODS',
32			'istorage' => 'FL_STORAGE',
33			'language' => 'FL_LANGUAGE',
34			];
35
36			/** {@inheritdoc} */
37			public $listFields = [
38			'server_id' => 'FL_SERVER',
39			'user_name' => 'FL_LOGIN',
40			'crmid' => 'FL_RECORD_NAME',
41			'type' => 'FL_TYPE',
42			'user_id' => 'FL_USER',
43			'status' => 'FL_STATUS',
44			'istorage' => 'FL_STORAGE',
45			'login_method' => 'FL_LOGIN_METHOD',
46			'login_time' => 'FL_LOGIN_TIME',
47			'custom_params' => 'FL_CUSTOM_PARAMS',
48			];
49
50			/** @var array Columns to show on the list session. */
51			public $columnsToShow = [
52			'time' => 'FL_LOGIN_TIME',
53			'status' => 'FL_STATUS',
54			'agent' => 'LBL_USER_AGENT',
55			'ip' => 'LBL_IP_ADDRESS',
56			'device_id' => 'LBL_DEVICE_ID',
57			];
58
59			/** {@inheritdoc} */
60			public function getFieldInstanceByName($name)
61			{
62			$moduleName = $this->getModule()->getName(true);
63			$fieldsLabel = $this->getEditFields();
64			$params = ['uitype' => 1, 'column' => $name, 'name' => $name, 'label' => $fieldsLabel[$name], 'displaytype' => 1, 'typeofdata' => 'V~M', 'presence' => 0, 'isEditableReadOnly' => false];
65			switch ($name) {
66			case 'crmid':
67			$params['uitype'] = 10;
68			$params['referenceList'] = ['Contacts'];
69			$params['fieldparams'] = [
70			'searchParams' => '[[["email","ny",""]]]',
71			];
72			break;
73			case 'istorage':
74			$params['uitype'] = 10;
75			$params['referenceList'] = ['IStorages'];
76			$params['typeofdata'] = 'V~O';
77			break;
78			case 'status':
79			$params['uitype'] = 16;
80			$params['picklistValues'] = [1 => \App\Language::translate('FL_ACTIVE'), 0 => \App\Language::translate('FL_INACTIVE')];
81			break;
82			case 'server_id':
83			$servers = Settings_WebserviceApps_Module_Model::getActiveServers($this->getModule()->typeApi);
84			$params['uitype'] = 16;
85			$params['picklistValues'] = [];
86			foreach ($servers as $key => $value) {
87			$params['picklistValues'][$key] = $value['name'];
88			}
89			break;
90			case 'type':
91			$params['uitype'] = 16;
92			$params['picklistValues'] = [];
93			foreach ($this->getTypeValues() as $key => $value) {
			0 ignored issues – show Bug introduced 2021-05-06 15:10 UTC by Report Bug Copy Issue Report The expression `$this->getTypeValues()` of type `string` is not traversable. Loading history...
94			$params['picklistValues'][$key] = \App\Language::translate($value, $moduleName);
95			}
96			break;
97			case 'language':
98			$params['typeofdata'] = 'V~O';
99			$params['uitype'] = 32;
100			$params['picklistValues'] = \App\Language::getAll();
101			break;
102			case 'user_id':
103			$params['uitype'] = 16;
104			$params['picklistValues'] = \App\Fields\Owner::getInstance($moduleName)->getAccessibleUsers('', 'owner');
105			break;
106			case 'login_method':
107			$params['uitype'] = 16;
108			$params['picklistValues'] = [
109			'PLL_PASSWORD' => \App\Language::translate('PLL_PASSWORD', 'Users'),
110			'PLL_PASSWORD_2FA' => \App\Language::translate('PLL_PASSWORD_2FA', 'Users'),
111			];
112			break;
113			case 'authy_methods':
114			$params['uitype'] = 16;
115			$params['typeofdata'] = 'V~O';
116			$params['picklistValues'] = [
117			'-' => \App\Language::translate('LBL_NONE'),
118			'PLL_AUTHY_TOTP' => \App\Language::translate('PLL_AUTHY_TOTP', 'Users'),
119			];
120			break;
121			case 'password':
122			$params['typeofdata'] = 'P~M';
123			if ($this->has('id')) {
124			$params = null;
125			}
126			break;
127			default: break;
128			}
129			return $params ? Settings_Vtiger_Field_Model::init($moduleName, $params) : null;
130			}
131
132			/** {@inheritdoc} */
133			public function setDataFromRequest(App\Request $request)
134			{
135			foreach (array_keys($this->getEditFields()) as $field) {
136			if ($request->has($field)) {
137			switch ($field) {
138			case 'server_id':
139			case 'status':
140			case 'type':
141			case 'user_id':
142			case 'istorage':
143			$value = $request->getInteger($field);
144			break;
145			case 'crmid':
146			$value = $request->isEmpty('crmid') ? '' : $request->getInteger('crmid');
147			break;
148			case 'user_name':
149			case 'language':
150			case 'login_method':
151			case 'authy_methods':
152			$value = $request->getByType($field, 'Text');
153			break;
154			case 'password':
155			if (!$this->isNew()) {
156			throw new \App\Exceptions\Security("ERR_ILLEGAL_FIELD_VALUE\|\|{$field}", 406);
157			}
158			$value = $request->getRaw($field, null);
159			parent::set($field, $value);
160			break;
161			default:
162			throw new \App\Exceptions\Security("ERR_ILLEGAL_FIELD_VALUE\|\|{$field}", 406);
163			break;
164			}
165			$this->set($field, $this->getValueToSave($field, $value));
166			}
167			}
168			}
169
170			/** {@inheritdoc} */
171			public function getValueToSave($key, $value)
172			{
173			switch ($key) {
174			case 'server_id':
175			case 'istorage':
176			case 'status':
177			case 'type':
178			case 'crmid':
179			case 'user_id':
180			$value = (int) $value;
181			break;
182			case 'password':
183			$value = App\Encryption::createPasswordHash($value, 'WebservicePremium');
184			break;
185			default: break;
186			}
187			return $value;
188			}
189			}
190

YetiForceCompany / YetiForceCRM

Pull Request — developer (#15351)

getFieldInstanceByName() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like