YetiForceCompany / YetiForceCRM

modules/Vtiger/actions/Save.php

Doc Comments +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
 
 	/**
 	 * Function to save record
-	 * @param <Vtiger_Request> $request - values of the record
+	 * @param Vtiger_Request $request - values of the record
 	 * @return <RecordModel> - record Model of saved record
 	 */
 	public function saveRecord($request)

Braces +6 added lines, -4 removed lines

@@ -87,8 +87,9 @@ 
 			$relatedRecordId = $recordModel->getId();
 
 			$relationModel = Vtiger_Relation_Model::getInstance($parentModuleModel, $relatedModule);
-			if ($relationModel)
-				$relationModel->addRelation($parentRecordId, $relatedRecordId);
+			if ($relationModel) {
+							$relationModel->addRelation($parentRecordId, $relatedRecordId);
+			}
 		}
 		if ($request->get('imgDeleted')) {
 			$imageIds = $request->get('imageid');
@@ -144,8 +145,9 @@ 
 					$fieldValue = trim($fieldValue);
 				}
 				$recordModel->set($fieldName, $fieldValue);
-			} else
-				$recordModel->set($fieldName, null);
+			} else {
+							$recordModel->set($fieldName, null);
+			}
 		}
 		return $recordModel;
 	}

modules/Vtiger/models/ChartFilter.php

Doc Comments +6 added lines

@@ -113,6 +113,9 @@ 
 		return [];
 	}
 
+	/**
+	 * @param Vtiger_Widget_Model $widgetModel
+	 */
 	public function setWidgetModel($widgetModel)
 	{
 		$this->widgetModel = $widgetModel;
@@ -127,6 +130,9 @@ 
 		}
 	}
 
+	/**
+	 * @return string
+	 */
 	public function getType()
 	{
 		return $this->extraData['chartType'];

Spacing +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
 				if (!isset($groupData[$displayValue]['count'])) {
 					$groupData[$displayValue]['count'] = 1;
 				} else {
-					$groupData[$displayValue]['count'] ++;
+					$groupData[$displayValue]['count']++;
 				}
 				if (!isset($groupData[$displayValue]['link'])) {
 					$moduleModel = $this->getTargetModuleModel();

modules/Vtiger/models/ExportToXml.php

Doc Comments +6 added lines

@@ -122,6 +122,9 @@ 
 		return html_entity_decode($value);
 	}
 
+	/**
+	 * @param string $fileName
+	 */
 	public function outputFile($fileName)
 	{
 		header("Content-Disposition:attachment;filename=$fileName.xml");
@@ -133,6 +136,9 @@ 
 		readfile($this->tmpXmlPath);
 	}
 
+	/**
+	 * @param string $fileName
+	 */
 	protected function outputZipFile($fileName)
 	{
 

modules/Vtiger/models/InventoryField.php

Doc Comments -5 removed lines

@@ -16,8 +16,6 @@ 
 
 	/**
 	 * Create the name of the Inventory data table
-	 * @param string $module Module name
-	 * @param string $prefix Prefix table
 	 * @return string Table name
 	 */
 	public function getTableName($type = 'data')
@@ -118,8 +116,6 @@ 
 
 	/**
 	 * Get inventory columns
-	 * @param string $module Module name
-	 * @param boolean $returnInBlock Should the result be divided into blocks
 	 * @return array Inventory columns
 	 */
 	public function getColumns()
@@ -164,7 +160,6 @@ 
 
 	/**
 	 * Retrieve list of all fields
-	 * @param string $moduleName Module name
 	 * @return array Fields instance Vtiger_Basic_InventoryField
 	 */
 	public function getAllFields()

Spacing +2 added lines, -2 removed lines

@@ -497,9 +497,9 @@
 		$db = PearDatabase::getInstance();
 		$query = sprintf('UPDATE `%s` SET sequence = CASE id ', $this->getTableName('fields'));
 		foreach ($sequenceList as $sequence => $id) {
-			$query .=' WHEN ' . $id . ' THEN ' . $sequence;
+			$query .= ' WHEN ' . $id . ' THEN ' . $sequence;
 		}
-		$query .=' END ';
+		$query .= ' END ';
 		$query .= sprintf(' WHERE id IN (%s)', generateQuestionMarks($sequenceList));
 		return $db->pquery($query, array_values($sequenceList));
 	}

Braces +6 added lines, -4 removed lines

@@ -133,8 +133,9 @@ 
 		$columns = [];
 		foreach ($this->getFields() as $key => $field) {
 			$column = $field->getColumnName();
-			if (!empty($column) && $column != '-')
-				$columns[] = $column;
+			if (!empty($column) && $column != '-') {
+							$columns[] = $column;
+			}
 			foreach ($field->getCustomColumn() as $name => $field) {
 				$columns[] = $name;
 			}
@@ -187,8 +188,9 @@ 
 		}
 		$fields = [];
 		foreach ($fieldPaths as $fieldPath) {
-			if (!is_dir($fieldPath))
-				continue;
+			if (!is_dir($fieldPath)) {
+							continue;
+			}
 			foreach (new DirectoryIterator($fieldPath) as $fileinfo) {
 				if ($fileinfo->isFile() && $fileinfo->getFilename() != 'Basic.php') {
 					$fieldName = str_replace('.php', '', $fileinfo->getFilename());

modules/Vtiger/models/ListView.php

Doc Comments -1 removed lines

@@ -332,7 +332,6 @@
 
 	/**
 	 * Function to get the list view entries
-	 * @param Vtiger_Paging_Model $pagingModel
 	 * @return <Array> - Associative array of record id mapped to Vtiger_Record_Model instance.
 	 */
 	public function getListViewCount()

Braces +3 added lines, -2 removed lines

@@ -169,8 +169,9 @@
 		$headerFieldModels = [];
 		$headerFields = $listViewContoller->getListViewHeaderFields();
 		foreach ($headerFields as $fieldName => $webserviceField) {
-			if ($webserviceField && !in_array($webserviceField->getPresence(), [0, 2]))
-				continue;
+			if ($webserviceField && !in_array($webserviceField->getPresence(), [0, 2])) {
+							continue;
+			}
 			$headerFieldModels[$fieldName] = Vtiger_Field_Model::getInstance($fieldName, $module);
 		}
 		return $headerFieldModels;

modules/Vtiger/models/MiniList.php

Doc Comments +3 added lines

@@ -20,6 +20,9 @@
 	protected $listviewRecords;
 	protected $targetModuleModel;
 
+	/**
+	 * @param Vtiger_Widget_Model $widgetModel
+	 */
 	public function setWidgetModel($widgetModel)
 	{
 		$this->widgetModel = $widgetModel;

Braces +3 added lines, -2 removed lines

@@ -42,8 +42,9 @@
 	public function getTargetFields()
 	{
 		$fields = $this->extraData['fields'];
-		if (!in_array("id", $fields))
-			$fields[] = "id";
+		if (!in_array("id", $fields)) {
+					$fields[] = "id";
+		}
 		return $fields;
 	}
 

modules/Vtiger/models/Record.php

Doc Comments +4 added lines, -4 removed lines

@@ -69,7 +69,7 @@ 
 
 	/**
 	 * Function to get the Module to which the record belongs
-	 * @return Vtiger_Module_Model
+	 * @return boolean
 	 */
 	public function getModule()
 	{
@@ -219,7 +219,7 @@ 
 	/**
 	 * Function to retieve display value for a field
 	 * @param <String> $fieldName - field name for which values need to get
-	 * @return <String>
+	 * @return string
 	 */
 	public function getDisplayValue($fieldName, $recordId = false, $rawText = false)
 	{
@@ -325,7 +325,7 @@ 
 	/**
 	 * Static Function to get the instance of the Vtiger Record Model given the recordid and the module name
 	 * @param <Number> $recordId
-	 * @param <String> $moduleName
+	 * @param <String> $module
 	 * @return Vtiger_Record_Model or Module Specific Record Model instance
 	 */
 	public static function getInstanceById($recordId, $module = null)
@@ -493,7 +493,6 @@ 
 
 	/**
 	 * Function to get Display value for RelatedList
-	 * @param <String> $value
 	 * @return <String>
 	 */
 	public function getRelatedListDisplayValue($fieldName)
@@ -596,6 +595,7 @@ 
 	/**
 	 * Function to set record module field values
 	 * @param parent record model
+	 * @param Vtiger_Record_Model $parentRecordModel
 	 */
 	public function setRecordFieldValues($parentRecordModel)
 	{

modules/Vtiger/views/Detail.php

Doc Comments +3 added lines

@@ -302,6 +302,9 @@
 		return $viewer->view('DetailViewFullContents.tpl', $moduleName, true);
 	}
 
+	/**
+	 * @param Vtiger_Request $request
+	 */
 	public function showModuleSummaryView($request)
 	{
 		$recordId = $request->get('record');

Braces +3 added lines, -2 removed lines

@@ -686,8 +686,9 @@
 			$sortImage = 'glyphicon glyphicon-chevron-up';
 		}
 		if (empty($orderBy) && empty($sortOrder)) {
-			if (is_numeric($relatedModuleName))
-				$relatedModuleName = vtlib\Functions::getModuleName($relatedModuleName);
+			if (is_numeric($relatedModuleName)) {
+							$relatedModuleName = vtlib\Functions::getModuleName($relatedModuleName);
+			}
 			$relatedInstance = CRMEntity::getInstance($relatedModuleName);
 			$orderBy = $relatedInstance->default_order_by;
 			$sortOrder = $relatedInstance->default_sort_order;

modules/WSAPP/SyncServer.php

Doc Comments +7 added lines, -1 removed lines

@@ -81,6 +81,9 @@ 
 		return $mapping;
 	}
 
+	/**
+	 * @param string $flag
+	 */
 	public function idmap_storeRecordsInQueue($syncServerId, $recordDetails, $flag, $appid)
 	{
 		if (!is_array($recordDetails))
@@ -182,7 +185,7 @@ 
 	 * @param <type> $appid
 	 * @param <type> $serverid
 	 * @param <type> $clientid
-	 * @param <type> $modifiedTime
+	 * @param <type> $clientModifiedTime
 	 * update the mapping of server and client id
 	 */
 	public function idmap_update($appid, $serverid, $clientid, $clientModifiedTime, $serverModifiedTime, $serverAppId)
@@ -499,6 +502,9 @@ 
 		return $serverIds;
 	}
 
+	/**
+	 * @param string $flag
+	 */
 	public function convertToQueueRecordFormat($record, $flag)
 	{
 		if ($flag != $this->delete)

Braces +53 added lines, -40 removed lines

@@ -31,8 +31,9 @@ 
 	{
 		$db = PearDatabase::getInstance();
 		$appidresult = $db->pquery("SELECT appid FROM vtiger_wsapp WHERE appkey=?", array($key));
-		if ($db->num_rows($appidresult))
-			return $db->query_result($appidresult, 0, 'appid');
+		if ($db->num_rows($appidresult)) {
+					return $db->query_result($appidresult, 0, 'appid');
+		}
 		return false;
 	}
 
@@ -42,8 +43,9 @@ 
 	 */
 	public function idmap_get_clientmap($appid, $serverids)
 	{
-		if (!is_array($serverids))
-			$serverids = array($serverids);
+		if (!is_array($serverids)) {
+					$serverids = array($serverids);
+		}
 		$db = PearDatabase::getInstance();
 		;
 		$result = $db->pquery(sprintf(
@@ -65,8 +67,9 @@ 
 	 */
 	public function idmap_get_clientservermap($appid, $clientids)
 	{
-		if (!is_array($clientids))
-			$clientids = array($clientids);
+		if (!is_array($clientids)) {
+					$clientids = array($clientids);
+		}
 
 		$db = PearDatabase::getInstance();
 
@@ -83,8 +86,9 @@ 
 
 	public function idmap_storeRecordsInQueue($syncServerId, $recordDetails, $flag, $appid)
 	{
-		if (!is_array($recordDetails))
-			$recordDetails = array($recordDetails);
+		if (!is_array($recordDetails)) {
+					$recordDetails = array($recordDetails);
+		}
 		$db = PearDatabase::getInstance();
 		$params = array();
 		$params[] = $syncServerId;
@@ -99,8 +103,9 @@ 
 		$db = PearDatabase::getInstance();
 		$checkQuery = "SELECT syncserverid FROM vtiger_wsapp_queuerecords WHERE syncserverid=?";
 		$result = $db->pquery($checkQuery, array($syncServerId));
-		if ($db->num_rows($result) > 0)
-			return true;
+		if ($db->num_rows($result) > 0) {
+					return true;
+		}
 		return false;
 	}
 
@@ -148,19 +153,20 @@ 
 	public function idmap_put($appid, $serverid, $clientid, $clientModifiedTime, $serverModifiedTime, $serverAppId, $mode = "save")
 	{
 		$db = PearDatabase::getInstance();
-		if ($mode == $this->create)
-			$this->idmap_create($appid, $serverid, $clientid, $clientModifiedTime, $serverModifiedTime, $serverAppId);
-		else if ($mode == $this->update)
-			$this->idmap_update($appid, $serverid, $clientid, $clientModifiedTime, $serverModifiedTime, $serverAppId);
-		else if ($mode == $this->save) {
+		if ($mode == $this->create) {
+					$this->idmap_create($appid, $serverid, $clientid, $clientModifiedTime, $serverModifiedTime, $serverAppId);
+		} else if ($mode == $this->update) {
+					$this->idmap_update($appid, $serverid, $clientid, $clientModifiedTime, $serverModifiedTime, $serverAppId);
+		} else if ($mode == $this->save) {
 			$result = $db->pquery("SELECT * FROM vtiger_wsapp_recordmapping WHERE appid=? and serverid=? and clientid=?", array($appid, $serverid, $clientid));
-			if ($db->num_rows($result) <= 0)
-				$this->idmap_create($appid, $serverid, $clientid, $clientModifiedTime, $serverModifiedTime, $serverAppId);
-			else
-				$this->idmap_update($appid, $serverid, $clientid, $clientModifiedTime, $serverModifiedTime, $serverAppId);
+			if ($db->num_rows($result) <= 0) {
+							$this->idmap_create($appid, $serverid, $clientid, $clientModifiedTime, $serverModifiedTime, $serverAppId);
+			} else {
+							$this->idmap_update($appid, $serverid, $clientid, $clientModifiedTime, $serverModifiedTime, $serverAppId);
+			}
+		} else if ($mode == $this->delete) {
+					$this->idmap_delete($appid, $serverid, $clientid, $serverAppId);
 		}
-		else if ($mode == $this->delete)
-			$this->idmap_delete($appid, $serverid, $clientid, $serverAppId);
 	}
 
 	/**
@@ -229,11 +235,13 @@ 
 		if (empty($type)) {
 			throw new WebServiceException('WSAPP06', "No sync type specified");
 		}
-		if (is_array($name))
-			throw new WebServiceException("WSAPP07", "type is in the wrong format");
+		if (is_array($name)) {
+					throw new WebServiceException("WSAPP07", "type is in the wrong format");
+		}
 		$type = strtolower($type);
-		if (!in_array($type, $this->syncTypes))
-			throw new WebServiceException('WSAPP05', "Wrong sync type specified");
+		if (!in_array($type, $this->syncTypes)) {
+					throw new WebServiceException('WSAPP05', "Wrong sync type specified");
+		}
 		$db = PearDatabase::getInstance();
 		$uid = uniqid();
 		$db->pquery("INSERT INTO vtiger_wsapp (name, appkey,type) VALUES(?,?,?)", array($name, $uid, $type));
@@ -267,10 +275,11 @@ 
 			throw new WebServiceException('WSAPP04', "Access restricted to app");
 		}
 
-		if (!is_array($element))
-			$records = array($element);
-		else
-			$records = $element;
+		if (!is_array($element)) {
+					$records = array($element);
+		} else {
+					$records = $element;
+		}
 
 		//hardcoded since the destination handler will be vtigerCRM
 		$serverKey = wsapp_getAppKey("vtigerCRM");
@@ -293,13 +302,15 @@ 
 			$clientRecordId = $record['id'];
 
 			// Missing client record id?
-			if (empty($clientRecordId))
-				continue;
+			if (empty($clientRecordId)) {
+							continue;
+			}
 
 			$lookupRecordId = false;
 			$lookupResult = $db->pquery("SELECT serverid,clientmodifiedtime FROM vtiger_wsapp_recordmapping WHERE appid=? && clientid=?", array($appid, $clientRecordId));
-			if ($db->num_rows($lookupResult))
-				$lookupRecordId = $db->query_result($lookupResult, 0, 'serverid');
+			if ($db->num_rows($lookupResult)) {
+							$lookupRecordId = $db->query_result($lookupResult, 0, 'serverid');
+			}
 			if (empty($lookupRecordId) && $record['mode'] != "delete") {
 				$createRecords[$clientRecordId] = $record['values'];
 				$createRecords[$clientRecordId]['module'] = $record['module'];
@@ -309,8 +320,9 @@ 
 					$deleteRecords[$clientRecordId] = $lookupRecordId;
 				} else if (!(empty($lookupRecordId))) {
 					$clientLastModifiedTime = $db->query_result($lookupResult, 0, 'clientmodifiedtime');
-					if ($clientLastModifiedTime >= $record['values']['modifiedtime'])
-						continue;
+					if ($clientLastModifiedTime >= $record['values']['modifiedtime']) {
+											continue;
+					}
 					$record['values']['id'] = $lookupRecordId;
 					$updateRecords[$clientRecordId] = $record['values'];
 					$updateRecords[$clientRecordId]['module'] = $record['module'];
@@ -446,8 +458,9 @@ 
 	 */
 	public function map($key, $element, $user)
 	{
-		if (empty($element))
-			return;
+		if (empty($element)) {
+					return;
+		}
 		$db = PearDatabase::getInstance();
 		$appid = $this->appid_with_key($key);
 		$createDetails = $element["create"];
@@ -501,9 +514,9 @@ 
 
 	public function convertToQueueRecordFormat($record, $flag)
 	{
-		if ($flag != $this->delete)
-			return $record;
-		else {
+		if ($flag != $this->delete) {
+					return $record;
+		} else {
 			$recordFormat = array();
 			$recordFormat['id'] = $record['id'];
 			return $recordFormat;