YetiForceCompany / YetiForceCRM

modules/PaymentsIn/helpers/mt940.php

Doc Comments +15 added lines

@@ -50,6 +50,9 @@ 
 		return $xml;
 	}
 
+	/**
+	 * @param integer $level
+	 */
 	protected function createXML($key, $value, $level)
 	{
 		$indent = '';
@@ -69,6 +72,9 @@ 
 		return $xml;
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -114,6 +120,9 @@ 
 		$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(
@@ -124,6 +133,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseBalance($value)
 	{
 		return array(
@@ -134,6 +146,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseTransaction($value)
 	{
 		$transaction = array(

Braces +19 added lines, -14 removed lines

@@ -34,8 +34,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	public function getXML()
@@ -53,13 +54,15 @@ 
 	protected function createXML($key, $value, $level)
 	{
 		$indent = '';
-		for ($i = 0; $i <= $level; $i++)
-			$indent .= "\t";
+		for ($i = 0; $i <= $level; $i++) {
+					$indent .= "\t";
+		}
 		if (is_array($value)) {
 			$xml = "$indent<$key>\n";
 			foreach ($value as $subKey => $subVal) {
-				if (is_numeric($subKey))
-					$subKey = substr($key, 0, -1);
+				if (is_numeric($subKey)) {
+									$subKey = substr($key, 0, -1);
+				}
 				$xml .= $this->createXML($subKey, $subVal, $level + 1);
 			}
 			$xml .= "$indent</$key>\n";
@@ -85,10 +88,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -103,10 +107,11 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == '61')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == '61') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;

modules/PaymentsIn/helpers/subclass/mt940_Milenium.php

Doc Comments +6 added lines

@@ -20,6 +20,9 @@ 
 			$this->parseLine($line);
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -65,6 +68,9 @@ 
 		$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(

Braces +13 added lines, -10 removed lines

@@ -16,8 +16,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	protected function parseLine($line)
@@ -36,10 +37,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -54,10 +56,11 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == '61')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == '61') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;

modules/PaymentsIn/helpers/subclass/mt940_WBK.php

Doc Comments +9 added lines

@@ -20,6 +20,9 @@ 
 			$this->parseLine($line);
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -65,6 +68,9 @@ 
 		$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseTransaction($value)
 	{
 		$transaction = array(
@@ -109,6 +115,9 @@ 
 		$this->operations[count($this->operations) - 1]['details'] = $transaction;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(

Braces +13 added lines, -10 removed lines

@@ -16,8 +16,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	protected function parseLine($line)
@@ -36,10 +37,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -54,10 +56,11 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == '61')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == '61') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;

modules/PBXManager/connectors/PBXManager.php

Doc Comments +8 added lines, -2 removed lines

@@ -54,6 +54,9 @@ 
 		return $this->webappurl;
 	}
 
+	/**
+	 * @return string
+	 */
 	public function getOutboundContext()
 	{
 		return $this->outboundcontext;
@@ -82,6 +85,7 @@ 
 	/**
 	 * Function to set server parameters
 	 * @param <array>  authdetails
+	 * @param PBXManager_Server_Model $serverModel
 	 */
 	public function setServerParameters($serverModel)
 	{
@@ -100,6 +104,9 @@ 
 		return self::$SETTINGS_REQUIRED_PARAMETERS;
 	}
 
+	/**
+	 * @param string $type
+	 */
 	protected function prepareParameters($details, $type)
 	{
 		switch ($type) {
@@ -294,7 +301,6 @@ 
 
 	/**
 	 * Function to respond for outgoing calls
-	 * @param <Vtiger_Request> $details 
 	 */
 	public function respondToOutgoingCall($to)
 	{
@@ -324,7 +330,7 @@ 
 	/**
 	 * Function to make outbound call 
 	 * @param <string> $number (Customer)
-	 * @param <string> $recordid
+	 * @param <string> $record
 	 */
 	public function call($number, $record)
 	{

Braces +8 added lines, -6 removed lines

@@ -239,10 +239,11 @@ 
 		$recordModel = PBXManager_Record_Model::getCleanInstance();
 		$recordModel->saveRecordWithArrray($params);
 
-		if ($direction == self::INCOMING_TYPE)
-			$this->respondToIncomingCall($details);
-		else
-			$this->respondToOutgoingCall($params['CustomerNumber']);
+		if ($direction == self::INCOMING_TYPE) {
+					$this->respondToIncomingCall($details);
+		} else {
+					$this->respondToOutgoingCall($params['CustomerNumber']);
+		}
 	}
 
 	/**
@@ -312,8 +313,9 @@ 
 		} else {
 			$response .= '<Number>SIP/';
 			$response .= $to;
-			if ($numberLength > 5)
-				$response .= '@' . $this->getOutboundTrunk();
+			if ($numberLength > 5) {
+							$response .= '@' . $this->getOutboundTrunk();
+			}
 			$response .= '</Number>';
 		}
 

modules/Reservations/actions/Calendar.php

Doc Comments +3 added lines

@@ -82,6 +82,9 @@
 		$response->emit();
 	}
 
+	/**
+	 * @param string $datetime
+	 */
 	public function changeDateTime($datetime, $delta)
 	{
 		$date = new DateTime($datetime);

modules/Settings/ConfReport/models/Module.php

Doc Comments +6 added lines

@@ -318,6 +318,9 @@ 
 		return $permissions;
 	}
 
+	/**
+	 * @param string $val
+	 */
 	public static function getFlag($val)
 	{
 		if ($val == 'On' || $val == 1 || stripos($val, 'On') !== false) {
@@ -326,6 +329,9 @@ 
 		return 'Off';
 	}
 
+	/**
+	 * @param string $value
+	 */
 	public function error2string($value)
 	{
 		$level_names = array(

Spacing +1 added lines, -1 removed lines

@@ -340,7 +340,7 @@
 		$levels = array();
 		if (($value & E_ALL) == E_ALL) {
 			$levels[] = 'E_ALL';
-			$value&=~E_ALL;
+			$value &= ~E_ALL;
 		}
 		foreach ($level_names as $level => $name)
 			if (($value & $level) == $level)

Braces +87 added lines, -58 removed lines

@@ -119,113 +119,139 @@ 
 			$directiveValues['suhosin.post.max_value_length'] = array('prefer' => '1500000');
 		}
 
-		if (ini_get('safe_mode') == '1' || stripos(ini_get('safe_mode'), 'On') !== false)
-			$directiveValues['safe_mode']['status'] = true;
+		if (ini_get('safe_mode') == '1' || stripos(ini_get('safe_mode'), 'On') !== false) {
+					$directiveValues['safe_mode']['status'] = true;
+		}
 		$directiveValues['safe_mode']['current'] = self::getFlag(ini_get('safe_mode'));
 
-		if (ini_get('display_errors') == '1' || stripos(ini_get('display_errors'), 'On') !== false)
-			$directiveValues['display_errors']['status'] = true;
+		if (ini_get('display_errors') == '1' || stripos(ini_get('display_errors'), 'On') !== false) {
+					$directiveValues['display_errors']['status'] = true;
+		}
 		$directiveValues['display_errors']['current'] = self::getFlag(ini_get('display_errors'));
 
-		if (ini_get('file_uploads') != '1' || stripos(ini_get('file_uploads'), 'Off') !== false)
-			$directiveValues['file_uploads']['status'] = true;
+		if (ini_get('file_uploads') != '1' || stripos(ini_get('file_uploads'), 'Off') !== false) {
+					$directiveValues['file_uploads']['status'] = true;
+		}
 		$directiveValues['file_uploads']['current'] = self::getFlag(ini_get('file_uploads'));
 
-		if ((ini_get('output_buffering') <= '4096' && ini_get('output_buffering') != '1') || stripos(ini_get('output_buffering'), 'Off') !== false)
-			$directiveValues['output_buffering']['status'] = true;
+		if ((ini_get('output_buffering') <= '4096' && ini_get('output_buffering') != '1') || stripos(ini_get('output_buffering'), 'Off') !== false) {
+					$directiveValues['output_buffering']['status'] = true;
+		}
 		if (!in_array(ini_get('output_buffering'), ['On', 1, 0, 'Off'])) {
 			$directiveValues['output_buffering']['current'] = ini_get('output_buffering');
 		} else {
 			$directiveValues['output_buffering']['current'] = self::getFlag(ini_get('output_buffering'));
 		}
 
-		if (ini_get('max_execution_time') != 0 && ini_get('max_execution_time') < 600)
-			$directiveValues['max_execution_time']['status'] = true;
+		if (ini_get('max_execution_time') != 0 && ini_get('max_execution_time') < 600) {
+					$directiveValues['max_execution_time']['status'] = true;
+		}
 		$directiveValues['max_execution_time']['current'] = ini_get('max_execution_time');
 
-		if (ini_get('max_input_time') != 0 && ini_get('max_input_time') < 600)
-			$directiveValues['max_input_time']['status'] = true;
+		if (ini_get('max_input_time') != 0 && ini_get('max_input_time') < 600) {
+					$directiveValues['max_input_time']['status'] = true;
+		}
 		$directiveValues['max_input_time']['current'] = ini_get('max_input_time');
 
-		if (ini_get('default_socket_timeout') != 0 && ini_get('default_socket_timeout') < 600)
-			$directiveValues['default_socket_timeout']['status'] = true;
+		if (ini_get('default_socket_timeout') != 0 && ini_get('default_socket_timeout') < 600) {
+					$directiveValues['default_socket_timeout']['status'] = true;
+		}
 		$directiveValues['default_socket_timeout']['current'] = ini_get('default_socket_timeout');
 
-		if (ini_get('mysql.connect_timeout') != 0 && ini_get('mysql.connect_timeout') < 600)
-			$directiveValues['mysql.connect_timeout']['status'] = true;
+		if (ini_get('mysql.connect_timeout') != 0 && ini_get('mysql.connect_timeout') < 600) {
+					$directiveValues['mysql.connect_timeout']['status'] = true;
+		}
 		$directiveValues['mysql.connect_timeout']['current'] = ini_get('mysql.connect_timeout');
 
-		if (vtlib\Functions::parseBytes(ini_get('memory_limit')) < 33554432)
-			$directiveValues['memory_limit']['status'] = true;
+		if (vtlib\Functions::parseBytes(ini_get('memory_limit')) < 33554432) {
+					$directiveValues['memory_limit']['status'] = true;
+		}
 		$directiveValues['memory_limit']['current'] = vtlib\Functions::showBytes(ini_get('memory_limit'));
 
-		if (vtlib\Functions::parseBytes(ini_get('post_max_size')) < 10485760)
-			$directiveValues['post_max_size']['status'] = true;
+		if (vtlib\Functions::parseBytes(ini_get('post_max_size')) < 10485760) {
+					$directiveValues['post_max_size']['status'] = true;
+		}
 		$directiveValues['post_max_size']['current'] = vtlib\Functions::showBytes(ini_get('post_max_size'));
 
-		if (vtlib\Functions::parseBytes(ini_get('upload_max_filesize')) < 10485760)
-			$directiveValues['upload_max_filesize']['status'] = true;
+		if (vtlib\Functions::parseBytes(ini_get('upload_max_filesize')) < 10485760) {
+					$directiveValues['upload_max_filesize']['status'] = true;
+		}
 		$directiveValues['upload_max_filesize']['current'] = vtlib\Functions::showBytes(ini_get('upload_max_filesize'));
 
-		if (ini_get('magic_quotes_gpc') == '1' || stripos(ini_get('magic_quotes_gpc'), 'On') !== false)
-			$directiveValues['magic_quotes_gpc']['status'] = true;
+		if (ini_get('magic_quotes_gpc') == '1' || stripos(ini_get('magic_quotes_gpc'), 'On') !== false) {
+					$directiveValues['magic_quotes_gpc']['status'] = true;
+		}
 		$directiveValues['magic_quotes_gpc']['current'] = self::getFlag(ini_get('magic_quotes_gpc'));
 
-		if (ini_get('magic_quotes_runtime') == '1' || stripos(ini_get('magic_quotes_runtime'), 'On') !== false)
-			$directiveValues['magic_quotes_runtime']['status'] = true;
+		if (ini_get('magic_quotes_runtime') == '1' || stripos(ini_get('magic_quotes_runtime'), 'On') !== false) {
+					$directiveValues['magic_quotes_runtime']['status'] = true;
+		}
 		$directiveValues['magic_quotes_runtime']['current'] = self::getFlag((ini_get('magic_quotes_runtime')));
 
-		if (ini_get('zlib.output_compression') == '1' || stripos(ini_get('zlib.output_compression'), 'On') !== false)
-			$directiveValues['zlib.output_compression']['status'] = true;
+		if (ini_get('zlib.output_compression') == '1' || stripos(ini_get('zlib.output_compression'), 'On') !== false) {
+					$directiveValues['zlib.output_compression']['status'] = true;
+		}
 		$directiveValues['zlib.output_compression']['current'] = self::getFlag((ini_get('zlib.output_compression')));
 
-		if (ini_get('zend.ze1_compatibility_mode') == '1' || stripos(ini_get('zend.ze1_compatibility_mode'), 'On') !== false)
-			$directiveValues['zend.ze1_compatibility_mode']['status'] = true;
+		if (ini_get('zend.ze1_compatibility_mode') == '1' || stripos(ini_get('zend.ze1_compatibility_mode'), 'On') !== false) {
+					$directiveValues['zend.ze1_compatibility_mode']['status'] = true;
+		}
 		$directiveValues['zend.ze1_compatibility_mode']['current'] = self::getFlag(ini_get('zend.ze1_compatibility_mode'));
 
 		if (extension_loaded('suhosin')) {
-			if (ini_get('suhosin.session.encrypt') == '1' || stripos(ini_get('suhosin.session.encrypt'), 'On') !== false)
-				$directiveValues['suhosin.session.encrypt']['status'] = true;
+			if (ini_get('suhosin.session.encrypt') == '1' || stripos(ini_get('suhosin.session.encrypt'), 'On') !== false) {
+							$directiveValues['suhosin.session.encrypt']['status'] = true;
+			}
 			$directiveValues['suhosin.session.encrypt']['current'] = self::getFlag(ini_get('suhosin.session.encrypt'));
 		}
-		if (ini_get('session.auto_start') == '1' || stripos(ini_get('session.auto_start'), 'On') !== false)
-			$directiveValues['session.auto_start']['status'] = true;
+		if (ini_get('session.auto_start') == '1' || stripos(ini_get('session.auto_start'), 'On') !== false) {
+					$directiveValues['session.auto_start']['status'] = true;
+		}
 		$directiveValues['session.auto_start']['current'] = self::getFlag(ini_get('session.auto_start'));
 
-		if (ini_get('mbstring.func_overload') == '1' || stripos(ini_get('mbstring.func_overload'), 'On') !== false)
-			$directiveValues['mbstring.func_overload']['status'] = true;
+		if (ini_get('mbstring.func_overload') == '1' || stripos(ini_get('mbstring.func_overload'), 'On') !== false) {
+					$directiveValues['mbstring.func_overload']['status'] = true;
+		}
 		$directiveValues['mbstring.func_overload']['current'] = self::getFlag(ini_get('mbstring.func_overload'));
 
-		if (ini_get('magic_quotes_sybase') == '1' || stripos(ini_get('magic_quotes_sybase'), 'On') !== false)
-			$directiveValues['magic_quotes_sybase']['status'] = true;
+		if (ini_get('magic_quotes_sybase') == '1' || stripos(ini_get('magic_quotes_sybase'), 'On') !== false) {
+					$directiveValues['magic_quotes_sybase']['status'] = true;
+		}
 		$directiveValues['magic_quotes_sybase']['current'] = self::getFlag(ini_get('magic_quotes_sybase'));
 
-		if (ini_get('log_errors') == '1' || stripos(ini_get('log_errors'), 'On') !== false)
-			$directiveValues['log_errors']['status'] = true;
+		if (ini_get('log_errors') == '1' || stripos(ini_get('log_errors'), 'On') !== false) {
+					$directiveValues['log_errors']['status'] = true;
+		}
 		$directiveValues['log_errors']['current'] = self::getFlag(ini_get('log_errors'));
 
-		if (ini_get('short_open_tag') != '1' || stripos(ini_get('short_open_tag'), 'Off') !== false)
-			$directiveValues['short_open_tag']['status'] = true;
+		if (ini_get('short_open_tag') != '1' || stripos(ini_get('short_open_tag'), 'Off') !== false) {
+					$directiveValues['short_open_tag']['status'] = true;
+		}
 		$directiveValues['short_open_tag']['current'] = self::getFlag(ini_get('short_open_tag'));
 
-		if (ini_get('session.gc_maxlifetime') < 21600)
-			$directiveValues['session.gc_maxlifetime']['status'] = true;
+		if (ini_get('session.gc_maxlifetime') < 21600) {
+					$directiveValues['session.gc_maxlifetime']['status'] = true;
+		}
 		$directiveValues['session.gc_maxlifetime']['current'] = ini_get('session.gc_maxlifetime');
 
-		if (ini_get('session.gc_divisor') < 500)
-			$directiveValues['session.gc_divisor']['status'] = true;
+		if (ini_get('session.gc_divisor') < 500) {
+					$directiveValues['session.gc_divisor']['status'] = true;
+		}
 		$directiveValues['session.gc_divisor']['current'] = ini_get('session.gc_divisor');
 
-		if (ini_get('session.gc_probability') < 1)
-			$directiveValues['session.gc_probability']['status'] = true;
+		if (ini_get('session.gc_probability') < 1) {
+					$directiveValues['session.gc_probability']['status'] = true;
+		}
 		$directiveValues['session.gc_probability']['current'] = ini_get('session.gc_probability');
 
-		if (ini_get('max_input_vars') < 5000)
-			$directiveValues['max_input_vars']['status'] = true;
+		if (ini_get('max_input_vars') < 5000) {
+					$directiveValues['max_input_vars']['status'] = true;
+		}
 		$directiveValues['max_input_vars']['current'] = ini_get('max_input_vars');
 
-		if (version_compare(PHP_VERSION, '5.4.0', '<'))
-			$directiveValues['PHP']['status'] = true;
+		if (version_compare(PHP_VERSION, '5.4.0', '<')) {
+					$directiveValues['PHP']['status'] = true;
+		}
 		$directiveValues['PHP']['current'] = PHP_VERSION;
 
 		if (extension_loaded('suhosin')) {
@@ -280,8 +306,9 @@ 
 		}
 
 		$errorReporting = stripos(ini_get('error_reporting'), '_') === false ? self::error2string(ini_get('error_reporting')) : ini_get('error_reporting');
-		if (in_array('E_NOTICE', $errorReporting) || in_array('E_DEPRECATED', $errorReporting) || in_array('E_STRICT', $errorReporting))
-			$directiveValues['error_reporting']['status'] = true;
+		if (in_array('E_NOTICE', $errorReporting) || in_array('E_DEPRECATED', $errorReporting) || in_array('E_STRICT', $errorReporting)) {
+					$directiveValues['error_reporting']['status'] = true;
+		}
 		$directiveValues['error_reporting']['current'] = implode(' | ', $errorReporting);
 
 		return $directiveValues;
@@ -335,16 +362,18 @@ 
 			E_COMPILE_ERROR => 'E_COMPILE_ERROR', E_COMPILE_WARNING => 'E_COMPILE_WARNING',
 			E_USER_ERROR => 'E_USER_ERROR', E_USER_WARNING => 'E_USER_WARNING',
 			E_USER_NOTICE => 'E_USER_NOTICE');
-		if (defined('E_STRICT'))
-			$level_names[E_STRICT] = 'E_STRICT';
+		if (defined('E_STRICT')) {
+					$level_names[E_STRICT] = 'E_STRICT';
+		}
 		$levels = array();
 		if (($value & E_ALL) == E_ALL) {
 			$levels[] = 'E_ALL';
 			$value&=~E_ALL;
 		}
-		foreach ($level_names as $level => $name)
-			if (($value & $level) == $level)
+		foreach ($level_names as $level => $name) {
+					if (($value & $level) == $level)
 				$levels[] = $name;
+		}
 		return $levels;
 	}
 }

modules/Settings/DataAccess/models/Module.php

Doc Comments +3 added lines

@@ -303,6 +303,9 @@
 		return array_merge($mainFolderFiles, $moduleFolderFiles);
 	}
 
+	/**
+	 * @param string|boolean $prefix
+	 */
 	public function listFolderFiles($dir, $prefix)
 	{
 		$ffs = scandir($dir);

Braces +8 added lines, -6 removed lines

@@ -131,8 +131,9 @@ 
 
 	public static function getListBaseModuleField($baseModule)
 	{
-		if ($baseModule === 'All')
-			return $baseModule;
+		if ($baseModule === 'All') {
+					return $baseModule;
+		}
 		$baseModuleModel = Vtiger_Module_Model::getInstance($baseModule);
 		$list = $baseModuleModel->getFields();
 		$output = array();
@@ -276,10 +277,11 @@ 
 	public function getActionName($name, $typ)
 	{
 		$actionsName = explode(self::$separator, $name);
-		if ($typ)
-			return vtranslate('Action_' . $actionsName[1], 'DataAccess');
-		else
-			return vtranslate('Action_Desc_' . $actionsName[1], 'DataAccess');
+		if ($typ) {
+					return vtranslate('Action_' . $actionsName[1], 'DataAccess');
+		} else {
+					return vtranslate('Action_Desc_' . $actionsName[1], 'DataAccess');
+		}
 	}
 
 	public function listAccesDataDirector($module = false)

modules/Users/CreateUserPrivilegeFile.php

Doc Comments +6 added lines, -6 removed lines

@@ -938,8 +938,8 @@ 
 
 /** Gives an array which contains the information for what all roles, groups and user's related module data that is to be shared  for the specified parent module and shared module 
 
- * @param $par_mod -- parent module name:: Type varchar
- * @param $share_mod -- shared module name:: Type varchar
+ * @param string $par_mod -- parent module name:: Type varchar
+ * @param string $share_mod -- shared module name:: Type varchar
  * @param $userid -- user id:: Type integer
  * @param $def_org_share -- default organization sharing permission array:: Type array
  * @param $mod_sharingrule_members -- Sharing Rule Members array:: Type array
@@ -1355,9 +1355,9 @@ 
 
 /** Function to populate the read/wirte Sharing permissions data for the specified user into the database 
  * @param $userid -- user id:: Type integer
- * @param $enttype -- can have the value of User or Group:: Type varchar
+ * @param string $enttype -- can have the value of User or Group:: Type varchar
  * @param $module -- module name:: Type varchar
- * @param $pertype -- can have the value of read or write:: Type varchar
+ * @param string $pertype -- can have the value of read or write:: Type varchar
  * @param $var_name_arr - Variable to use instead of including the sharing access again
  */
 function populateSharingPrivileges($enttype, $userid, $module, $pertype, $var_name_arr = false)
@@ -1432,10 +1432,10 @@ 
 
 /** Function to populate the read/wirte Sharing permissions related module data for the specified user into the database 
  * @param $userid -- user id:: Type integer
- * @param $enttype -- can have the value of User or Group:: Type varchar
+ * @param string $enttype -- can have the value of User or Group:: Type varchar
  * @param $module -- module name:: Type varchar
  * @param $relmodule -- related module name:: Type varchar
- * @param $pertype -- can have the value of read or write:: Type varchar
+ * @param string $pertype -- can have the value of read or write:: Type varchar
  * @param $var_name_arr - Variable to use instead of including the sharing access again
  */
 function populateRelatedSharingPrivileges($enttype, $userid, $module, $relmodule, $pertype, $var_name_arr = false)

Indentation -12 removed lines

@@ -154,7 +154,6 @@ 
 }
 
 /** Gives an array which contains the information for what all roles, groups and user data is to be shared with the spcified user for the specified module 
-
  * @param $module -- module name:: Type varchar
  * @param $userid -- user id:: Type integer
  * @param $def_org_share -- default organization sharing permission array:: Type array
@@ -937,7 +936,6 @@ 
 }
 
 /** Gives an array which contains the information for what all roles, groups and user's related module data that is to be shared  for the specified parent module and shared module 
-
  * @param $par_mod -- parent module name:: Type varchar
  * @param $share_mod -- shared module name:: Type varchar
  * @param $userid -- user id:: Type integer
@@ -1097,7 +1095,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1114,7 +1111,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1139,7 +1135,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1164,7 +1159,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1191,7 +1185,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1208,7 +1201,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1225,7 +1217,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1246,7 +1237,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1267,7 +1257,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1288,7 +1277,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */

Spacing +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@ 
 
 	if ($handle) {
 		$newbuf = '';
-		$newbuf .="<?php\n";
+		$newbuf .= "<?php\n";
 		$user_focus = CRMEntity::getInstance('Users');
 		$user_focus->retrieve_entity_info($userid, 'Users');
 		$userInfo = [];
@@ -1217,7 +1217,7 @@ 
 	if (is_array($var)) {
 		$code = '[';
 		foreach ($var as $value) {
-			$code .="'" . $value . "',";
+			$code .= "'" . $value . "',";
 		}
 		$code .= ']';
 		return $code;

Braces +15 added lines, -10 removed lines

@@ -257,8 +257,9 @@ 
 
 		//Get roles from Role2Grp
 		$groupList = $current_user_groups;
-		if (empty($groupList))
-			$groupList = array(0);
+		if (empty($groupList)) {
+					$groupList = array(0);
+		}
 
 		if (!empty($groupList)) {
 			$query = "select vtiger_datashare_role2group.* from vtiger_datashare_role2group inner join vtiger_datashare_module_rel on vtiger_datashare_module_rel.shareid=vtiger_datashare_role2group.shareid where vtiger_datashare_module_rel.tabid=?";
@@ -1379,8 +1380,9 @@ 
 			$var_name = $module . '_share_write_permission';
 		}
 		// Lookup for the variable if not set through function argument		
-		if (!$var_name_arr)
-			$var_name_arr = $$var_name;
+		if (!$var_name_arr) {
+					$var_name_arr = $$var_name;
+		}
 		$user_arr = [];
 		if (sizeof($var_name_arr['ROLE']) > 0) {
 			foreach ($var_name_arr['ROLE'] as $roleid => $roleusers) {
@@ -1414,8 +1416,9 @@ 
 			$var_name = $module . '_share_write_permission';
 		}
 		// Lookup for the variable if not set through function argument
-		if (!$var_name_arr)
-			$var_name_arr = $$var_name;
+		if (!$var_name_arr) {
+					$var_name_arr = $$var_name;
+		}
 		$grp_arr = [];
 		if (sizeof($var_name_arr['GROUP']) > 0) {
 
@@ -1458,8 +1461,9 @@ 
 			$var_name = $module . '_' . $relmodule . '_share_write_permission';
 		}
 		// Lookup for the variable if not set through function argument
-		if (!$var_name_arr)
-			$var_name_arr = $$var_name;
+		if (!$var_name_arr) {
+					$var_name_arr = $$var_name;
+		}
 		$user_arr = [];
 		if (sizeof($var_name_arr['ROLE']) > 0) {
 			foreach ($var_name_arr['ROLE'] as $roleid => $roleusers) {
@@ -1493,8 +1497,9 @@ 
 			$var_name = $module . '_' . $relmodule . '_share_write_permission';
 		}
 		// Lookup for the variable if not set through function argument
-		if (!$var_name_arr)
-			$var_name_arr = $$var_name;
+		if (!$var_name_arr) {
+					$var_name_arr = $$var_name;
+		}
 		$grp_arr = [];
 		if (sizeof($var_name_arr['GROUP']) > 0) {
 

modules/Vtiger/actions/GenerateRecords.php

Doc Comments +3 added lines

@@ -17,6 +17,9 @@
 		}
 	}
 
+	/**
+	 * @param Vtiger_Record_Model $recordModel
+	 */
 	public function checkMandatoryFields($recordModel)
 	{
 		$mandatoryFields = $recordModel->getModule()->getMandatoryFieldModels();