YetiForceCompany / YetiForceCRM

modules/com_vtiger_workflow/VTWorkflowApplication.inc

Doc Comments +6 added lines

@@ -11,6 +11,9 @@ 
 class VTWorkflowApplication
 {
 
+	/**
+	 * @param string $action
+	 */
 	function __construct($action)
 	{
 		$this->request;
@@ -36,6 +39,9 @@ 
 		return $_SERVER["REQUEST_URI"];
 	}
 
+	/**
+	 * @return string
+	 */
 	function returnUrl()
 	{
 		return $this->returnUrl;

modules/com_vtiger_workflow/VTWorkflowManager.inc

Doc Comments +3 added lines, -3 removed lines

@@ -480,7 +480,7 @@ 
 	/**
 	 * Function gets the next trigger for the workflows
 	 * @global <String> $default_timezone
-	 * @return type
+	 * @return string|null
 	 */
 	function getNextTriggerTime()
 	{
@@ -525,8 +525,8 @@ 
 
 	/**
 	 * get next trigger time for daily
-	 * @param type $schTime
-	 * @return time
+	 * @param type $scheduledTime
+	 * @return string
 	 */
 	function getNextTriggerTimeForDaily($scheduledTime)
 	{

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
 								module_name=?, summary=?, test=?, execution_condition=?, defaultworkflow=?, filtersavedinnew=?,
 								schtypeid=?, schtime=?, schdayofmonth=?, schdayofweek=?, schannualdates=?, nexttrigger_time=? where workflow_id=?", array($wf->moduleName, $wf->description, $wf->test, $wf->executionCondition, $wf->defaultworkflow, $wf->filtersavedinnew,
 				$wf->schtypeid, $wf->schtime, $wf->schdayofmonth, $wf->schdayofweek, $wf->schannualdates, $wf->nexttrigger_time, $wf->id));
-		}else {
+		} else {
 			$workflowId = $adb->getUniqueID("com_vtiger_workflows");
 			$workflow->id = $workflowId;
 			$wf = $workflow;

Braces +10 added lines, -7 removed lines

@@ -35,18 +35,20 @@ 
 		$adb = $this->adb;
 		if (isset($workflow->id)) {
 			$wf = $workflow;
-			if ($wf->filtersavedinnew == null)
-				$wf->filtersavedinnew = 5;
+			if ($wf->filtersavedinnew == null) {
+							$wf->filtersavedinnew = 5;
+			}
 			$adb->pquery("update com_vtiger_workflows set
 								module_name=?, summary=?, test=?, execution_condition=?, defaultworkflow=?, filtersavedinnew=?,
 								schtypeid=?, schtime=?, schdayofmonth=?, schdayofweek=?, schannualdates=?, nexttrigger_time=? where workflow_id=?", array($wf->moduleName, $wf->description, $wf->test, $wf->executionCondition, $wf->defaultworkflow, $wf->filtersavedinnew,
 				$wf->schtypeid, $wf->schtime, $wf->schdayofmonth, $wf->schdayofweek, $wf->schannualdates, $wf->nexttrigger_time, $wf->id));
-		}else {
+		} else {
 			$workflowId = $adb->getUniqueID("com_vtiger_workflows");
 			$workflow->id = $workflowId;
 			$wf = $workflow;
-			if ($wf->filtersavedinnew == null)
-				$wf->filtersavedinnew = 5;
+			if ($wf->filtersavedinnew == null) {
+							$wf->filtersavedinnew = 5;
+			}
 
 			$result = $adb->getColumnNames("com_vtiger_workflows");
 			if (in_array("type", $result)) {
@@ -155,8 +157,9 @@ 
 			$workflow = $this->getWorkflowInstance($row->type);
 			$workflow->setup($row->data);
 
-			if (!is_a($workflow, 'Workflow'))
-				continue;
+			if (!is_a($workflow, 'Workflow')) {
+							continue;
+			}
 
 			$workflows[$i++] = $workflow;
 		}

modules/com_vtiger_workflow/VTWorkflowTemplateManager.inc

Doc Comments +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
 	 * Retrieve a template given it's id
 	 *
 	 * @param $templateId The id of the template
-	 * @return The template object
+	 * @return VTWorkflowTemplate template object
 	 */
 	public function retrieveTemplate($templateId)
 	{
@@ -62,7 +62,7 @@ 
 	 *
 	 * The new workflow will also be added to the database.
 	 *
-	 * @param $template The template to use
+	 * @param VTWorkflowTemplate $template The template to use
 	 * @return A workflow object.
 	 */
 	public function createWorkflow($template)
@@ -145,7 +145,7 @@ 
 	 * This can be used for exporting templates from one 
 	 * machine to another
 	 *
-	 * @return The string dump of the templates.
+	 * @return string string dump of the templates.
 	 */
 	public function dumpAllTemplates()
 	{

Spacing +1 added lines, -2 removed lines

@@ -113,8 +113,7 @@
 		$adb = $this->adb;
 		if (is_numeric($template->id)) {//How do I check whether a member exists in php?
 			$templateId = $template->id;
-			$adb->pquery("update com_vtiger_workflowtemplates set title=?," +
-				" module_name=?, template=? where template_id=?", array($template->title, $template->moduleName,
+			$adb->pquery("update com_vtiger_workflowtemplates set title=?," +" module_name=?, template=? where template_id=?", array($template->title, $template->moduleName,
 				$template->template, $templateId));
 			return $templateId;
 		} else {

modules/com_vtiger_workflow/WorkFlowScheduler.php

Doc Comments +4 added lines, -1 removed lines

@@ -126,6 +126,9 @@ 
 		$scheduledWorkflows = null;
 	}
 
+	/**
+	 * @param QueryGenerator $queryGenerator
+	 */
 	public function addWorkflowConditionsToQueryGenerator($queryGenerator, $conditions)
 	{
 		$conditionMapping = array(
@@ -232,7 +235,7 @@ 
 	/**
 	 * Function parse the value based on the condition
 	 * @param <Array> $condition
-	 * @return <String>
+	 * @return string
 	 */
 	public function _parseValueForDate($condition)
 	{

Braces +3 added lines, -2 removed lines

@@ -175,8 +175,9 @@
 				$operation = $condition['operation'];
 
 				//Cannot handle this condition for scheduled workflows
-				if ($operation == 'has changed')
-					continue;
+				if ($operation == 'has changed') {
+									continue;
+				}
 
 				$value = $condition['value'];
 				if (in_array($operation, $this->_specialDateTimeOperator())) {

modules/CustomView/models/Record.php

Doc Comments +2 added lines, -3 removed lines

@@ -67,7 +67,7 @@ 
 	/**
 	 * Function to set the Module to which the record belongs
 	 * @param <String> $moduleName
-	 * @return Vtiger_Record_Model or Module Specific Record Model instance
+	 * @return CustomView_Record_Model or Module Specific Record Model instance
 	 */
 	public function setModule($moduleName)
 	{
@@ -78,7 +78,7 @@ 
 	/**
 	 * Function to set the Module to which the record belongs from the Module model instance
 	 * @param <Vtiger_Module_Model> $module
-	 * @return Vtiger_Record_Model or Module Specific Record Model instance
+	 * @return CustomView_Record_Model or Module Specific Record Model instance
 	 */
 	public function setModuleFromInstance($module)
 	{
@@ -1057,7 +1057,6 @@ 
 
 	/**
 	 * function to check duplicates from database
-	 * @param <type> $viewName
 	 * @param <type> module name entity type in database
 	 * @return <boolean> true/false
 	 */

Spacing +3 added lines, -3 removed lines

@@ -297,7 +297,7 @@ 
 			$lockFields = $crmEntityModel->getLockFields();
 			if (is_array($lockFields)) {
 				foreach ($lockFields as $fieldName => $fieldValues) {
-					$listQuery .=' && ' . $baseTableName . '.' . $fieldName . ' NOT IN (' . generateQuestionMarks($fieldValues) . ')';
+					$listQuery .= ' && ' . $baseTableName . '.' . $fieldName . ' NOT IN (' . generateQuestionMarks($fieldValues) . ')';
 					$params = array_merge($params, $fieldValues);
 				}
 			}
@@ -451,7 +451,7 @@ 
 					}
 
 					$temp_val = explode(",", $advFitlerValue);
-					if (($fieldType == 'date' || ($fieldType == 'time' && $fieldName != 'time_start' && $fieldName != 'time_end') || ($fieldType == 'datetime')) && ($fieldType != '' && $advFitlerValue != '' )) {
+					if (($fieldType == 'date' || ($fieldType == 'time' && $fieldName != 'time_start' && $fieldName != 'time_end') || ($fieldType == 'datetime')) && ($fieldType != '' && $advFitlerValue != '')) {
 						$val = Array();
 						for ($x = 0; $x < count($temp_val); $x++) {
 							//if date and time given then we have to convert the date and
@@ -672,7 +672,7 @@ 
 						inner join vtiger_cvadvfilter on vtiger_cvadvfilter.cvid = vtiger_customview.cvid
 						left join vtiger_cvadvfilter_grouping on vtiger_cvadvfilter.cvid = vtiger_cvadvfilter_grouping.cvid
 								and vtiger_cvadvfilter.groupid = vtiger_cvadvfilter_grouping.groupid';
-			$ssql.= " where vtiger_customview.cvid = ? && vtiger_cvadvfilter.groupid = ? order by vtiger_cvadvfilter.columnindex";
+			$ssql .= " where vtiger_customview.cvid = ? && vtiger_cvadvfilter.groupid = ? order by vtiger_cvadvfilter.columnindex";
 
 			$result = $db->pquery($ssql, array($this->getId(), $groupId));
 			$noOfColumns = $db->num_rows($result);

Braces +16 added lines, -10 removed lines

@@ -413,15 +413,17 @@ 
 		$advFilterList = $this->get('advfilterlist');
 		if (!empty($advFilterList)) {
 			foreach ($advFilterList as $groupIndex => $groupInfo) {
-				if (empty($groupInfo))
-					continue;
+				if (empty($groupInfo)) {
+									continue;
+				}
 
 				$groupColumns = $groupInfo['columns'];
 				$groupCondition = $groupInfo['condition'];
 
 				foreach ($groupColumns as $columnIndex => $columnCondition) {
-					if (empty($columnCondition))
-						continue;
+					if (empty($columnCondition)) {
+											continue;
+					}
 
 					$advFilterColumn = $columnCondition['columnname'];
 					$advFilterComparator = $columnCondition['comparator'];
@@ -494,8 +496,10 @@ 
 				}
 
 				$groupConditionExpression = $advFilterList[$groupIndex]["conditionexpression"];
-				if (empty($groupConditionExpression))
-					continue; // Case when the group doesn't have any column criteria
+				if (empty($groupConditionExpression)) {
+									continue;
+				}
+				// Case when the group doesn't have any column criteria
 
 				$db->insert('vtiger_cvadvfilter_grouping', [
 					'groupid' => $groupIndex,
@@ -676,8 +680,9 @@ 
 
 			$result = $db->pquery($ssql, array($this->getId(), $groupId));
 			$noOfColumns = $db->num_rows($result);
-			if ($noOfColumns <= 0)
-				continue;
+			if ($noOfColumns <= 0) {
+							continue;
+			}
 
 			while ($relcriteriarow = $db->fetch_array($result)) {
 				$criteria = [];
@@ -730,8 +735,9 @@ 
 			$i++;
 		}
 		// Clear the condition (and/or) for last group, if any.
-		if (!empty($advft_criteria[$i - 1]['condition']))
-			$advft_criteria[$i - 1]['condition'] = '';
+		if (!empty($advft_criteria[$i - 1]['condition'])) {
+					$advft_criteria[$i - 1]['condition'] = '';
+		}
 		return $advft_criteria;
 	}
 

modules/Emails/class.phpmailer.php

Doc Comments +1 added lines, -1 removed lines

@@ -2758,7 +2758,7 @@
 	 * @link http://www.php.net/manual/en/function.pathinfo.php#107461
 	 * @param string $path A filename or path, does not need to exist as a file
 	 * @param integer|string $options Either a PATHINFO_* constant, or a string name to return only the specified piece, allows 'filename' to work on PHP < 5.2
-	 * @return string|array
+	 * @return string
 	 * @static
 	 */
 	public static function mb_pathinfo($path, $options = null)

Indentation +1 added lines, -1 removed lines

@@ -1927,7 +1927,7 @@
 				//If a filename contains any of these chars, it should be quoted, but not otherwise: RFC2183 & RFC2045 5.1
 				//Fixes a warning in IETF's msglint MIME checker
 				//
-        // Allow for bypassing the Content-Disposition header totally
+		// Allow for bypassing the Content-Disposition header totally
 				if (!(empty($disposition))) {
 					if (preg_match('/[ \(\)<>@,;:\\"\/\[\]\?=]/', $name)) {
 						$mime[] = sprintf("Content-Disposition: %s; filename=\"%s\"%s", $disposition, $this->EncodeHeader($this->SecureHeader($name)), $this->LE . $this->LE);

Spacing +3 added lines, -4 removed lines

@@ -530,7 +530,7 @@ 
 	const STOP_MESSAGE = 0; // message only, continue processing
 	const STOP_CONTINUE = 1; // message?, likely ok to continue processing
 	const STOP_CRITICAL = 2; // message, plus full stop, critical error reached
-	const CRLF = "\r\n";  // SMTP RFC specified EOL
+	const CRLF = "\r\n"; // SMTP RFC specified EOL
 
 	/////////////////////////////////////////////////
 	// METHODS, VARIABLES
@@ -1301,7 +1301,7 @@ 
 			$message = substr($message, 0, -$lelen);
 		}
 
-		$line = explode($this->LE, $message);   // Magic. We know FixEOL uses $LE
+		$line = explode($this->LE, $message); // Magic. We know FixEOL uses $LE
 		$message = '';
 		for ($i = 0; $i < count($line); $i++) {
 			$line_part = explode(' ', $line[$i]);
@@ -1390,8 +1390,7 @@ 
 				if ($dec < 128) { // Single byte character.
 					// If the encoded char was found at pos 0, it will fit
 					// otherwise reduce maxLength to start of the encoded char
-					$maxLength = ($encodedCharPos == 0) ? $maxLength :
-						$maxLength - ($lookBack - $encodedCharPos);
+					$maxLength = ($encodedCharPos == 0) ? $maxLength : $maxLength - ($lookBack - $encodedCharPos);
 					$foundSplitPos = true;
 				} elseif ($dec >= 192) { // First byte of a multi byte character
 					// Reduce maxLength to split at start of character

Braces +21 added lines, -14 removed lines

@@ -828,8 +828,9 @@ 
 	public function Send()
 	{
 		try {
-			if (!$this->PreSend())
-				return false;
+			if (!$this->PreSend()) {
+							return false;
+			}
 			return $this->PostSend();
 		} catch (phpmailerException $e) {
 			$this->mailHeader = '';
@@ -1773,15 +1774,19 @@ 
 	protected function SetMessageType()
 	{
 		$this->message_type = array();
-		if ($this->AlternativeExists())
-			$this->message_type[] = "alt";
-		if ($this->InlineImageExists())
-			$this->message_type[] = "inline";
-		if ($this->AttachmentExists())
-			$this->message_type[] = "attach";
+		if ($this->AlternativeExists()) {
+					$this->message_type[] = "alt";
+		}
+		if ($this->InlineImageExists()) {
+					$this->message_type[] = "inline";
+		}
+		if ($this->AttachmentExists()) {
+					$this->message_type[] = "attach";
+		}
 		$this->message_type = implode("_", $this->message_type);
-		if ($this->message_type == "")
-			$this->message_type = "plain";
+		if ($this->message_type == "") {
+					$this->message_type = "plain";
+		}
 	}
 
 	/**
@@ -2019,8 +2024,9 @@ 
 			case '8bit':
 				$encoded = $this->FixEOL($str);
 				//Make sure it ends with a line break
-				if (substr($encoded, -(strlen($this->LE))) != $this->LE)
-					$encoded .= $this->LE;
+				if (substr($encoded, -(strlen($this->LE))) != $this->LE) {
+									$encoded .= $this->LE;
+				}
 				break;
 			case 'binary':
 				$encoded = $str;
@@ -2950,8 +2956,9 @@ 
 	 */
 	public function DKIM_BodyC($body)
 	{
-		if ($body == '')
-			return "\r\n";
+		if ($body == '') {
+					return "\r\n";
+		}
 		// stabilize line endings
 		$body = str_replace("\r\n", "\n", $body);
 		$body = str_replace("\n", "\r\n", $body);

modules/Emails/class.smtp.php

Doc Comments +7 added lines

@@ -111,6 +111,7 @@ 
 	 * SMTP CODE SUCCESS: 220
 	 * SMTP CODE FAILURE: 421
 	 * @access public
+	 * @param string $host
 	 * @return bool
 	 */
 	public function Connect($host, $port = 0, $tval = 30)
@@ -210,6 +211,8 @@ 
 	 * Performs SMTP authentication.  Must be run after running the
 	 * Hello() method.  Returns true if successfully authenticated.
 	 * @access public
+	 * @param string $username
+	 * @param string $password
 	 * @return bool
 	 */
 	public function Authenticate($username, $password)
@@ -325,6 +328,7 @@ 
 	 * SMTP CODE FAILURE: 451,554
 	 * SMTP CODE ERROR  : 500,501,503,421
 	 * @access public
+	 * @param string $msg_data
 	 * @return bool
 	 */
 	public function Data($msg_data)
@@ -491,6 +495,8 @@ 
 	/**
 	 * Sends a HELO/EHLO command.
 	 * @access private
+	 * @param string $hello
+	 * @param string $host
 	 * @return bool
 	 */
 	private function SendHello($hello, $host)
@@ -531,6 +537,7 @@ 
 	 * SMTP CODE SUCCESS: 552,451,452
 	 * SMTP CODE SUCCESS: 500,501,421
 	 * @access public
+	 * @param string $from
 	 * @return bool
 	 */
 	public function Mail($from)

Spacing +2 added lines, -2 removed lines

@@ -79,7 +79,7 @@ 
 	/////////////////////////////////////////////////
 
 	private $smtp_conn; // the socket to the server
-	private $error;  // error if any on the last call
+	private $error; // error if any on the last call
 	private $helo_rply; // the reply the server sent to us for HELO
 
 	/**
@@ -134,7 +134,7 @@ 
 				$port, // the port to use
 				$errno, // error number if any
 				$errstr, // error message if any
-				$tval);   // give up after ? secs
+				$tval); // give up after ? secs
 		// verify we connected properly
 		if (empty($this->smtp_conn)) {
 			$this->error = array("error" => "Failed to connect to server",

Braces +3 added lines, -2 removed lines

@@ -148,8 +148,9 @@
 
 		// SMTP server can take longer to respond, give longer timeout for first read
 		// Windows does not have support for this timeout function
-		if (substr(PHP_OS, 0, 3) != "WIN")
-			socket_set_timeout($this->smtp_conn, $tval, 0);
+		if (substr(PHP_OS, 0, 3) != "WIN") {
+					socket_set_timeout($this->smtp_conn, $tval, 0);
+		}
 
 		// get any announcement
 		$announce = $this->get_lines();

modules/Emails/mail.php

Doc Comments +10 added lines

@@ -103,6 +103,7 @@ 
 /** 	Function to get the user Email id based on column name and column value
  * 	$name -- column name of the vtiger_users vtiger_table
  * 	$val  -- column value
+ * @param string $name
  */
 function getUserEmailId($name, $val)
 {
@@ -162,6 +163,8 @@ 
  * 	$attachment	-- whether we want to attach the currently selected file or all vtiger_files.
   [values = current,all] - optional
  * 	$emailid	-- id of the email object which will be used to get the vtiger_attachments - optional
+ * @param PHPMailer $mail
+ * @param string $to_email
  */
 function setMailerProperties($mail, $subject, $contents, $fromEmail, $fromName, $to_email, $attachment = '', $emailid = '', $module = '', $logo = '')
 {
@@ -297,6 +300,7 @@ 
  * 	$mail -- reference of the mail object
  * 	$filename -- filename which is going to added with the mail
  * 	$record -- id of the record - optional
+ * @param string $record
  */
 function addAttachment($mail, $filename, $record)
 {
@@ -313,6 +317,7 @@ 
 /**     Function to add all the vtiger_files as attachment with the mail object
  *     $mail -- reference of the mail object
  *     $record -- email id ie., record id which is used to get the all vtiger_attachments from database
+ * @param string $record
  */
 function addAllAttachments($mail, $record)
 {
@@ -347,6 +352,9 @@ 
  * 	$mail -- reference of the mail object
  * 	$cc_mod -- mode to set the address ie., cc or bcc
  * 	$cc_val -- addresss with comma seperated to set as CC or BCC in the mail
+ * @param PHPMailer $mail
+ * @param string $cc_mod
+ * @param string $cc_val
  */
 function setCCAddress($mail, $cc_mod, $cc_val)
 {
@@ -375,6 +383,7 @@ 
 
 /** 	Function to send the mail which will be called after set all the mail object values
  * 	$mail -- reference of the mail object
+ * @param PHPMailer $mail
  */
 function MailSend($mail)
 {
@@ -423,6 +432,7 @@ 
  * 	$mail_status -- status of the mail which is sent or not
  * 	$to -- the email address to whom we sent the mail and failes
  * 	return -- Mail error occured during the mail sending process
+ * @param PHPMailer $mail
  */
 function getMailError($mail, $mail_status, $to)
 {

Spacing +5 added lines, -5 removed lines

@@ -179,7 +179,7 @@ 
 	$mail->Body = decode_html($contents);
 	$mail->AltBody = strip_tags(preg_replace(array("/<p>/i", "/<br>/i", "/<br \/>/i"), array("\n", "\n", "\n"), $contents));
 
-	$mail->IsSMTP();  //set mailer to use SMTP
+	$mail->IsSMTP(); //set mailer to use SMTP
 
 	setMailServerProperties($mail);
 
@@ -230,7 +230,7 @@ 
 		addAllAttachments($mail, $emailid);
 	}
 
-	$mail->IsHTML(true);  // set email format to HTML
+	$mail->IsHTML(true); // set email format to HTML
 
 	return;
 }
@@ -278,7 +278,7 @@ 
 	if ($smtp_auth) {
 		$mail->SMTPAuth = true; // turn on SMTP authentication
 	}
-	$mail->Host = $server;  // specify main and backup server
+	$mail->Host = $server; // specify main and backup server
 	$mail->Username = $username; // SMTP username
 	$mail->Password = $password; // SMTP password
 	// To Support TLS
@@ -525,8 +525,8 @@ 
 
 function isUserInitiated()
 {
-	return ( AppRequest::get('module') == 'Emails' &&
-		( AppRequest::get('action') == 'mailsend' || AppRequest::get('action') == 'Save'));
+	return (AppRequest::get('module') == 'Emails' &&
+		(AppRequest::get('action') == 'mailsend' || AppRequest::get('action') == 'Save'));
 }
 
 /**

Braces +31 added lines, -24 removed lines

@@ -245,27 +245,30 @@ 
 	$log->debug('Inside the function setMailServerProperties');
 
 	$res = $adb->pquery('select * from vtiger_systems where server_type=?', array('email'));
-	if (AppRequest::has('server'))
-		$server = AppRequest::get('server');
-	else
-		$server = $adb->query_result_raw($res, 0, 'server');
-	if (AppRequest::has('server_username'))
-		$username = AppRequest::get('server_username');
-	else
-		$username = $adb->query_result_raw($res, 0, 'server_username');
-
-	if (AppRequest::has('server_password'))
-		$password = AppRequest::get('server_password');
-	else
-		$password = $adb->query_result_raw($res, 0, 'server_password');
+	if (AppRequest::has('server')) {
+			$server = AppRequest::get('server');
+	} else {
+			$server = $adb->query_result_raw($res, 0, 'server');
+	}
+	if (AppRequest::has('server_username')) {
+			$username = AppRequest::get('server_username');
+	} else {
+			$username = $adb->query_result_raw($res, 0, 'server_username');
+	}
+
+	if (AppRequest::has('server_password')) {
+			$password = AppRequest::get('server_password');
+	} else {
+			$password = $adb->query_result_raw($res, 0, 'server_password');
+	}
 
 	// Define default state
 	$smtp_auth = false;
 
 	// Prasad: First time read smtp_auth from the request
-	if (AppRequest::get('smtp_auth') == 'on')
-		$smtp_auth = true;
-	else if (AppRequest::get('module') == 'Settings' && (!AppRequest::has('smtp_auth'))) {
+	if (AppRequest::get('smtp_auth') == 'on') {
+			$smtp_auth = true;
+	} else if (AppRequest::get('module') == 'Settings' && (!AppRequest::has('smtp_auth'))) {
 		//added to avoid issue while editing the values in the outgoing mail server.
 		$smtp_auth = false;
 	} else {
@@ -353,10 +356,12 @@ 
 	$log = LoggerManager::getInstance();
 	$log->debug('Inside the functin setCCAddress');
 
-	if ($cc_mod == 'cc')
-		$method = 'AddCC';
-	if ($cc_mod == 'bcc')
-		$method = 'AddBCC';
+	if ($cc_mod == 'cc') {
+			$method = 'AddCC';
+	}
+	if ($cc_mod == 'bcc') {
+			$method = 'AddBCC';
+	}
 	if ($cc_val != '') {
 		$ccmail = explode(",", trim($cc_val, ","));
 		for ($i = 0; $i < count($ccmail); $i++) {
@@ -367,8 +372,9 @@ 
 				$cc_name = $name_addr_pair[0];
 				$addr = trim($name_addr_pair[1], ">");
 			}
-			if ($ccmail[$i] != '')
-				$mail->$method($addr, $cc_name);
+			if ($ccmail[$i] != '') {
+							$mail->$method($addr, $cc_name);
+			}
 		}
 	}
 }
@@ -541,8 +547,9 @@ 
 		$userGroups = new GetGroupUsers();
 		$userGroups->getAllUsersInGroup($groupId);
 
-		if (count($userGroups->group_users) == 0)
-			return [];
+		if (count($userGroups->group_users) == 0) {
+					return [];
+		}
 
 		$query = sprintf('SELECT 
 					email1 

modules/HelpDesk/dashboards/TicketsByStatus.php

Doc Comments -1 removed lines

@@ -27,7 +27,6 @@
 
 	/**
 	 * Function returns Tickets grouped by Status
-	 * @param type $data
 	 * @return <Array>
 	 */
 	public function getTicketsByStatus($owner)

Braces +17 added lines, -12 removed lines

@@ -19,8 +19,9 @@ 
 
 		$listSearchParams = [];
 		$conditions = array(array('ticketstatus', 'e', $value));
-		if (!empty($assignedto))
-			array_push($conditions, array('assigned_user_id', 'e', $assignedto));
+		if (!empty($assignedto)) {
+					array_push($conditions, array('assigned_user_id', 'e', $assignedto));
+		}
 		$listSearchParams[] = $conditions;
 		return '&viewname=All&search_params=' . json_encode($listSearchParams);
 	}
@@ -62,8 +63,9 @@ 
 			$sql .= " && vtiger_troubletickets.status NOT IN ('$ticketStatusSearch')";
 			$this->conditions = ['vtiger_troubletickets.status', "'$ticketStatusSearch'", 'nin', QueryGenerator::$AND];
 		}
-		if (!empty($securityParameter))
-			$sql .= $securityParameter;
+		if (!empty($securityParameter)) {
+					$sql .= $securityParameter;
+		}
 
 
 		$sql .= ' GROUP BY statusvalue, priority ORDER BY vtiger_ticketstatus.sortorderid';
@@ -78,8 +80,9 @@ 
 				$priorities[$row['priority']] = $counter++;
 				$colors[$row['priority']] = $row['color'];
 			}
-			if (!in_array($row['statusvalue'], $status))
-				$status[] = $row['statusvalue'];
+			if (!in_array($row['statusvalue'], $status)) {
+							$status[] = $row['statusvalue'];
+			}
 		}
 		if (!empty($tickets)) {
 			$counter = 0;
@@ -123,13 +126,15 @@ 
 		$data = $request->get('data');
 		$createdTime = $request->get('createdtime');
 		$widget = Vtiger_Widget_Model::getInstance($linkId, $currentUser->getId());
-		if (!$request->has('owner'))
-			$owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget, $moduleName);
-		else
-			$owner = $request->get('owner');
+		if (!$request->has('owner')) {
+					$owner = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget, $moduleName);
+		} else {
+					$owner = $request->get('owner');
+		}
 		$ownerForwarded = $owner;
-		if ($owner == 'all')
-			$owner = '';
+		if ($owner == 'all') {
+					$owner = '';
+		}
 
 		//Date conversion from user to database format
 		if (!empty($createdTime)) {