YetiForceCompany / YetiForceCRM

include/main/WebUI.php

Doc Comments +9 added lines

@@ -54,6 +54,9 @@ 
 		return $user;
 	}
 
+	/**
+	 * @param Vtiger_Request $request
+	 */
 	protected function triggerCheckPermission($handler, $request)
 	{
 		$moduleName = $request->getModule();
@@ -73,6 +76,9 @@ 
 		throw new \Exception\NoPermitted('LBL_NOT_ACCESSIBLE');
 	}
 
+	/**
+	 * @param Vtiger_Request $request
+	 */
 	protected function triggerPreProcess($handler, $request)
 	{
 		if ($request->isAjax()) {
@@ -82,6 +88,9 @@ 
 		$handler->preProcess($request);
 	}
 
+	/**
+	 * @param Vtiger_Request $request
+	 */
 	protected function triggerPostProcess($handler, $request)
 	{
 		if ($request->isAjax()) {

include/Webservices/DataTransform.php

Doc Comments +3 added lines

@@ -48,6 +48,9 @@
 		return $row;
 	}
 
+	/**
+	 * @param boolean $t
+	 */
 	public static function sanitizeData($newRow, $meta, $t = null)
 	{
 

Braces +6 added lines, -4 removed lines

@@ -24,8 +24,9 @@ 
 		$fieldColumnMapping = $meta->getFieldColumnMapping();
 		$columnFieldMapping = array_flip($fieldColumnMapping);
 		foreach ($row as $col => $val) {
-			if (array_key_exists($col, $columnFieldMapping))
-				$newRow[$columnFieldMapping[$col]] = $val;
+			if (array_key_exists($col, $columnFieldMapping)) {
+							$newRow[$columnFieldMapping[$col]] = $val;
+			}
 		}
 		$newRow = DataTransform::sanitizeData($newRow, $meta, true);
 		return $newRow;
@@ -149,8 +150,9 @@ 
 		$allFields = $meta->getFieldColumnMapping();
 		$newRow = [];
 		foreach ($allFields as $field => $col) {
-			if (isset($row[$field]))
-				$newRow[$field] = $row[$field];
+			if (isset($row[$field])) {
+							$newRow[$field] = $row[$field];
+			}
 		}
 		if (isset($row[$recordString])) {
 			$newRow[$recordString] = $row[$recordString];

include/Webservices/Query.php

Doc Comments +3 added lines

@@ -10,6 +10,9 @@
 
 require_once("include/Webservices/QueryParser.php");
 
+/**
+ * @param string $q
+ */
 function vtws_query($q, $user)
 {
 

Braces +3 added lines, -2 removed lines

@@ -21,8 +21,9 @@
 	// Cache the instance for re-use		
 	$moduleRegex = "/[fF][rR][Oo][Mm]\s+([^\s;]+)/";
 	$moduleName = '';
-	if (preg_match($moduleRegex, $q, $m))
-		$moduleName = trim($m[1]);
+	if (preg_match($moduleRegex, $q, $m)) {
+			$moduleName = trim($m[1]);
+	}
 
 	if (!isset($vtws_create_cache[$moduleName]['webserviceobject'])) {
 		$webserviceObject = VtigerWebserviceObject::fromQuery($adb, $q);

include/Webservices/QueryRelated.php

Doc Comments +3 added lines

@@ -12,6 +12,9 @@
 include_once 'include/Webservices/Query.php';
 include_once 'include/Webservices/RelatedTypes.php';
 
+/**
+ * @param string $query
+ */
 function vtws_query_related($query, $id, $relatedLabel, $user, $filterClause = null)
 {
 

Spacing +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
 		if (!empty($filterClause)) {
 			$query .= " " . $filterClause;
 		}
-		$query.=";";
+		$query .= ";";
 		$relatedRecords = vtws_query($query, $user);
 	}
 

include/Webservices/VtigerActorOperation.php

Doc Comments +3 added lines

@@ -148,6 +148,9 @@
 		return false;
 	}
 
+	/**
+	 * @param string $id
+	 */
 	public function retrieve($id)
 	{
 

Spacing +1 added lines, -2 removed lines

@@ -270,8 +270,7 @@
 			foreach ($moduleFields as $fieldName => $webserviceField) {
 				array_push($fields, $this->getDescribeFieldArray($webserviceField));
 			}
-			$label = ($app_strings[$this->meta->getObectIndexColumn()]) ? $app_strings[$this->meta->getObectIndexColumn()] :
-				$this->meta->getObectIndexColumn();
+			$label = ($app_strings[$this->meta->getObectIndexColumn()]) ? $app_strings[$this->meta->getObectIndexColumn()] : $this->meta->getObectIndexColumn();
 			$this->moduleFields = $fields;
 		}
 		return $this->moduleFields;

include/Webservices/VtigerCRMActorMeta.php

Doc Comments +3 added lines

@@ -15,6 +15,9 @@
 	protected static $fieldTypeMapping = [];
 	protected static $referenceTypeMapping = [];
 
+	/**
+	 * @param PearDatabase $adb
+	 */
 	public function __construct($tableName, $webserviceObject, $adb, $user)
 	{
 		parent::__construct($webserviceObject, $user);

include/Webservices/VTQL_Lexer.php

Doc Comments +9 added lines

@@ -5,6 +5,9 @@ 
 $in_started = false;
 $count = false;
 
+/**
+ * @param integer $count
+ */
 function incrementN($lexer, $count)
 {
 	$i = 0;
@@ -160,6 +163,9 @@ 
 	}
 }
 
+/**
+ * @param VTQL_Lexer $lexer
+ */
 function handleend($lexer, $val)
 {
 	return VTQL_Parser::SEMICOLON;
@@ -179,6 +185,9 @@ 
 	public $mandatory;
 	public $current_state;
 
+	/**
+	 * @param string $data
+	 */
 	public function __construct($data)
 	{
 		$this->index = 0;

include/Webservices/VTQL_Parser.php

Doc Comments +3 added lines

@@ -159,6 +159,9 @@
 	private $syntax_error;
 	private $user;
 
+	/**
+	 * @param VTQL_Lexer $lex
+	 */
 	public function __construct($user, $lex, $out)
 	{
 		if (!is_array($out)) {

Spacing +6 added lines, -6 removed lines

@@ -89,7 +89,7 @@ 
 {
 
 	public $stateno; /* The state-number */
-	public $major;   /* The major token value.  This is the code
+	public $major; /* The major token value.  This is the code
 	 * * number for the token at this stack level */
 	public $minor; /* The user-supplied minor token value.  This
 	 * * is the value of the token  */
@@ -663,17 +663,17 @@ 
 	/**
 	 * @var int
 	 */
-	public $yyidx;  /* Index of top element in stack */
+	public $yyidx; /* Index of top element in stack */
 
 	/**
 	 * @var int
 	 */
-	public $yyerrcnt;  /* Shifts left before out of the error */
+	public $yyerrcnt; /* Shifts left before out of the error */
 
 	/**
 	 * @var array
 	 */
-	public $yystack = [];  /* The parser's stack */
+	public $yystack = []; /* The parser's stack */
 
 	/**
 	 * For tracing shifts, the names of all terminals and nonterminals
@@ -782,7 +782,7 @@ 
 			 * * which appear on the RHS of the rule, but which are not used
 			 * * inside the C code.
 			 */
-			default: break;   /* If no destructor action specified: do nothing */
+			default: break; /* If no destructor action specified: do nothing */
 		}
 	}
 
@@ -1608,7 +1608,7 @@ 
 	{
 //        $yyact;            /* The parser action. */
 //        $yyendofinput;     /* True if we are at the end of input */
-		$yyerrorhit = 0;   /* True if yymajor has invoked an error */
+		$yyerrorhit = 0; /* True if yymajor has invoked an error */
 
 		/* (re)initialize the parser, if necessary */
 		if ($this->yyidx === null || $this->yyidx < 0) {

modules/Accounts/Accounts.php

Doc Comments +2 added lines, -1 removed lines

@@ -611,6 +611,7 @@ 
 	 * @param  integer   $id      		- accountid
 	 * @param  array   $parent_accounts   - Array of all the parent accounts
 	 * returns All the parent accounts of the given accountid in array format
+	 * @param integer[] $encountered_accounts
 	 */
 	public function __getParentAccounts($id, &$parent_accounts, &$encountered_accounts, $depthBase = 0)
 	{
@@ -673,7 +674,7 @@ 
 	 * Function to Recursively get all the child accounts of a given Account
 	 * @param  integer   $id      		- accountid
 	 * @param  array   $child_accounts   - Array of all the child accounts
-	 * @param  integer   $depth          - Depth at which the particular account has to be placed in the hierarchy
+	 * @param  integer   $depthBase          - Depth at which the particular account has to be placed in the hierarchy
 	 * returns All the child accounts of the given accountid in array format
 	 */
 	public function __getChildAccounts($id, &$child_accounts, $depthBase)

Braces +23 added lines, -16 removed lines

@@ -111,10 +111,11 @@ 
 		$query .= $this->getNonAdminAccessControlQuery('Accounts', $current_user);
 		$where_auto = " vtiger_crmentity.deleted = 0 ";
 
-		if ($where != '')
-			$query .= sprintf(' where (%s) && %s', $where, $where_auto);
-		else
-			$query .= sprintf(' where %s', $where_auto);
+		if ($where != '') {
+					$query .= sprintf(' where (%s) && %s', $where, $where_auto);
+		} else {
+					$query .= sprintf(' where %s', $where_auto);
+		}
 
 		\App\Log::trace("Exiting create_export_query method ...");
 		return $query;
@@ -430,8 +431,9 @@ 
 	public function unlinkRelationship($id, $return_module, $return_id, $relatedName = false)
 	{
 
-		if (empty($return_module) || empty($return_id))
-			return;
+		if (empty($return_module) || empty($return_id)) {
+					return;
+		}
 
 		if ($return_module === 'Campaigns') {
 			App\Db::getInstance()->createCommand()->delete('vtiger_campaign_records', ['crmid' => $id, 'campaignid' => $return_id])->execute();
@@ -444,8 +446,9 @@ 
 
 	public function save_related_module($module, $crmid, $with_module, $with_crmids, $relatedName = false)
 	{
-		if (!is_array($with_crmids))
-			$with_crmids = [$with_crmids];
+		if (!is_array($with_crmids)) {
+					$with_crmids = [$with_crmids];
+		}
 		if (!in_array($with_module, ['Products', 'Campaigns'])) {
 			parent::save_related_module($module, $crmid, $with_module, $with_crmids, $relatedName);
 		} else {
@@ -495,10 +498,12 @@ 
 					continue;
 				}
 				// Setup the default JOIN conditions if not specified
-				if (empty($relmap[1]))
-					$relmap[1] = $other->table_name;
-				if (empty($relmap[2]))
-					$relmap[2] = $relmap[0];
+				if (empty($relmap[1])) {
+									$relmap[1] = $other->table_name;
+				}
+				if (empty($relmap[2])) {
+									$relmap[2] = $relmap[0];
+				}
 				$join .= " LEFT JOIN $tname ON $tname.$relmap[0] = $relmap[1].$relmap[2]";
 			}
 		}
@@ -523,14 +528,16 @@ 
 	public function getRelatedContactsIds($id = null)
 	{
 
-		if ($id === null)
-			$id = $this->id;
+		if ($id === null) {
+					$id = $this->id;
+		}
 		$query = (new \App\Db\Query())->select('contactid')->from('vtiger_contactdetails')
 			->innerJoin('vtiger_crmentity', 'vtiger_contactdetails.contactid = vtiger_crmentity.crmid')
 			->where(['vtiger_contactdetails.parentid' => $id, 'vtiger_crmentity.deleted' => 0]);
 		$entityIds = $query->column();
-		if (empty($entityIds))
-			$entityIds = [];
+		if (empty($entityIds)) {
+					$entityIds = [];
+		}
 
 		return $entityIds;
 	}