YetiForceCompany / YetiForceCRM

modules/Users/Users.php

Spacing +1 added lines, -1 removed lines

@@ -296,7 +296,7 @@
 			$buffer = fread($handle, filesize($validate));
 			if (substr_count($buffer, $authkey) < $i)
 				return -1;
-		}else {
+		} else {
 			return -1;
 		}
 	}

Braces +32 added lines, -25 removed lines

@@ -118,10 +118,11 @@ 
 	{
 
 		\App\Log::trace("Entering getSortOrder() method ...");
-		if (AppRequest::has('sorder'))
-			$sorder = $this->db->sql_escape_string(AppRequest::get('sorder'));
-		else
-			$sorder = (($_SESSION['USERS_SORT_ORDER'] != '') ? ($_SESSION['USERS_SORT_ORDER']) : ($this->default_sort_order));
+		if (AppRequest::has('sorder')) {
+					$sorder = $this->db->sql_escape_string(AppRequest::get('sorder'));
+		} else {
+					$sorder = (($_SESSION['USERS_SORT_ORDER'] != '') ? ($_SESSION['USERS_SORT_ORDER']) : ($this->default_sort_order));
+		}
 		\App\Log::trace("Exiting getSortOrder method ...");
 		return $sorder;
 	}
@@ -140,10 +141,11 @@ 
 			$use_default_order_by = $this->default_order_by;
 		}
 
-		if (AppRequest::has('order_by'))
-			$order_by = $this->db->sql_escape_string(AppRequest::get('order_by'));
-		else
-			$order_by = (($_SESSION['USERS_ORDER_BY'] != '') ? ($_SESSION['USERS_ORDER_BY']) : ($use_default_order_by));
+		if (AppRequest::has('order_by')) {
+					$order_by = $this->db->sql_escape_string(AppRequest::get('order_by'));
+		} else {
+					$order_by = (($_SESSION['USERS_ORDER_BY'] != '') ? ($_SESSION['USERS_ORDER_BY']) : ($use_default_order_by));
+		}
 		\App\Log::trace("Exiting getOrderBy method ...");
 		return $order_by;
 	}
@@ -157,10 +159,11 @@ 
 	public function setPreference($name, $value)
 	{
 		if (!isset($this->user_preferences)) {
-			if (isset($_SESSION["USER_PREFERENCES"]))
-				$this->user_preferences = $_SESSION["USER_PREFERENCES"];
-			else
-				$this->user_preferences = [];
+			if (isset($_SESSION["USER_PREFERENCES"])) {
+							$this->user_preferences = $_SESSION["USER_PREFERENCES"];
+			} else {
+							$this->user_preferences = [];
+			}
 		}
 		if (!array_key_exists($name, $this->user_preferences) || $this->user_preferences[$name] != $value) {
 			\App\Log::trace("Saving To Preferences:" . $name . "=" . $value);
@@ -284,9 +287,10 @@ 
 		$authkey = base64_decode($authkey);
 		if (file_exists($validate) && $handle = fopen($validate, 'rb', true)) {
 			$buffer = fread($handle, filesize($validate));
-			if (substr_count($buffer, $authkey) < $i)
-				return -1;
-		}else {
+			if (substr_count($buffer, $authkey) < $i) {
+							return -1;
+			}
+		} else {
 			return -1;
 		}
 	}
@@ -378,8 +382,9 @@ 
 		}
 		\App\Log::trace("Starting user load for $usr_name");
 
-		if (!isset($this->column_fields["user_name"]) || $this->column_fields["user_name"] == "" || !isset($user_password) || $user_password == "")
-			return null;
+		if (!isset($this->column_fields["user_name"]) || $this->column_fields["user_name"] == "" || !isset($user_password) || $user_password == "") {
+					return null;
+		}
 
 		$authCheck = false;
 		$authCheck = $this->doLogin($user_password);
@@ -407,8 +412,9 @@ 
 		$this->loadPreferencesFromDB($row['user_preferences']);
 
 
-		if ($row['status'] != "Inactive")
-			$this->authenticated = true;
+		if ($row['status'] != "Inactive") {
+					$this->authenticated = true;
+		}
 
 		unset($_SESSION['loginattempts']);
 		return $this;
@@ -940,8 +946,9 @@ 
 		$db = App\Db::getInstance();
 		//to get the owner id
 		$ownerid = $this->column_fields['assigned_user_id'];
-		if (!isset($ownerid) || $ownerid == '')
-			$ownerid = $currentUserId;
+		if (!isset($ownerid) || $ownerid == '') {
+					$ownerid = $currentUserId;
+		}
 		$fileInstance = \App\Fields\File::loadFromRequest($fileDetails);
 		if (!$fileInstance->validate('image')) {
 			\App\Log::trace('Skip the save attachment process.');
@@ -1202,10 +1209,10 @@ 
 					$result = $adb->pquery($qry, [$id, $this->homeorder_array[$i]]);
 				}
 			}
-			if ($save_array != "")
-				$homeorder = implode(',', $save_array);
-		}
-		else {
+			if ($save_array != "") {
+							$homeorder = implode(',', $save_array);
+			}
+		} else {
 			$this->insertUserdetails('postinstall');
 		}
 		\App\Log::trace("Exiting from function saveHomeOrder($id)");

Doc Comments +7 added lines, -3 removed lines

@@ -204,7 +204,6 @@ 
 
 	/**
 	 * @return string encrypted password for storage in DB and comparison against DB password.
-	 * @param string $user_name - Must be non null and at least 2 characters
 	 * @param string $user_password - Must be non null and at least 1 character.
 	 * @desc Take an unencrypted username and password and return the encrypted password
 	 * Portions created by SugarCRM are Copyright (C) SugarCRM, Inc..
@@ -452,7 +451,6 @@ 
 	}
 
 	/**
-	 * @param string $user name - Must be non null and at least 1 character.
 	 * @param string $userPassword - Must be non null and at least 1 character.
 	 * @param string $newPassword - Must be non null and at least 1 character.
 	 * @return boolean - If passwords pass verification and query succeeds, return true, else return false.
@@ -869,7 +867,7 @@ 
 
 	/** Function to retreive the user info of the specifed user id The user info will be available in $this->column_fields array
 	 * @param $record -- record id:: Type integer
-	 * @param $module -- module:: Type varchar
+	 * @param string $module -- module:: Type varchar
 	 */
 	public function retrieve_entity_info($record, $module)
 	{
@@ -1092,6 +1090,9 @@ 
 		return $return_array;
 	}
 
+	/**
+	 * @param string $home_string
+	 */
 	public function getDefaultHomeModuleVisibility($home_string, $inVal)
 	{
 		$homeModComptVisibility = 1;
@@ -1105,6 +1106,9 @@ 
 		return $homeModComptVisibility;
 	}
 
+	/**
+	 * @param string $inVal
+	 */
 	public function insertUserdetails($inVal)
 	{
 		$adb = PearDatabase::getInstance();

modules/OSSTimeControl/actions/GetTCInfo.php

Braces +10 added lines, -8 removed lines

@@ -37,17 +37,19 @@
 			$sourceData = $entity->column_fields;
 			if ($sourceModule == 'HelpDesk') {
 				$sourceData['contact_label'] = vtlib\Functions::getCRMRecordLabel($sourceData['contact_id']);
-				if (vtlib\Functions::getCRMRecordType($sourceData['parent_id']) != 'Accounts')
-					unset($sourceData['parent_id']);
-				else
-					$sourceData['account_label'] = vtlib\Functions::getCRMRecordLabel($sourceData['parent_id']);
+				if (vtlib\Functions::getCRMRecordType($sourceData['parent_id']) != 'Accounts') {
+									unset($sourceData['parent_id']);
+				} else {
+									$sourceData['account_label'] = vtlib\Functions::getCRMRecordLabel($sourceData['parent_id']);
+				}
 			} else if ($sourceModule == 'Project') {
 				$query = sprintf("select * from vtiger_account where accountid = %s", $sourceData['linktoaccountscontacts']);
 				$ifExist = $adb->query($query, true, "Błąd podczas pobierania danych z vtiger_crmentityrel");
-				if ($adb->num_rows($ifExist) > 0)
-					$sourceData['account_label'] = vtlib\Functions::getCRMRecordLabel($sourceData['linktoaccountscontacts']);
-				else
-					$sourceData['contact_label'] = vtlib\Functions::getCRMRecordLabel($sourceData['linktoaccountscontacts']);
+				if ($adb->num_rows($ifExist) > 0) {
+									$sourceData['account_label'] = vtlib\Functions::getCRMRecordLabel($sourceData['linktoaccountscontacts']);
+				} else {
+									$sourceData['contact_label'] = vtlib\Functions::getCRMRecordLabel($sourceData['linktoaccountscontacts']);
+				}
 			}
 		}
 

modules/ModComments/ModCommentsCore.php

Braces +21 added lines, -16 removed lines

@@ -96,10 +96,11 @@ 
 		$currentModule = vglobal('currentModule');
 
 		$sortorder = $this->default_sort_order;
-		if (!AppRequest::isEmpty('sorder'))
-			$sortorder = $this->db->sql_escape_string(AppRequest::get('sorder'));
-		else if ($_SESSION[$currentModule . '_Sort_Order'])
-			$sortorder = $_SESSION[$currentModule . '_Sort_Order'];
+		if (!AppRequest::isEmpty('sorder')) {
+					$sortorder = $this->db->sql_escape_string(AppRequest::get('sorder'));
+		} else if ($_SESSION[$currentModule . '_Sort_Order']) {
+					$sortorder = $_SESSION[$currentModule . '_Sort_Order'];
+		}
 
 		return $sortorder;
 	}
@@ -114,10 +115,11 @@ 
 		}
 
 		$orderby = $use_default_order_by;
-		if (!AppRequest::isEmpty('order_by'))
-			$orderby = $this->db->sql_escape_string(AppRequest::get('order_by'));
-		else if ($_SESSION[$currentModule . '_Order_By'])
-			$orderby = $_SESSION[$currentModule . '_Order_By'];
+		if (!AppRequest::isEmpty('order_by')) {
+					$orderby = $this->db->sql_escape_string(AppRequest::get('order_by'));
+		} else if ($_SESSION[$currentModule . '_Order_By']) {
+					$orderby = $_SESSION[$currentModule . '_Order_By'];
+		}
 		return $orderby;
 	}
 
@@ -146,8 +148,9 @@ 
 		$joinedTables = array();
 
 		// Select Custom Field Table Columns if present
-		if (!empty($this->customFieldTable))
-			$query .= ", " . $this->customFieldTable[0] . ".* ";
+		if (!empty($this->customFieldTable)) {
+					$query .= ", " . $this->customFieldTable[0] . ".* ";
+		}
 
 		$query .= " FROM $this->table_name";
 
@@ -285,10 +288,11 @@ 
 
 		$where_auto = " vtiger_crmentity.deleted=0";
 
-		if ($where != '')
-			$query .= " WHERE ($where) && $where_auto";
-		else
-			$query .= " WHERE $where_auto";
+		if ($where != '') {
+					$query .= " WHERE ($where) && $where_auto";
+		} else {
+					$query .= " WHERE $where_auto";
+		}
 
 		require('user_privileges/user_privileges_' . $current_user->id . '.php');
 		require('user_privileges/sharing_privileges_' . $current_user->id . '.php');
@@ -317,8 +321,9 @@ 
 		$select_clause = sprintf('SELECT %s.%s AS recordid, vtiger_users_last_import.deleted, %s', $this->table_name, $this->table_index, $table_cols);
 
 		// Select Custom Field Table Columns if present
-		if (isset($this->customFieldTable))
-			$query .= ", " . $this->customFieldTable[0] . ".* ";
+		if (isset($this->customFieldTable)) {
+					$query .= ", " . $this->customFieldTable[0] . ".* ";
+		}
 
 		$from_clause = " FROM $this->table_name";
 

modules/Settings/QuickCreateEditor/models/Module.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
 		$db = PearDatabase::getInstance();
 
 		$query = 'UPDATE vtiger_field SET ';
-		$query .=' quickcreatesequence= CASE ';
+		$query .= ' quickcreatesequence= CASE ';
 		foreach ($blockFieldSequence as $newFieldSequence) {
 			$fieldId = $newFieldSequence['fieldid'];
 			$sequence = $newFieldSequence['sequence'];
@@ -27,7 +27,7 @@ 
 			$query .= ' WHEN fieldid=' . $fieldId . ' THEN ' . $sequence;
 		}
 
-		$query .=' END ';
+		$query .= ' END ';
 		$query .= sprintf(' WHERE fieldid IN (%s)', generateQuestionMarks($fieldIdList));
 		$db->pquery($query, array($fieldIdList));
 	}

modules/Settings/QuickCreateEditor/views/Index.php

Braces +6 added lines, -4 removed lines

@@ -37,13 +37,15 @@
 			//To get the first element
 			$firstElement = reset($menuModelsList);
 			$sourceModule = array($firstElement->get('name'));
-		} else
-			$sourceModule = array($sourceModule);
+		} else {
+					$sourceModule = array($sourceModule);
+		}
 
 		$quickCreateContents = array();
 
-		if (in_array('Calendar', $sourceModule))
-			$sourceModule = array('Calendar', 'Events');
+		if (in_array('Calendar', $sourceModule)) {
+					$sourceModule = array('Calendar', 'Events');
+		}
 
 		foreach ($sourceModule as $module) {
 			$recordModel = Vtiger_Record_Model::getCleanInstance($module);

modules/Settings/OSSPasswords/views/ConfigurePass.php

Braces +5 added lines, -4 removed lines

@@ -237,10 +237,11 @@
 		$viewer->assign('MODULENAME', $moduleName);
 		$viewer->assign('SAVE', 'Save');
 		$viewer->assign('CANCEL', 'Cancel');
-		if (\vtlib\Functions::userIsAdministrator($current_user))
-			$viewer->assign('ISADMIN', 1);
-		else
-			$viewer->assign('ISADMIN', 0);
+		if (\vtlib\Functions::userIsAdministrator($current_user)) {
+					$viewer->assign('ISADMIN', 1);
+		} else {
+					$viewer->assign('ISADMIN', 0);
+		}
 
 		// encryption variables
 		$viewer->assign('CONFIG', (!$config ? false : array('key' => $config['key'])));

modules/Vtiger/CRMEntity.php

Braces +11 added lines, -8 removed lines

@@ -52,8 +52,9 @@ 
 		$query = "SELECT vtiger_crmentity.*, $this->table_name.*";
 
 		// Select Custom Field Table Columns if present
-		if (!empty($this->customFieldTable))
-			$query .= ", " . $this->customFieldTable[0] . ".* ";
+		if (!empty($this->customFieldTable)) {
+					$query .= ", " . $this->customFieldTable[0] . ".* ";
+		}
 
 		$query .= " FROM $this->table_name";
 
@@ -180,10 +181,11 @@ 
 		$query .= $this->getNonAdminAccessControlQuery($thismodule, $current_user);
 		$where_auto = " vtiger_crmentity.deleted=0";
 
-		if ($where != '')
-			$query .= " WHERE ($where) && $where_auto";
-		else
-			$query .= " WHERE $where_auto";
+		if ($where != '') {
+					$query .= " WHERE ($where) && $where_auto";
+		} else {
+					$query .= " WHERE $where_auto";
+		}
 
 		return $query;
 	}
@@ -196,8 +198,9 @@ 
 		$select_clause = sprintf("SELECT %s.%s AS recordid, vtiger_users_last_import.deleted,%s", $this->table_name, $this->table_index, $table_cols);
 
 		// Select Custom Field Table Columns if present
-		if (isset($this->customFieldTable))
-			$query .= ", " . $this->customFieldTable[0] . ".* ";
+		if (isset($this->customFieldTable)) {
+					$query .= ", " . $this->customFieldTable[0] . ".* ";
+		}
 
 		$from_clause = " FROM $this->table_name";
 

modules/Vtiger/actions/TransferOwnership.php

Braces +5 added lines, -4 removed lines

@@ -22,10 +22,11 @@
 		$modelClassName = Vtiger_Loader::getComponentClassName('Model', 'TransferOwnership', $module);
 		$transferModel = new $modelClassName();
 
-		if (empty($record))
-			$recordIds = $this->getBaseModuleRecordIds($request);
-		else
-			$recordIds = [$record];
+		if (empty($record)) {
+					$recordIds = $this->getBaseModuleRecordIds($request);
+		} else {
+					$recordIds = [$record];
+		}
 		if (!empty($recordIds)) {
 			$transferModel->transferRecordsOwnership($module, $transferOwnerId, $recordIds);
 		}

modules/Vtiger/models/DetailView.php

Spacing +1 added lines, -1 removed lines

@@ -144,7 +144,7 @@
 			$linkModelList['DETAILVIEW'][] = Vtiger_Link_Model::getInstanceFromValues($editViewLinks);
 		}
 
-		if (($recordModel->isEditable() && $recordModel->editFieldByModalPermission() ) || $recordModel->editFieldByModalPermission(true)) {
+		if (($recordModel->isEditable() && $recordModel->editFieldByModalPermission()) || $recordModel->editFieldByModalPermission(true)) {
 			$fieldByEditData = $recordModel->getFieldToEditByModal();
 			$basicActionLink = [
 				'linktype' => 'DETAILVIEW',

Doc Comments +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
 
 	/**
 	 * Function to get Module instance
-	 * @return Vtiger_Module_Model
+	 * @return boolean
 	 */
 	public function getModule()
 	{

Braces +3 added lines, -2 removed lines

@@ -306,8 +306,9 @@
 	 */
 	public function getWidgets()
 	{
-		if (count($this->widgetsList) > 0)
-			return;
+		if (count($this->widgetsList) > 0) {
+					return;
+		}
 		$moduleModel = $this->getModule();
 		$module = $this->getModuleName();
 		$record = $this->getRecord()->getId();