YetiForceCompany / YetiForceCRM

vtlib/Vtiger/Unzip.php

Braces +34 added lines, -22 removed lines

@@ -25,8 +25,9 @@ 
 	public function __checkPathInArray($path, $pathArray)
 	{
 		foreach ($pathArray as $checkPath) {
-			if (strpos($path, $checkPath) === 0)
-				return true;
+			if (strpos($path, $checkPath) === 0) {
+							return true;
+			}
 		}
 		return false;
 	}
@@ -37,8 +38,9 @@ 
 	 */
 	public function isdir($filepath)
 	{
-		if (substr($filepath, -1, 1) == "/")
-			return true;
+		if (substr($filepath, -1, 1) == "/") {
+					return true;
+		}
 		return false;
 	}
 
@@ -53,11 +55,13 @@ 
 		// We want to always maintain the structure
 		$maintainStructure = true;
 
-		if ($targetDir === false)
-			$targetDir = dirname(__FILE__) . "/";
+		if ($targetDir === false) {
+					$targetDir = dirname(__FILE__) . "/";
+		}
 
-		if ($renamePaths === false)
-			$renamePaths = [];
+		if ($renamePaths === false) {
+					$renamePaths = [];
+		}
 
 		/*
 		 * Setup includeExclude parameter
@@ -70,17 +74,19 @@ 
 		 * DEFAULT: If include is specified only files under the specified path will be included.
 		 * If exclude is specified folders or files will be excluded.
 		 */
-		if ($includeExclude === false)
-			$includeExclude = [];
+		if ($includeExclude === false) {
+					$includeExclude = [];
+		}
 
 		$lista = $this->getList();
-		if (sizeof($lista))
-			foreach ($lista as $fileName => $trash) {
+		if (sizeof($lista)) {
+					foreach ($lista as $fileName => $trash) {
 				// Should the file be ignored?
 				if ($includeExclude['include'] &&
 					!$this->__checkPathInArray($fileName, $includeExclude['include'])) {
 					// Do not include something not specified in include
 					continue;
+		}
 				}
 				if ($includeExclude['exclude'] &&
 					$this->__checkPathInArray($fileName, $includeExclude['exclude'])) {
@@ -104,8 +110,9 @@ 
 
 				$outDN = "$targetDir/$dirname";
 
-				if (substr($dirname, 0, strlen($baseDir)) != $baseDir)
-					continue;
+				if (substr($dirname, 0, strlen($baseDir)) != $baseDir) {
+									continue;
+				}
 
 				if (!is_dir($outDN) && $maintainStructure) {
 					$str = '';
@@ -115,16 +122,20 @@ 
 						if (!is_dir("$targetDir/$str")) {
 							$this->debugMsg(1, "Creating folder: $targetDir/$str");
 							mkdir("$targetDir/$str");
-							if ($applyChmod)
-								@chmod("$targetDir/$str", $applyChmod);
+							if ($applyChmod) {
+															@chmod("$targetDir/$str", $applyChmod);
+							}
 						}
 					}
 				}
-				if (substr($fileName, -1, 1) == '/')
-					continue;
+				if (substr($fileName, -1, 1) == '/') {
+									continue;
+				}
 
-				if (substr($fileName, -3) == '.sh')
-					$applyChmod = 0775; // Script executable.
+				if (substr($fileName, -3) == '.sh') {
+									$applyChmod = 0775;
+				}
+				// Script executable.
 				$this->unzip($fileName, "$targetDir/$dirname/" . basename($fileName), $applyChmod);
 			}
 	}
@@ -138,8 +149,9 @@ 
 	{
 		$fileList = $this->getList();
 		foreach ($fileList as $file => $details) {
-			if ($fileName === $file)
-				return true;
+			if ($fileName === $file) {
+							return true;
+			}
 		}
 		return false;
 	}

vtlib/Vtiger/ThemeImport.php

Braces +6 added lines, -4 removed lines

@@ -78,8 +78,9 @@ 
 		foreach ($filelist as $filename => $fileinfo) {
 			if (!$unzip->isdir($filename)) {
 
-				if (strpos($filename, '/') === false)
-					continue;
+				if (strpos($filename, '/') === false) {
+									continue;
+				}
 
 
 				$targetdir = substr($filename, 0, strripos($filename, '/'));
@@ -107,8 +108,9 @@ 
 				}
 			}
 		}
-		if ($unzip)
-			$unzip->close();
+		if ($unzip) {
+					$unzip->close();
+		}
 
 		self::register($label, $name, $parent);
 

Doc Comments +1 added lines

@@ -28,6 +28,7 @@
 	/**
 	 * Initialize Import
 	 * @access private
+	 * @param boolean $overwrite
 	 */
 	public function initImport($zipfile, $overwrite)
 	{

vtlib/Vtiger/LanguageImport.php

Braces +6 added lines, -4 removed lines

@@ -84,8 +84,9 @@ 
 		foreach ($filelist as $filename => $fileinfo) {
 			if (!$unzip->isdir($filename)) {
 
-				if (strpos($filename, '/') === false)
-					continue;
+				if (strpos($filename, '/') === false) {
+									continue;
+				}
 
 				$targetdir = substr($filename, 0, strripos($filename, '/'));
 				$targetfile = basename($filename);
@@ -146,8 +147,9 @@ 
 				}
 			}
 		}
-		if ($unzip)
-			$unzip->close();
+		if ($unzip) {
+					$unzip->close();
+		}
 
 		self::register($prefix, $label, $name);
 

modules/WSAPP/WorkFlowHandlers/WSAPPAssignToTracker.php

Spacing +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@ 
 		//END
 
 		$recordId = $entityData->getId();
-		$vtEntityDelta = new VTEntityDelta ();
+		$vtEntityDelta = new VTEntityDelta();
 		$newEntityData = $vtEntityDelta->getNewEntity($moduleName, $recordId);
 		$recordValues = $newEntityData->getData();
 		$isAssignToModified = $this->isAssignToChanged($moduleName, $recordId, $current_user);
@@ -60,7 +60,7 @@ 
 		$meta = $handler->getMeta();
 		$moduleOwnerFields = $meta->getOwnerFields();
 		$assignToChanged = false;
-		$vtEntityDelta = new VTEntityDelta ();
+		$vtEntityDelta = new VTEntityDelta();
 		foreach ($moduleOwnerFields as $ownerField) {
 			$assignToChanged = $vtEntityDelta->hasChanged($moduleName, $recordId, $ownerField);
 			if ($assignToChanged)

Braces +6 added lines, -4 removed lines

@@ -62,8 +62,9 @@ 
 		$vtEntityDelta = new VTEntityDelta ();
 		foreach ($moduleOwnerFields as $ownerField) {
 			$assignToChanged = $vtEntityDelta->hasChanged($moduleName, $recordId, $ownerField);
-			if ($assignToChanged)
-				break;
+			if ($assignToChanged) {
+							break;
+			}
 		}
 		return $assignToChanged;
 	}
@@ -71,8 +72,9 @@ 
 	public function getWsModuleName($workFlowModuleName)
 	{
 		$wsModuleName = $workFlowModuleName;
-		if ($workFlowModuleName == "Activity")
-			$wsModuleName = "Calendar";
+		if ($workFlowModuleName == "Activity") {
+					$wsModuleName = "Calendar";
+		}
 		return $wsModuleName;
 	}
 }

modules/WSAPP/Utils.php

Braces +25 added lines, -17 removed lines

@@ -42,15 +42,19 @@ 
 	$entityMetaList = array();
 	$db = PearDatabase::getInstance();
 
-	if (empty($entityNames))
-		return;
-
-	if (!is_array($entityNames))
-		$entityNames = array($entityNames);
-	if (empty($modules))
-		return array();
-	if (!is_array($modules))
-		$modules = array($modules);
+	if (empty($entityNames)) {
+			return;
+	}
+
+	if (!is_array($entityNames)) {
+			$entityNames = array($entityNames);
+	}
+	if (empty($modules)) {
+			return array();
+	}
+	if (!is_array($modules)) {
+			$modules = array($modules);
+	}
 	$entityNameIds = array();
 	foreach ($modules as $moduleName) {
 		if (empty($entityMetaList[$moduleName])) {
@@ -62,8 +66,9 @@ 
 		$nameFieldsArray = explode(",", $meta->getNameFields());
 		if (count($nameFieldsArray) > 1) {
 			$nameFields = "concat(" . implode(",' ',", $nameFieldsArray) . ")";
-		} else
-			$nameFields = $nameFieldsArray[0];
+		} else {
+					$nameFields = $nameFieldsArray[0];
+		}
 
 		$query = sprintf("SELECT %s as id,%s as entityname 
 				FROM %s as moduleentity 
@@ -102,12 +107,15 @@ 
 function wsapp_checkIfRecordsAssignToUser($recordsIds, $userIds)
 {
 	$assignedRecordIds = [];
-	if (!is_array($recordsIds))
-		$recordsIds = [$recordsIds];
-	if (count($recordsIds) <= 0)
-		return $assignedRecordIds;
-	if (!is_array($userIds))
-		$userIds = [$userIds];
+	if (!is_array($recordsIds)) {
+			$recordsIds = [$recordsIds];
+	}
+	if (count($recordsIds) <= 0) {
+			return $assignedRecordIds;
+	}
+	if (!is_array($userIds)) {
+			$userIds = [$userIds];
+	}
 	$db = PearDatabase::getInstance();
 	$query = sprintf("SELECT * FROM vtiger_crmentity where crmid IN (%s) and smownerid in (%s)", generateQuestionMarks($recordsIds), generateQuestionMarks($userIds));
 	$params = [];

Doc Comments +8 added lines

@@ -126,6 +126,9 @@ 
 	return $assignedRecordIds;
 }
 
+/**
+ * @param string $appName
+ */
 function wsapp_getAppKey($appName)
 {
 	$db = PearDatabase::getInstance();
@@ -152,6 +155,11 @@ 
 	return $syncType;
 }
 
+/**
+ * @param string $type
+ * @param string $handlerClass
+ * @param string $handlerPath
+ */
 function wsapp_RegisterHandler($type, $handlerClass, $handlerPath)
 {
 	$db = PearDatabase::getInstance();

modules/WSAPP/OutlookSyncServer.php

Braces +17 added lines, -12 removed lines

@@ -38,10 +38,11 @@ 
 			throw new WebServiceException('WSAPP04', "Access restricted to app");
 		}
 
-		if (!is_array($element))
-			$records = array($element);
-		else
-			$records = $element;
+		if (!is_array($element)) {
+					$records = array($element);
+		} else {
+					$records = $element;
+		}
 
 		//hardcoded since the destination handler will be vtigerCRM
 		$serverKey = wsapp_getAppKey("vtigerCRM");
@@ -64,16 +65,18 @@ 
 			$clientRecordId = $record['id'];
 
 			// Missing client record id?
-			if (empty($clientRecordId))
-				continue;
+			if (empty($clientRecordId)) {
+							continue;
+			}
 
 			$lookupRecordId = false;
 			// Added for Duplication handling
 			if (!empty($record['crmid'])) {
 				$crmid = vtws_getIdComponents($record['crmid']);
 				$lookupResult = $db->pquery("SELECT crmid,modifiedtime FROM vtiger_crmentity WHERE crmid=?", array($crmid[1]));
-				if ($db->num_rows($lookupResult))
-					$lookupRecordId = $record['crmid'];
+				if ($db->num_rows($lookupResult)) {
+									$lookupRecordId = $record['crmid'];
+				}
 				if (!(empty($lookupRecordId))) {
 					$clientLastModifiedTime = $db->query_result($lookupResult, 0, 'modifiedtime');
 					$record['values']['id'] = $lookupRecordId;
@@ -86,8 +89,9 @@ 
 			// End
 			else {
 				$lookupResult = $db->pquery("SELECT serverid,clientmodifiedtime FROM vtiger_wsapp_recordmapping WHERE appid=? && clientid=?", array($appid, $clientRecordId));
-				if ($db->num_rows($lookupResult))
-					$lookupRecordId = $db->query_result($lookupResult, 0, 'serverid');
+				if ($db->num_rows($lookupResult)) {
+									$lookupRecordId = $db->query_result($lookupResult, 0, 'serverid');
+				}
 				if (empty($lookupRecordId) && $record['mode'] != "delete") {
 					$createRecords[$clientRecordId] = $record['values'];
 					$createRecords[$clientRecordId]['module'] = $record['module'];
@@ -97,8 +101,9 @@ 
 						$deleteRecords[$clientRecordId] = $lookupRecordId;
 					} else if (!(empty($lookupRecordId))) {
 						$clientLastModifiedTime = $db->query_result($lookupResult, 0, 'clientmodifiedtime');
-						if ($clientLastModifiedTime >= $record['values']['modifiedtime'])
-							continue;
+						if ($clientLastModifiedTime >= $record['values']['modifiedtime']) {
+													continue;
+						}
 						$record['values']['id'] = $lookupRecordId;
 						$updateRecords[$clientRecordId] = $record['values'];
 						$updateRecords[$clientRecordId]['module'] = $record['module'];

modules/WSAPP/WSAPP.php

Braces +3 added lines, -2 removed lines

@@ -124,8 +124,9 @@
 		$appTypehandler['handlerpath'] = "modules/WSAPP/Handlers/vtigerCRMHandler.php";
 		$handlerDetails[] = $appTypehandler;
 
-		foreach ($handlerDetails as $appHandlerDetails)
-			$adb->pquery("INSERT INTO vtiger_wsapp_handlerdetails VALUES(?,?,?)", array($appHandlerDetails['type'], $appHandlerDetails['handlerclass'], $appHandlerDetails['handlerpath']));
+		foreach ($handlerDetails as $appHandlerDetails) {
+					$adb->pquery("INSERT INTO vtiger_wsapp_handlerdetails VALUES(?,?,?)", array($appHandlerDetails['type'], $appHandlerDetails['handlerclass'], $appHandlerDetails['handlerpath']));
+		}
 	}
 
 	public function registerVtigerCRMApp()

modules/Assets/views/EditFieldByModal.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 		}
 		$showFields = array_keys($recordModel->getModule()->getQuickCreateFields());
 		$configureFields = AppConfig::module($moduleName, 'SHOW_FIELD_IN_MODAL');
-		if($configureFields){
+		if ($configureFields) {
 			$showFields = array_merge($showFields, $configureFields);
 		}
 

modules/Reports/views/Edit.php

Braces +3 added lines, -2 removed lines

@@ -97,8 +97,9 @@
 			$viewer->assign('MODE', 'edit');
 		} else {
 			$firstModuleName = reset($modulesList);
-			if ($firstModuleName)
-				$reportModel->setPrimaryModule($firstModuleName);
+			if ($firstModuleName) {
+							$reportModel->setPrimaryModule($firstModuleName);
+			}
 			$viewer->assign('MODE', '');
 		}