Completed
Pull Request — developer (#4001)
by Thom
542:26 queued 508:45
created
modules/ModComments/ModComments.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 
60 60
 	/**
61 61
 	 * Add widget to other module.
62
-	 * @param unknown_type $moduleNames
62
+	 * @param string[] $moduleNames
63 63
 	 * @return unknown_type
64 64
 	 */
65 65
 	static function addWidgetTo($moduleNames, $widgetType = 'DETAILVIEWWIDGET', $widgetName = 'DetailViewBlockCommentWidget')
Please login to merge, or discard this patch.
Braces   +12 added lines, -8 removed lines patch added patch discarded remove patch
@@ -64,11 +64,13 @@  discard block
 block discarded – undo
64 64
 	 */
65 65
 	static function addWidgetTo($moduleNames, $widgetType = 'DETAILVIEWWIDGET', $widgetName = 'DetailViewBlockCommentWidget')
66 66
 	{
67
-		if (empty($moduleNames))
68
-			return;
67
+		if (empty($moduleNames)) {
68
+					return;
69
+		}
69 70
 
70
-		if (is_string($moduleNames))
71
-			$moduleNames = array($moduleNames);
71
+		if (is_string($moduleNames)) {
72
+					$moduleNames = array($moduleNames);
73
+		}
72 74
 
73 75
 		$commentWidgetModules = array();
74 76
 		foreach ($moduleNames as $moduleName) {
@@ -95,11 +97,13 @@  discard block
 block discarded – undo
95 97
 	 */
96 98
 	static function removeWidgetFrom($moduleNames, $widgetType = 'DETAILVIEWWIDGET', $widgetName = 'DetailViewBlockCommentWidget')
97 99
 	{
98
-		if (empty($moduleNames))
99
-			return;
100
+		if (empty($moduleNames)) {
101
+					return;
102
+		}
100 103
 
101
-		if (is_string($moduleNames))
102
-			$moduleNames = array($moduleNames);
104
+		if (is_string($moduleNames)) {
105
+					$moduleNames = array($moduleNames);
106
+		}
103 107
 
104 108
 		$commentWidgetModules = array();
105 109
 		foreach ($moduleNames as $moduleName) {
Please login to merge, or discard this patch.
modules/OSSEmployees/OSSEmployees.php 2 patches
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -149,6 +149,10 @@  discard block
 block discarded – undo
149 149
 		return $hierarchy;
150 150
 	}
151 151
 
152
+	/**
153
+	 * @param integer $id
154
+	 * @param integer[] $encountered_accounts
155
+	 */
152 156
 	public function __getParentEmployees($id, &$parent_accounts, &$encountered_accounts)
153 157
 	{
154 158
 		$adb = PearDatabase::getInstance();
@@ -200,6 +204,9 @@  discard block
 block discarded – undo
200 204
 		return $parent_accounts;
201 205
 	}
202 206
 
207
+	/**
208
+	 * @param integer $id
209
+	 */
203 210
 	public function __getChildEmployees($id, &$child_accounts, $depth)
204 211
 	{
205 212
 		$adb = PearDatabase::getInstance();
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -257,8 +257,9 @@
 block discarded – undo
257 257
 			$modcommentsModuleInstance = vtlib\Module::getInstance('ModComments');
258 258
 			if ($modcommentsModuleInstance && file_exists('modules/ModComments/ModComments.php')) {
259 259
 				include_once 'modules/ModComments/ModComments.php';
260
-				if (class_exists('ModComments'))
261
-					ModComments::addWidgetTo(array('OSSEmployees'));
260
+				if (class_exists('ModComments')) {
261
+									ModComments::addWidgetTo(array('OSSEmployees'));
262
+				}
262 263
 			}
263 264
 		} else if ($event_type == 'module.disabled') {
264 265
 			
Please login to merge, or discard this patch.
modules/PaymentsIn/helpers/mt940.php 2 patches
Doc Comments   +15 added lines patch added patch discarded remove patch
@@ -50,6 +50,9 @@  discard block
 block discarded – undo
50 50
 		return $xml;
51 51
 	}
52 52
 
53
+	/**
54
+	 * @param integer $level
55
+	 */
53 56
 	protected function createXML($key, $value, $level)
54 57
 	{
55 58
 		$indent = '';
@@ -69,6 +72,9 @@  discard block
 block discarded – undo
69 72
 		return $xml;
70 73
 	}
71 74
 
75
+	/**
76
+	 * @param string $line
77
+	 */
72 78
 	protected function parseLine($line)
73 79
 	{
74 80
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -114,6 +120,9 @@  discard block
 block discarded – undo
114 120
 		$this->_lastTag = $tag;
115 121
 	}
116 122
 
123
+	/**
124
+	 * @param string $value
125
+	 */
117 126
 	protected function parseOperation($value)
118 127
 	{
119 128
 		$this->operations[] = array(
@@ -124,6 +133,9 @@  discard block
 block discarded – undo
124 133
 		);
125 134
 	}
126 135
 
136
+	/**
137
+	 * @param string $value
138
+	 */
127 139
 	protected function parseBalance($value)
128 140
 	{
129 141
 		return array(
@@ -134,6 +146,9 @@  discard block
 block discarded – undo
134 146
 		);
135 147
 	}
136 148
 
149
+	/**
150
+	 * @param string $value
151
+	 */
137 152
 	protected function parseTransaction($value)
138 153
 	{
139 154
 		$transaction = array(
Please login to merge, or discard this patch.
Braces   +19 added lines, -14 removed lines patch added patch discarded remove patch
@@ -34,8 +34,9 @@  discard block
 block discarded – undo
34 34
 	public function parse()
35 35
 	{
36 36
 		$tab = $this->prepareFile();
37
-		foreach ($tab as $line)
38
-			$this->parseLine($line);
37
+		foreach ($tab as $line) {
38
+					$this->parseLine($line);
39
+		}
39 40
 	}
40 41
 
41 42
 	public function getXML()
@@ -53,13 +54,15 @@  discard block
 block discarded – undo
53 54
 	protected function createXML($key, $value, $level)
54 55
 	{
55 56
 		$indent = '';
56
-		for ($i = 0; $i <= $level; $i++)
57
-			$indent .= "\t";
57
+		for ($i = 0; $i <= $level; $i++) {
58
+					$indent .= "\t";
59
+		}
58 60
 		if (is_array($value)) {
59 61
 			$xml = "$indent<$key>\n";
60 62
 			foreach ($value as $subKey => $subVal) {
61
-				if (is_numeric($subKey))
62
-					$subKey = substr($key, 0, -1);
63
+				if (is_numeric($subKey)) {
64
+									$subKey = substr($key, 0, -1);
65
+				}
63 66
 				$xml .= $this->createXML($subKey, $subVal, $level + 1);
64 67
 			}
65 68
 			$xml .= "$indent</$key>\n";
@@ -85,10 +88,11 @@  discard block
 block discarded – undo
85 88
 				break;
86 89
 			case 'NS':
87 90
 				$code = substr($value, 0, 2);
88
-				if ($code == '22')
89
-					$this->ownerName = substr($value, 2);
90
-				else if ($code == '23')
91
-					$this->accountName = substr($value, 2);
91
+				if ($code == '22') {
92
+									$this->ownerName = substr($value, 2);
93
+				} else if ($code == '23') {
94
+									$this->accountName = substr($value, 2);
95
+				}
92 96
 				break;
93 97
 			case '60F':
94 98
 				$this->openBalance = $this->parseBalance($value);
@@ -103,10 +107,11 @@  discard block
 block discarded – undo
103 107
 				self::parseOperation($value);
104 108
 				break;
105 109
 			case '86':
106
-				if ($this->_lastTag == '61')
107
-					$this->parseTransaction($value);
108
-				else
109
-					$this->info .= $value;
110
+				if ($this->_lastTag == '61') {
111
+									$this->parseTransaction($value);
112
+				} else {
113
+									$this->info .= $value;
114
+				}
110 115
 				break;
111 116
 			default:
112 117
 				break;
Please login to merge, or discard this patch.
modules/PaymentsIn/helpers/subclass/mt940_Alior.php 2 patches
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -20,6 +20,9 @@  discard block
 block discarded – undo
20 20
 			$this->parseLine($line);
21 21
 	}
22 22
 
23
+	/**
24
+	 * @param string $line
25
+	 */
23 26
 	protected function parseLine($line)
24 27
 	{
25 28
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -65,6 +68,9 @@  discard block
 block discarded – undo
65 68
 		$this->_lastTag = $tag;
66 69
 	}
67 70
 
71
+	/**
72
+	 * @param string $value
73
+	 */
68 74
 	protected function parseTransaction($value)
69 75
 	{
70 76
 		$transaction = array(
@@ -129,6 +135,9 @@  discard block
 block discarded – undo
129 135
 		$this->operations[count($this->operations) - 1]['details'] = $transaction;
130 136
 	}
131 137
 
138
+	/**
139
+	 * @param string $value
140
+	 */
132 141
 	protected function parseOperation($value)
133 142
 	{
134 143
 		$this->operations[] = array(
Please login to merge, or discard this patch.
Braces   +13 added lines, -10 removed lines patch added patch discarded remove patch
@@ -16,8 +16,9 @@  discard block
 block discarded – undo
16 16
 	public function parse()
17 17
 	{
18 18
 		$tab = $this->prepareFile();
19
-		foreach ($tab as $line)
20
-			$this->parseLine($line);
19
+		foreach ($tab as $line) {
20
+					$this->parseLine($line);
21
+		}
21 22
 	}
22 23
 
23 24
 	protected function parseLine($line)
@@ -36,10 +37,11 @@  discard block
 block discarded – undo
36 37
 				break;
37 38
 			case 'NS':
38 39
 				$code = substr($value, 0, 2);
39
-				if ($code == '22')
40
-					$this->ownerName = substr($value, 2);
41
-				else if ($code == '23')
42
-					$this->accountName = substr($value, 2);
40
+				if ($code == '22') {
41
+									$this->ownerName = substr($value, 2);
42
+				} else if ($code == '23') {
43
+									$this->accountName = substr($value, 2);
44
+				}
43 45
 				break;
44 46
 			case '60F':
45 47
 				$this->openBalance = $this->parseBalance($value);
@@ -54,10 +56,11 @@  discard block
 block discarded – undo
54 56
 				self::parseOperation($value);
55 57
 				break;
56 58
 			case '86':
57
-				if ($this->_lastTag == '61')
58
-					$this->parseTransaction($value);
59
-				else
60
-					$this->info .= $value;
59
+				if ($this->_lastTag == '61') {
60
+									$this->parseTransaction($value);
61
+				} else {
62
+									$this->info .= $value;
63
+				}
61 64
 				break;
62 65
 			default:
63 66
 				break;
Please login to merge, or discard this patch.
modules/PaymentsIn/helpers/subclass/mt940_BGK.php 2 patches
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -20,6 +20,9 @@  discard block
 block discarded – undo
20 20
 			$this->parseLine($line);
21 21
 	}
22 22
 
23
+	/**
24
+	 * @param string $line
25
+	 */
23 26
 	protected function parseLine($line)
24 27
 	{
25 28
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -66,6 +69,9 @@  discard block
 block discarded – undo
66 69
 			$this->_lastTag = $tag;
67 70
 	}
68 71
 
72
+	/**
73
+	 * @param string $value
74
+	 */
69 75
 	protected function parseTransaction($value)
70 76
 	{
71 77
 		$transaction = array(
@@ -84,6 +90,9 @@  discard block
 block discarded – undo
84 90
 		$this->operations[count($this->operations) - 1]['details'] = $transaction;
85 91
 	}
86 92
 
93
+	/**
94
+	 * @param string $value
95
+	 */
87 96
 	protected function parseOperation($value)
88 97
 	{
89 98
 		$this->operations[] = array(
Please login to merge, or discard this patch.
Braces   +11 added lines, -8 removed lines patch added patch discarded remove patch
@@ -16,8 +16,9 @@  discard block
 block discarded – undo
16 16
 	public function parse()
17 17
 	{
18 18
 		$tab = $this->prepareFile();
19
-		foreach ($tab as $line)
20
-			$this->parseLine($line);
19
+		foreach ($tab as $line) {
20
+					$this->parseLine($line);
21
+		}
21 22
 	}
22 23
 
23 24
 	protected function parseLine($line)
@@ -36,10 +37,11 @@  discard block
 block discarded – undo
36 37
 				break;
37 38
 			case 'NS':
38 39
 				$code = substr($value, 0, 2);
39
-				if ($code == '22')
40
-					$this->ownerName = substr($value, 2);
41
-				else if ($code == '23')
42
-					$this->accountName = substr($value, 2);
40
+				if ($code == '22') {
41
+									$this->ownerName = substr($value, 2);
42
+				} else if ($code == '23') {
43
+									$this->accountName = substr($value, 2);
44
+				}
43 45
 				break;
44 46
 			case '60F':
45 47
 				$this->openBalance = $this->parseBalance($value);
@@ -62,8 +64,9 @@  discard block
 block discarded – undo
62 64
 			default:
63 65
 				break;
64 66
 		}
65
-		if ($tag)
66
-			$this->_lastTag = $tag;
67
+		if ($tag) {
68
+					$this->_lastTag = $tag;
69
+		}
67 70
 	}
68 71
 
69 72
 	protected function parseTransaction($value)
Please login to merge, or discard this patch.
modules/PaymentsIn/helpers/subclass/mt940_Citi.php 2 patches
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -20,6 +20,9 @@  discard block
 block discarded – undo
20 20
 			$this->parseLine($line);
21 21
 	}
22 22
 
23
+	/**
24
+	 * @param string $line
25
+	 */
23 26
 	protected function parseLine($line)
24 27
 	{
25 28
 
@@ -68,6 +71,9 @@  discard block
 block discarded – undo
68 71
 			$this->_lastTag = $tag;
69 72
 	}
70 73
 
74
+	/**
75
+	 * @param string $value
76
+	 */
71 77
 	protected function parseTransaction($value)
72 78
 	{
73 79
 		$transaction = array(
@@ -113,6 +119,9 @@  discard block
 block discarded – undo
113 119
 		$this->operations[count($this->operations) - 1]['details'] = $transaction;
114 120
 	}
115 121
 
122
+	/**
123
+	 * @param string $value
124
+	 */
116 125
 	protected function parseOperation($value)
117 126
 	{
118 127
 		$this->operations[] = array(
Please login to merge, or discard this patch.
Braces   +16 added lines, -12 removed lines patch added patch discarded remove patch
@@ -18,8 +18,9 @@  discard block
 block discarded – undo
18 18
 	public function parse()
19 19
 	{
20 20
 		$tab = $this->prepareFile();
21
-		foreach ($tab as $line)
22
-			$this->parseLine($line);
21
+		foreach ($tab as $line) {
22
+					$this->parseLine($line);
23
+		}
23 24
 	}
24 25
 
25 26
 	protected function parseLine($line)
@@ -38,10 +39,11 @@  discard block
 block discarded – undo
38 39
 				break;
39 40
 			case 'NS':
40 41
 				$code = substr($value, 0, 2);
41
-				if ($code == '22')
42
-					$this->ownerName = substr($value, 2);
43
-				else if ($code == '23')
44
-					$this->accountName = substr($value, 2);
42
+				if ($code == '22') {
43
+									$this->ownerName = substr($value, 2);
44
+				} else if ($code == '23') {
45
+									$this->accountName = substr($value, 2);
46
+				}
45 47
 				break;
46 48
 			case '60F':
47 49
 				$this->openBalance = $this->parseBalance($value);
@@ -56,16 +58,18 @@  discard block
 block discarded – undo
56 58
 				self::parseOperation($value);
57 59
 				break;
58 60
 			case '86':
59
-				if ($this->_lastTag == '61')
60
-					$this->parseTransaction($value);
61
-				else
62
-					$this->info .= $value;
61
+				if ($this->_lastTag == '61') {
62
+									$this->parseTransaction($value);
63
+				} else {
64
+									$this->info .= $value;
65
+				}
63 66
 				break;
64 67
 			default:
65 68
 				break;
66 69
 		}
67
-		if ($tag)
68
-			$this->_lastTag = $tag;
70
+		if ($tag) {
71
+					$this->_lastTag = $tag;
72
+		}
69 73
 	}
70 74
 
71 75
 	protected function parseTransaction($value)
Please login to merge, or discard this patch.
modules/PaymentsIn/helpers/subclass/mt940_ing.php 2 patches
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -22,6 +22,9 @@  discard block
 block discarded – undo
22 22
 			$this->parseLine($line);
23 23
 	}
24 24
 
25
+	/**
26
+	 * @param string $line
27
+	 */
25 28
 	protected function parseLine($line)
26 29
 	{
27 30
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -68,6 +71,9 @@  discard block
 block discarded – undo
68 71
 		$this->_lastTag = $tag;
69 72
 	}
70 73
 
74
+	/**
75
+	 * @param string $value
76
+	 */
71 77
 	protected function parseTransaction($value)
72 78
 	{
73 79
 		$transaction = array(
@@ -124,6 +130,9 @@  discard block
 block discarded – undo
124 130
 		$this->operations[count($this->operations) - 1]['details'] = $transaction;
125 131
 	}
126 132
 
133
+	/**
134
+	 * @param string $value
135
+	 */
127 136
 	protected function parseOperation($value)
128 137
 	{
129 138
 		if (substr($value, 15, 4) != 'S940') {
Please login to merge, or discard this patch.
Braces   +16 added lines, -12 removed lines patch added patch discarded remove patch
@@ -18,8 +18,9 @@  discard block
 block discarded – undo
18 18
 	public function parse()
19 19
 	{
20 20
 		$tab = $this->prepareFile();
21
-		foreach ($tab as $line)
22
-			$this->parseLine($line);
21
+		foreach ($tab as $line) {
22
+					$this->parseLine($line);
23
+		}
23 24
 	}
24 25
 
25 26
 	protected function parseLine($line)
@@ -38,10 +39,11 @@  discard block
 block discarded – undo
38 39
 				break;
39 40
 			case 'NS':
40 41
 				$code = substr($value, 0, 2);
41
-				if ($code == '22')
42
-					$this->ownerName = substr($value, 2);
43
-				else if ($code == '23')
44
-					$this->accountName = substr($value, 2);
42
+				if ($code == '22') {
43
+									$this->ownerName = substr($value, 2);
44
+				} else if ($code == '23') {
45
+									$this->accountName = substr($value, 2);
46
+				}
45 47
 				break;
46 48
 			case '60F':
47 49
 				$this->openBalance = $this->parseBalance($value);
@@ -56,10 +58,11 @@  discard block
 block discarded – undo
56 58
 				self::parseOperation($value);
57 59
 				break;
58 60
 			case '86':
59
-				if ($this->_lastTag == '86')
60
-					$this->parseTransaction($value);
61
-				else
62
-					$this->info .= $value;
61
+				if ($this->_lastTag == '86') {
62
+									$this->parseTransaction($value);
63
+				} else {
64
+									$this->info .= $value;
65
+				}
63 66
 				$this->lastLine = $value;
64 67
 				break;
65 68
 			default:
@@ -79,8 +82,9 @@  discard block
 block discarded – undo
79 82
 			'contAccount' => '',
80 83
 			'currancy' => ''
81 84
 		);
82
-		if ($transaction['code'] == '940')
83
-			return;
85
+		if ($transaction['code'] == '940') {
86
+					return;
87
+		}
84 88
 		$delimiter = substr($value, 3, 1);
85 89
 		$transaction['currancy'] = substr($this->lastLine, 9, 3);
86 90
 		$transaction['currancyAmount'] = substr($this->lastLine, 12, 14);
Please login to merge, or discard this patch.
modules/PaymentsIn/helpers/subclass/mt940_Milenium.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -20,6 +20,9 @@  discard block
 block discarded – undo
20 20
 			$this->parseLine($line);
21 21
 	}
22 22
 
23
+	/**
24
+	 * @param string $line
25
+	 */
23 26
 	protected function parseLine($line)
24 27
 	{
25 28
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -65,6 +68,9 @@  discard block
 block discarded – undo
65 68
 		$this->_lastTag = $tag;
66 69
 	}
67 70
 
71
+	/**
72
+	 * @param string $value
73
+	 */
68 74
 	protected function parseOperation($value)
69 75
 	{
70 76
 		$this->operations[] = array(
Please login to merge, or discard this patch.
Braces   +13 added lines, -10 removed lines patch added patch discarded remove patch
@@ -16,8 +16,9 @@  discard block
 block discarded – undo
16 16
 	public function parse()
17 17
 	{
18 18
 		$tab = $this->prepareFile();
19
-		foreach ($tab as $line)
20
-			$this->parseLine($line);
19
+		foreach ($tab as $line) {
20
+					$this->parseLine($line);
21
+		}
21 22
 	}
22 23
 
23 24
 	protected function parseLine($line)
@@ -36,10 +37,11 @@  discard block
 block discarded – undo
36 37
 				break;
37 38
 			case 'NS':
38 39
 				$code = substr($value, 0, 2);
39
-				if ($code == '22')
40
-					$this->ownerName = substr($value, 2);
41
-				else if ($code == '23')
42
-					$this->accountName = substr($value, 2);
40
+				if ($code == '22') {
41
+									$this->ownerName = substr($value, 2);
42
+				} else if ($code == '23') {
43
+									$this->accountName = substr($value, 2);
44
+				}
43 45
 				break;
44 46
 			case '60F':
45 47
 				$this->openBalance = $this->parseBalance($value);
@@ -54,10 +56,11 @@  discard block
 block discarded – undo
54 56
 				self::parseOperation($value);
55 57
 				break;
56 58
 			case '86':
57
-				if ($this->_lastTag == '61')
58
-					$this->parseTransaction($value);
59
-				else
60
-					$this->info .= $value;
59
+				if ($this->_lastTag == '61') {
60
+									$this->parseTransaction($value);
61
+				} else {
62
+									$this->info .= $value;
63
+				}
61 64
 				break;
62 65
 			default:
63 66
 				break;
Please login to merge, or discard this patch.
modules/PBXManager/actions/IncomingCallPoll.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -136,6 +136,9 @@
 block discarded – undo
136 136
 		$response->emit();
137 137
 	}
138 138
 
139
+	/**
140
+	 * @param Vtiger_Request $request
141
+	 */
139 142
 	public function updateCustomerInPhoneCalls($customer, $request)
140 143
 	{
141 144
 		$id = vtws_getIdComponents($customer['id']);
Please login to merge, or discard this patch.