Completed
Pull Request — developer (#4001)
by Thom
542:26 queued 508:45
created
modules/Settings/MappedFields/views/Edit.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -30,6 +30,9 @@
 block discarded – undo
30 30
 		$viewer->view('EditHeader.tpl', $request->getModule(false));
31 31
 	}
32 32
 
33
+	/**
34
+	 * @param string $step
35
+	 */
33 36
 	public function step($step, Vtiger_Request $request)
34 37
 	{
35 38
 		$viewer = $this->getViewer($request);
Please login to merge, or discard this patch.
modules/Settings/PBXManager/models/Module.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
 	/**
15 15
 	 * Function to get the module model
16
-	 * @return string
16
+	 * @return Settings_PBXManager_Module_Model
17 17
 	 */
18 18
 	public static function getCleanInstance()
19 19
 	{
Please login to merge, or discard this patch.
modules/Settings/Picklist/models/Module.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -17,6 +17,9 @@
 block discarded – undo
17 17
 		return 'vtiger_' . $fieldName;
18 18
 	}
19 19
 
20
+	/**
21
+	 * @param string[] $type
22
+	 */
20 23
 	public function getFieldsByType($type)
21 24
 	{
22 25
 		$presence = array('0', '2');
Please login to merge, or discard this patch.
modules/Settings/SharingAccess/models/Rule.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
 
258 258
 	/**
259 259
 	 * Function to get the detailViewUrl for the rule member in Sharing Access Custom Rules
260
-	 * @return DetailViewUrl
260
+	 * @return string|null
261 261
 	 */
262 262
 	public function getSourceDetailViewUrl()
263 263
 	{
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 
278 278
 	/**
279 279
 	 * Function to get the detailViewUrl for the rule member in Sharing Access Custom Rules
280
-	 * @return DetailViewUrl
280
+	 * @return string|null
281 281
 	 */
282 282
 	public function getTargetDetailViewUrl()
283 283
 	{
Please login to merge, or discard this patch.
modules/Settings/SharingAccess/models/RuleMember.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -80,6 +80,9 @@
 block discarded – undo
80 80
 		return $type . ':' . $id;
81 81
 	}
82 82
 
83
+	/**
84
+	 * @param string $qualifiedId
85
+	 */
83 86
 	public static function getInstance($qualifiedId)
84 87
 	{
85 88
 		$db = PearDatabase::getInstance();
Please login to merge, or discard this patch.
modules/Settings/Vtiger/models/ConfigModule.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 
30 30
 	/**
31 31
 	 * Function to get CompanyDetails Menu item
32
-	 * @return menu item Model
32
+	 * @return Settings_Vtiger_MenuItem_Model item Model
33 33
 	 */
34 34
 	public function getMenuItem()
35 35
 	{
Please login to merge, or discard this patch.
modules/Settings/Workflows/models/TaskRecord.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -93,6 +93,9 @@  discard block
 block discarded – undo
93 93
 		return $this->task_type;
94 94
 	}
95 95
 
96
+	/**
97
+	 * @param Settings_Workflows_Record_Model $workflowModel
98
+	 */
96 99
 	public static function getAllForWorkflow($workflowModel, $active = false)
97 100
 	{
98 101
 		$db = PearDatabase::getInstance();
@@ -119,6 +122,9 @@  discard block
 block discarded – undo
119 122
 		return self::getInstanceFromTaskObject($task, $workflowModel, $tm);
120 123
 	}
121 124
 
125
+	/**
126
+	 * @param Settings_Workflows_Record_Model $workflowModel
127
+	 */
122 128
 	public static function getCleanInstance($workflowModel, $taskName)
123 129
 	{
124 130
 		$db = PearDatabase::getInstance();
@@ -127,6 +133,9 @@  discard block
 block discarded – undo
127 133
 		return self::getInstanceFromTaskObject($task, $workflowModel, $tm);
128 134
 	}
129 135
 
136
+	/**
137
+	 * @param VTTaskManager $tm
138
+	 */
130 139
 	public static function getInstanceFromTaskObject($task, $workflowModel, $tm)
131 140
 	{
132 141
 		$taskId = $task->id;
Please login to merge, or discard this patch.
modules/Settings/Workflows/models/TaskType.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -43,6 +43,9 @@  discard block
 block discarded – undo
43 43
 		return '?module=Workflows&parent=Settings&view=EditTask&type=' . $this->getName();
44 44
 	}
45 45
 
46
+	/**
47
+	 * @param string $taskClass
48
+	 */
46 49
 	public static function getInstanceFromClassName($taskClass)
47 50
 	{
48 51
 		$db = PearDatabase::getInstance();
@@ -68,6 +71,9 @@  discard block
 block discarded – undo
68 71
 		return self::getInstanceFromTaskTypeObject($taskTypeObject);
69 72
 	}
70 73
 
74
+	/**
75
+	 * @param VTTaskType $taskTypeObject
76
+	 */
71 77
 	public static function getInstanceFromTaskTypeObject($taskTypeObject)
72 78
 	{
73 79
 		return new self($taskTypeObject->data);
Please login to merge, or discard this patch.
modules/SMSNotifier/SMSNotifier.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
 	/**
16 16
 	 * Check if there is active server configured.
17 17
 	 *
18
-	 * @return true if activer server is found, false otherwise.
18
+	 * @return boolean if activer server is found, false otherwise.
19 19
 	 */
20 20
 	static function checkServer()
21 21
 	{
Please login to merge, or discard this patch.
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -163,8 +163,9 @@  discard block
 block discarded – undo
163 163
 	private function processFireSendSMSResponse($responses)
164 164
 	{
165 165
 
166
-		if (empty($responses))
167
-			return;
166
+		if (empty($responses)) {
167
+					return;
168
+		}
168 169
 
169 170
 		$adb = PearDatabase::getInstance();
170 171
 
@@ -260,8 +261,9 @@  discard block
 block discarded – undo
260 261
 			$resultrow = $adb->fetch_array($result);
261 262
 			$provider = SMSNotifier_Provider_Model::getInstance($resultrow['providertype']);
262 263
 			$parameters = array();
263
-			if (!empty($resultrow['parameters']))
264
-				$parameters = \App\Json::decode(decode_html($resultrow['parameters']));
264
+			if (!empty($resultrow['parameters'])) {
265
+							$parameters = \App\Json::decode(decode_html($resultrow['parameters']));
266
+			}
265 267
 			foreach ($parameters as $k => $v) {
266 268
 				$provider->setParameter($k, $v);
267 269
 			}
Please login to merge, or discard this patch.