Completed
Pull Request — developer (#4001)
by Thom
542:26 queued 508:45
created
modules/Import/actions/Queue.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -158,6 +158,9 @@
 block discarded – undo
158 158
 		];
159 159
 	}
160 160
 
161
+	/**
162
+	 * @param integer $temp_status
163
+	 */
161 164
 	static function updateStatus($importId, $temp_status)
162 165
 	{
163 166
 		$db = PearDatabase::getInstance();
Please login to merge, or discard this patch.
modules/Import/models/Map.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -59,6 +59,9 @@
 block discarded – undo
59 59
 		return $this->map;
60 60
 	}
61 61
 
62
+	/**
63
+	 * @param string $key
64
+	 */
62 65
 	public function getValue($key)
63 66
 	{
64 67
 		$map = $this->map;
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -67,8 +67,9 @@
 block discarded – undo
67 67
 
68 68
 	public function getStringifiedContent()
69 69
 	{
70
-		if (empty($this->map['content']))
71
-			return;
70
+		if (empty($this->map['content'])) {
71
+					return;
72
+		}
72 73
 		$content = $this->map['content'];
73 74
 		$keyValueStrings = array();
74 75
 		foreach ($content as $key => $value) {
Please login to merge, or discard this patch.
modules/IStorages/data_access/checkHierarchy.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 	 * Checks if chosen parent is record child
45 45
 	 * @param type $parentId
46 46
 	 * @param type $childArray
47
-	 * @return true if parent can be set
47
+	 * @return boolean if parent can be set
48 48
 	 */
49 49
 	public function checkChildren($parentId, $childArray)
50 50
 	{
Please login to merge, or discard this patch.
modules/IStorages/IStorages.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -201,6 +201,7 @@  discard block
 block discarded – undo
201 201
 	 * @param integer $id - istorageid
202 202
 	 * @param array $parentIStorages - Array of all the parent storages
203 203
 	 * returns All the parent Storages of the given istorageid in array format
204
+	 * @param integer[] $encounteredIStorages
204 205
 	 */
205 206
 	public function getParentIStorages($id, &$parentIStorages, &$encounteredIStorages, $depthBase = 0)
206 207
 	{
@@ -266,7 +267,7 @@  discard block
 block discarded – undo
266 267
 	 * Function to Recursively get all the child storages of a given Storage
267 268
 	 * @param integer $id - istorageid
268 269
 	 * @param array $childIStorages - Array of all the child storages
269
-	 * @param integer $depth - Depth at which the particular storage has to be placed in the hierarchy
270
+	 * @param integer $depthBase - Depth at which the particular storage has to be placed in the hierarchy
270 271
 	 * returns All the child storages of the given istorageid in array format
271 272
 	 */
272 273
 	public function getChildIStorages($id, &$childIStorages, $depthBase)
Please login to merge, or discard this patch.
modules/IStorages/models/Module.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -36,6 +36,12 @@
 block discarded – undo
36 36
 		}
37 37
 	}
38 38
 
39
+	/**
40
+	 * @param boolean $moduleName
41
+	 * @param boolean $data
42
+	 * @param boolean $storageId
43
+	 * @param boolean $action
44
+	 */
39 45
 	public static function setQtyInStock($moduleName, $data, $storageId, $action)
40 46
 	{
41 47
 		$db = PearDatabase::getInstance();
Please login to merge, or discard this patch.
modules/OSSMail/models/Mail.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -129,6 +129,9 @@  discard block
 block discarded – undo
129 129
 		$this->mailCrmId = $id;
130 130
 	}
131 131
 
132
+	/**
133
+	 * @param string $name
134
+	 */
132 135
 	public function getEmail($name)
133 136
 	{
134 137
 		$header = $this->get('header');
@@ -145,6 +148,9 @@  discard block
 block discarded – undo
145 148
 		return $return;
146 149
 	}
147 150
 
151
+	/**
152
+	 * @param string $field
153
+	 */
148 154
 	public function findEmailAdress($field, $searchModule = false, $returnArray = true)
149 155
 	{
150 156
 		$db = PearDatabase::getInstance();
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -137,9 +137,9 @@
 block discarded – undo
137 137
 		if (is_array($text)) {
138 138
 			foreach ($text as $row) {
139 139
 				if ($return != '') {
140
-					$return.= ',';
140
+					$return .= ',';
141 141
 				}
142
-				$return.= $row->mailbox . '@' . $row->host;
142
+				$return .= $row->mailbox . '@' . $row->host;
143 143
 			}
144 144
 		}
145 145
 		return $return;
Please login to merge, or discard this patch.
modules/OSSMail/models/Module.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -186,6 +186,10 @@
 block discarded – undo
186 186
 		return $url;
187 187
 	}
188 188
 
189
+	/**
190
+	 * @param boolean $record
191
+	 * @param string $type
192
+	 */
189 193
 	public function getExternalUrlForWidget($record, $type, $srecord = false, $smoduleName = false)
190 194
 	{
191 195
 		if (is_object($record)) {
Please login to merge, or discard this patch.
modules/OSSMailScanner/models/EmailScannerAction.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -9,6 +9,9 @@
 block discarded – undo
9 9
 class OSSMailScanner_EmailScannerAction_Model
10 10
 {
11 11
 
12
+	/**
13
+	 * @param string $moduleName
14
+	 */
12 15
 	public function process(OSSMail_Mail_Model $mail, $moduleName)
13 16
 	{
14 17
 		$db = PearDatabase::getInstance();
Please login to merge, or discard this patch.
modules/OSSMailView/models/Record.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -226,6 +226,9 @@
 block discarded – undo
226 226
 		$adb->pquery("UPDATE vtiger_ossmailview SET `ossmailview_sendtype` = ?, `type` = ? where ossmailviewid in (?);", array($MailType[$mail_type], $mail_type, $selectedIdsSql), true);
227 227
 	}
228 228
 
229
+	/**
230
+	 * @param string $action
231
+	 */
229 232
 	public function addLog($action, $info)
230 233
 	{
231 234
 		$adb = PearDatabase::getInstance();
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -144,8 +144,9 @@
 block discarded – undo
144 144
 
145 145
 	public function findEmail($record, $module)
146 146
 	{
147
-		if (!isRecordExists($record))
148
-			return false;
147
+		if (!isRecordExists($record)) {
148
+					return false;
149
+		}
149 150
 		$returnEmail = '';
150 151
 		if (in_array($module, ['HelpDesk', 'Project', 'SSalesProcesses'])) {
151 152
 			$accountId = '';
Please login to merge, or discard this patch.