YetiForceCompany / YetiForceCRM

libraries/SabreDAV/DAV/Sync/Plugin.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -3,8 +3,8 @@
 namespace Sabre\DAV\Sync;
 
 use Sabre\DAV;
-use Sabre\HTTP\RequestInterface;
 use Sabre\DAV\Xml\Request\SyncCollectionReport;
+use Sabre\HTTP\RequestInterface;
 
 /**
  * This plugin all WebDAV-sync capabilities to the Server.

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
 
         });
 
-        $server->on('propFind',       [$this, 'propFind']);
+        $server->on('propFind', [$this, 'propFind']);
         $server->on('validateTokens', [$this, 'validateTokens']);
 
     }

Indentation +253 added lines, -253 removed lines

@@ -20,258 +20,258 @@
  */
 class Plugin extends DAV\ServerPlugin {
 
-    /**
-     * Reference to server object
-     *
-     * @var DAV\Server
-     */
-    protected $server;
-
-    const SYNCTOKEN_PREFIX = 'http://sabre.io/ns/sync/';
-
-    /**
-     * Returns a plugin name.
-     *
-     * Using this name other plugins will be able to access other plugins
-     * using \Sabre\DAV\Server::getPlugin
-     *
-     * @return string
-     */
-    public function getPluginName() {
-
-        return 'sync';
-
-    }
-
-    /**
-     * Initializes the plugin.
-     *
-     * This is when the plugin registers it's hooks.
-     *
-     * @param DAV\Server $server
-     * @return void
-     */
-    public function initialize(DAV\Server $server) {
-
-        $this->server = $server;
-        $server->xml->elementMap['{DAV:}sync-collection'] = 'Sabre\\DAV\\Xml\\Request\\SyncCollectionReport';
-
-        $self = $this;
-
-        $server->on('report', function($reportName, $dom, $uri) use ($self) {
-
-            if ($reportName === '{DAV:}sync-collection') {
-                $this->server->transactionType = 'report-sync-collection';
-                $self->syncCollection($uri, $dom);
-                return false;
-            }
-
-        });
-
-        $server->on('propFind',       [$this, 'propFind']);
-        $server->on('validateTokens', [$this, 'validateTokens']);
-
-    }
-
-    /**
-     * Returns a list of reports this plugin supports.
-     *
-     * This will be used in the {DAV:}supported-report-set property.
-     * Note that you still need to subscribe to the 'report' event to actually
-     * implement them
-     *
-     * @param string $uri
-     * @return array
-     */
-    public function getSupportedReportSet($uri) {
-
-        $node = $this->server->tree->getNodeForPath($uri);
-        if ($node instanceof ISyncCollection && $node->getSyncToken()) {
-            return [
-                '{DAV:}sync-collection',
-            ];
-        }
-
-        return [];
-
-    }
-
-
-    /**
-     * This method handles the {DAV:}sync-collection HTTP REPORT.
-     *
-     * @param string $uri
-     * @param SyncCollectionReport $report
-     * @return void
-     */
-    public function syncCollection($uri, SyncCollectionReport $report) {
-
-        // Getting the data
-        $node = $this->server->tree->getNodeForPath($uri);
-        if (!$node instanceof ISyncCollection) {
-            throw new DAV\Exception\ReportNotSupported('The {DAV:}sync-collection REPORT is not supported on this url.');
-        }
-        $token = $node->getSyncToken();
-        if (!$token) {
-            throw new DAV\Exception\ReportNotSupported('No sync information is available at this node');
-        }
-
-        $syncToken = $report->syncToken;
-        if (!is_null($syncToken)) {
-            // Sync-token must start with our prefix
-            if (substr($syncToken, 0, strlen(self::SYNCTOKEN_PREFIX)) !== self::SYNCTOKEN_PREFIX) {
-                throw new DAV\Exception\InvalidSyncToken('Invalid or unknown sync token');
-            }
-
-            $syncToken = substr($syncToken, strlen(self::SYNCTOKEN_PREFIX));
-
-        }
-        $changeInfo = $node->getChanges($syncToken, $report->syncLevel, $report->limit);
-
-        if (is_null($changeInfo)) {
-
-            throw new DAV\Exception\InvalidSyncToken('Invalid or unknown sync token');
-
-        }
-
-        // Encoding the response
-        $this->sendSyncCollectionResponse(
-            $changeInfo['syncToken'],
-            $uri,
-            $changeInfo['added'],
-            $changeInfo['modified'],
-            $changeInfo['deleted'],
-            $report->properties
-        );
-
-    }
-
-    /**
-     * Sends the response to a sync-collection request.
-     *
-     * @param string $syncToken
-     * @param string $collectionUrl
-     * @param array $added
-     * @param array $modified
-     * @param array $deleted
-     * @param array $properties
-     * @return void
-     */
-    protected function sendSyncCollectionResponse($syncToken, $collectionUrl, array $added, array $modified, array $deleted, array $properties) {
-
-
-        $fullPaths = [];
-
-        // Pre-fetching children, if this is possible.
-        foreach (array_merge($added, $modified) as $item) {
-            $fullPath = $collectionUrl . '/' . $item;
-            $fullPaths[] = $fullPath;
-        }
-
-        $responses = [];
-        foreach ($this->server->getPropertiesForMultiplePaths($fullPaths, $properties) as $fullPath => $props) {
-
-            // The 'Property_Response' class is responsible for generating a
-            // single {DAV:}response xml element.
-            $responses[] = new DAV\Xml\Element\Response($fullPath, $props);
-
-        }
-
-
-
-        // Deleted items also show up as 'responses'. They have no properties,
-        // and a single {DAV:}status element set as 'HTTP/1.1 404 Not Found'.
-        foreach ($deleted as $item) {
-
-            $fullPath = $collectionUrl . '/' . $item;
-            $responses[] = new DAV\Xml\Element\Response($fullPath, [], 404);
-
-        }
-        $multiStatus = new DAV\Xml\Response\MultiStatus($responses, self::SYNCTOKEN_PREFIX . $syncToken);
-
-        $this->server->httpResponse->setStatus(207);
-        $this->server->httpResponse->setHeader('Content-Type', 'application/xml; charset=utf-8');
-        $this->server->httpResponse->setBody(
-            $this->server->xml->write('{DAV:}multistatus', $multiStatus, $this->server->getBaseUri())
-        );
-
-    }
-
-    /**
-     * This method is triggered whenever properties are requested for a node.
-     * We intercept this to see if we must return a {DAV:}sync-token.
-     *
-     * @param DAV\PropFind $propFind
-     * @param DAV\INode $node
-     * @return void
-     */
-    public function propFind(DAV\PropFind $propFind, DAV\INode $node) {
-
-        $propFind->handle('{DAV:}sync-token', function() use ($node) {
-            if (!$node instanceof ISyncCollection || !$token = $node->getSyncToken()) {
-                return;
-            }
-            return self::SYNCTOKEN_PREFIX . $token;
-        });
-
-    }
-
-    /**
-     * The validateTokens event is triggered before every request.
-     *
-     * It's a moment where this plugin can check all the supplied lock tokens
-     * in the If: header, and check if they are valid.
-     *
-     * @param RequestInterface $request
-     * @param array $conditions
-     * @return void
-     */
-    public function validateTokens(RequestInterface $request, &$conditions) {
-
-        foreach ($conditions as $kk => $condition) {
-
-            foreach ($condition['tokens'] as $ii => $token) {
-
-                // Sync-tokens must always start with our designated prefix.
-                if (substr($token['token'], 0, strlen(self::SYNCTOKEN_PREFIX)) !== self::SYNCTOKEN_PREFIX) {
-                    continue;
-                }
-
-                // Checking if the token is a match.
-                $node = $this->server->tree->getNodeForPath($condition['uri']);
-
-                if (
-                    $node instanceof ISyncCollection &&
-                    $node->getSyncToken() == substr($token['token'], strlen(self::SYNCTOKEN_PREFIX))
-                ) {
-                    $conditions[$kk]['tokens'][$ii]['validToken'] = true;
-                }
-
-            }
-
-        }
-
-    }
-
-    /**
-     * Returns a bunch of meta-data about the plugin.
-     *
-     * Providing this information is optional, and is mainly displayed by the
-     * Browser plugin.
-     *
-     * The description key in the returned array may contain html and will not
-     * be sanitized.
-     *
-     * @return array
-     */
-    public function getPluginInfo() {
-
-        return [
-            'name'        => $this->getPluginName(),
-            'description' => 'Adds support for WebDAV Collection Sync (rfc6578)',
-            'link'        => 'http://sabre.io/dav/sync/',
-        ];
-
-    }
+	/**
+	 * Reference to server object
+	 *
+	 * @var DAV\Server
+	 */
+	protected $server;
+
+	const SYNCTOKEN_PREFIX = 'http://sabre.io/ns/sync/';
+
+	/**
+	 * Returns a plugin name.
+	 *
+	 * Using this name other plugins will be able to access other plugins
+	 * using \Sabre\DAV\Server::getPlugin
+	 *
+	 * @return string
+	 */
+	public function getPluginName() {
+
+		return 'sync';
+
+	}
+
+	/**
+	 * Initializes the plugin.
+	 *
+	 * This is when the plugin registers it's hooks.
+	 *
+	 * @param DAV\Server $server
+	 * @return void
+	 */
+	public function initialize(DAV\Server $server) {
+
+		$this->server = $server;
+		$server->xml->elementMap['{DAV:}sync-collection'] = 'Sabre\\DAV\\Xml\\Request\\SyncCollectionReport';
+
+		$self = $this;
+
+		$server->on('report', function($reportName, $dom, $uri) use ($self) {
+
+			if ($reportName === '{DAV:}sync-collection') {
+				$this->server->transactionType = 'report-sync-collection';
+				$self->syncCollection($uri, $dom);
+				return false;
+			}
+
+		});
+
+		$server->on('propFind',       [$this, 'propFind']);
+		$server->on('validateTokens', [$this, 'validateTokens']);
+
+	}
+
+	/**
+	 * Returns a list of reports this plugin supports.
+	 *
+	 * This will be used in the {DAV:}supported-report-set property.
+	 * Note that you still need to subscribe to the 'report' event to actually
+	 * implement them
+	 *
+	 * @param string $uri
+	 * @return array
+	 */
+	public function getSupportedReportSet($uri) {
+
+		$node = $this->server->tree->getNodeForPath($uri);
+		if ($node instanceof ISyncCollection && $node->getSyncToken()) {
+			return [
+				'{DAV:}sync-collection',
+			];
+		}
+
+		return [];
+
+	}
+
+
+	/**
+	 * This method handles the {DAV:}sync-collection HTTP REPORT.
+	 *
+	 * @param string $uri
+	 * @param SyncCollectionReport $report
+	 * @return void
+	 */
+	public function syncCollection($uri, SyncCollectionReport $report) {
+
+		// Getting the data
+		$node = $this->server->tree->getNodeForPath($uri);
+		if (!$node instanceof ISyncCollection) {
+			throw new DAV\Exception\ReportNotSupported('The {DAV:}sync-collection REPORT is not supported on this url.');
+		}
+		$token = $node->getSyncToken();
+		if (!$token) {
+			throw new DAV\Exception\ReportNotSupported('No sync information is available at this node');
+		}
+
+		$syncToken = $report->syncToken;
+		if (!is_null($syncToken)) {
+			// Sync-token must start with our prefix
+			if (substr($syncToken, 0, strlen(self::SYNCTOKEN_PREFIX)) !== self::SYNCTOKEN_PREFIX) {
+				throw new DAV\Exception\InvalidSyncToken('Invalid or unknown sync token');
+			}
+
+			$syncToken = substr($syncToken, strlen(self::SYNCTOKEN_PREFIX));
+
+		}
+		$changeInfo = $node->getChanges($syncToken, $report->syncLevel, $report->limit);
+
+		if (is_null($changeInfo)) {
+
+			throw new DAV\Exception\InvalidSyncToken('Invalid or unknown sync token');
+
+		}
+
+		// Encoding the response
+		$this->sendSyncCollectionResponse(
+			$changeInfo['syncToken'],
+			$uri,
+			$changeInfo['added'],
+			$changeInfo['modified'],
+			$changeInfo['deleted'],
+			$report->properties
+		);
+
+	}
+
+	/**
+	 * Sends the response to a sync-collection request.
+	 *
+	 * @param string $syncToken
+	 * @param string $collectionUrl
+	 * @param array $added
+	 * @param array $modified
+	 * @param array $deleted
+	 * @param array $properties
+	 * @return void
+	 */
+	protected function sendSyncCollectionResponse($syncToken, $collectionUrl, array $added, array $modified, array $deleted, array $properties) {
+
+
+		$fullPaths = [];
+
+		// Pre-fetching children, if this is possible.
+		foreach (array_merge($added, $modified) as $item) {
+			$fullPath = $collectionUrl . '/' . $item;
+			$fullPaths[] = $fullPath;
+		}
+
+		$responses = [];
+		foreach ($this->server->getPropertiesForMultiplePaths($fullPaths, $properties) as $fullPath => $props) {
+
+			// The 'Property_Response' class is responsible for generating a
+			// single {DAV:}response xml element.
+			$responses[] = new DAV\Xml\Element\Response($fullPath, $props);
+
+		}
+
+
+
+		// Deleted items also show up as 'responses'. They have no properties,
+		// and a single {DAV:}status element set as 'HTTP/1.1 404 Not Found'.
+		foreach ($deleted as $item) {
+
+			$fullPath = $collectionUrl . '/' . $item;
+			$responses[] = new DAV\Xml\Element\Response($fullPath, [], 404);
+
+		}
+		$multiStatus = new DAV\Xml\Response\MultiStatus($responses, self::SYNCTOKEN_PREFIX . $syncToken);
+
+		$this->server->httpResponse->setStatus(207);
+		$this->server->httpResponse->setHeader('Content-Type', 'application/xml; charset=utf-8');
+		$this->server->httpResponse->setBody(
+			$this->server->xml->write('{DAV:}multistatus', $multiStatus, $this->server->getBaseUri())
+		);
+
+	}
+
+	/**
+	 * This method is triggered whenever properties are requested for a node.
+	 * We intercept this to see if we must return a {DAV:}sync-token.
+	 *
+	 * @param DAV\PropFind $propFind
+	 * @param DAV\INode $node
+	 * @return void
+	 */
+	public function propFind(DAV\PropFind $propFind, DAV\INode $node) {
+
+		$propFind->handle('{DAV:}sync-token', function() use ($node) {
+			if (!$node instanceof ISyncCollection || !$token = $node->getSyncToken()) {
+				return;
+			}
+			return self::SYNCTOKEN_PREFIX . $token;
+		});
+
+	}
+
+	/**
+	 * The validateTokens event is triggered before every request.
+	 *
+	 * It's a moment where this plugin can check all the supplied lock tokens
+	 * in the If: header, and check if they are valid.
+	 *
+	 * @param RequestInterface $request
+	 * @param array $conditions
+	 * @return void
+	 */
+	public function validateTokens(RequestInterface $request, &$conditions) {
+
+		foreach ($conditions as $kk => $condition) {
+
+			foreach ($condition['tokens'] as $ii => $token) {
+
+				// Sync-tokens must always start with our designated prefix.
+				if (substr($token['token'], 0, strlen(self::SYNCTOKEN_PREFIX)) !== self::SYNCTOKEN_PREFIX) {
+					continue;
+				}
+
+				// Checking if the token is a match.
+				$node = $this->server->tree->getNodeForPath($condition['uri']);
+
+				if (
+					$node instanceof ISyncCollection &&
+					$node->getSyncToken() == substr($token['token'], strlen(self::SYNCTOKEN_PREFIX))
+				) {
+					$conditions[$kk]['tokens'][$ii]['validToken'] = true;
+				}
+
+			}
+
+		}
+
+	}
+
+	/**
+	 * Returns a bunch of meta-data about the plugin.
+	 *
+	 * Providing this information is optional, and is mainly displayed by the
+	 * Browser plugin.
+	 *
+	 * The description key in the returned array may contain html and will not
+	 * be sanitized.
+	 *
+	 * @return array
+	 */
+	public function getPluginInfo() {
+
+		return [
+			'name'        => $this->getPluginName(),
+			'description' => 'Adds support for WebDAV Collection Sync (rfc6578)',
+			'link'        => 'http://sabre.io/dav/sync/',
+		];
+
+	}
 
 }

libraries/SabreDAV/DAV/Xml/Element/Prop.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -3,8 +3,8 @@
 namespace Sabre\DAV\Xml\Element;
 
 use Sabre\DAV\Xml\Property\Complex;
-use Sabre\Xml\XmlDeserializable;
 use Sabre\Xml\Reader;
+use Sabre\Xml\XmlDeserializable;
 
 /**
  * This class is responsible for decoding the {DAV:}prop element as it appears

Indentation +93 added lines, -93 removed lines

@@ -19,98 +19,98 @@
  */
 class Prop implements XmlDeserializable {
 
-    /**
-     * The deserialize method is called during xml parsing.
-     *
-     * This method is called statictly, this is because in theory this method
-     * may be used as a type of constructor, or factory method.
-     *
-     * Often you want to return an instance of the current class, but you are
-     * free to return other data as well.
-     *
-     * You are responsible for advancing the reader to the next element. Not
-     * doing anything will result in a never-ending loop.
-     *
-     * If you just want to skip parsing for this element altogether, you can
-     * just call $reader->next();
-     *
-     * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
-     * the next element.
-     *
-     * @param Reader $reader
-     * @return mixed
-     */
-    static function xmlDeserialize(Reader $reader) {
-
-        // If there's no children, we don't do anything.
-        if ($reader->isEmptyElement) {
-            $reader->next();
-            return [];
-        }
-
-        $values = [];
-
-        $reader->read();
-        do {
-
-            if ($reader->nodeType === Reader::ELEMENT) {
-
-                $clark = $reader->getClark();
-                $values[$clark] = self::parseCurrentElement($reader)['value'];
-
-            } else {
-                $reader->read();
-            }
-
-        } while ($reader->nodeType !== Reader::END_ELEMENT);
-
-        $reader->read();
-
-        return $values;
-
-    }
-
-    /**
-     * This function behaves similar to Sabre\Xml\Reader::parseCurrentElement,
-     * but instead of creating deep xml array structures, it will turn any
-     * top-level element it doesn't recognize into either a string, or an
-     * XmlFragment class.
-     *
-     * This method returns arn array with 2 properties:
-     *   * name - A clark-notation XML element name.
-     *   * value - The parsed value.
-     *
-     * @param Reader $reader
-     * @return array
-     */
-    private static function parseCurrentElement(Reader $reader) {
-
-        $name = $reader->getClark();
-
-        if (array_key_exists($name, $reader->elementMap)) {
-            $deserializer = $reader->elementMap[$name];
-            if (is_subclass_of($deserializer, 'Sabre\\Xml\\XmlDeserializable')) {
-                $value = call_user_func([ $deserializer, 'xmlDeserialize' ], $reader);
-            } elseif (is_callable($deserializer)) {
-                $value = call_user_func($deserializer, $reader);
-            } else {
-                $type = gettype($deserializer);
-                if ($type === 'string') {
-                    $type .= ' (' . $deserializer . ')';
-                } elseif ($type === 'object') {
-                    $type .= ' (' . get_class($deserializer) . ')';
-                }
-                throw new \LogicException('Could not use this type as a deserializer: ' . $type);
-            }
-        } else {
-            $value = Complex::xmlDeserialize($reader);
-        }
-
-        return [
-            'name'  => $name,
-            'value' => $value,
-        ];
-
-    }
+	/**
+	 * The deserialize method is called during xml parsing.
+	 *
+	 * This method is called statictly, this is because in theory this method
+	 * may be used as a type of constructor, or factory method.
+	 *
+	 * Often you want to return an instance of the current class, but you are
+	 * free to return other data as well.
+	 *
+	 * You are responsible for advancing the reader to the next element. Not
+	 * doing anything will result in a never-ending loop.
+	 *
+	 * If you just want to skip parsing for this element altogether, you can
+	 * just call $reader->next();
+	 *
+	 * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
+	 * the next element.
+	 *
+	 * @param Reader $reader
+	 * @return mixed
+	 */
+	static function xmlDeserialize(Reader $reader) {
+
+		// If there's no children, we don't do anything.
+		if ($reader->isEmptyElement) {
+			$reader->next();
+			return [];
+		}
+
+		$values = [];
+
+		$reader->read();
+		do {
+
+			if ($reader->nodeType === Reader::ELEMENT) {
+
+				$clark = $reader->getClark();
+				$values[$clark] = self::parseCurrentElement($reader)['value'];
+
+			} else {
+				$reader->read();
+			}
+
+		} while ($reader->nodeType !== Reader::END_ELEMENT);
+
+		$reader->read();
+
+		return $values;
+
+	}
+
+	/**
+	 * This function behaves similar to Sabre\Xml\Reader::parseCurrentElement,
+	 * but instead of creating deep xml array structures, it will turn any
+	 * top-level element it doesn't recognize into either a string, or an
+	 * XmlFragment class.
+	 *
+	 * This method returns arn array with 2 properties:
+	 *   * name - A clark-notation XML element name.
+	 *   * value - The parsed value.
+	 *
+	 * @param Reader $reader
+	 * @return array
+	 */
+	private static function parseCurrentElement(Reader $reader) {
+
+		$name = $reader->getClark();
+
+		if (array_key_exists($name, $reader->elementMap)) {
+			$deserializer = $reader->elementMap[$name];
+			if (is_subclass_of($deserializer, 'Sabre\\Xml\\XmlDeserializable')) {
+				$value = call_user_func([ $deserializer, 'xmlDeserialize' ], $reader);
+			} elseif (is_callable($deserializer)) {
+				$value = call_user_func($deserializer, $reader);
+			} else {
+				$type = gettype($deserializer);
+				if ($type === 'string') {
+					$type .= ' (' . $deserializer . ')';
+				} elseif ($type === 'object') {
+					$type .= ' (' . get_class($deserializer) . ')';
+				}
+				throw new \LogicException('Could not use this type as a deserializer: ' . $type);
+			}
+		} else {
+			$value = Complex::xmlDeserialize($reader);
+		}
+
+		return [
+			'name'  => $name,
+			'value' => $value,
+		];
+
+	}
 
 }

Spacing +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
         if (array_key_exists($name, $reader->elementMap)) {
             $deserializer = $reader->elementMap[$name];
             if (is_subclass_of($deserializer, 'Sabre\\Xml\\XmlDeserializable')) {
-                $value = call_user_func([ $deserializer, 'xmlDeserialize' ], $reader);
+                $value = call_user_func([$deserializer, 'xmlDeserialize'], $reader);
             } elseif (is_callable($deserializer)) {
                 $value = call_user_func($deserializer, $reader);
             } else {

libraries/SabreDAV/DAV/Xml/Element/Response.php

Doc Comments +1 added lines, -1 removed lines

@@ -176,7 +176,7 @@
      * the next element.
      *
      * @param Reader $reader
-     * @return mixed
+     * @return Response
      */
     static function xmlDeserialize(Reader $reader) {
 

Spacing +2 added lines, -2 removed lines

@@ -234,12 +234,12 @@
                     break;
                 case '{DAV:}propstat' :
                     $status = $elem['value']['{DAV:}status'];
-                    list(, $status, ) = explode(' ', $status, 3);
+                    list(, $status,) = explode(' ', $status, 3);
                     $properties = isset($elem['value']['{DAV:}prop']) ? $elem['value']['{DAV:}prop'] : [];
                     if ($properties) $propertyLists[$status] = $properties;
                     break;
                 case '{DAV:}status' :
-                    list(, $statusCode, ) = explode(' ', $elem['value'], 3);
+                    list(, $statusCode,) = explode(' ', $elem['value'], 3);
                     break;
 
             }

Braces +3 added lines, -1 removed lines

@@ -236,7 +236,9 @@
                     $status = $elem['value']['{DAV:}status'];
                     list(, $status, ) = explode(' ', $status, 3);
                     $properties = isset($elem['value']['{DAV:}prop']) ? $elem['value']['{DAV:}prop'] : [];
-                    if ($properties) $propertyLists[$status] = $properties;
+                    if ($properties) {
+                    	$propertyLists[$status] = $properties;
+                    }
                     break;
                 case '{DAV:}status' :
                     list(, $statusCode, ) = explode(' ', $elem['value'], 3);

Indentation +223 added lines, -223 removed lines

@@ -19,128 +19,128 @@ 
  */
 class Response implements Element {
 
-    /**
-     * Url for the response
-     *
-     * @var string
-     */
-    protected $href;
-
-    /**
-     * Propertylist, ordered by HTTP status code
-     *
-     * @var array
-     */
-    protected $responseProperties;
-
-    /**
-     * The HTTP status for an entire response.
-     *
-     * This is currently only used in WebDAV-Sync
-     *
-     * @var string
-     */
-    protected $httpStatus;
-
-    /**
-     * The href argument is a url relative to the root of the server. This
-     * class will calculate the full path.
-     *
-     * The responseProperties argument is a list of properties
-     * within an array with keys representing HTTP status codes
-     *
-     * Besides specific properties, the entire {DAV:}response element may also
-     * have a http status code.
-     * In most cases you don't need it.
-     *
-     * This is currently used by the Sync extension to indicate that a node is
-     * deleted.
-     *
-     * @param string $href
-     * @param array $responseProperties
-     * @param string $httpStatus
-     */
-    public function __construct($href, array $responseProperties, $httpStatus = null) {
-
-        $this->href = $href;
-        $this->responseProperties = $responseProperties;
-        $this->httpStatus = $httpStatus;
-
-    }
-
-    /**
-     * Returns the url
-     *
-     * @return string
-     */
-    public function getHref() {
-
-        return $this->href;
-
-    }
-
-    /**
-     * Returns the httpStatus value
-     *
-     * @return string
-     */
-    public function getHttpStatus() {
-
-        return $this->httpStatus;
-
-    }
-
-    /**
-     * Returns the property list
-     *
-     * @return array
-     */
-    public function getResponseProperties() {
-
-        return $this->responseProperties;
-
-    }
-
-
-    /**
-     * The serialize method is called during xml writing.
-     *
-     * It should use the $writer argument to encode this object into XML.
-     *
-     * Important note: it is not needed to create the parent element. The
-     * parent element is already created, and we only have to worry about
-     * attributes, child elements and text (if any).
-     *
-     * Important note 2: If you are writing any new elements, you are also
-     * responsible for closing them.
-     *
-     * @param Writer $writer
-     * @return void
-     */
-    public function xmlSerialize(Writer $writer) {
-
-        if ($status = $this->getHTTPStatus()) {
-            $writer->writeElement('{DAV:}status', 'HTTP/1.1 ' . $status . ' ' . \Sabre\HTTP\Response::$statusCodes[$status]);
-        }
-        $writer->writeElement('{DAV:}href', $writer->contextUri . \Sabre\HTTP\encodePath($this->getHref()));
-
-        $empty = true;
-
-        foreach ($this->getResponseProperties() as $status => $properties) {
-
-            // Skipping empty lists
-            if (!$properties || (!ctype_digit($status) && !is_int($status))) {
-                continue;
-            }
-            $empty = false;
-            $writer->startElement('{DAV:}propstat');
-            $writer->writeElement('{DAV:}prop', $properties);
-            $writer->writeElement('{DAV:}status', 'HTTP/1.1 ' . $status . ' ' . \Sabre\HTTP\Response::$statusCodes[$status]);
-            $writer->endElement(); // {DAV:}propstat
-
-        }
-        if ($empty) {
-            /*
+	/**
+	 * Url for the response
+	 *
+	 * @var string
+	 */
+	protected $href;
+
+	/**
+	 * Propertylist, ordered by HTTP status code
+	 *
+	 * @var array
+	 */
+	protected $responseProperties;
+
+	/**
+	 * The HTTP status for an entire response.
+	 *
+	 * This is currently only used in WebDAV-Sync
+	 *
+	 * @var string
+	 */
+	protected $httpStatus;
+
+	/**
+	 * The href argument is a url relative to the root of the server. This
+	 * class will calculate the full path.
+	 *
+	 * The responseProperties argument is a list of properties
+	 * within an array with keys representing HTTP status codes
+	 *
+	 * Besides specific properties, the entire {DAV:}response element may also
+	 * have a http status code.
+	 * In most cases you don't need it.
+	 *
+	 * This is currently used by the Sync extension to indicate that a node is
+	 * deleted.
+	 *
+	 * @param string $href
+	 * @param array $responseProperties
+	 * @param string $httpStatus
+	 */
+	public function __construct($href, array $responseProperties, $httpStatus = null) {
+
+		$this->href = $href;
+		$this->responseProperties = $responseProperties;
+		$this->httpStatus = $httpStatus;
+
+	}
+
+	/**
+	 * Returns the url
+	 *
+	 * @return string
+	 */
+	public function getHref() {
+
+		return $this->href;
+
+	}
+
+	/**
+	 * Returns the httpStatus value
+	 *
+	 * @return string
+	 */
+	public function getHttpStatus() {
+
+		return $this->httpStatus;
+
+	}
+
+	/**
+	 * Returns the property list
+	 *
+	 * @return array
+	 */
+	public function getResponseProperties() {
+
+		return $this->responseProperties;
+
+	}
+
+
+	/**
+	 * The serialize method is called during xml writing.
+	 *
+	 * It should use the $writer argument to encode this object into XML.
+	 *
+	 * Important note: it is not needed to create the parent element. The
+	 * parent element is already created, and we only have to worry about
+	 * attributes, child elements and text (if any).
+	 *
+	 * Important note 2: If you are writing any new elements, you are also
+	 * responsible for closing them.
+	 *
+	 * @param Writer $writer
+	 * @return void
+	 */
+	public function xmlSerialize(Writer $writer) {
+
+		if ($status = $this->getHTTPStatus()) {
+			$writer->writeElement('{DAV:}status', 'HTTP/1.1 ' . $status . ' ' . \Sabre\HTTP\Response::$statusCodes[$status]);
+		}
+		$writer->writeElement('{DAV:}href', $writer->contextUri . \Sabre\HTTP\encodePath($this->getHref()));
+
+		$empty = true;
+
+		foreach ($this->getResponseProperties() as $status => $properties) {
+
+			// Skipping empty lists
+			if (!$properties || (!ctype_digit($status) && !is_int($status))) {
+				continue;
+			}
+			$empty = false;
+			$writer->startElement('{DAV:}propstat');
+			$writer->writeElement('{DAV:}prop', $properties);
+			$writer->writeElement('{DAV:}status', 'HTTP/1.1 ' . $status . ' ' . \Sabre\HTTP\Response::$statusCodes[$status]);
+			$writer->endElement(); // {DAV:}propstat
+
+		}
+		if ($empty) {
+			/*
              * The WebDAV spec _requires_ at least one DAV:propstat to appear for
              * every DAV:response. In some circumstances however, there are no
              * properties to encode.
@@ -148,106 +148,106 @@ 
              * In those cases we MUST specify at least one DAV:propstat anyway, with
              * no properties.
              */
-            $writer->writeElement('{DAV:}propstat', [
-                '{DAV:}prop'   => [],
-                '{DAV:}status' => 'HTTP/1.1 418 ' . \Sabre\HTTP\Response::$statusCodes[418]
-            ]);
-
-        }
-
-    }
-
-    /**
-     * The deserialize method is called during xml parsing.
-     *
-     * This method is called statictly, this is because in theory this method
-     * may be used as a type of constructor, or factory method.
-     *
-     * Often you want to return an instance of the current class, but you are
-     * free to return other data as well.
-     *
-     * You are responsible for advancing the reader to the next element. Not
-     * doing anything will result in a never-ending loop.
-     *
-     * If you just want to skip parsing for this element altogether, you can
-     * just call $reader->next();
-     *
-     * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
-     * the next element.
-     *
-     * @param Reader $reader
-     * @return mixed
-     */
-    static function xmlDeserialize(Reader $reader) {
-
-        $reader->pushContext();
-
-        $reader->elementMap['{DAV:}propstat'] = 'Sabre\\Xml\\Element\\KeyValue';
-
-        // We are overriding the parser for {DAV:}prop. This deserializer is
-        // almost identical to the one for Sabre\Xml\Element\KeyValue.
-        //
-        // The difference is that if there are any child-elements inside of
-        // {DAV:}prop, that have no value, normally any deserializers are
-        // called. But we don't want this, because a singular element without
-        // child-elements implies 'no value' in {DAV:}prop, so we want to skip
-        // deserializers and just set null for those.
-        $reader->elementMap['{DAV:}prop'] = function(Reader $reader) {
-
-            if ($reader->isEmptyElement) {
-                $reader->next();
-                return [];
-            }
-            $values = [];
-            $reader->read();
-            do {
-                if ($reader->nodeType === Reader::ELEMENT) {
-                    $clark = $reader->getClark();
-
-                    if ($reader->isEmptyElement) {
-                        $values[$clark] = null;
-                        $reader->next();
-                    } else {
-                        $values[$clark] = $reader->parseCurrentElement()['value'];
-                    }
-                } else {
-                    $reader->read();
-                }
-            } while ($reader->nodeType !== Reader::END_ELEMENT);
-            $reader->read();
-            return $values;
-
-        };
-        $elems = $reader->parseInnerTree();
-        $reader->popContext();
-
-        $href = null;
-        $propertyLists = [];
-        $statusCode = null;
-
-        foreach ($elems as $elem) {
-
-            switch ($elem['name']) {
-
-                case '{DAV:}href' :
-                    $href = $elem['value'];
-                    break;
-                case '{DAV:}propstat' :
-                    $status = $elem['value']['{DAV:}status'];
-                    list(, $status, ) = explode(' ', $status, 3);
-                    $properties = isset($elem['value']['{DAV:}prop']) ? $elem['value']['{DAV:}prop'] : [];
-                    if ($properties) $propertyLists[$status] = $properties;
-                    break;
-                case '{DAV:}status' :
-                    list(, $statusCode, ) = explode(' ', $elem['value'], 3);
-                    break;
-
-            }
-
-        }
-
-        return new self($href, $propertyLists, $statusCode);
-
-    }
+			$writer->writeElement('{DAV:}propstat', [
+				'{DAV:}prop'   => [],
+				'{DAV:}status' => 'HTTP/1.1 418 ' . \Sabre\HTTP\Response::$statusCodes[418]
+			]);
+
+		}
+
+	}
+
+	/**
+	 * The deserialize method is called during xml parsing.
+	 *
+	 * This method is called statictly, this is because in theory this method
+	 * may be used as a type of constructor, or factory method.
+	 *
+	 * Often you want to return an instance of the current class, but you are
+	 * free to return other data as well.
+	 *
+	 * You are responsible for advancing the reader to the next element. Not
+	 * doing anything will result in a never-ending loop.
+	 *
+	 * If you just want to skip parsing for this element altogether, you can
+	 * just call $reader->next();
+	 *
+	 * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
+	 * the next element.
+	 *
+	 * @param Reader $reader
+	 * @return mixed
+	 */
+	static function xmlDeserialize(Reader $reader) {
+
+		$reader->pushContext();
+
+		$reader->elementMap['{DAV:}propstat'] = 'Sabre\\Xml\\Element\\KeyValue';
+
+		// We are overriding the parser for {DAV:}prop. This deserializer is
+		// almost identical to the one for Sabre\Xml\Element\KeyValue.
+		//
+		// The difference is that if there are any child-elements inside of
+		// {DAV:}prop, that have no value, normally any deserializers are
+		// called. But we don't want this, because a singular element without
+		// child-elements implies 'no value' in {DAV:}prop, so we want to skip
+		// deserializers and just set null for those.
+		$reader->elementMap['{DAV:}prop'] = function(Reader $reader) {
+
+			if ($reader->isEmptyElement) {
+				$reader->next();
+				return [];
+			}
+			$values = [];
+			$reader->read();
+			do {
+				if ($reader->nodeType === Reader::ELEMENT) {
+					$clark = $reader->getClark();
+
+					if ($reader->isEmptyElement) {
+						$values[$clark] = null;
+						$reader->next();
+					} else {
+						$values[$clark] = $reader->parseCurrentElement()['value'];
+					}
+				} else {
+					$reader->read();
+				}
+			} while ($reader->nodeType !== Reader::END_ELEMENT);
+			$reader->read();
+			return $values;
+
+		};
+		$elems = $reader->parseInnerTree();
+		$reader->popContext();
+
+		$href = null;
+		$propertyLists = [];
+		$statusCode = null;
+
+		foreach ($elems as $elem) {
+
+			switch ($elem['name']) {
+
+				case '{DAV:}href' :
+					$href = $elem['value'];
+					break;
+				case '{DAV:}propstat' :
+					$status = $elem['value']['{DAV:}status'];
+					list(, $status, ) = explode(' ', $status, 3);
+					$properties = isset($elem['value']['{DAV:}prop']) ? $elem['value']['{DAV:}prop'] : [];
+					if ($properties) $propertyLists[$status] = $properties;
+					break;
+				case '{DAV:}status' :
+					list(, $statusCode, ) = explode(' ', $elem['value'], 3);
+					break;
+
+			}
+
+		}
+
+		return new self($href, $propertyLists, $statusCode);
+
+	}
 
 }

libraries/SabreDAV/DAV/Xml/Property/GetLastModified.php

Doc Comments +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
      * the next element.
      *
      * @param Reader $reader
-     * @return mixed
+     * @return GetLastModified
      */
     static function xmlDeserialize(Reader $reader) {
 

Unused Use Statements +3 added lines, -3 removed lines

@@ -2,12 +2,12 @@
 
 namespace Sabre\DAV\Xml\Property;
 
+use DateTime;
+use DateTimeZone;
+use Sabre\HTTP;
 use Sabre\Xml\Element;
 use Sabre\Xml\Reader;
 use Sabre\Xml\Writer;
-use Sabre\HTTP;
-use DateTime;
-use DateTimeZone;
 
 /**
  * This property represents the {DAV:}getlastmodified property.

Indentation +86 added lines, -86 removed lines

@@ -21,90 +21,90 @@
  */
 class GetLastModified implements Element {
 
-    /**
-     * time
-     *
-     * @var DateTime
-     */
-    public $time;
-
-    /**
-     * Constructor
-     *
-     * @param int|DateTime $time
-     */
-    public function __construct($time) {
-
-        if ($time instanceof DateTime) {
-            $this->time = clone $time;
-        } else {
-            $this->time = new DateTime('@' . $time);
-        }
-
-        // Setting timezone to UTC
-        $this->time->setTimezone(new DateTimeZone('UTC'));
-
-    }
-
-    /**
-     * getTime
-     *
-     * @return DateTime
-     */
-    public function getTime() {
-
-        return $this->time;
-
-    }
-
-    /**
-     * The serialize method is called during xml writing.
-     *
-     * It should use the $writer argument to encode this object into XML.
-     *
-     * Important note: it is not needed to create the parent element. The
-     * parent element is already created, and we only have to worry about
-     * attributes, child elements and text (if any).
-     *
-     * Important note 2: If you are writing any new elements, you are also
-     * responsible for closing them.
-     *
-     * @param Writer $writer
-     * @return void
-     */
-    public function xmlSerialize(Writer $writer) {
-
-        $writer->write(
-            HTTP\Util::toHTTPDate($this->time)
-        );
-
-    }
-
-    /**
-     * The deserialize method is called during xml parsing.
-     *
-     * This method is called statictly, this is because in theory this method
-     * may be used as a type of constructor, or factory method.
-     *
-     * Often you want to return an instance of the current class, but you are
-     * free to return other data as well.
-     *
-     * Important note 2: You are responsible for advancing the reader to the
-     * next element. Not doing anything will result in a never-ending loop.
-     *
-     * If you just want to skip parsing for this element altogether, you can
-     * just call $reader->next();
-     *
-     * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
-     * the next element.
-     *
-     * @param Reader $reader
-     * @return mixed
-     */
-    static function xmlDeserialize(Reader $reader) {
-
-        return
-            new self(new DateTime($reader->parseInnerTree()));
-
-    }
+	/**
+	 * time
+	 *
+	 * @var DateTime
+	 */
+	public $time;
+
+	/**
+	 * Constructor
+	 *
+	 * @param int|DateTime $time
+	 */
+	public function __construct($time) {
+
+		if ($time instanceof DateTime) {
+			$this->time = clone $time;
+		} else {
+			$this->time = new DateTime('@' . $time);
+		}
+
+		// Setting timezone to UTC
+		$this->time->setTimezone(new DateTimeZone('UTC'));
+
+	}
+
+	/**
+	 * getTime
+	 *
+	 * @return DateTime
+	 */
+	public function getTime() {
+
+		return $this->time;
+
+	}
+
+	/**
+	 * The serialize method is called during xml writing.
+	 *
+	 * It should use the $writer argument to encode this object into XML.
+	 *
+	 * Important note: it is not needed to create the parent element. The
+	 * parent element is already created, and we only have to worry about
+	 * attributes, child elements and text (if any).
+	 *
+	 * Important note 2: If you are writing any new elements, you are also
+	 * responsible for closing them.
+	 *
+	 * @param Writer $writer
+	 * @return void
+	 */
+	public function xmlSerialize(Writer $writer) {
+
+		$writer->write(
+			HTTP\Util::toHTTPDate($this->time)
+		);
+
+	}
+
+	/**
+	 * The deserialize method is called during xml parsing.
+	 *
+	 * This method is called statictly, this is because in theory this method
+	 * may be used as a type of constructor, or factory method.
+	 *
+	 * Often you want to return an instance of the current class, but you are
+	 * free to return other data as well.
+	 *
+	 * Important note 2: You are responsible for advancing the reader to the
+	 * next element. Not doing anything will result in a never-ending loop.
+	 *
+	 * If you just want to skip parsing for this element altogether, you can
+	 * just call $reader->next();
+	 *
+	 * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
+	 * the next element.
+	 *
+	 * @param Reader $reader
+	 * @return mixed
+	 */
+	static function xmlDeserialize(Reader $reader) {
+
+		return
+			new self(new DateTime($reader->parseInnerTree()));
+
+	}
 }

libraries/SabreDAV/DAV/Xml/Request/Lock.php

Doc Comments +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
      * the next element.
      *
      * @param Reader $reader
-     * @return mixed
+     * @return Lock
      */
     static function xmlDeserialize(Reader $reader) {
 

Indentation +49 added lines, -49 removed lines

@@ -20,62 +20,62 @@
  */
 class Lock implements XmlDeserializable {
 
-    /**
-     * Owner of the lock
-     *
-     * @var string
-     */
-    public $owner;
+	/**
+	 * Owner of the lock
+	 *
+	 * @var string
+	 */
+	public $owner;
 
-    /**
-     * Scope of the lock.
-     *
-     * Either LockInfo::SHARED or LockInfo::EXCLUSIVE
-     * @var int
-     */
-    public $scope;
+	/**
+	 * Scope of the lock.
+	 *
+	 * Either LockInfo::SHARED or LockInfo::EXCLUSIVE
+	 * @var int
+	 */
+	public $scope;
 
-    /**
-     * The deserialize method is called during xml parsing.
-     *
-     * This method is called statictly, this is because in theory this method
-     * may be used as a type of constructor, or factory method.
-     *
-     * Often you want to return an instance of the current class, but you are
-     * free to return other data as well.
-     *
-     * You are responsible for advancing the reader to the next element. Not
-     * doing anything will result in a never-ending loop.
-     *
-     * If you just want to skip parsing for this element altogether, you can
-     * just call $reader->next();
-     *
-     * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
-     * the next element.
-     *
-     * @param Reader $reader
-     * @return mixed
-     */
-    static function xmlDeserialize(Reader $reader) {
+	/**
+	 * The deserialize method is called during xml parsing.
+	 *
+	 * This method is called statictly, this is because in theory this method
+	 * may be used as a type of constructor, or factory method.
+	 *
+	 * Often you want to return an instance of the current class, but you are
+	 * free to return other data as well.
+	 *
+	 * You are responsible for advancing the reader to the next element. Not
+	 * doing anything will result in a never-ending loop.
+	 *
+	 * If you just want to skip parsing for this element altogether, you can
+	 * just call $reader->next();
+	 *
+	 * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
+	 * the next element.
+	 *
+	 * @param Reader $reader
+	 * @return mixed
+	 */
+	static function xmlDeserialize(Reader $reader) {
 
-        $reader->pushContext();
-        $reader->elementMap['{DAV:}owner'] = 'Sabre\\Xml\\Element\\XmlFragment';
+		$reader->pushContext();
+		$reader->elementMap['{DAV:}owner'] = 'Sabre\\Xml\\Element\\XmlFragment';
 
-        $values = KeyValue::xmlDeserialize($reader);
+		$values = KeyValue::xmlDeserialize($reader);
 
-        $reader->popContext();
+		$reader->popContext();
 
-        $new = new self();
-        $new->owner = !empty($values['{DAV:}owner']) ? $values['{DAV:}owner']->getXml() : null;
-        $new->scope = LockInfo::SHARED;
+		$new = new self();
+		$new->owner = !empty($values['{DAV:}owner']) ? $values['{DAV:}owner']->getXml() : null;
+		$new->scope = LockInfo::SHARED;
 
-        if (isset($values['{DAV:}lockscope'])) {
-            foreach ($values['{DAV:}lockscope'] as $elem) {
-                if ($elem['name'] === '{DAV:}exclusive') $new->scope = LockInfo::EXCLUSIVE;
-            }
-        }
-        return $new;
+		if (isset($values['{DAV:}lockscope'])) {
+			foreach ($values['{DAV:}lockscope'] as $elem) {
+				if ($elem['name'] === '{DAV:}exclusive') $new->scope = LockInfo::EXCLUSIVE;
+			}
+		}
+		return $new;
 
-    }
+	}
 
 }

Braces +3 added lines, -1 removed lines

@@ -71,7 +71,9 @@
 
         if (isset($values['{DAV:}lockscope'])) {
             foreach ($values['{DAV:}lockscope'] as $elem) {
-                if ($elem['name'] === '{DAV:}exclusive') $new->scope = LockInfo::EXCLUSIVE;
+                if ($elem['name'] === '{DAV:}exclusive') {
+                	$new->scope = LockInfo::EXCLUSIVE;
+                }
             }
         }
         return $new;

libraries/SabreDAV/DAV/Xml/Request/MkCol.php

Doc Comments +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
      * the next element.
      *
      * @param Reader $reader
-     * @return mixed
+     * @return MkCol
      */
     static function xmlDeserialize(Reader $reader) {
 

Indentation +50 added lines, -50 removed lines

@@ -18,65 +18,65 @@
  */
 class MkCol implements XmlDeserializable {
 
-    /**
-     * The list of properties that will be set.
-     *
-     * @var array
-     */
-    protected $properties = [];
+	/**
+	 * The list of properties that will be set.
+	 *
+	 * @var array
+	 */
+	protected $properties = [];
 
-    /**
-     * Returns a key=>value array with properties that are supposed to get set
-     * during creation of the new collection.
-     *
-     * @return array
-     */
-    public function getProperties() {
+	/**
+	 * Returns a key=>value array with properties that are supposed to get set
+	 * during creation of the new collection.
+	 *
+	 * @return array
+	 */
+	public function getProperties() {
 
-        return $this->properties;
+		return $this->properties;
 
-    }
+	}
 
-    /**
-     * The deserialize method is called during xml parsing.
-     *
-     * This method is called statictly, this is because in theory this method
-     * may be used as a type of constructor, or factory method.
-     *
-     * Often you want to return an instance of the current class, but you are
-     * free to return other data as well.
-     *
-     * You are responsible for advancing the reader to the next element. Not
-     * doing anything will result in a never-ending loop.
-     *
-     * If you just want to skip parsing for this element altogether, you can
-     * just call $reader->next();
-     *
-     * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
-     * the next element.
-     *
-     * @param Reader $reader
-     * @return mixed
-     */
-    static function xmlDeserialize(Reader $reader) {
+	/**
+	 * The deserialize method is called during xml parsing.
+	 *
+	 * This method is called statictly, this is because in theory this method
+	 * may be used as a type of constructor, or factory method.
+	 *
+	 * Often you want to return an instance of the current class, but you are
+	 * free to return other data as well.
+	 *
+	 * You are responsible for advancing the reader to the next element. Not
+	 * doing anything will result in a never-ending loop.
+	 *
+	 * If you just want to skip parsing for this element altogether, you can
+	 * just call $reader->next();
+	 *
+	 * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
+	 * the next element.
+	 *
+	 * @param Reader $reader
+	 * @return mixed
+	 */
+	static function xmlDeserialize(Reader $reader) {
 
-        $self = new self();
+		$self = new self();
 
-        $elementMap = $reader->elementMap;
-        $elementMap['{DAV:}prop']   = 'Sabre\DAV\Xml\Element\Prop';
-        $elementMap['{DAV:}set']    = 'Sabre\Xml\Element\KeyValue';
-        $elementMap['{DAV:}remove'] = 'Sabre\Xml\Element\KeyValue';
+		$elementMap = $reader->elementMap;
+		$elementMap['{DAV:}prop']   = 'Sabre\DAV\Xml\Element\Prop';
+		$elementMap['{DAV:}set']    = 'Sabre\Xml\Element\KeyValue';
+		$elementMap['{DAV:}remove'] = 'Sabre\Xml\Element\KeyValue';
 
-        $elems = $reader->parseInnerTree($elementMap);
+		$elems = $reader->parseInnerTree($elementMap);
 
-        foreach ($elems as $elem) {
-            if ($elem['name'] === '{DAV:}set') {
-                $self->properties = array_merge($self->properties, $elem['value']['{DAV:}prop']);
-            }
-        }
+		foreach ($elems as $elem) {
+			if ($elem['name'] === '{DAV:}set') {
+				$self->properties = array_merge($self->properties, $elem['value']['{DAV:}prop']);
+			}
+		}
 
-        return $self;
+		return $self;
 
-    }
+	}
 
 }

libraries/SabreDAV/DAV/Xml/Request/PropFind.php

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
      * the next element.
      *
      * @param Reader $reader
-     * @return mixed
+     * @return PropFind
      */
     static function xmlDeserialize(Reader $reader) {
 

Indentation +60 added lines, -60 removed lines

@@ -19,65 +19,65 @@
  */
 class PropFind implements XmlDeserializable {
 
-    /**
-     * If this is set to true, this was an 'allprop' request.
-     *
-     * @var bool
-     */
-    public $allProp = false;
-
-    /**
-     * The property list
-     *
-     * @var null|array
-     */
-    public $properties;
-
-    /**
-     * The deserialize method is called during xml parsing.
-     *
-     * This method is called statictly, this is because in theory this method
-     * may be used as a type of constructor, or factory method.
-     *
-     * Often you want to return an instance of the current class, but you are
-     * free to return other data as well.
-     *
-     * You are responsible for advancing the reader to the next element. Not
-     * doing anything will result in a never-ending loop.
-     *
-     * If you just want to skip parsing for this element altogether, you can
-     * just call $reader->next();
-     *
-     * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
-     * the next element.
-     *
-     * @param Reader $reader
-     * @return mixed
-     */
-    static function xmlDeserialize(Reader $reader) {
-
-        $self = new self();
-
-        $reader->pushContext();
-        $reader->elementMap['{DAV:}prop'] = 'Sabre\Xml\Element\Elements';
-
-        foreach (KeyValue::xmlDeserialize($reader) as $k => $v) {
-
-            switch ($k) {
-                case '{DAV:}prop' :
-                    $self->properties = $v;
-                    break;
-                case '{DAV:}allprop' :
-                    $self->allProp = true;
-
-            }
-
-        }
-
-        $reader->popContext();
-
-        return $self;
-
-    }
+	/**
+	 * If this is set to true, this was an 'allprop' request.
+	 *
+	 * @var bool
+	 */
+	public $allProp = false;
+
+	/**
+	 * The property list
+	 *
+	 * @var null|array
+	 */
+	public $properties;
+
+	/**
+	 * The deserialize method is called during xml parsing.
+	 *
+	 * This method is called statictly, this is because in theory this method
+	 * may be used as a type of constructor, or factory method.
+	 *
+	 * Often you want to return an instance of the current class, but you are
+	 * free to return other data as well.
+	 *
+	 * You are responsible for advancing the reader to the next element. Not
+	 * doing anything will result in a never-ending loop.
+	 *
+	 * If you just want to skip parsing for this element altogether, you can
+	 * just call $reader->next();
+	 *
+	 * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
+	 * the next element.
+	 *
+	 * @param Reader $reader
+	 * @return mixed
+	 */
+	static function xmlDeserialize(Reader $reader) {
+
+		$self = new self();
+
+		$reader->pushContext();
+		$reader->elementMap['{DAV:}prop'] = 'Sabre\Xml\Element\Elements';
+
+		foreach (KeyValue::xmlDeserialize($reader) as $k => $v) {
+
+			switch ($k) {
+				case '{DAV:}prop' :
+					$self->properties = $v;
+					break;
+				case '{DAV:}allprop' :
+					$self->allProp = true;
+
+			}
+
+		}
+
+		$reader->popContext();
+
+		return $self;
+
+	}
 
 }

libraries/SabreDAV/DAV/Xml/Request/PropPatch.php

Doc Comments +1 added lines, -1 removed lines

@@ -84,7 +84,7 @@
      * the next element.
      *
      * @param Reader $reader
-     * @return mixed
+     * @return PropPatch
      */
     static function xmlDeserialize(Reader $reader) {
 

Indentation +95 added lines, -95 removed lines

@@ -19,100 +19,100 @@
  */
 class PropPatch implements Element {
 
-    /**
-     * The list of properties that will be updated and removed.
-     *
-     * If a property will be removed, it's value will be set to null.
-     *
-     * @var array
-     */
-    public $properties = [];
-
-    /**
-     * The xmlSerialize metod is called during xml writing.
-     *
-     * Use the $writer argument to write its own xml serialization.
-     *
-     * An important note: do _not_ create a parent element. Any element
-     * implementing XmlSerializble should only ever write what's considered
-     * its 'inner xml'.
-     *
-     * The parent of the current element is responsible for writing a
-     * containing element.
-     *
-     * This allows serializers to be re-used for different element names.
-     *
-     * If you are opening new elements, you must also close them again.
-     *
-     * @param Writer $writer
-     * @return void
-     */
-    public function xmlSerialize(Writer $writer) {
-
-        foreach ($this->properties as $propertyName => $propertyValue) {
-
-            if (is_null($propertyValue)) {
-                $writer->startElement("{DAV:}remove");
-                $writer->write(['{DAV:}prop' => [$propertyName => $propertyValue]]);
-                $writer->endElement();
-            } else {
-                $writer->startElement("{DAV:}set");
-                $writer->write(['{DAV:}prop' => [$propertyName => $propertyValue]]);
-                $writer->endElement();
-            }
-
-        }
-
-    }
-
-    /**
-     * The deserialize method is called during xml parsing.
-     *
-     * This method is called statictly, this is because in theory this method
-     * may be used as a type of constructor, or factory method.
-     *
-     * Often you want to return an instance of the current class, but you are
-     * free to return other data as well.
-     *
-     * You are responsible for advancing the reader to the next element. Not
-     * doing anything will result in a never-ending loop.
-     *
-     * If you just want to skip parsing for this element altogether, you can
-     * just call $reader->next();
-     *
-     * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
-     * the next element.
-     *
-     * @param Reader $reader
-     * @return mixed
-     */
-    static function xmlDeserialize(Reader $reader) {
-
-        $self = new self();
-
-        $elementMap = $reader->elementMap;
-        $elementMap['{DAV:}prop']   = 'Sabre\DAV\Xml\Element\Prop';
-        $elementMap['{DAV:}set']    = 'Sabre\Xml\Element\KeyValue';
-        $elementMap['{DAV:}remove'] = 'Sabre\Xml\Element\KeyValue';
-
-        $elems = $reader->parseInnerTree($elementMap);
-
-        foreach ($elems as $elem) {
-            if ($elem['name'] === '{DAV:}set') {
-                $self->properties = array_merge($self->properties, $elem['value']['{DAV:}prop']);
-            }
-            if ($elem['name'] === '{DAV:}remove') {
-
-                // Ensuring there are no values.
-                foreach ($elem['value']['{DAV:}prop'] as $remove => $value) {
-                    $self->properties[$remove] = null;
-                }
-
-            }
-        }
-
-        return $self;
-
-    }
+	/**
+	 * The list of properties that will be updated and removed.
+	 *
+	 * If a property will be removed, it's value will be set to null.
+	 *
+	 * @var array
+	 */
+	public $properties = [];
+
+	/**
+	 * The xmlSerialize metod is called during xml writing.
+	 *
+	 * Use the $writer argument to write its own xml serialization.
+	 *
+	 * An important note: do _not_ create a parent element. Any element
+	 * implementing XmlSerializble should only ever write what's considered
+	 * its 'inner xml'.
+	 *
+	 * The parent of the current element is responsible for writing a
+	 * containing element.
+	 *
+	 * This allows serializers to be re-used for different element names.
+	 *
+	 * If you are opening new elements, you must also close them again.
+	 *
+	 * @param Writer $writer
+	 * @return void
+	 */
+	public function xmlSerialize(Writer $writer) {
+
+		foreach ($this->properties as $propertyName => $propertyValue) {
+
+			if (is_null($propertyValue)) {
+				$writer->startElement("{DAV:}remove");
+				$writer->write(['{DAV:}prop' => [$propertyName => $propertyValue]]);
+				$writer->endElement();
+			} else {
+				$writer->startElement("{DAV:}set");
+				$writer->write(['{DAV:}prop' => [$propertyName => $propertyValue]]);
+				$writer->endElement();
+			}
+
+		}
+
+	}
+
+	/**
+	 * The deserialize method is called during xml parsing.
+	 *
+	 * This method is called statictly, this is because in theory this method
+	 * may be used as a type of constructor, or factory method.
+	 *
+	 * Often you want to return an instance of the current class, but you are
+	 * free to return other data as well.
+	 *
+	 * You are responsible for advancing the reader to the next element. Not
+	 * doing anything will result in a never-ending loop.
+	 *
+	 * If you just want to skip parsing for this element altogether, you can
+	 * just call $reader->next();
+	 *
+	 * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
+	 * the next element.
+	 *
+	 * @param Reader $reader
+	 * @return mixed
+	 */
+	static function xmlDeserialize(Reader $reader) {
+
+		$self = new self();
+
+		$elementMap = $reader->elementMap;
+		$elementMap['{DAV:}prop']   = 'Sabre\DAV\Xml\Element\Prop';
+		$elementMap['{DAV:}set']    = 'Sabre\Xml\Element\KeyValue';
+		$elementMap['{DAV:}remove'] = 'Sabre\Xml\Element\KeyValue';
+
+		$elems = $reader->parseInnerTree($elementMap);
+
+		foreach ($elems as $elem) {
+			if ($elem['name'] === '{DAV:}set') {
+				$self->properties = array_merge($self->properties, $elem['value']['{DAV:}prop']);
+			}
+			if ($elem['name'] === '{DAV:}remove') {
+
+				// Ensuring there are no values.
+				foreach ($elem['value']['{DAV:}prop'] as $remove => $value) {
+					$self->properties[$remove] = null;
+				}
+
+			}
+		}
+
+		return $self;
+
+	}
 
 }

libraries/SabreDAV/DAV/Xml/Request/SyncCollectionReport.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
      * the next element.
      *
      * @param Reader $reader
-     * @return mixed
+     * @return SyncCollectionReport
      */
     static function xmlDeserialize(Reader $reader) {
 

Unused Use Statements +2 added lines, -2 removed lines

@@ -2,10 +2,10 @@
 
 namespace Sabre\DAV\Xml\Request;
 
+use Sabre\DAV\Exception\BadRequest;
+use Sabre\Xml\Element\KeyValue;
 use Sabre\Xml\Reader;
 use Sabre\Xml\XmlDeserializable;
-use Sabre\Xml\Element\KeyValue;
-use Sabre\DAV\Exception\BadRequest;
 
 /**
  * SyncCollection request parser.

Indentation +98 added lines, -98 removed lines

@@ -20,103 +20,103 @@
  */
 class SyncCollectionReport implements XmlDeserializable {
 
-    /**
-     * The sync-token the client supplied for the report.
-     *
-     * @var string|null
-     */
-    public $syncToken;
-
-    /**
-     * The 'depth' of the sync the client is interested in.
-     *
-     * @var int
-     */
-    public $syncLevel;
-
-    /**
-     * Maximum amount of items returned.
-     *
-     * @var int|null
-     */
-    public $limit;
-
-    /**
-     * The list of properties that are being requested for every change.
-     *
-     * @var null|array
-     */
-    public $properties;
-
-    /**
-     * The deserialize method is called during xml parsing.
-     *
-     * This method is called statictly, this is because in theory this method
-     * may be used as a type of constructor, or factory method.
-     *
-     * Often you want to return an instance of the current class, but you are
-     * free to return other data as well.
-     *
-     * You are responsible for advancing the reader to the next element. Not
-     * doing anything will result in a never-ending loop.
-     *
-     * If you just want to skip parsing for this element altogether, you can
-     * just call $reader->next();
-     *
-     * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
-     * the next element.
-     *
-     * @param Reader $reader
-     * @return mixed
-     */
-    static function xmlDeserialize(Reader $reader) {
-
-        $self = new self();
-
-        $reader->pushContext();
-
-        $reader->elementMap['{DAV:}prop']   = 'Sabre\Xml\Element\Elements';
-        $elems = KeyValue::xmlDeserialize($reader);
-
-        $reader->popContext();
-
-        $required = [
-            '{DAV:}sync-token',
-            '{DAV:}prop',
-            ];
-
-        foreach ($required as $elem) {
-            if (!array_key_exists($elem, $elems)) {
-                throw new BadRequest('The ' . $elem . ' element in the {DAV:}sync-collection report is required');
-            }
-        }
-
-
-        $self->properties = $elems['{DAV:}prop'];
-        $self->syncToken = $elems['{DAV:}sync-token'];
-
-        if (isset($elems['{DAV:}limit'])) {
-            $nresults = null;
-            foreach ($elems['{DAV:}limit'] as $child) {
-                if ($child['name'] === '{DAV:}nresults') {
-                    $nresults = (int)$child['value'];
-                }
-            }
-            $self->limit = $nresults;
-        }
-
-        if (isset($elems['{DAV:}sync-level'])) {
-
-            $value = $elems['{DAV:}sync-level'];
-            if ($value === 'infinity') {
-                $value = \Sabre\DAV\Server::DEPTH_INFINITY;
-            }
-            $self->syncLevel = $value;
-
-        }
-
-        return $self;
-
-    }
+	/**
+	 * The sync-token the client supplied for the report.
+	 *
+	 * @var string|null
+	 */
+	public $syncToken;
+
+	/**
+	 * The 'depth' of the sync the client is interested in.
+	 *
+	 * @var int
+	 */
+	public $syncLevel;
+
+	/**
+	 * Maximum amount of items returned.
+	 *
+	 * @var int|null
+	 */
+	public $limit;
+
+	/**
+	 * The list of properties that are being requested for every change.
+	 *
+	 * @var null|array
+	 */
+	public $properties;
+
+	/**
+	 * The deserialize method is called during xml parsing.
+	 *
+	 * This method is called statictly, this is because in theory this method
+	 * may be used as a type of constructor, or factory method.
+	 *
+	 * Often you want to return an instance of the current class, but you are
+	 * free to return other data as well.
+	 *
+	 * You are responsible for advancing the reader to the next element. Not
+	 * doing anything will result in a never-ending loop.
+	 *
+	 * If you just want to skip parsing for this element altogether, you can
+	 * just call $reader->next();
+	 *
+	 * $reader->parseInnerTree() will parse the entire sub-tree, and advance to
+	 * the next element.
+	 *
+	 * @param Reader $reader
+	 * @return mixed
+	 */
+	static function xmlDeserialize(Reader $reader) {
+
+		$self = new self();
+
+		$reader->pushContext();
+
+		$reader->elementMap['{DAV:}prop']   = 'Sabre\Xml\Element\Elements';
+		$elems = KeyValue::xmlDeserialize($reader);
+
+		$reader->popContext();
+
+		$required = [
+			'{DAV:}sync-token',
+			'{DAV:}prop',
+			];
+
+		foreach ($required as $elem) {
+			if (!array_key_exists($elem, $elems)) {
+				throw new BadRequest('The ' . $elem . ' element in the {DAV:}sync-collection report is required');
+			}
+		}
+
+
+		$self->properties = $elems['{DAV:}prop'];
+		$self->syncToken = $elems['{DAV:}sync-token'];
+
+		if (isset($elems['{DAV:}limit'])) {
+			$nresults = null;
+			foreach ($elems['{DAV:}limit'] as $child) {
+				if ($child['name'] === '{DAV:}nresults') {
+					$nresults = (int)$child['value'];
+				}
+			}
+			$self->limit = $nresults;
+		}
+
+		if (isset($elems['{DAV:}sync-level'])) {
+
+			$value = $elems['{DAV:}sync-level'];
+			if ($value === 'infinity') {
+				$value = \Sabre\DAV\Server::DEPTH_INFINITY;
+			}
+			$self->syncLevel = $value;
+
+		}
+
+		return $self;
+
+	}
 
 }

Spacing +2 added lines, -2 removed lines

@@ -75,7 +75,7 @@ 
 
         $reader->pushContext();
 
-        $reader->elementMap['{DAV:}prop']   = 'Sabre\Xml\Element\Elements';
+        $reader->elementMap['{DAV:}prop'] = 'Sabre\Xml\Element\Elements';
         $elems = KeyValue::xmlDeserialize($reader);
 
         $reader->popContext();
@@ -99,7 +99,7 @@ 
             $nresults = null;
             foreach ($elems['{DAV:}limit'] as $child) {
                 if ($child['name'] === '{DAV:}nresults') {
-                    $nresults = (int)$child['value'];
+                    $nresults = (int) $child['value'];
                 }
             }
             $self->limit = $nresults;