Passed
Pull Request — developer (#15350)
by Arkadiusz
20:22
created
api/webservice/RestApi/Users/Record.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@
 block discarded – undo
152 152
 				$rawData[$fieldModel->getName() . '_info'] = \Vtiger_Taxes_UIType::getValues($rawData[$fieldModel->getName()]);
153 153
 			}
154 154
 		}
155
-		unset($fieldsLabel['user_password'],$fieldsLabel['confirm_password'],$fieldsLabel['accesskey'],$displayData['user_password'],$displayData['confirm_password'],$displayData['accesskey'],$rawData['user_password'],$rawData['confirm_password'],$rawData['accesskey']);
155
+		unset($fieldsLabel['user_password'], $fieldsLabel['confirm_password'], $fieldsLabel['accesskey'], $displayData['user_password'], $displayData['confirm_password'], $displayData['accesskey'], $rawData['user_password'], $rawData['confirm_password'], $rawData['accesskey']);
156 156
 		$response = [
157 157
 			'name' => \App\Purifier::decodeHtml($this->recordModel->getName()),
158 158
 			'id' => $this->recordModel->getId(),
Please login to merge, or discard this patch.
app/Utils/Benchmarks.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -193,7 +193,7 @@
 block discarded – undo
193 193
 				'time' => (int) ($readOperations / (microtime(true) - $timeStart)),
194 194
 			];
195 195
 		}
196
-		register_shutdown_function(function () {
196
+		register_shutdown_function(function() {
197 197
 			\vtlib\Functions::recurseDelete('cache/speed');
198 198
 		});
199 199
 		return [
Please login to merge, or discard this patch.
app/MeetingService.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -133,13 +133,13 @@
 block discarded – undo
133 133
 	public function generateRoomName(string $prefix = ''): string
134 134
 	{
135 135
 		$prefix = preg_replace_callback_array([
136
-			'/[^a-z0-9 ]/' => function () {
136
+			'/[^a-z0-9 ]/' => function() {
137 137
 				return '';
138 138
 			},
139
-			'/\b[a-z]/' => function ($matches) {
139
+			'/\b[a-z]/' => function($matches) {
140 140
 				return mb_strtoupper($matches[0]);
141 141
 			},
142
-			'/[\s]/' => function () {
142
+			'/[\s]/' => function() {
143 143
 				return '';
144 144
 			},
145 145
 		], strtolower(\App\Utils::sanitizeSpecialChars($prefix, ' ')));
Please login to merge, or discard this patch.
modules/Calendar/views/RightPanel.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
 		}
56 56
 		if (!empty($users) && $favouriteUsers = $currentUser->getFavouritesUsers()) {
57 57
 			uksort($users,
58
-				function ($a, $b) use ($favouriteUsers) {
58
+				function($a, $b) use ($favouriteUsers) {
59 59
 					return (int) (!isset($favouriteUsers[$a]) && isset($favouriteUsers[$b]));
60 60
 				});
61 61
 			$viewer->assign('FAVOURITES_USERS', $favouriteUsers);
Please login to merge, or discard this patch.
app/QueryGenerator.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -966,7 +966,7 @@  discard block
 block discarded – undo
966 966
 			$subQuery->andHaving((new \yii\db\Expression('COUNT(1) > 1')));
967 967
 			$this->joins['duplicates'] = ['INNER JOIN', ['duplicates' => $subQuery], implode(' AND ', $duplicateCheckClause)];
968 968
 		}
969
-		uksort($this->joins, function ($a, $b) use ($moduleTableIndexList) {
969
+		uksort($this->joins, function($a, $b) use ($moduleTableIndexList) {
970 970
 			return (int) (!isset($moduleTableIndexList[$a]) && isset($moduleTableIndexList[$b]));
971 971
 		});
972 972
 		foreach ($this->joins as $join) {
@@ -1362,7 +1362,7 @@  discard block
 block discarded – undo
1362 1362
 			$searchParamsConditions['condition'] = $glueOrder[$key];
1363 1363
 			$searchParamsConditions['rules'] = [];
1364 1364
 			foreach ($conditions as $condition) {
1365
-				[$fieldName, , $sourceFieldName] = array_pad(explode(':', $condition[0]), 3, false);
1365
+				[$fieldName,, $sourceFieldName] = array_pad(explode(':', $condition[0]), 3, false);
1366 1366
 				if (!$sourceFieldName) {
1367 1367
 					$condition[0] = "{$fieldName}:{$this->getModule()}";
1368 1368
 				}
Please login to merge, or discard this patch.
modules/Vtiger/models/Module.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -675,7 +675,7 @@
 block discarded – undo
675 675
 	{
676 676
 		$quickCreateFieldList = [];
677 677
 		foreach ($this->getFieldsByBlocks() as $blockFields) {
678
-			uksort($blockFields, function ($a, $b) use ($blockFields) {
678
+			uksort($blockFields, function($a, $b) use ($blockFields) {
679 679
 				if ($blockFields[$a]->get('quicksequence') === $blockFields[$b]->get('quicksequence')) {
680 680
 					return 0;
681 681
 				}
Please login to merge, or discard this patch.
vtlib/Vtiger/Link.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@
 block discarded – undo
185 185
 				if (self::IGNORE_MODULE === $tabid) {
186 186
 					$permittedTabIdList = \vtlib\Deprecated::getPermittedModuleIdList();
187 187
 					if (!empty($permittedTabIdList)) {
188
-						$permittedTabIdList[] = 0;  // Added to support one link for all modules
188
+						$permittedTabIdList[] = 0; // Added to support one link for all modules
189 189
 						foreach ($permittedTabIdList as $moduleId) {
190 190
 							foreach ($type as $typ) {
191 191
 								if (isset($rows[$moduleId][$typ])) {
Please login to merge, or discard this patch.
modules/Vtiger/models/ChartFilter.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -619,7 +619,7 @@  discard block
 block discarded – undo
619 619
 		$colors = \App\Fields\Picklist::getColors($fieldName);
620 620
 		$this->colorsFrom = 'picklist';
621 621
 		$this->colorsFromRow = 'picklist_id';
622
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) use ($colors) {
622
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) use ($colors) {
623 623
 			if (isset($colors[$row['picklist_id']])) {
624 624
 				$this->colors[$row['picklist_id']] = $colors[$row['picklist_id']];
625 625
 			}
@@ -634,7 +634,7 @@  discard block
 block discarded – undo
634 634
 		$this->colorsFrom = 'filters';
635 635
 		$this->colorsFromRow = 'color';
636 636
 		$colors = \App\Colors::getAllFilterColors();
637
-		$this->iterateAllRows(function (&$row, $groupValue, $dividingValue, $rowIndex) use ($colors) {
637
+		$this->iterateAllRows(function(&$row, $groupValue, $dividingValue, $rowIndex) use ($colors) {
638 638
 			$this->colors[$dividingValue] = $colors[$this->filterIds[$dividingValue]] ?? null;
639 639
 		});
640 640
 	}
@@ -646,7 +646,7 @@  discard block
 block discarded – undo
646 646
 	{
647 647
 		$this->colorsFrom = 'assigned_user_id';
648 648
 		$this->colorsFromRow = 'assigned_user_id';
649
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) {
649
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) {
650 650
 			$this->colors[$row['assigned_user_id']] = \App\Fields\Owner::getColor($row['assigned_user_id']);
651 651
 		});
652 652
 	}
@@ -658,7 +658,7 @@  discard block
 block discarded – undo
658 658
 	{
659 659
 		$this->colorsFrom = 'record_id';
660 660
 		$this->colorsFromRow = 'id';
661
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) {
661
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) {
662 662
 			$this->colors[$row['id']] = \App\Colors::getRandomColor('from_id_' . $row['id']);
663 663
 		});
664 664
 	}
@@ -670,7 +670,7 @@  discard block
 block discarded – undo
670 670
 	{
671 671
 		$this->colorsFrom = 'record_number';
672 672
 		$this->colorsFromRow = 'record_number';
673
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) {
673
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) {
674 674
 			$this->colors[$groupValue] = \App\Colors::getRandomColor('generated_' . $groupValue);
675 675
 		});
676 676
 	}
@@ -895,7 +895,7 @@  discard block
 block discarded – undo
895 895
 					$firstReturnValueForSort = 1;
896 896
 					$secondReturnValueForSort = -1;
897 897
 				}
898
-				uksort($dataForSort, function ($a, $b) use ($dataForSort, $firstReturnValueForSort, $secondReturnValueForSort) {
898
+				uksort($dataForSort, function($a, $b) use ($dataForSort, $firstReturnValueForSort, $secondReturnValueForSort) {
899 899
 					if ($dataForSort[$a]['avg'] === $dataForSort[$b]['avg']) {
900 900
 						return 0;
901 901
 					}
@@ -998,7 +998,7 @@  discard block
 block discarded – undo
998 998
 		$this->calculateAverage();
999 999
 		$this->normalizeData();
1000 1000
 		$this->setColorsFrom($this->findOutColorsFromRows());
1001
-		$this->iterateAllRows(function ($row, $groupValue, $dividingValue, $rowIndex) {
1001
+		$this->iterateAllRows(function($row, $groupValue, $dividingValue, $rowIndex) {
1002 1002
 			$this->setColorFromRow($row, $groupValue, $dividingValue);
1003 1003
 		});
1004 1004
 		return $this->data;
Please login to merge, or discard this patch.
modules/OSSMail/models/Record.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -178,7 +178,7 @@
 block discarded – undo
178 178
 					->execute();
179 179
 			}
180 180
 			\App\Log::trace('Exit OSSMail_Record_Model::imapConnect() method ...');
181
-			register_shutdown_function(function () use ($mbox, $user) {
181
+			register_shutdown_function(function() use ($mbox, $user) {
182 182
 				\App\Log::beginProfile('OSSMail_Record_Model|imap_close|' . $user, 'Mail|IMAP');
183 183
 				imap_close($mbox);
184 184
 				\App\Log::endProfile('OSSMail_Record_Model|imap_close|' . $user, 'Mail|IMAP');
Please login to merge, or discard this patch.