YetiForceCompany / YetiForceCRM

vtlib/tools/console.php

Doc Comments +13 added lines

@@ -32,6 +32,9 @@ 
 		
 	}
 
+	/**
+	 * @param boolean $interactive
+	 */
 	public function setArguments($args, $interactive)
 	{
 		$this->arguments = $args;
@@ -156,11 +159,18 @@ 
 		} while (true);
 	}
 
+	/**
+	 * @return string
+	 */
 	protected function toAlphaNumeric($value)
 	{
 		return preg_replace("/[^a-zA-Z0-9_]/", "", $value);
 	}
 
+	/**
+	 * @param string $dir
+	 * @param string $file_pattern
+	 */
 	protected function findFiles($dir, $file_pattern, &$files)
 	{
 		$items = glob($dir . '/*', GLOB_NOSORT);
@@ -257,6 +267,9 @@ 
 		echo "DONE.\n";
 	}
 
+	/**
+	 * @param string $name
+	 */
 	public function find($name)
 	{
 		return vtlib\Module::getInstance($name);

Spacing +1 added lines, -1 removed lines

@@ -401,7 +401,7 @@
 					if (!file_exists($tplpath . $tplname)) {
 						$initialContent = "{* License Text *}\n";
 						// Enable debug to make it easy to implement.
-						$initialContent.= "{debug}{* REMOVE THIS LINE AFTER IMPLEMENTATION *}\n\n";
+						$initialContent .= "{debug}{* REMOVE THIS LINE AFTER IMPLEMENTATION *}\n\n";
 						file_put_contents($tplpath . $tplname, $initialContent);
 					}
 					file_put_contents($tplpath . $tplname, "{* $file *}\n", FILE_APPEND);

Braces +6 added lines, -4 removed lines

@@ -116,8 +116,9 @@ 
 	protected function prompt($msg = '', $type = self::PROMPT_ANY)
 	{
 		do {
-			if ($msg)
-				echo $msg;
+			if ($msg) {
+							echo $msg;
+			}
 			$value = trim(fgets(STDIN));
 
 			if (!$value && $type == self::PROMPT_OPTIONAL) {
@@ -463,8 +464,9 @@ 
 			$filename = basename($file, true);
 			$dir = substr($file, 0, strpos($file, $filename));
 			$dir = str_replace('languages/' . self::BASE_LANG_PREFIX, 'languages/' . $languageInformation['prefix'], $dir);
-			if (!file_exists($dir))
-				mkdir($dir);
+			if (!file_exists($dir)) {
+							mkdir($dir);
+			}
 
 			if (isset($languageInformation['prefix_value'])) {
 				$contents = file_get_contents($file);

vtlib/Vtiger/FieldBasic.php

Doc Comments +1 added lines

@@ -146,6 +146,7 @@
 	/**
 	 * Create this field instance
 	 * @param vtlib\Block Instance of the block to use
+	 * @param boolean $blockInstance
 	 * @access private
 	 */
 	public function __create($blockInstance)

Braces +5 added lines, -4 removed lines

@@ -253,10 +253,11 @@
 	 */
 	public function save($blockInstance = false)
 	{
-		if ($this->id)
-			$this->__update();
-		else
-			$this->__create($blockInstance);
+		if ($this->id) {
+					$this->__update();
+		} else {
+					$this->__create($blockInstance);
+		}
 		return $this->id;
 	}
 

vtlib/Vtiger/LayoutImport.php

Doc Comments +1 added lines

@@ -28,6 +28,7 @@
 	/**
 	 * Initialize Import
 	 * @access private
+	 * @param boolean $overwrite
 	 */
 	public function initImport($zipfile, $overwrite)
 	{

Braces +6 added lines, -4 removed lines

@@ -78,8 +78,9 @@ 
 		foreach ($filelist as $filename => $fileinfo) {
 			if (!$unzip->isdir($filename)) {
 
-				if (strpos($filename, '/') === false)
-					continue;
+				if (strpos($filename, '/') === false) {
+									continue;
+				}
 
 
 				$targetdir = substr($filename, 0, strripos($filename, '/'));
@@ -130,8 +131,9 @@ 
 				}
 			}
 		}
-		if ($unzip)
-			$unzip->close();
+		if ($unzip) {
+					$unzip->close();
+		}
 
 		self::register($name, $label);
 

vtlib/Vtiger/LinkData.php

Doc Comments +3 added lines

@@ -23,6 +23,9 @@
 	protected $user;
 	protected $module;
 
+	/**
+	 * @param Link $link
+	 */
 	public function __construct($link, $user, $input = null)
 	{
 		$this->link = $link;

vtlib/Vtiger/PackageImport.php

Doc Comments +19 added lines

@@ -53,6 +53,7 @@ 
 
 	/**
 	 * Get type of package (as specified in manifest)
+	 * @return string
 	 */
 	public function type()
 	{
@@ -393,6 +394,7 @@ 
 	/**
 	 * Cache the field instance for re-use
 	 * @access private
+	 * @param Field $fieldInstance
 	 */
 	public function __AddModuleFieldToCache($moduleInstance, $fieldname, $fieldInstance)
 	{
@@ -674,6 +676,8 @@ 
 	/**
 	 * Import Blocks of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
+	 * @param Module $moduleInstance
 	 */
 	public function import_Blocks($modulenode, $moduleInstance)
 	{
@@ -717,6 +721,7 @@ 
 	/**
 	 * Import Fields of the module
 	 * @access private
+	 * @param Block $blockInstance
 	 */
 	public function import_Fields($blocknode, $blockInstance, $moduleInstance)
 	{
@@ -807,6 +812,8 @@ 
 	/**
 	 * Import Custom views of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
+	 * @param Module $moduleInstance
 	 */
 	public function import_CustomViews($modulenode, $moduleInstance)
 	{
@@ -851,6 +858,8 @@ 
 	/**
 	 * Import Sharing Access of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
+	 * @param Module $moduleInstance
 	 */
 	public function import_SharingAccess($modulenode, $moduleInstance)
 	{
@@ -867,6 +876,8 @@ 
 	/**
 	 * Import Events of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
+	 * @param Module $moduleInstance
 	 */
 	public function import_Events($modulenode, $moduleInstance)
 	{
@@ -899,6 +910,8 @@ 
 	/**
 	 * Import actions of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
+	 * @param Module $moduleInstance
 	 */
 	public function import_Actions($modulenode, $moduleInstance)
 	{
@@ -925,6 +938,8 @@ 
 	/**
 	 * Import related lists of the module
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
+	 * @param Module $moduleInstance
 	 */
 	public function import_RelatedLists($modulenode, $moduleInstance)
 	{
@@ -1004,6 +1019,7 @@ 
 	/**
 	 * Import cron jobs of the module.
 	 * @access private
+	 * @param \SimpleXMLElement $modulenode
 	 */
 	public function import_CronTasks($modulenode)
 	{
@@ -1022,6 +1038,9 @@ 
 		}
 	}
 
+	/**
+	 * @param \SimpleXMLElement $modulenode
+	 */
 	public function import_update($modulenode)
 	{
 		$dirName = 'cache/updates';

Braces +84 added lines, -56 removed lines

@@ -101,8 +101,9 @@ 
 	{
 		$xpathres = $this->xpath($path);
 		foreach ($xpathres as $pathkey => $pathvalue) {
-			if ($pathkey == $path)
-				return $pathvalue;
+			if ($pathkey == $path) {
+							return $pathvalue;
+			}
 		}
 		return false;
 	}
@@ -121,13 +122,15 @@ 
 
 		if ($packagetype) {
 			$lcasetype = strtolower($packagetype);
-			if ($lcasetype == 'language')
-				return true;
+			if ($lcasetype == 'language') {
+							return true;
+			}
 		}
 		if ($packagetype) {
 			$lcasetype = strtolower($packagetype);
-			if ($lcasetype == 'layout')
-				return true;
+			if ($lcasetype == 'layout') {
+							return true;
+			}
 		}
 		return false;
 	}
@@ -146,8 +149,9 @@ 
 
 		if ($packagetype) {
 			$lcasetype = strtolower($packagetype);
-			if ($lcasetype == 'extension')
-				return true;
+			if ($lcasetype == 'extension') {
+							return true;
+			}
 		}
 		return false;
 	}
@@ -163,8 +167,9 @@ 
 
 		if ($packagetype) {
 			$lcasetype = strtolower($packagetype);
-			if ($lcasetype == 'update')
-				return true;
+			if ($lcasetype == 'update') {
+							return true;
+			}
 		}
 		return false;
 	}
@@ -183,8 +188,9 @@ 
 
 		if ($packagetype) {
 			$lcasetype = strtolower($packagetype);
-			if ($lcasetype == 'layout')
-				return true;
+			if ($lcasetype == 'layout') {
+							return true;
+			}
 		}
 		return false;
 	}
@@ -227,8 +233,9 @@ 
 	public function getParameters()
 	{
 		$parameters = [];
-		if (empty($this->_modulexml->parameters))
-			return $parameters;
+		if (empty($this->_modulexml->parameters)) {
+					return $parameters;
+		}
 		foreach ($this->_modulexml->parameters->parameter as $parameter) {
 			$parameters[] = $parameter;
 		}
@@ -338,17 +345,21 @@ 
 		}
 
 		$validzip = false;
-		if ($manifestxml_found && $languagefile_found && $moduleVersionFound)
-			$validzip = true;
+		if ($manifestxml_found && $languagefile_found && $moduleVersionFound) {
+					$validzip = true;
+		}
 
-		if ($manifestxml_found && $layoutfile_found && $moduleVersionFound)
-			$validzip = true;
+		if ($manifestxml_found && $layoutfile_found && $moduleVersionFound) {
+					$validzip = true;
+		}
 
-		if ($manifestxml_found && $languagefile_found && $extensionfile_found && $moduleVersionFound)
-			$validzip = true;
+		if ($manifestxml_found && $languagefile_found && $extensionfile_found && $moduleVersionFound) {
+					$validzip = true;
+		}
 
-		if ($manifestxml_found && $updatefile_found && $moduleVersionFound)
-			$validzip = true;
+		if ($manifestxml_found && $updatefile_found && $moduleVersionFound) {
+					$validzip = true;
+		}
 
 		if ($validzip) {
 			if (!empty($this->_modulexml->license)) {
@@ -365,8 +376,9 @@ 
 				}
 			}
 		}
-		if ($unzip)
-			$unzip->close();
+		if ($unzip) {
+					$unzip->close();
+		}
 		return $validzip;
 	}
 
@@ -376,8 +388,9 @@ 
 	 */
 	public function getModuleNameFromZip($zipfile)
 	{
-		if (!$this->checkZip($zipfile))
-			return null;
+		if (!$this->checkZip($zipfile)) {
+					return null;
+		}
 		return (string) $this->_modulexml->name;
 	}
 
@@ -453,8 +466,9 @@ 
 				$unzip->unzip("$module.png", 'layouts/' . \Vtiger_Viewer::getDefaultLayoutName() . "/skins/images/$module.png");
 			}
 
-			if ($unzip)
-				$unzip->close();
+			if ($unzip) {
+							$unzip->close();
+			}
 		}
 		return $module;
 	}
@@ -640,8 +654,9 @@ 
 	 */
 	public function import_Tables($modulenode)
 	{
-		if (empty($modulenode->tables) || empty($modulenode->tables->table))
-			return;
+		if (empty($modulenode->tables) || empty($modulenode->tables->table)) {
+					return;
+		}
 		$adb = \PearDatabase::getInstance();
 		$adb->query('SET FOREIGN_KEY_CHECKS = 0;');
 
@@ -675,8 +690,9 @@ 
 	 */
 	public function import_Blocks($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->blocks) || empty($modulenode->blocks->block))
-			return;
+		if (empty($modulenode->blocks) || empty($modulenode->blocks->block)) {
+					return;
+		}
 		foreach ($modulenode->blocks->block as $blocknode) {
 			$blockInstance = $this->import_Block($modulenode, $moduleInstance, $blocknode);
 			$this->import_Fields($blocknode, $blockInstance, $moduleInstance);
@@ -695,8 +711,9 @@ 
 		$blockInstance->label = $blocklabel;
 		if (isset($blocknode->sequence) && isset($blocknode->display_status)) {
 			$blockInstance->sequence = strval($blocknode->sequence);
-			if ($blockInstance->sequence = "")
-				$blockInstance->sequence = NULL;
+			if ($blockInstance->sequence = "") {
+							$blockInstance->sequence = NULL;
+			}
 			$blockInstance->showtitle = strval($blocknode->show_title);
 			$blockInstance->visible = strval($blocknode->visible);
 			$blockInstance->increateview = strval($blocknode->create_view);
@@ -718,8 +735,9 @@ 
 	 */
 	public function import_Fields($blocknode, $blockInstance, $moduleInstance)
 	{
-		if (empty($blocknode->fields) || empty($blocknode->fields->field))
-			return;
+		if (empty($blocknode->fields) || empty($blocknode->fields->field)) {
+					return;
+		}
 
 		foreach ($blocknode->fields->field as $fieldnode) {
 			$fieldInstance = $this->import_Field($blocknode, $blockInstance, $moduleInstance, $fieldnode);
@@ -750,17 +768,21 @@ 
 		$fieldInstance->displaytype = $fieldnode->displaytype;
 		$fieldInstance->info_type = $fieldnode->info_type;
 
-		if (!empty($fieldnode->fieldparams))
-			$fieldInstance->fieldparams = $fieldnode->fieldparams;
+		if (!empty($fieldnode->fieldparams)) {
+					$fieldInstance->fieldparams = $fieldnode->fieldparams;
+		}
 
-		if (!empty($fieldnode->helpinfo))
-			$fieldInstance->helpinfo = $fieldnode->helpinfo;
+		if (!empty($fieldnode->helpinfo)) {
+					$fieldInstance->helpinfo = $fieldnode->helpinfo;
+		}
 
-		if (isset($fieldnode->masseditable))
-			$fieldInstance->masseditable = $fieldnode->masseditable;
+		if (isset($fieldnode->masseditable)) {
+					$fieldInstance->masseditable = $fieldnode->masseditable;
+		}
 
-		if (isset($fieldnode->columntype) && !empty($fieldnode->columntype))
-			$fieldInstance->columntype = strval($fieldnode->columntype);
+		if (isset($fieldnode->columntype) && !empty($fieldnode->columntype)) {
+					$fieldInstance->columntype = strval($fieldnode->columntype);
+		}
 
 		if (!empty($fieldnode->tree_template)) {
 			$templateid = $fieldInstance->setTreeTemplate($fieldnode->tree_template, $moduleInstance);
@@ -808,8 +830,9 @@ 
 	 */
 	public function import_CustomViews($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->customviews) || empty($modulenode->customviews->customview))
-			return;
+		if (empty($modulenode->customviews) || empty($modulenode->customviews->customview)) {
+					return;
+		}
 		foreach ($modulenode->customviews->customview as $customviewnode) {
 			$this->import_CustomView($modulenode, $moduleInstance, $customviewnode);
 		}
@@ -852,8 +875,9 @@ 
 	 */
 	public function import_SharingAccess($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->sharingaccess))
-			return;
+		if (empty($modulenode->sharingaccess)) {
+					return;
+		}
 
 		if (!empty($modulenode->sharingaccess->default)) {
 			foreach ($modulenode->sharingaccess->default as $defaultnode) {
@@ -883,8 +907,9 @@ 
 	 */
 	public function import_Actions($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->actions) || empty($modulenode->actions->action))
-			return;
+		if (empty($modulenode->actions) || empty($modulenode->actions->action)) {
+					return;
+		}
 		foreach ($modulenode->actions->action as $actionnode) {
 			$this->import_Action($modulenode, $moduleInstance, $actionnode);
 		}
@@ -966,8 +991,9 @@ 
 	 */
 	public function import_CustomLinks($modulenode, $moduleInstance)
 	{
-		if (empty($modulenode->customlinks) || empty($modulenode->customlinks->customlink))
-			return;
+		if (empty($modulenode->customlinks) || empty($modulenode->customlinks->customlink)) {
+					return;
+		}
 
 		foreach ($modulenode->customlinks->customlink as $customlinknode) {
 			$handlerInfo = null;
@@ -989,8 +1015,9 @@ 
 	 */
 	public function import_CronTasks($modulenode)
 	{
-		if (empty($modulenode->crons) || empty($modulenode->crons->cron))
-			return;
+		if (empty($modulenode->crons) || empty($modulenode->crons->cron)) {
+					return;
+		}
 		foreach ($modulenode->crons->cron as $cronTask) {
 			if (empty($cronTask->status)) {
 				$cronTask->status = Cron::$STATUS_DISABLED;
@@ -1051,8 +1078,9 @@ 
 	 */
 	public function importInventory()
 	{
-		if (empty($this->_modulexml->inventory) || empty($this->_modulexml->inventory->fields->field))
-			return false;
+		if (empty($this->_modulexml->inventory) || empty($this->_modulexml->inventory->fields->field)) {
+					return false;
+		}
 		$module = (string) $this->moduleInstance->name;
 
 		$inventoryInstance = \Vtiger_Inventory_Model::getInstance($module);

vtlib/Vtiger/Utils/StringTemplate.php

Doc Comments +1 added lines

@@ -112,6 +112,7 @@
 	/**
 	 * Clean up the input to be used as a regex
 	 * @access private
+	 * @param string $value
 	 */
 	public function __formatAsRegex($value)
 	{

Braces +6 added lines, -4 removed lines

@@ -70,8 +70,9 @@ 
 		unset($this->tplvars);
 
 		$this->tplvars = [];
-		foreach ($restorevars as $key => $val)
-			$this->assign($key, $val);
+		foreach ($restorevars as $key => $val) {
+					$this->assign($key, $val);
+		}
 	}
 
 	/**
@@ -82,8 +83,9 @@ 
 	 */
 	public function merge($instring, $avoidLookup = false)
 	{
-		if (empty($instring))
-			return $instring;
+		if (empty($instring)) {
+					return $instring;
+		}
 
 		if (!$avoidLookup) {
 

vtlib/Vtiger/Webservice.php

Doc Comments +3 added lines

@@ -20,6 +20,7 @@ 
 	 * Helper function to log messages
 	 * @param String Message to log
 	 * @param Boolean true appends linebreak, false to avoid it
+	 * @param string $message
 	 * @access private
 	 */
 	static function log($message, $delim = true)
@@ -30,6 +31,7 @@ 
 	/**
 	 * Initialize webservice for the given module
 	 * @param Module Instance of the module.
+	 * @param Module $moduleInstance
 	 */
 	static function initialize($moduleInstance)
 	{
@@ -45,6 +47,7 @@ 
 	/**
 	 * Initialize webservice for the given module
 	 * @param Module Instance of the module.
+	 * @param Module $moduleInstance
 	 */
 	static function uninitialize($moduleInstance)
 	{

vtlib/Vtiger/Zip.php

Doc Comments +2 added lines

@@ -69,6 +69,7 @@ 
 
 	/**
 	 * Normalize the directory path separators.
+	 * @param string $path
 	 */
 	public function __normalizePath($path)
 	{
@@ -79,6 +80,7 @@ 
 
 	/**
 	 * Copy the directory on the disk into zip file.
+	 * @param string $zipdirname
 	 */
 	public function copyDirectoryFromDisk($dirname, $zipdirname = null, $excludeList = null, $basedirname = null)
 	{

Braces +18 added lines, -12 removed lines

@@ -50,8 +50,9 @@ 
 		if ($search_index === 0) {
 			$startindex = strlen($base_realpath) + 1;
 			// On windows $base_realpath ends with / and On Linux it will not have / at end!
-			if (strrpos($base_realpath, '/') == strlen($base_realpath) - 1)
-				$startindex -= 1;
+			if (strrpos($base_realpath, '/') == strlen($base_realpath) - 1) {
+							$startindex -= 1;
+			}
 			$relpath = substr($src_realpath, $startindex);
 		}
 		return $relpath;
@@ -62,8 +63,9 @@ 
 	 */
 	public function __fixDirSeparator($path)
 	{
-		if ($path != '' && (strripos($path, '/') != strlen($path) - 1))
-			$path .= '/';
+		if ($path != '' && (strripos($path, '/') != strlen($path) - 1)) {
+					$path .= '/';
+		}
 		return $path;
 	}
 
@@ -72,8 +74,9 @@ 
 	 */
 	public function __normalizePath($path)
 	{
-		if ($path && strpos($path, '\\') !== false)
-			$path = preg_replace("/\\\\/", "/", $path);
+		if ($path && strpos($path, '\\') !== false) {
+					$path = preg_replace("/\\\\/", "/", $path);
+		}
 		return $path;
 	}
 
@@ -83,18 +86,21 @@ 
 	public function copyDirectoryFromDisk($dirname, $zipdirname = null, $excludeList = null, $basedirname = null)
 	{
 		$dir = opendir($dirname);
-		if (strripos($dirname, '/') != strlen($dirname) - 1)
-			$dirname .= '/';
+		if (strripos($dirname, '/') != strlen($dirname) - 1) {
+					$dirname .= '/';
+		}
 
-		if ($basedirname === null)
-			$basedirname = realpath($dirname);
+		if ($basedirname === null) {
+					$basedirname = realpath($dirname);
+		}
 
 		while (false !== ($file = readdir($dir))) {
 			if ($file != '.' && $file != '..' &&
 				$file != '.svn' && $file != 'CVS') {
 				// Exclude the file/directory 
-				if (!empty($excludeList) && in_array("$dirname$file", $excludeList))
-					continue;
+				if (!empty($excludeList) && in_array("$dirname$file", $excludeList)) {
+									continue;
+				}
 
 				if (is_dir("$dirname$file")) {
 					$this->copyDirectoryFromDisk("$dirname$file", $zipdirname, $excludeList, $basedirname);

include/Loader.php

Braces +3 added lines, -2 removed lines

@@ -124,8 +124,9 @@
 			$secondFallBackModuleDir = $secondFallBackModuleClassPath = $actualModule;
 			if ($actualModule != 'Users') {
 				$baseModule = $moduleHierarchyParts[0];
-				if ($baseModule == 'Settings')
-					$baseModule = 'Settings:Vtiger';
+				if ($baseModule == 'Settings') {
+									$baseModule = 'Settings:Vtiger';
+				}
 				$firstFallBackDir = str_replace(':', '.', $baseModule);
 				$firstFallBackClassPath = str_replace(':', '_', $baseModule);
 			}