Test Setup Failed
Pull Request — developer (#17277)
by Arkadiusz
18:24
created
modules/Vtiger/uitypes/Text.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
 		$maximumLength = $this->getFieldModel()->getMaxValue();
42 42
 		if ($maximumLength && \App\TextUtils::getTextLength($value, true) > $maximumLength) {
43 43
 			throw new \App\Exceptions\Security('ERR_VALUE_IS_TOO_LONG||' . $this->getFieldModel()->getName() . '||' . $this->getFieldModel()->getModuleName() . '||' . $value, 406);
44
-		} elseif ($value && ($minLength = $this->getFieldModel()->getMinValue()) && \App\TextUtils::getTextLength($value, true) < $minLength){
44
+		} elseif ($value && ($minLength = $this->getFieldModel()->getMinValue()) && \App\TextUtils::getTextLength($value, true) < $minLength) {
45 45
 			throw new \App\Exceptions\Security('ERR_VALUE_IS_TOO_SHORT||' . $this->getFieldModel()->getName() . '||' . $this->getFieldModel()->getModuleName() . '||' . $value, 406);
46 46
 		}
47 47
 		$this->validate[$value] = true;
Please login to merge, or discard this patch.
app/Utils/ConfReport.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -162,12 +162,12 @@  discard block
 block discarded – undo
162 162
 		'filter' => ['mandatory' => true, 'type' => 'ExtExist', 'extName' => 'filter', 'container' => 'ext', 'testCli' => true],
163 163
 		'ctype' => ['mandatory' => true, 'type' => 'ExtExist', 'extName' => 'ctype', 'container' => 'ext', 'testCli' => true],
164 164
 		'hash' => ['mandatory' => true, 'type' => 'ExtExist', 'extName' => 'hash', 'container' => 'ext', 'testCli' => true],
165
-		'exif' => ['mandatory' => false, 'type' => 'ExtExist', 'extName' => 'exif', 'container' => 'ext', 'testCli' => true,  'showHelp' => true, 'mode' => 'showWarnings'],
166
-		'ldap' => ['mandatory' => false, 'type' => 'ExtExist', 'extName' => 'ldap', 'container' => 'ext', 'testCli' => true,  'showHelp' => true, 'mode' => 'showWarnings'],
167
-		'OPcache' => ['mandatory' => false, 'type' => 'ExtExist', 'extName' => 'Zend OPcache', 'container' => 'ext', 'testCli' => true,  'showHelp' => true, 'mode' => 'showWarnings'],
168
-		'apcu' => ['mandatory' => false, 'type' => 'ExtExist', 'extName' => 'apcu', 'container' => 'ext', 'testCli' => true,  'showHelp' => true, 'mode' => 'showWarnings'],
169
-		'imagick' => ['mandatory' => false, 'type' => 'ExtExist', 'extName' => 'imagick', 'container' => 'ext', 'testCli' => true,  'showHelp' => true, 'mode' => 'showWarnings'],
170
-		'pdo_sqlsrv' => ['mandatory' => false, 'type' => 'ExtExist', 'extName' => 'pdo_sqlsrv', 'container' => 'ext', 'testCli' => true,  'showHelp' => true, 'mode' => 'showWarnings'],
165
+		'exif' => ['mandatory' => false, 'type' => 'ExtExist', 'extName' => 'exif', 'container' => 'ext', 'testCli' => true, 'showHelp' => true, 'mode' => 'showWarnings'],
166
+		'ldap' => ['mandatory' => false, 'type' => 'ExtExist', 'extName' => 'ldap', 'container' => 'ext', 'testCli' => true, 'showHelp' => true, 'mode' => 'showWarnings'],
167
+		'OPcache' => ['mandatory' => false, 'type' => 'ExtExist', 'extName' => 'Zend OPcache', 'container' => 'ext', 'testCli' => true, 'showHelp' => true, 'mode' => 'showWarnings'],
168
+		'apcu' => ['mandatory' => false, 'type' => 'ExtExist', 'extName' => 'apcu', 'container' => 'ext', 'testCli' => true, 'showHelp' => true, 'mode' => 'showWarnings'],
169
+		'imagick' => ['mandatory' => false, 'type' => 'ExtExist', 'extName' => 'imagick', 'container' => 'ext', 'testCli' => true, 'showHelp' => true, 'mode' => 'showWarnings'],
170
+		'pdo_sqlsrv' => ['mandatory' => false, 'type' => 'ExtExist', 'extName' => 'pdo_sqlsrv', 'container' => 'ext', 'testCli' => true, 'showHelp' => true, 'mode' => 'showWarnings'],
171 171
 		'allExt' => ['container' => 'ext', 'type' => 'AllExt', 'testCli' => true, 'label' => 'EXTENSIONS'],
172 172
 	];
173 173
 
@@ -345,13 +345,13 @@  discard block
 block discarded – undo
345 345
 		'lastCronStart' => ['container' => 'env', 'testCli' => false, 'label' => 'LAST_CRON_START', 'isHtml' => true],
346 346
 		'crmProvider' => ['container' => 'env', 'testCli' => true, 'label' => 'CRM_PROVIDER'],
347 347
 		'appId' => ['container' => 'env', 'testCli' => true, 'label' => 'APP_ID'],
348
-		'open_basedir' => ['container' => 'php',  'type' => 'OpenBasedir', 'testCli' => true, 'mode' => 'showWarnings'],
348
+		'open_basedir' => ['container' => 'php', 'type' => 'OpenBasedir', 'testCli' => true, 'mode' => 'showWarnings'],
349 349
 		'caCertBundle' => ['recommended' => 'On', 'container' => 'env', 'type' => 'OnOff', 'testCli' => true, 'label' => 'CACERTBUNDLE'],
350 350
 		'caCertBundlePath' => ['recommended' => 'On', 'container' => 'env', 'testCli' => true, 'label' => 'CACERTBUNDLE_PATH'],
351 351
 		'SSL_CERT_FILE' => ['container' => 'env', 'testCli' => true, 'label' => 'SSL_CERT_FILE'],
352 352
 		'SSL_CERT_DIR' => ['container' => 'env', 'testCli' => true, 'label' => 'SSL_CERT_DIR'],
353
-		'openssl.cafile' => ['container' => 'php',  'type' => 'NotEmpty', 'testCli' => true, 'mode' => 'showWarnings'],
354
-		'openssl.capath' => ['container' => 'php',  'type' => 'NotEmpty', 'testCli' => true, 'mode' => 'showWarnings'],
353
+		'openssl.cafile' => ['container' => 'php', 'type' => 'NotEmpty', 'testCli' => true, 'mode' => 'showWarnings'],
354
+		'openssl.capath' => ['container' => 'php', 'type' => 'NotEmpty', 'testCli' => true, 'mode' => 'showWarnings'],
355 355
 	];
356 356
 
357 357
 	/**
@@ -436,11 +436,11 @@  discard block
 block discarded – undo
436 436
 	 * @var array
437 437
 	 */
438 438
 	public static $functionalVerification = [
439
-		'branding' => ['type' => 'Branding',  'testCli' => false, 'label' => 'FOOTER', 'mode' => 'onlyText'],
440
-		'shop' => ['type' => 'ShopProducts',  'testCli' => false, 'label' => 'PREMIUM_MODULES', 'mode' => 'onlyText'],
441
-		'watchdog' => ['type' => 'Watchdog',  'testCli' => true, 'label' => 'WATCHDOG', 'mode' => 'onlyText'],
442
-		'register' => ['type' => 'Register',  'testCli' => true, 'label' => 'REGISTER', 'mode' => 'onlyText'],
443
-		'shopCache' => ['type' => 'ShopCache',  'testCli' => true, 'label' => 'SHOP_CACHE', 'mode' => 'onlyText'],
439
+		'branding' => ['type' => 'Branding', 'testCli' => false, 'label' => 'FOOTER', 'mode' => 'onlyText'],
440
+		'shop' => ['type' => 'ShopProducts', 'testCli' => false, 'label' => 'PREMIUM_MODULES', 'mode' => 'onlyText'],
441
+		'watchdog' => ['type' => 'Watchdog', 'testCli' => true, 'label' => 'WATCHDOG', 'mode' => 'onlyText'],
442
+		'register' => ['type' => 'Register', 'testCli' => true, 'label' => 'REGISTER', 'mode' => 'onlyText'],
443
+		'shopCache' => ['type' => 'ShopCache', 'testCli' => true, 'label' => 'SHOP_CACHE', 'mode' => 'onlyText'],
444 444
 	];
445 445
 	/**
446 446
 	 * Php variables.
Please login to merge, or discard this patch.
app/Integrations/WooCommerce/Synchronizer/Maps/Base.php 1 patch
Spacing   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -365,9 +365,7 @@
 block discarded – undo
365 365
 	protected function convert($value, array $field, bool $fromApi)
366 366
 	{
367 367
 		switch ($field[$fromApi ? 'crmType' : 'apiType'] ?? 'string') {
368
-			default:
369
-			case 'string':
370
-				$value = (string) $value;
368
+			default : case 'string' : $value = (string) $value;
371 369
 				break;
372 370
 			case 'float':
373 371
 				$value = (float) $value;
Please login to merge, or discard this patch.
app/Integrations/WooCommerce/Synchronizer/Maps/Order.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
 	];
46 46
 	/** {@inheritdoc} */
47 47
 	protected $invFieldMap = [
48
-		'name' => ['name' => 'product_id', 'fn' => 'findProduct', 'moduleName' => 'Products',  'direction' => 'yf'],
48
+		'name' => ['name' => 'product_id', 'fn' => 'findProduct', 'moduleName' => 'Products', 'direction' => 'yf'],
49 49
 		'qty' => 'quantity',
50 50
 		'price' => 'price',
51 51
 		'taxparam' => ['name' => 'total_tax', 'fn' => 'convertTax', 'direction' => 'yf'],
Please login to merge, or discard this patch.
app/Integrations/WooCommerce/Synchronizer/Maps/Product.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -280,7 +280,7 @@
 block discarded – undo
280 280
 		$tags = [];
281 281
 		foreach (explode(\Vtiger_Multipicklist_UIType::SEPARATOR, $value) as $tag) {
282 282
 			if (isset($all[$tag])) {
283
-				$tags[] = ['id' => $all[$tag],  'name' => $tag];
283
+				$tags[] = ['id' => $all[$tag], 'name' => $tag];
284 284
 			}
285 285
 		}
286 286
 		return $tags;
Please login to merge, or discard this patch.
modules/Settings/LayoutEditor/models/Module.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@
 block discarded – undo
85 85
 	public function getAddSupportedFieldTypes()
86 86
 	{
87 87
 		return [
88
-			'Text', 'Decimal', 'Integer',  'Currency',  'Percent', 'AdvPercentage', 'Date', 'Time', 'DateTime', 'RangeTime', 'Phone', 'Email', 'MultiEmail', 'MultiDomain', 'Picklist', 'MultiSelectCombo', 'MultipicklistTags', 'Country', 'URL', 'Checkbox', 'TextArea', 'Related1M', 'MultiReference', 'Editor', 'Tree', 'CategoryMultipicklist', 'Image', 'MultiImage',  'MultiAttachment', 'MultiReferenceValue', 'ServerAccess', 'Skype', 'Twitter', 'Token', 'Smtp', 'MapCoordinates', 'Group',
88
+			'Text', 'Decimal', 'Integer', 'Currency', 'Percent', 'AdvPercentage', 'Date', 'Time', 'DateTime', 'RangeTime', 'Phone', 'Email', 'MultiEmail', 'MultiDomain', 'Picklist', 'MultiSelectCombo', 'MultipicklistTags', 'Country', 'URL', 'Checkbox', 'TextArea', 'Related1M', 'MultiReference', 'Editor', 'Tree', 'CategoryMultipicklist', 'Image', 'MultiImage', 'MultiAttachment', 'MultiReferenceValue', 'ServerAccess', 'Skype', 'Twitter', 'Token', 'Smtp', 'MapCoordinates', 'Group',
89 89
 		];
90 90
 	}
91 91
 
Please login to merge, or discard this patch.
modules/Settings/Groups/views/GetData.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@
 block discarded – undo
98 98
 						break;
99 99
 					case 'members':
100 100
 						foreach ($value as $memberTypeId) {
101
-							[$type,  $memberId] = explode(':', $memberTypeId);
101
+							[$type, $memberId] = explode(':', $memberTypeId);
102 102
 							switch ($type) {
103 103
 								case 'Users':
104 104
 									$users[] = (int) $memberId;
Please login to merge, or discard this patch.
modules/Vtiger/models/Module.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -649,7 +649,7 @@
 block discarded – undo
649 649
 				}
650 650
 			}
651 651
 		}
652
-		uksort($quickCreateFieldList, function ($a, $b) use ($quickCreateFieldList) {
652
+		uksort($quickCreateFieldList, function($a, $b) use ($quickCreateFieldList) {
653 653
 			if ($quickCreateFieldList[$a]->get('quicksequence') === $quickCreateFieldList[$b]->get('quicksequence')) {
654 654
 				return 0;
655 655
 			}
Please login to merge, or discard this patch.
modules/ModTracker/handlers/ModTrackerHandler.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 	 */
141 141
 	public function entityAfterLinkForSource(App\EventHandler $eventHandler)
142 142
 	{
143
-		['sourceModule' => $sourceModule, 'sourceRecordId' => $sourceRecordId,'destinationModule' => $destinationModule,'destinationRecordId' => $destinationRecordId, 'relationId' => $relationId] = $eventHandler->getParams();
143
+		['sourceModule' => $sourceModule, 'sourceRecordId' => $sourceRecordId, 'destinationModule' => $destinationModule, 'destinationRecordId' => $destinationRecordId, 'relationId' => $relationId] = $eventHandler->getParams();
144 144
 		if (!ModTracker::isTrackingEnabledForModule($destinationModule) || Vtiger_Relation_Model::getInstanceById($relationId)->isDirectRelation()) {
145 145
 			return false;
146 146
 		}
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 	 */
183 183
 	public function entityAfterUnLinkForSource(App\EventHandler $eventHandler)
184 184
 	{
185
-		['sourceModule' => $sourceModule, 'sourceRecordId' => $sourceRecordId,'destinationModule' => $destinationModule,'destinationRecordId' => $destinationRecordId, 'relationId' => $relationId] = $eventHandler->getParams();
185
+		['sourceModule' => $sourceModule, 'sourceRecordId' => $sourceRecordId, 'destinationModule' => $destinationModule, 'destinationRecordId' => $destinationRecordId, 'relationId' => $relationId] = $eventHandler->getParams();
186 186
 		if (!ModTracker::isTrackingEnabledForModule($destinationModule) || Vtiger_Relation_Model::getInstanceById($relationId)->isDirectRelation()) {
187 187
 			return false;
188 188
 		}
Please login to merge, or discard this patch.