YetiForceCompany / YetiForceCRM

modules/PaymentsIn/helpers/mt940.php

Doc Comments +15 added lines

@@ -50,6 +50,9 @@ 
 		return $xml;
 	}
 
+	/**
+	 * @param integer $level
+	 */
 	protected function createXML($key, $value, $level)
 	{
 		$indent = '';
@@ -69,6 +72,9 @@ 
 		return $xml;
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -114,6 +120,9 @@ 
 		$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(
@@ -124,6 +133,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseBalance($value)
 	{
 		return array(
@@ -134,6 +146,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseTransaction($value)
 	{
 		$transaction = array(

Braces +19 added lines, -14 removed lines

@@ -34,8 +34,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	public function getXML()
@@ -53,13 +54,15 @@ 
 	protected function createXML($key, $value, $level)
 	{
 		$indent = '';
-		for ($i = 0; $i <= $level; $i++)
-			$indent .= "\t";
+		for ($i = 0; $i <= $level; $i++) {
+					$indent .= "\t";
+		}
 		if (is_array($value)) {
 			$xml = "$indent<$key>\n";
 			foreach ($value as $subKey => $subVal) {
-				if (is_numeric($subKey))
-					$subKey = substr($key, 0, -1);
+				if (is_numeric($subKey)) {
+									$subKey = substr($key, 0, -1);
+				}
 				$xml .= $this->createXML($subKey, $subVal, $level + 1);
 			}
 			$xml .= "$indent</$key>\n";
@@ -85,10 +88,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -103,10 +107,11 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == '61')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == '61') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;

modules/PaymentsIn/helpers/subclass/mt940_Milenium.php

Doc Comments +6 added lines

@@ -20,6 +20,9 @@ 
 			$this->parseLine($line);
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -65,6 +68,9 @@ 
 		$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(

Braces +13 added lines, -10 removed lines

@@ -16,8 +16,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	protected function parseLine($line)
@@ -36,10 +37,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -54,10 +56,11 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == '61')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == '61') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;

modules/PaymentsIn/helpers/subclass/mt940_WBK.php

Doc Comments +9 added lines

@@ -20,6 +20,9 @@ 
 			$this->parseLine($line);
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -65,6 +68,9 @@ 
 		$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseTransaction($value)
 	{
 		$transaction = array(
@@ -109,6 +115,9 @@ 
 		$this->operations[count($this->operations) - 1]['details'] = $transaction;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(

Braces +13 added lines, -10 removed lines

@@ -16,8 +16,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	protected function parseLine($line)
@@ -36,10 +37,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -54,10 +56,11 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == '61')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == '61') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;

modules/PBXManager/connectors/PBXManager.php

Doc Comments +8 added lines, -2 removed lines

@@ -54,6 +54,9 @@ 
 		return $this->webappurl;
 	}
 
+	/**
+	 * @return string
+	 */
 	public function getOutboundContext()
 	{
 		return $this->outboundcontext;
@@ -82,6 +85,7 @@ 
 	/**
 	 * Function to set server parameters
 	 * @param <array>  authdetails
+	 * @param PBXManager_Server_Model $serverModel
 	 */
 	public function setServerParameters($serverModel)
 	{
@@ -100,6 +104,9 @@ 
 		return self::$SETTINGS_REQUIRED_PARAMETERS;
 	}
 
+	/**
+	 * @param string $type
+	 */
 	protected function prepareParameters($details, $type)
 	{
 		switch ($type) {
@@ -294,7 +301,6 @@ 
 
 	/**
 	 * Function to respond for outgoing calls
-	 * @param <Vtiger_Request> $details 
 	 */
 	public function respondToOutgoingCall($to)
 	{
@@ -324,7 +330,7 @@ 
 	/**
 	 * Function to make outbound call 
 	 * @param <string> $number (Customer)
-	 * @param <string> $recordid
+	 * @param <string> $record
 	 */
 	public function call($number, $record)
 	{

Braces +8 added lines, -6 removed lines

@@ -239,10 +239,11 @@ 
 		$recordModel = PBXManager_Record_Model::getCleanInstance();
 		$recordModel->saveRecordWithArrray($params);
 
-		if ($direction == self::INCOMING_TYPE)
-			$this->respondToIncomingCall($details);
-		else
-			$this->respondToOutgoingCall($params['CustomerNumber']);
+		if ($direction == self::INCOMING_TYPE) {
+					$this->respondToIncomingCall($details);
+		} else {
+					$this->respondToOutgoingCall($params['CustomerNumber']);
+		}
 	}
 
 	/**
@@ -312,8 +313,9 @@ 
 		} else {
 			$response .= '<Number>SIP/';
 			$response .= $to;
-			if ($numberLength > 5)
-				$response .= '@' . $this->getOutboundTrunk();
+			if ($numberLength > 5) {
+							$response .= '@' . $this->getOutboundTrunk();
+			}
 			$response .= '</Number>';
 		}
 

modules/PriceBooks/PriceBooks.php

Doc Comments +1 added lines, -1 removed lines

@@ -197,7 +197,7 @@
 
 	/** 	function used to get whether the pricebook has related with a product or not
 	 * 	@param int $id - product id
-	 * 	@return true or false - if there are no pricebooks available or associated pricebooks for the product is equal to total number of pricebooks then return false, else return true
+	 * 	@return boolean|null or false - if there are no pricebooks available or associated pricebooks for the product is equal to total number of pricebooks then return false, else return true
 	 */
 	public function get_pricebook_noproduct($id)
 	{

Spacing +5 added lines, -5 removed lines

@@ -283,19 +283,19 @@
 		$query = $this->getRelationQuery($module, $secmodule, "vtiger_pricebook", "pricebookid", $queryplanner);
 		// TODO Support query planner
 		if ($queryplanner->requireTable("vtiger_crmentityPriceBooks", $matrix)) {
-			$query .=" left join vtiger_crmentity as vtiger_crmentityPriceBooks on vtiger_crmentityPriceBooks.crmid=vtiger_pricebook.pricebookid and vtiger_crmentityPriceBooks.deleted=0";
+			$query .= " left join vtiger_crmentity as vtiger_crmentityPriceBooks on vtiger_crmentityPriceBooks.crmid=vtiger_pricebook.pricebookid and vtiger_crmentityPriceBooks.deleted=0";
 		}
 		if ($queryplanner->requireTable("vtiger_currency_infoPriceBooks")) {
-			$query .=" left join vtiger_currency_info as vtiger_currency_infoPriceBooks on vtiger_currency_infoPriceBooks.id = vtiger_pricebook.currency_id";
+			$query .= " left join vtiger_currency_info as vtiger_currency_infoPriceBooks on vtiger_currency_infoPriceBooks.id = vtiger_pricebook.currency_id";
 		}
 		if ($queryplanner->requireTable("vtiger_usersPriceBooks")) {
-			$query .=" left join vtiger_users as vtiger_usersPriceBooks on vtiger_usersPriceBooks.id = vtiger_crmentityPriceBooks.smownerid";
+			$query .= " left join vtiger_users as vtiger_usersPriceBooks on vtiger_usersPriceBooks.id = vtiger_crmentityPriceBooks.smownerid";
 		}
 		if ($queryplanner->requireTable("vtiger_groupsPriceBooks")) {
-			$query .=" left join vtiger_groups as vtiger_groupsPriceBooks on vtiger_groupsPriceBooks.groupid = vtiger_crmentityPriceBooks.smownerid";
+			$query .= " left join vtiger_groups as vtiger_groupsPriceBooks on vtiger_groupsPriceBooks.groupid = vtiger_crmentityPriceBooks.smownerid";
 		}
 		if ($queryplanner->requireTable("vtiger_lastModifiedByPriceBooks")) {
-			$query .=" left join vtiger_users as vtiger_lastModifiedByPriceBooks on vtiger_lastModifiedByPriceBooks.id = vtiger_crmentityPriceBooks.smownerid";
+			$query .= " left join vtiger_users as vtiger_lastModifiedByPriceBooks on vtiger_lastModifiedByPriceBooks.id = vtiger_crmentityPriceBooks.smownerid";
 		}
 		if ($queryplanner->requireTable("vtiger_createdbyPriceBooks")) {
 			$query .= " left join vtiger_users as vtiger_createdbyPriceBooks on vtiger_createdbyPriceBooks.id = vtiger_crmentityPriceBooks.smcreatorid ";

Braces +22 added lines, -16 removed lines

@@ -102,16 +102,18 @@ 
 		vtlib_setup_modulevars($related_module, $other);
 		$singular_modname = vtlib_toSingular($related_module);
 
-		if ($singlepane_view == 'true')
-			$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
-		else
-			$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		if ($singlepane_view == 'true') {
+					$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
+		} else {
+					$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		}
 
 		$button = '';
 
 		if ($actions) {
-			if (is_string($actions))
-				$actions = explode(',', strtoupper($actions));
+			if (is_string($actions)) {
+							$actions = explode(',', strtoupper($actions));
+			}
 			if (in_array('SELECT', $actions) && isPermitted($related_module, 4, '') == 'yes') {
 				$button .= "<input title='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "' class='crmbutton small edit' type='submit' name='button' onclick=\"this.form.action.value='AddProductsToPriceBook';this.form.module.value='$related_module';this.form.return_module.value='$currentModule';this.form.return_action.value='PriceBookDetailView'\" value='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "'>&nbsp;";
 			}
@@ -131,8 +133,9 @@ 
 		$this->retrieve_entity_info($id, $this_module);
 		$return_value = getPriceBookRelatedProducts($query, $this, $returnset);
 
-		if ($return_value === null)
-			$return_value = Array();
+		if ($return_value === null) {
+					$return_value = Array();
+		}
 		$return_value['CUSTOM_BUTTON'] = $button;
 
 		$log->debug("Exiting get_pricebook_products method ...");
@@ -158,16 +161,18 @@ 
 		vtlib_setup_modulevars($related_module, $other);
 		$singular_modname = vtlib_toSingular($related_module);
 
-		if ($singlepane_view == 'true')
-			$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
-		else
-			$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		if ($singlepane_view == 'true') {
+					$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
+		} else {
+					$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		}
 
 		$button = '';
 
 		if ($actions) {
-			if (is_string($actions))
-				$actions = explode(',', strtoupper($actions));
+			if (is_string($actions)) {
+							$actions = explode(',', strtoupper($actions));
+			}
 			if (in_array('SELECT', $actions) && isPermitted($related_module, 4, '') == 'yes') {
 				$button .= "<input title='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "' class='crmbutton small edit' type='submit' name='button' onclick=\"this.form.action.value='AddServicesToPriceBook';this.form.module.value='$related_module';this.form.return_module.value='$currentModule';this.form.return_action.value='PriceBookDetailView'\" value='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "'>&nbsp;";
 			}
@@ -187,8 +192,9 @@ 
 		$this->retrieve_entity_info($id, $this_module);
 		$return_value = $other->getPriceBookRelatedServices($query, $this, $returnset);
 
-		if ($return_value === null)
-			$return_value = Array();
+		if ($return_value === null) {
+					$return_value = Array();
+		}
 		$return_value['CUSTOM_BUTTON'] = $button;
 
 		$log->debug("Exiting get_pricebook_services method ...");

modules/Products/Products.php

Doc Comments +3 added lines, -2 removed lines

@@ -192,6 +192,9 @@ 
 		$this->db->pquery($query, $params);
 	}
 
+	/**
+	 * @param string $module
+	 */
 	public function insertIntoAttachment($id, $module)
 	{
 		$adb = PearDatabase::getInstance();
@@ -556,8 +559,6 @@ 
 	}
 
 	/** 	function used to get the number of vendors which are related to the product
-	 * 	@param int $id - product id
-	 * 	@return int number of rows - return the number of products which do not have relationship with vendor
 	 */
 	public function product_novendor()
 	{

Braces +87 added lines, -64 removed lines

@@ -202,10 +202,11 @@ 
 		foreach ($_FILES as $fileindex => $files) {
 			$fileInstance = \includes\fields\File::loadFromRequest($files);
 			if ($fileInstance->validate('image')) {
-				if (AppRequest::get($fileindex . '_hidden') != '')
-					$files['original_name'] = AppRequest::get($fileindex . '_hidden');
-				else
-					$files['original_name'] = stripslashes($files['name']);
+				if (AppRequest::get($fileindex . '_hidden') != '') {
+									$files['original_name'] = AppRequest::get($fileindex . '_hidden');
+				} else {
+									$files['original_name'] = stripslashes($files['name']);
+				}
 				$files['original_name'] = str_replace('"', '', $files['original_name']);
 				$file_saved = $this->uploadAndSaveFile($id, $module, $files);
 			}
@@ -261,16 +262,18 @@ 
 		vtlib_setup_modulevars($related_module, $other);
 		$singular_modname = vtlib_toSingular($related_module);
 
-		if ($singlepane_view == 'true')
-			$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
-		else
-			$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		if ($singlepane_view == 'true') {
+					$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
+		} else {
+					$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		}
 
 		$button = '';
 
 		if ($actions) {
-			if (is_string($actions))
-				$actions = explode(',', strtoupper($actions));
+			if (is_string($actions)) {
+							$actions = explode(',', strtoupper($actions));
+			}
 			if (in_array('SELECT', $actions) && isPermitted($related_module, 4, '') == 'yes') {
 				$button .= "<input title='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "' class='crmbutton small edit' type='button' onclick=\"return window.open('index.php?module=$related_module&return_module=$currentModule&action=Popup&popuptype=detailview&select=enable&form=EditView&form_submit=false&recordid=$id','test','width=640,height=602,resizable=0,scrollbars=0');\" value='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "'>&nbsp;";
 			}
@@ -295,8 +298,9 @@ 
 
 		$return_value = GetRelatedList($this_module, $related_module, $other, $query, $button, $returnset);
 
-		if ($return_value === null)
-			$return_value = Array();
+		if ($return_value === null) {
+					$return_value = Array();
+		}
 		$return_value['CUSTOM_BUTTON'] = $button;
 
 		$log->debug("Exiting get_leads method ...");
@@ -322,16 +326,18 @@ 
 		vtlib_setup_modulevars($related_module, $other);
 		$singular_modname = vtlib_toSingular($related_module);
 
-		if ($singlepane_view == 'true')
-			$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
-		else
-			$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		if ($singlepane_view == 'true') {
+					$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
+		} else {
+					$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		}
 
 		$button = '';
 
 		if ($actions) {
-			if (is_string($actions))
-				$actions = explode(',', strtoupper($actions));
+			if (is_string($actions)) {
+							$actions = explode(',', strtoupper($actions));
+			}
 			if (in_array('SELECT', $actions) && isPermitted($related_module, 4, '') == 'yes') {
 				$button .= "<input title='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "' class='crmbutton small edit' type='button' onclick=\"return window.open('index.php?module=$related_module&return_module=$currentModule&action=Popup&popuptype=detailview&select=enable&form=EditView&form_submit=false&recordid=$id','test','width=640,height=602,resizable=0,scrollbars=0');\" value='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "'>&nbsp;";
 			}
@@ -355,8 +361,9 @@ 
 
 		$return_value = GetRelatedList($this_module, $related_module, $other, $query, $button, $returnset);
 
-		if ($return_value === null)
-			$return_value = Array();
+		if ($return_value === null) {
+					$return_value = Array();
+		}
 		$return_value['CUSTOM_BUTTON'] = $button;
 
 		$log->debug("Exiting get_accounts method ...");
@@ -382,16 +389,18 @@ 
 		vtlib_setup_modulevars($related_module, $other);
 		$singular_modname = vtlib_toSingular($related_module);
 
-		if ($singlepane_view == 'true')
-			$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
-		else
-			$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		if ($singlepane_view == 'true') {
+					$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
+		} else {
+					$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		}
 
 		$button = '';
 
 		if ($actions) {
-			if (is_string($actions))
-				$actions = explode(',', strtoupper($actions));
+			if (is_string($actions)) {
+							$actions = explode(',', strtoupper($actions));
+			}
 			if (in_array('SELECT', $actions) && isPermitted($related_module, 4, '') == 'yes') {
 				$button .= "<input title='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "' class='crmbutton small edit' type='button' onclick=\"return window.open('index.php?module=$related_module&return_module=$currentModule&action=Popup&popuptype=detailview&select=enable&form=EditView&form_submit=false&recordid=$id','test','width=640,height=602,resizable=0,scrollbars=0');\" value='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "'>&nbsp;";
 			}
@@ -418,8 +427,9 @@ 
 
 		$return_value = GetRelatedList($this_module, $related_module, $other, $query, $button, $returnset);
 
-		if ($return_value === null)
-			$return_value = Array();
+		if ($return_value === null) {
+					$return_value = Array();
+		}
 		$return_value['CUSTOM_BUTTON'] = $button;
 
 		$log->debug("Exiting get_contacts method ...");
@@ -445,16 +455,18 @@ 
 		vtlib_setup_modulevars($related_module, $other);
 		$singular_modname = vtlib_toSingular($related_module);
 
-		if ($singlepane_view == 'true')
-			$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
-		else
-			$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		if ($singlepane_view == 'true') {
+					$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
+		} else {
+					$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		}
 
 		$button = '';
 
 		if ($actions && getFieldVisibilityPermission($related_module, $current_user->id, 'product_id', 'readwrite') == '0') {
-			if (is_string($actions))
-				$actions = explode(',', strtoupper($actions));
+			if (is_string($actions)) {
+							$actions = explode(',', strtoupper($actions));
+			}
 			if (in_array('SELECT', $actions) && isPermitted($related_module, 4, '') == 'yes') {
 				$button .= "<input title='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "' class='crmbutton small edit' type='button' onclick=\"return window.open('index.php?module=$related_module&return_module=$currentModule&action=Popup&popuptype=detailview&select=enable&form=EditView&form_submit=false&recordid=$id','test','width=640,height=602,resizable=0,scrollbars=0');\" value='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "'>&nbsp;";
 			}
@@ -491,8 +503,9 @@ 
 
 		$return_value = GetRelatedList($this_module, $related_module, $other, $query, $button, $returnset);
 
-		if ($return_value === null)
-			$return_value = Array();
+		if ($return_value === null) {
+					$return_value = Array();
+		}
 		$return_value['CUSTOM_BUTTON'] = $button;
 
 		$log->debug("Exiting get_tickets method ...");
@@ -517,8 +530,9 @@ 
 
 		$button = '';
 		if ($actions) {
-			if (is_string($actions))
-				$actions = explode(',', strtoupper($actions));
+			if (is_string($actions)) {
+							$actions = explode(',', strtoupper($actions));
+			}
 			if (in_array('ADD', $actions) && isPermitted($related_module, 1, '') == 'yes' && isPermitted($currentModule, 'EditView', $id) == 'yes') {
 				$button .= "<input title='" . \includes\Language::translate('LBL_ADD_TO') . " " . \includes\Language::translate($related_module) . "' class='crmbutton small create'" .
 					" onclick='this.form.action.value=\"AddProductToPriceBooks\";this.form.module.value=\"$currentModule\"' type='submit' name='button'" .
@@ -526,10 +540,11 @@ 
 			}
 		}
 
-		if ($singlepane_view == 'true')
-			$returnset = '&return_module=Products&return_action=DetailView&return_id=' . $id;
-		else
-			$returnset = '&return_module=Products&return_action=CallRelatedList&return_id=' . $id;
+		if ($singlepane_view == 'true') {
+					$returnset = '&return_module=Products&return_action=DetailView&return_id=' . $id;
+		} else {
+					$returnset = '&return_module=Products&return_action=CallRelatedList&return_id=' . $id;
+		}
 
 
 		$query = sprintf('SELECT vtiger_crmentity.crmid,
@@ -548,8 +563,9 @@ 
 
 		$return_value = GetRelatedList($currentModule, $related_module, $focus, $query, $button, $returnset);
 
-		if ($return_value === null)
-			$return_value = Array();
+		if ($return_value === null) {
+					$return_value = Array();
+		}
 		$return_value['CUSTOM_BUTTON'] = $button;
 
 		return $return_value;
@@ -594,16 +610,18 @@ 
 		vtlib_setup_modulevars($related_module, $other);
 		$singular_modname = vtlib_toSingular($related_module);
 
-		if ($singlepane_view == 'true')
-			$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
-		else
-			$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		if ($singlepane_view == 'true') {
+					$returnset = '&return_module=' . $this_module . '&return_action=DetailView&return_id=' . $id;
+		} else {
+					$returnset = '&return_module=' . $this_module . '&return_action=CallRelatedList&return_id=' . $id;
+		}
 
 		$button = '';
 
 		if ($actions && $this->ismember_check() === 0) {
-			if (is_string($actions))
-				$actions = explode(',', strtoupper($actions));
+			if (is_string($actions)) {
+							$actions = explode(',', strtoupper($actions));
+			}
 			if (in_array('SELECT', $actions) && isPermitted($related_module, 4, '') == 'yes') {
 				$button .= "<input title='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "' class='crmbutton small edit' type='button' onclick=\"return window.open('index.php?module=$related_module&return_module=$currentModule&action=Popup&popuptype=detailview&select=enable&form=EditView&form_submit=false&recordid=$id','test','width=640,height=602,resizable=0,scrollbars=0');\" value='" . \includes\Language::translate('LBL_SELECT') . " " . \includes\Language::translate($related_module) . "'>&nbsp;";
 			}
@@ -632,8 +650,9 @@ 
 
 		$return_value = GetRelatedList($this_module, $related_module, $other, $query, $button, $returnset);
 
-		if ($return_value === null)
-			$return_value = Array();
+		if ($return_value === null) {
+					$return_value = Array();
+		}
 		$return_value['CUSTOM_BUTTON'] = $button;
 
 		$log->debug("Exiting get_products method ...");
@@ -658,10 +677,11 @@ 
 		if (isPermitted("Products", 1, "") == 'yes') {
 			$button .= '<input title="' . \includes\Language::translate('LBL_NEW_PRODUCT') . '" accessyKey="F" class="button" onclick="this.form.action.value=\'EditView\';this.form.module.value=\'Products\';this.form.return_module.value=\'Products\';this.form.return_action.value=\'DetailView\'" type="submit" name="button" value="' . \includes\Language::translate('LBL_NEW_PRODUCT') . '">&nbsp;';
 		}
-		if ($singlepane_view == 'true')
-			$returnset = '&return_module=Products&return_action=DetailView&is_parent=1&return_id=' . $id;
-		else
-			$returnset = '&return_module=Products&return_action=CallRelatedList&is_parent=1&return_id=' . $id;
+		if ($singlepane_view == 'true') {
+					$returnset = '&return_module=Products&return_action=DetailView&is_parent=1&return_id=' . $id;
+		} else {
+					$returnset = '&return_module=Products&return_action=CallRelatedList&is_parent=1&return_id=' . $id;
+		}
 
 		$query = "SELECT vtiger_products.productid, vtiger_products.productname,
 			vtiger_products.productcode, vtiger_products.commissionrate,
@@ -707,10 +727,11 @@ 
 		$query .= $this->getNonAdminAccessControlQuery('Products', $current_user);
 		$where_auto = " vtiger_crmentity.deleted=0";
 
-		if ($where != '')
-			$query .= " WHERE ($where) && $where_auto";
-		else
-			$query .= " WHERE $where_auto";
+		if ($where != '') {
+					$query .= " WHERE ($where) && $where_auto";
+		} else {
+					$query .= " WHERE $where_auto";
+		}
 
 		$log->debug("Exiting create_export_query method ...");
 		return $query;
@@ -895,8 +916,9 @@ 
 	public function unlinkRelationship($id, $return_module, $return_id, $relatedName = false)
 	{
 		$log = vglobal('log');
-		if (empty($return_module) || empty($return_id))
-			return;
+		if (empty($return_module) || empty($return_id)) {
+					return;
+		}
 
 		if ($return_module == 'Leads' || $return_module == 'Contacts') {
 			$sql = 'DELETE FROM vtiger_seproductsrel WHERE productid = ? && crmid = ?';
@@ -918,8 +940,9 @@ 
 		$db = PearDatabase::getInstance();
 		$currentUser = Users_Record_Model::getCurrentUserModel();
 
-		if (!is_array($with_crmids))
-			$with_crmids = Array($with_crmids);
+		if (!is_array($with_crmids)) {
+					$with_crmids = Array($with_crmids);
+		}
 		foreach ($with_crmids as $with_crmid) {
 			if ($with_module == 'Leads' || $with_module == 'Accounts' ||
 				$with_module == 'Contacts' || $with_module == 'Products') {

modules/Reports/ReportRun.php

Doc Comments +9 added lines

@@ -103,6 +103,9 @@ 
 		$this->customTables[] = $table;
 	}
 
+	/**
+	 * @param ReportRunQueryDependencyMatrix $dependencies
+	 */
 	public function requireTable($table, $dependencies = null)
 	{
 
@@ -782,6 +785,7 @@ 
 	/** Function to get field that is to be compared in query form for the given Comparator and field
 	 *  @ param $field : field
 	 *  returns the value for the comparator
+	 * @param string $field
 	 */
 	public function getFilterComparedField($field)
 	{
@@ -2308,6 +2312,11 @@ 
 	 * 		HTML strings for
 	 */
 	// Performance Optimization: Added parameter directOutput to avoid building big-string!
+
+	/**
+	 * @param string $outputformat
+	 * @param string $filtersql
+	 */
 	public function GenerateReport($outputformat, $filtersql, $directOutput = false, $startLimit = false, $endLimit = false)
 	{
 		$adb = PearDatabase::getInstance();

Braces +213 added lines, -161 removed lines

@@ -53,8 +53,9 @@ 
 
 	protected function computeDependencies()
 	{
-		if ($this->computedMatrix !== null)
-			return;
+		if ($this->computedMatrix !== null) {
+					return;
+		}
 
 		$this->computedMatrix = array();
 		foreach ($this->matrix as $key => $values) {
@@ -93,8 +94,9 @@ 
 
 	public function addTable($table)
 	{
-		if (!empty($table))
-			$this->tables[$table] = $table;
+		if (!empty($table)) {
+					$this->tables[$table] = $table;
+		}
 	}
 
 	public function addCustomTable($table)
@@ -594,8 +596,9 @@ 
 			$access_fields[] = $collistrow["fieldname"];
 		}
 		//added to include ticketid for Reports module in select columnlist for all users
-		if ($module == "HelpDesk")
-			$access_fields[] = "ticketid";
+		if ($module == "HelpDesk") {
+					$access_fields[] = "ticketid";
+		}
 		return $access_fields;
 	}
 
@@ -671,8 +674,9 @@ 
 				}
 				if ($ordercolumnsequal) {
 					$selectedfields = explode(":", $fieldcolname);
-					if ($selectedfields[0] == "vtiger_crmentity" . $this->primarymodule)
-						$selectedfields[0] = "vtiger_crmentity";
+					if ($selectedfields[0] == "vtiger_crmentity" . $this->primarymodule) {
+											$selectedfields[0] = "vtiger_crmentity";
+					}
 					$sSQLList[] = $selectedfields[0] . "." . $selectedfields[1] . " '" . $selectedfields[2] . "'";
 				}
 			}
@@ -724,11 +728,12 @@ 
 			if (trim($value) == 'NULL') {
 				$rtvalue = ' is NOT NULL';
 			} elseif (trim($value) != '') {
-				if ($columnName)
-					$rtvalue = ' <> ' . $adb->quote($value) . ' || ' . $columnName . " IS NULL ";
-				else
-					$rtvalue = ' <> ' . $adb->quote($value);
-			}elseif (trim($value) == '' && $datatype == 'V') {
+				if ($columnName) {
+									$rtvalue = ' <> ' . $adb->quote($value) . ' || ' . $columnName . " IS NULL ";
+				} else {
+									$rtvalue = ' <> ' . $adb->quote($value);
+				}
+			} elseif (trim($value) == '' && $datatype == 'V') {
 				$rtvalue = ' <> ' . $adb->quote($value);
 			} else {
 				$rtvalue = ' is NOT NULL';
@@ -864,8 +869,9 @@ 
 
 			$result = $adb->pquery($ssql, array($reportid, $groupId));
 			$noOfColumns = $adb->num_rows($result);
-			if ($noOfColumns <= 0)
-				continue;
+			if ($noOfColumns <= 0) {
+							continue;
+			}
 
 			while ($relcriteriarow = $adb->fetch_array($result)) {
 				$columnIndex = $relcriteriarow["columnindex"];
@@ -889,8 +895,9 @@ 
 			$i++;
 		}
 		// Clear the condition (and/or) for last group, if any.
-		if (!empty($advft_criteria[$i - 1]['condition']))
-			$advft_criteria[$i - 1]['condition'] = '';
+		if (!empty($advft_criteria[$i - 1]['condition'])) {
+					$advft_criteria[$i - 1]['condition'] = '';
+		}
 		return $advft_criteria;
 	}
 
@@ -1000,11 +1007,12 @@ 
 									$end = getValidDBInsertDateTimeValue($date2);
 									$start = "'$start'";
 									$end = "'$end'";
-									if ($comparator == 'e')
-										$advfiltergroupsql .= "$tableColumnSql BETWEEN $start AND $end";
-									else
-										$advfiltergroupsql .= "$tableColumnSql NOT BETWEEN $start AND $end";
-								}else if ($comparator == 'bw') {
+									if ($comparator == 'e') {
+																			$advfiltergroupsql .= "$tableColumnSql BETWEEN $start AND $end";
+									} else {
+																			$advfiltergroupsql .= "$tableColumnSql NOT BETWEEN $start AND $end";
+									}
+								} else if ($comparator == 'bw') {
 									$values = explode(',', $value);
 									$startDateTime = explode(' ', $values[0]);
 									$endDateTime = explode(' ', $values[1]);
@@ -1056,10 +1064,12 @@ 
 						}
 						//Added to handle yes or no for checkbox  field in reports advance filters. -shahul
 						if ($selectedfields[4] == 'C') {
-							if (strcasecmp(trim($value), "yes") == 0)
-								$value = "1";
-							if (strcasecmp(trim($value), "no") == 0)
-								$value = "0";
+							if (strcasecmp(trim($value), "yes") == 0) {
+															$value = "1";
+							}
+							if (strcasecmp(trim($value), "no") == 0) {
+															$value = "0";
+							}
 						}
 						if (in_array($comparator, $dateSpecificConditions)) {
 							$customView = new CustomView($moduleName);
@@ -1105,13 +1115,15 @@ 
 										$advcolsql[] = "vtiger_troubletickets.status" . $this->getAdvComparator($comparator, trim($valuearray[$n]), $datatype);
 									} else if ($selectedfields[2] == 'Faq_Status') {
 										$advcolsql[] = "vtiger_faq.status" . $this->getAdvComparator($comparator, trim($valuearray[$n]), $datatype);
-									} else
-										$advcolsql[] = $selectedfields[0] . "." . $selectedfields[1] . $this->getAdvComparator($comparator, trim($valuearray[$n]), $datatype);
+									} else {
+																			$advcolsql[] = $selectedfields[0] . "." . $selectedfields[1] . $this->getAdvComparator($comparator, trim($valuearray[$n]), $datatype);
+									}
 								} elseif ($selectedfields[1] == 'description') {//when you use comma seperated values.
-									if ($selectedfields[0] == 'vtiger_crmentity' . $this->primarymodule)
-										$advcolsql[] = "vtiger_crmentity.description" . $this->getAdvComparator($comparator, trim($valuearray[$n]), $datatype);
-									else
-										$advcolsql[] = $selectedfields[0] . "." . $selectedfields[1] . $this->getAdvComparator($comparator, trim($valuearray[$n]), $datatype);
+									if ($selectedfields[0] == 'vtiger_crmentity' . $this->primarymodule) {
+																			$advcolsql[] = "vtiger_crmentity.description" . $this->getAdvComparator($comparator, trim($valuearray[$n]), $datatype);
+									} else {
+																			$advcolsql[] = $selectedfields[0] . "." . $selectedfields[1] . $this->getAdvComparator($comparator, trim($valuearray[$n]), $datatype);
+									}
 								} elseif ($selectedfields[2] == 'Quotes_Inventory_Manager') {
 									$advcolsql[] = ("trim($concatSql)" . $this->getAdvComparator($comparator, trim($valuearray[$n]), $datatype));
 								} elseif ($selectedfields[1] == 'modifiedby') {
@@ -1128,10 +1140,11 @@ 
 								}
 							}
 							//If negative logic filter ('not equal to', 'does not contain') is used, 'and' condition should be applied instead of 'or'
-							if ($comparator == 'n' || $comparator == 'k')
-								$advcolumnsql = implode(" and ", $advcolsql);
-							else
-								$advcolumnsql = implode(" or ", $advcolsql);
+							if ($comparator == 'n' || $comparator == 'k') {
+															$advcolumnsql = implode(" and ", $advcolsql);
+							} else {
+															$advcolumnsql = implode(" or ", $advcolsql);
+							}
 							$fieldvalue = " (" . $advcolumnsql . ") ";
 						} elseif ($selectedfields[1] == 'user_name') {
 							if ($selectedfields[0] == "vtiger_users" . $this->primarymodule) {
@@ -1199,18 +1212,20 @@ 
 								$fieldvalue = "vtiger_activity.status" . $this->getAdvComparator($comparator, trim($value), $datatype);
 							}
 						} else if ($comparator == 'ny') {
-							if ($fieldInfo['uitype'] == '10' || isReferenceUIType($fieldInfo['uitype']))
-								$fieldvalue = "(" . $selectedfields[0] . "." . $selectedfields[1] . " IS NOT NULL && " . $selectedfields[0] . "." . $selectedfields[1] . " != '' && " . $selectedfields[0] . "." . $selectedfields[1] . "  != '0')";
-							else
-								$fieldvalue = "(" . $selectedfields[0] . "." . $selectedfields[1] . " IS NOT NULL && " . $selectedfields[0] . "." . $selectedfields[1] . " != '')";
-						}elseif ($comparator == 'y' || ($comparator == 'e' && (trim($value) == "NULL" || trim($value) == ''))) {
+							if ($fieldInfo['uitype'] == '10' || isReferenceUIType($fieldInfo['uitype'])) {
+															$fieldvalue = "(" . $selectedfields[0] . "." . $selectedfields[1] . " IS NOT NULL && " . $selectedfields[0] . "." . $selectedfields[1] . " != '' && " . $selectedfields[0] . "." . $selectedfields[1] . "  != '0')";
+							} else {
+															$fieldvalue = "(" . $selectedfields[0] . "." . $selectedfields[1] . " IS NOT NULL && " . $selectedfields[0] . "." . $selectedfields[1] . " != '')";
+							}
+						} elseif ($comparator == 'y' || ($comparator == 'e' && (trim($value) == "NULL" || trim($value) == ''))) {
 							if ($selectedfields[0] == 'vtiger_inventoryproductrel') {
 								$selectedfields[0] = 'vtiger_inventoryproductrel' . $moduleName;
 							}
-							if ($fieldInfo['uitype'] == '10' || isReferenceUIType($fieldInfo['uitype']))
-								$fieldvalue = "(" . $selectedfields[0] . "." . $selectedfields[1] . " IS NULL || " . $selectedfields[0] . "." . $selectedfields[1] . " = '' || " . $selectedfields[0] . "." . $selectedfields[1] . " = '0')";
-							else
-								$fieldvalue = "(" . $selectedfields[0] . "." . $selectedfields[1] . " IS NULL || " . $selectedfields[0] . "." . $selectedfields[1] . " = '')";
+							if ($fieldInfo['uitype'] == '10' || isReferenceUIType($fieldInfo['uitype'])) {
+															$fieldvalue = "(" . $selectedfields[0] . "." . $selectedfields[1] . " IS NULL || " . $selectedfields[0] . "." . $selectedfields[1] . " = '' || " . $selectedfields[0] . "." . $selectedfields[1] . " = '0')";
+							} else {
+															$fieldvalue = "(" . $selectedfields[0] . "." . $selectedfields[1] . " IS NULL || " . $selectedfields[0] . "." . $selectedfields[1] . " = '')";
+							}
 						} elseif ($selectedfields[0] == 'vtiger_inventoryproductrel') {
 							if ($selectedfields[1] == 'productid') {
 								$fieldvalue = "vtiger_products$moduleName.productname " . $this->getAdvComparator($comparator, trim($value), $datatype);
@@ -1256,8 +1271,9 @@ 
 				}
 			}
 		}
-		if (trim($advfiltersql) != "")
-			$advfiltersql = '(' . $advfiltersql . ')';
+		if (trim($advfiltersql) != "") {
+					$advfiltersql = '(' . $advfiltersql . ')';
+		}
 
 		return $advfiltersql;
 	}
@@ -1312,8 +1328,9 @@ 
 
 			if ($fieldcolname != "none") {
 				$selectedfields = explode(":", $fieldcolname);
-				if ($selectedfields[0] == "vtiger_crmentity" . $this->primarymodule)
-					$selectedfields[0] = "vtiger_crmentity";
+				if ($selectedfields[0] == "vtiger_crmentity" . $this->primarymodule) {
+									$selectedfields[0] = "vtiger_crmentity";
+				}
 
 				$moduleFieldLabel = $selectedfields[3];
 				list($moduleName, $fieldLabel) = explode('__', $moduleFieldLabel, 2);
@@ -1382,8 +1399,9 @@ 
 	{
 		if ($filtercolumn != "none") {
 			$selectedfields = explode(":", $filtercolumn);
-			if ($selectedfields[0] == "vtiger_crmentity" . $this->primarymodule)
-				$selectedfields[0] = "vtiger_crmentity";
+			if ($selectedfields[0] == "vtiger_crmentity" . $this->primarymodule) {
+							$selectedfields[0] = "vtiger_crmentity";
+			}
 			if ($filter == "custom") {
 				if ($startdate != "0000-00-00" && $enddate != "0000-00-00" && $startdate != "" &&
 					$enddate != "" && $selectedfields[0] != "" && $selectedfields[1] != "") {
@@ -1416,8 +1434,9 @@ 
 		if (!empty($advft_criteria)) {
 			foreach ($advft_criteria as $column_index => $column_condition) {
 
-				if (empty($column_condition))
-					continue;
+				if (empty($column_condition)) {
+									continue;
+				}
 
 				$adv_filter_column = $column_condition["columnname"];
 				$adv_filter_comparator = $column_condition["comparator"];
@@ -1474,10 +1493,12 @@ 
 			}
 
 			foreach ($advft_criteria_groups as $group_index => $group_condition_info) {
-				if (empty($group_condition_info))
-					continue;
-				if (empty($advfilterlist[$group_index]))
-					continue;
+				if (empty($group_condition_info)) {
+									continue;
+				}
+				if (empty($advfilterlist[$group_index])) {
+									continue;
+				}
 				$advfilterlist[$group_index]['condition'] = $group_condition_info["groupcondition"];
 				$noOfGroupColumns = count($advfilterlist[$group_index]['columns']);
 				if (!empty($advfilterlist[$group_index]['columns'][$noOfGroupColumns - 1]['column_condition'])) {
@@ -1519,8 +1540,9 @@ 
 
 			if ($fieldcolname != "none") {
 				$selectedfields = explode(":", $fieldcolname);
-				if ($selectedfields[0] == "vtiger_crmentity" . $this->primarymodule)
-					$selectedfields[0] = "vtiger_crmentity";
+				if ($selectedfields[0] == "vtiger_crmentity" . $this->primarymodule) {
+									$selectedfields[0] = "vtiger_crmentity";
+				}
 				if ($datefilter == "custom") {
 
 					if ($startdate != "0000-00-00" && $enddate != "0000-00-00" && $selectedfields[0] != "" && $selectedfields[1] != "" && $startdate != '' && $enddate != '') {
@@ -1609,8 +1631,9 @@ 
 
 			if ($fieldcolname != "none") {
 				$selectedfields = explode(":", $fieldcolname);
-				if ($selectedfields[0] == "vtiger_crmentity" . $this->primarymodule)
-					$selectedfields[0] = "vtiger_crmentity";
+				if ($selectedfields[0] == "vtiger_crmentity" . $this->primarymodule) {
+									$selectedfields[0] = "vtiger_crmentity";
+				}
 				if (stripos($selectedfields[1], 'cf_') == 0 && stristr($selectedfields[1], 'cf_') === true) {
 					//In sql queries forward slash(/) is treated as query terminator,so to avoid this problem
 					//the column names are enclosed within ('[]'),which will treat this as part of column name
@@ -1703,8 +1726,9 @@ 
 					$sSQL .= ", ";
 					$this->orderbylistsql .= ", ";
 				}
-				if ($selectedfields[0] == "vtiger_crmentity" . $this->primarymodule)
-					$selectedfields[0] = "vtiger_crmentity";
+				if ($selectedfields[0] == "vtiger_crmentity" . $this->primarymodule) {
+									$selectedfields[0] = "vtiger_crmentity";
+				}
 				$sSQL .= $selectedfields[0] . "." . $selectedfields[1] . " " . $sortorder;
 				$this->orderbylistsql .= $selectedfields[0] . "." . $selectedfields[1] . " " . $selectedfields[2];
 			}
@@ -2289,8 +2313,9 @@ 
 		}
 		/* STRING TRANSLATION starts */
 		$moduleLabel = '';
-		if (in_array($module, $modules_selected))
-			$moduleLabel = \App\Language::translate($module, $module);
+		if (in_array($module, $modules_selected)) {
+					$moduleLabel = \App\Language::translate($module, $module);
+		}
 
 		if (empty($translatedLabel)) {
 			$translatedLabel = \App\Language::translate(str_replace('__', " ", $fld->name), $module);
@@ -2370,8 +2395,9 @@ 
 			}
 			// END
 
-			if ($is_admin === false && $profileGlobalPermission[1] == 1 && $profileGlobalPermission[2] == 1)
-				$picklistarray = $this->getAccessPickListValues();
+			if ($is_admin === false && $profileGlobalPermission[1] == 1 && $profileGlobalPermission[2] == 1) {
+							$picklistarray = $this->getAccessPickListValues();
+			}
 			if ($result) {
 				$y = $adb->getFieldsCount($result);
 				$arrayHeaders = Array();
@@ -2405,10 +2431,11 @@ 
 							$headerLabel_tmp = \App\Language::translate($mod_name[0] . " " . $mod_name[1]);
 						}
 					}
-					if ($headerLabel == $headerLabel_tmp)
-						$headerLabel = \App\Language::translate($headerLabel_tmp);
-					else
-						$headerLabel = $headerLabel_tmp;
+					if ($headerLabel == $headerLabel_tmp) {
+											$headerLabel = \App\Language::translate($headerLabel_tmp);
+					} else {
+											$headerLabel = $headerLabel_tmp;
+					}
 					/* STRING TRANSLATION ends */
 					$header .= "<td class='rptCellLabel'>" . $headerLabel . "</td>";
 
@@ -2444,14 +2471,17 @@ 
 						$snewvalue = $custom_field_values[1];
 						$tnewvalue = $custom_field_values[2];
 					}
-					if ($newvalue == "")
-						$newvalue = "-";
+					if ($newvalue == "") {
+											$newvalue = "-";
+					}
 
-					if ($snewvalue == "")
-						$snewvalue = "-";
+					if ($snewvalue == "") {
+											$snewvalue = "-";
+					}
 
-					if ($tnewvalue == "")
-						$tnewvalue = "-";
+					if ($tnewvalue == "") {
+											$tnewvalue = "-";
+					}
 
 					$valtemplate .= "<tr>";
 
@@ -2577,8 +2607,9 @@ 
 		} elseif ($outputformat == "PDF") {
 			$sSQL = $this->sGetSQLforReport($this->reportid, $filtersql, $outputformat, false, $startLimit, $endLimit);
 			$result = $adb->pquery($sSQL, array());
-			if ($is_admin === false && $profileGlobalPermission[1] == 1 && $profileGlobalPermission[2] == 1)
-				$picklistarray = $this->getAccessPickListValues();
+			if ($is_admin === false && $profileGlobalPermission[1] == 1 && $profileGlobalPermission[2] == 1) {
+							$picklistarray = $this->getAccessPickListValues();
+			}
 
 			if ($result) {
 				$y = $adb->getFieldsCount($result);
@@ -2661,45 +2692,49 @@ 
 						$value = trim($key);
 						$arraykey = $value . '__SUM';
 						if (isset($keyhdr[$arraykey])) {
-							if ($convert_price)
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
-							else
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							if ($convert_price) {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
+							} else {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							}
 							$totalpdf[$rowcount][$arraykey] = $conv_value;
-						}else {
+						} else {
 							$totalpdf[$rowcount][$arraykey] = '';
 						}
 
 						$arraykey = $value . '__AVG';
 						if (isset($keyhdr[$arraykey])) {
-							if ($convert_price)
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
-							else
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							if ($convert_price) {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
+							} else {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							}
 							$totalpdf[$rowcount][$arraykey] = $conv_value;
-						}else {
+						} else {
 							$totalpdf[$rowcount][$arraykey] = '';
 						}
 
 						$arraykey = $value . '__MIN';
 						if (isset($keyhdr[$arraykey])) {
-							if ($convert_price)
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
-							else
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							if ($convert_price) {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
+							} else {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							}
 							$totalpdf[$rowcount][$arraykey] = $conv_value;
-						}else {
+						} else {
 							$totalpdf[$rowcount][$arraykey] = '';
 						}
 
 						$arraykey = $value . '__MAX';
 						if (isset($keyhdr[$arraykey])) {
-							if ($convert_price)
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
-							else
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							if ($convert_price) {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
+							} else {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							}
 							$totalpdf[$rowcount][$arraykey] = $conv_value;
-						}else {
+						} else {
 							$totalpdf[$rowcount][$arraykey] = '';
 						}
 						$rowcount++;
@@ -2773,45 +2808,49 @@ 
 						$value = trim($key);
 						$arraykey = $value . '__SUM';
 						if (isset($keyhdr[$arraykey])) {
-							if ($convert_price)
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
-							else
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							if ($convert_price) {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
+							} else {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							}
 							$coltotalhtml .= '<td class="rptTotal">' . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= '<td class="rptTotal">&nbsp;</td>';
 						}
 
 						$arraykey = $value . '__AVG';
 						if (isset($keyhdr[$arraykey])) {
-							if ($convert_price)
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
-							else
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							if ($convert_price) {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
+							} else {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							}
 							$coltotalhtml .= '<td class="rptTotal">' . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= '<td class="rptTotal">&nbsp;</td>';
 						}
 
 						$arraykey = $value . '__MIN';
 						if (isset($keyhdr[$arraykey])) {
-							if ($convert_price)
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
-							else
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							if ($convert_price) {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
+							} else {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							}
 							$coltotalhtml .= '<td class="rptTotal">' . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= '<td class="rptTotal">&nbsp;</td>';
 						}
 
 						$arraykey = $value . '__MAX';
 						if (isset($keyhdr[$arraykey])) {
-							if ($convert_price)
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
-							else
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							if ($convert_price) {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
+							} else {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							}
 							$coltotalhtml .= '<td class="rptTotal">' . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= '<td class="rptTotal">&nbsp;</td>';
 						}
 
@@ -2839,8 +2878,9 @@ 
 		} elseif ($outputformat == "PRINT") {
 			$sSQL = $this->sGetSQLforReport($this->reportid, $filtersql, $outputformat);
 			$result = $adb->query($sSQL);
-			if ($is_admin === false && $profileGlobalPermission[1] == 1 && $profileGlobalPermission[2] == 1)
-				$picklistarray = $this->getAccessPickListValues();
+			if ($is_admin === false && $profileGlobalPermission[1] == 1 && $profileGlobalPermission[2] == 1) {
+							$picklistarray = $this->getAccessPickListValues();
+			}
 
 			if ($result) {
 				$y = $adb->getFieldsCount($result);
@@ -2869,14 +2909,17 @@ 
 						$tnewvalue = $custom_field_values[2];
 					}
 
-					if ($newvalue == "")
-						$newvalue = "-";
+					if ($newvalue == "") {
+											$newvalue = "-";
+					}
 
-					if ($snewvalue == "")
-						$snewvalue = "-";
+					if ($snewvalue == "") {
+											$snewvalue = "-";
+					}
 
-					if ($tnewvalue == "")
-						$tnewvalue = "-";
+					if ($tnewvalue == "") {
+											$tnewvalue = "-";
+					}
 
 					$valtemplate .= "<tr>";
 
@@ -2978,45 +3021,49 @@ 
 						$value = trim($key);
 						$arraykey = $value . '__SUM';
 						if (isset($keyhdr[$arraykey])) {
-							if ($convert_price)
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
-							else
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							if ($convert_price) {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
+							} else {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							}
 							$coltotalhtml .= "<td class='rptTotal'>" . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= "<td class='rptTotal'>&nbsp;</td>";
 						}
 
 						$arraykey = $value . '__AVG';
 						if (isset($keyhdr[$arraykey])) {
-							if ($convert_price)
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
-							else
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							if ($convert_price) {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
+							} else {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							}
 							$coltotalhtml .= "<td class='rptTotal'>" . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= "<td class='rptTotal'>&nbsp;</td>";
 						}
 
 						$arraykey = $value . '__MIN';
 						if (isset($keyhdr[$arraykey])) {
-							if ($convert_price)
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
-							else
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							if ($convert_price) {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
+							} else {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							}
 							$coltotalhtml .= "<td class='rptTotal'>" . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= "<td class='rptTotal'>&nbsp;</td>";
 						}
 
 						$arraykey = $value . '__MAX';
 						if (isset($keyhdr[$arraykey])) {
-							if ($convert_price)
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
-							else
-								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							if ($convert_price) {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey]);
+							} else {
+															$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
+							}
 							$coltotalhtml .= "<td class='rptTotal'>" . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= "<td class='rptTotal'>&nbsp;</td>";
 						}
 
@@ -3271,8 +3318,9 @@ 
 		$adb = PearDatabase::getInstance();
 		$current_user = vglobal('current_user');
 		$id = array(\App\Module::getModuleId($this->primarymodule));
-		if ($this->secondarymodule != '')
-			array_push($id, \App\Module::getModuleId($this->secondarymodule));
+		if ($this->secondarymodule != '') {
+					array_push($id, \App\Module::getModuleId($this->secondarymodule));
+		}
 
 		$query = sprintf('select fieldname,columnname,fieldid,fieldlabel,tabid,uitype from vtiger_field where tabid in(%s) and uitype in (15,33,55)', generateQuestionMarks($id)); //and columnname in (?)';
 		$result = $adb->pquery($query, $id); //,$select_column));
@@ -3301,13 +3349,15 @@ 
 			} else {
 				$mulsel = "select distinct $fieldname from vtiger_$fieldname inner join vtiger_role2picklist on vtiger_role2picklist.picklistvalueid = vtiger_$fieldname.picklist_valueid where roleid ='" . $roleid . "' and picklistid in (select picklistid from vtiger_$fieldname)"; // order by sortid asc - not requried
 			}
-			if ($fieldname != 'firstname')
-				$mulselresult = $adb->query($mulsel);
+			if ($fieldname != 'firstname') {
+							$mulselresult = $adb->query($mulsel);
+			}
 			$countMulSelResult = $adb->num_rows($mulselresult);
 			for ($j = 0; $j < $countMulSelResult; $j++) {
 				$fldvalue = $adb->query_result($mulselresult, $j, $fieldname);
-				if (in_array($fldvalue, $fieldvalues))
-					continue;
+				if (in_array($fldvalue, $fieldvalues)) {
+									continue;
+				}
 				$fieldvalues[] = $fldvalue;
 			}
 			$field_count = count($fieldvalues);
@@ -3318,16 +3368,18 @@ 
 						$temp_status[$keyvalue][($temp_count + $t)] = $fieldvalues[$t];
 					}
 					$fieldvalues = $temp_status[$keyvalue];
-				} else
-					$temp_status[$keyvalue] = $fieldvalues;
+				} else {
+									$temp_status[$keyvalue] = $fieldvalues;
+				}
 			}
 
-			if ($uitype == 33)
-				$fieldlists[1][$keyvalue] = $fieldvalues;
-			else if ($uitype == 55 && $fieldname == 'salutationtype')
-				$fieldlists[$keyvalue] = $fieldvalues;
-			else if ($uitype == 15)
-				$fieldlists[$keyvalue] = $fieldvalues;
+			if ($uitype == 33) {
+							$fieldlists[1][$keyvalue] = $fieldvalues;
+			} else if ($uitype == 55 && $fieldname == 'salutationtype') {
+							$fieldlists[$keyvalue] = $fieldvalues;
+			} else if ($uitype == 15) {
+							$fieldlists[$keyvalue] = $fieldvalues;
+			}
 		}
 		return $fieldlists;
 	}

Spacing +16 added lines, -16 removed lines

@@ -1004,7 +1004,7 @@ 
 										$advfiltergroupsql .= "$tableColumnSql BETWEEN $start AND $end";
 									else
 										$advfiltergroupsql .= "$tableColumnSql NOT BETWEEN $start AND $end";
-								}else if ($comparator == 'bw') {
+								} else if ($comparator == 'bw') {
 									$values = explode(',', $value);
 									$startDateTime = explode(' ', $values[0]);
 									$endDateTime = explode(' ', $values[1]);
@@ -1447,7 +1447,7 @@ 
 				}
 
 				$temp_val = explode(",", $adv_filter_value);
-				if (($column_info[4] == 'D' || ($column_info[4] == 'T' && $column_info[1] != 'time_start' && $column_info[1] != 'time_end') || ($column_info[4] == 'DT')) && ($column_info[4] != '' && $adv_filter_value != '' )) {
+				if (($column_info[4] == 'D' || ($column_info[4] == 'T' && $column_info[1] != 'time_start' && $column_info[1] != 'time_end') || ($column_info[4] == 'DT')) && ($column_info[4] != '' && $adv_filter_value != '')) {
 					$val = Array();
 					$countTempVal = count($temp_val);
 					for ($x = 0; $x < $countTempVal; $x++) {
@@ -2666,7 +2666,7 @@ 
 							else
 								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
 							$totalpdf[$rowcount][$arraykey] = $conv_value;
-						}else {
+						} else {
 							$totalpdf[$rowcount][$arraykey] = '';
 						}
 
@@ -2677,7 +2677,7 @@ 
 							else
 								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
 							$totalpdf[$rowcount][$arraykey] = $conv_value;
-						}else {
+						} else {
 							$totalpdf[$rowcount][$arraykey] = '';
 						}
 
@@ -2688,7 +2688,7 @@ 
 							else
 								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
 							$totalpdf[$rowcount][$arraykey] = $conv_value;
-						}else {
+						} else {
 							$totalpdf[$rowcount][$arraykey] = '';
 						}
 
@@ -2699,7 +2699,7 @@ 
 							else
 								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
 							$totalpdf[$rowcount][$arraykey] = $conv_value;
-						}else {
+						} else {
 							$totalpdf[$rowcount][$arraykey] = '';
 						}
 						$rowcount++;
@@ -2778,7 +2778,7 @@ 
 							else
 								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
 							$coltotalhtml .= '<td class="rptTotal">' . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= '<td class="rptTotal">&nbsp;</td>';
 						}
 
@@ -2789,7 +2789,7 @@ 
 							else
 								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
 							$coltotalhtml .= '<td class="rptTotal">' . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= '<td class="rptTotal">&nbsp;</td>';
 						}
 
@@ -2800,7 +2800,7 @@ 
 							else
 								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
 							$coltotalhtml .= '<td class="rptTotal">' . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= '<td class="rptTotal">&nbsp;</td>';
 						}
 
@@ -2811,7 +2811,7 @@ 
 							else
 								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
 							$coltotalhtml .= '<td class="rptTotal">' . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= '<td class="rptTotal">&nbsp;</td>';
 						}
 
@@ -2983,7 +2983,7 @@ 
 							else
 								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
 							$coltotalhtml .= "<td class='rptTotal'>" . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= "<td class='rptTotal'>&nbsp;</td>";
 						}
 
@@ -2994,7 +2994,7 @@ 
 							else
 								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
 							$coltotalhtml .= "<td class='rptTotal'>" . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= "<td class='rptTotal'>&nbsp;</td>";
 						}
 
@@ -3005,7 +3005,7 @@ 
 							else
 								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
 							$coltotalhtml .= "<td class='rptTotal'>" . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= "<td class='rptTotal'>&nbsp;</td>";
 						}
 
@@ -3016,7 +3016,7 @@ 
 							else
 								$conv_value = CurrencyField::convertToUserFormat($keyhdr[$arraykey], null, true);
 							$coltotalhtml .= "<td class='rptTotal'>" . $conv_value . '</td>';
-						}else {
+						} else {
 							$coltotalhtml .= "<td class='rptTotal'>&nbsp;</td>";
 						}
 
@@ -3377,7 +3377,7 @@ 
 			$rowcount = 1;
 			//copy the first value details
 			$arrayFirstRowValues = $arr_val[0];
-			array_pop($arrayFirstRowValues);   // removed action link in details
+			array_pop($arrayFirstRowValues); // removed action link in details
 			foreach ($arrayFirstRowValues as $key => $value) {
 				$worksheet->setCellValueExplicitByColumnAndRow($count, $rowcount, $key, true);
 				$worksheet->getStyleByColumnAndRow($count, $rowcount)->applyFromArray($header_styles);
@@ -3442,7 +3442,7 @@ 
 		if (isset($arr_val)) {
 			// Header
 			$csv_values = array_keys($arr_val[0]);
-			array_pop($csv_values);   //removed header in csv file
+			array_pop($csv_values); //removed header in csv file
 			fputcsv($fp, $csv_values);
 			foreach ($arr_val as $key => $array_value) {
 				array_pop($array_value); //removed action link

modules/Reports/Reports.php

Doc Comments +1 added lines

@@ -387,6 +387,7 @@
 	 *  This function accepts the folderid
 	 *  This Generates the Reports under each Reports module
 	 *  This Returns a HTML sring
+	 * @param boolean $rpt_fldr_id
 	 */
 	public function sgetRptsforFldr($rpt_fldr_id, $paramsList = false)
 	{

Spacing +7 added lines, -7 removed lines

@@ -188,9 +188,9 @@ 
 			if ($modulerows) {
 				foreach ($modulerows as $resultrow) {
 					if ($resultrow['presence'] == '1')
-						continue;   // skip disabled modules
+						continue; // skip disabled modules
 					if ($resultrow['isentitytype'] != '1')
-						continue;  // skip extension modules
+						continue; // skip extension modules
 					if (in_array($resultrow['name'], $restricted_modules)) { // skip restricted modules
 						continue;
 					}
@@ -307,7 +307,7 @@ 
 					$details = [];
 					$details['state'] = $reportfldrow["state"];
 					$details['id'] = $reportfldrow["folderid"];
-					$details['name'] = ($mod_strings[$reportfldrow["foldername"]] == '' ) ? $reportfldrow["foldername"] : $mod_strings[$reportfldrow["foldername"]];
+					$details['name'] = ($mod_strings[$reportfldrow["foldername"]] == '') ? $reportfldrow["foldername"] : $mod_strings[$reportfldrow["foldername"]];
 					$details['description'] = $reportfldrow["description"];
 					$details['fname'] = popup_decode_html($details['name']);
 					$details['fdescription'] = popup_decode_html($reportfldrow["description"]);
@@ -320,7 +320,7 @@ 
 				$details = [];
 				$details['state'] = $reportfldrow["state"];
 				$details['id'] = $reportfldrow["folderid"];
-				$details['name'] = ($mod_strings[$reportfldrow["foldername"]] == '' ) ? $reportfldrow["foldername"] : $mod_strings[$reportfldrow["foldername"]];
+				$details['name'] = ($mod_strings[$reportfldrow["foldername"]] == '') ? $reportfldrow["foldername"] : $mod_strings[$reportfldrow["foldername"]];
 				$details['description'] = $reportfldrow["description"];
 				$details['fname'] = popup_decode_html($details['name']);
 				$details['fdescription'] = popup_decode_html($reportfldrow["description"]);
@@ -375,7 +375,7 @@ 
 
 				if (isPermitted($report["primarymodule"], 'index') == "yes")
 					$returndata[] = $report_details;
-			}while ($report = $adb->fetch_array($result));
+			} while ($report = $adb->fetch_array($result));
 		}
 		\App\Log::trace("Reports :: ListView->Successfully returned vtiger_report details HTML");
 		return $returndata;
@@ -462,7 +462,7 @@ 
 
 				if (isPermitted($report["primarymodule"], 'index') == "yes")
 					$returndata [$report["folderid"]][] = $report_details;
-			}while ($report = $adb->fetch_array($result));
+			} while ($report = $adb->fetch_array($result));
 		}
 
 		if ($rpt_fldr_id !== false) {
@@ -1264,7 +1264,7 @@ 
 		}
 
 		$temp_val = explode(",", $adv_filter_value);
-		if (($column_info[4] == 'D' || ($column_info[4] == 'T' && $column_info[1] != 'time_start' && $column_info[1] != 'time_end') || ($column_info[4] == 'DT')) && ($column_info[4] != '' && $adv_filter_value != '' )) {
+		if (($column_info[4] == 'D' || ($column_info[4] == 'T' && $column_info[1] != 'time_start' && $column_info[1] != 'time_end') || ($column_info[4] == 'DT')) && ($column_info[4] != '' && $adv_filter_value != '')) {
 			$val = [];
 			$countTempVal = count($temp_val);
 			for ($x = 0; $x < $countTempVal; $x++) {

Braces +78 added lines, -54 removed lines

@@ -127,10 +127,11 @@ 
 				$this->reportname = decode_html($cachedInfo["reportname"]);
 				$this->reportdescription = decode_html($cachedInfo["description"]);
 				$this->folderid = $cachedInfo["folderid"];
-				if ($is_admin === true || in_array($cachedInfo["owner"], $subordinate_users) || $cachedInfo["owner"] == $current_user->id)
-					$this->is_editable = 'true';
-				else
-					$this->is_editable = 'false';
+				if ($is_admin === true || in_array($cachedInfo["owner"], $subordinate_users) || $cachedInfo["owner"] == $current_user->id) {
+									$this->is_editable = 'true';
+				} else {
+									$this->is_editable = 'false';
+				}
 			} else {
 				throw new \Exception\NoPermitted('LBL_PERMISSION_DENIED');
 			}
@@ -141,8 +142,9 @@ 
 	public function updateModuleList($module)
 	{
 		$adb = PearDatabase::getInstance();
-		if (!isset($module))
-			return;
+		if (!isset($module)) {
+					return;
+		}
 		require_once('include/utils/utils.php');
 		$tabid = \App\Module::getModuleId($module);
 		if ($module == 'Calendar') {
@@ -151,12 +153,14 @@ 
 		$sql = sprintf('SELECT blockid, blocklabel FROM vtiger_blocks WHERE tabid IN (%s)', generateQuestionMarks($tabid));
 		$res = $adb->pquery($sql, [$tabid]);
 		$noOfRows = $adb->num_rows($res);
-		if ($noOfRows <= 0)
-			return;
+		if ($noOfRows <= 0) {
+					return;
+		}
 		for ($index = 0; $index < $noOfRows; ++$index) {
 			$blockid = $adb->query_result($res, $index, 'blockid');
-			if (in_array($blockid, $this->module_list[$module]))
-				continue;
+			if (in_array($blockid, $this->module_list[$module])) {
+							continue;
+			}
 			$blockid_list[] = $blockid;
 			$blocklabel = $adb->query_result($res, $index, 'blocklabel');
 			$this->module_list[$module][$blocklabel] = $blockid;
@@ -187,10 +191,14 @@ 
 
 			if ($modulerows) {
 				foreach ($modulerows as $resultrow) {
-					if ($resultrow['presence'] == '1')
-						continue;   // skip disabled modules
-					if ($resultrow['isentitytype'] != '1')
-						continue;  // skip extension modules
+					if ($resultrow['presence'] == '1') {
+											continue;
+					}
+					// skip disabled modules
+					if ($resultrow['isentitytype'] != '1') {
+											continue;
+					}
+					// skip extension modules
 					if (in_array($resultrow['name'], $restricted_modules)) { // skip restricted modules
 						continue;
 					}
@@ -221,10 +229,11 @@ 
 						}
 
 						if (!empty($blocklabel)) {
-							if ($module == 'Calendar' && $blocklabel == 'LBL_CUSTOM_INFORMATION')
-								$this->module_list[$module][$blockid] = \App\Language::translate($blocklabel, $module);
-							else
-								$this->module_list[$module][$blockid] = \App\Language::translate($blocklabel, $module);
+							if ($module == 'Calendar' && $blocklabel == 'LBL_CUSTOM_INFORMATION') {
+															$this->module_list[$module][$blockid] = \App\Language::translate($blocklabel, $module);
+							} else {
+															$this->module_list[$module][$blockid] = \App\Language::translate($blocklabel, $module);
+							}
 							$prev_block_label = $blocklabel;
 						} else {
 							$this->module_list[$module][$blockid] = \App\Language::translate($prev_block_label, $module);
@@ -368,13 +377,15 @@ 
 				$report_details ['reportname'] = $report["reportname"];
 				$report_details ['sharingtype'] = $report["sharingtype"];
 				$report_details['folderid'] = $report["folderid"];
-				if ($is_admin === true)
-					$report_details ['editable'] = 'true';
-				else
-					$report_details['editable'] = 'false';
+				if ($is_admin === true) {
+									$report_details ['editable'] = 'true';
+				} else {
+									$report_details['editable'] = 'false';
+				}
 
-				if (isPermitted($report["primarymodule"], 'index') == "yes")
-					$returndata[] = $report_details;
+				if (isPermitted($report["primarymodule"], 'index') == "yes") {
+									$returndata[] = $report_details;
+				}
 			}while ($report = $adb->fetch_array($result));
 		}
 		\App\Log::trace("Reports :: ListView->Successfully returned vtiger_report details HTML");
@@ -455,13 +466,15 @@ 
 				$report_details['reportname'] = $report["reportname"];
 				$report_details['reporttype'] = $report["reporttype"];
 				$report_details['sharingtype'] = $report["sharingtype"];
-				if ($is_admin === true || in_array($report["owner"], $subordinate_users) || $report["owner"] == $currentUser->getId())
-					$report_details['editable'] = 'true';
-				else
-					$report_details['editable'] = 'false';
+				if ($is_admin === true || in_array($report["owner"], $subordinate_users) || $report["owner"] == $currentUser->getId()) {
+									$report_details['editable'] = 'true';
+				} else {
+									$report_details['editable'] = 'false';
+				}
 
-				if (isPermitted($report["primarymodule"], 'index') == "yes")
-					$returndata [$report["folderid"]][] = $report_details;
+				if (isPermitted($report["primarymodule"], 'index') == "yes") {
+									$returndata [$report["folderid"]][] = $report_details;
+				}
 			}while ($report = $adb->fetch_array($result));
 		}
 
@@ -594,8 +607,9 @@ 
 		$adb = PearDatabase::getInstance();
 		$currentUser = Users_Privileges_Model::getCurrentUserPrivilegesModel();
 
-		if (is_string($block))
-			$block = explode(",", $block);
+		if (is_string($block)) {
+					$block = explode(",", $block);
+		}
 		$skipTalbes = array('vtiger_emaildetails', 'vtiger_attachments');
 
 		$tabid = \App\Module::getModuleId($module);
@@ -609,10 +623,11 @@ 
 			$sql = sprintf("select * from vtiger_field where vtiger_field.tabid in (%s) and vtiger_field.block in (%s) and vtiger_field.displaytype in (1,2,3,10) and vtiger_field.presence in (0,2) && tablename NOT IN (%s) ", generateQuestionMarks($tabid), generateQuestionMarks($block), generateQuestionMarks($skipTalbes));
 
 			//fix for Ticket #4016
-			if ($module == "Calendar")
-				$sql .= " group by vtiger_field.fieldlabel order by sequence";
-			else
-				$sql .= " order by sequence";
+			if ($module == "Calendar") {
+							$sql .= " group by vtiger_field.fieldlabel order by sequence";
+			} else {
+							$sql .= " order by sequence";
+			}
 		} else {
 			$profileList = $currentUser->getProfiles();
 			$sql = sprintf("select * from vtiger_field inner join vtiger_profile2field on vtiger_profile2field.fieldid=vtiger_field.fieldid inner join vtiger_def_org_field on vtiger_def_org_field.fieldid=vtiger_field.fieldid where vtiger_field.tabid in (%s)  and vtiger_field.block in (%s) and vtiger_field.displaytype in (1,2,3,10) and vtiger_profile2field.visible=0 and vtiger_def_org_field.visible=0 and vtiger_field.presence in (0,2)", generateQuestionMarks($tabid), generateQuestionMarks($block));
@@ -623,10 +638,11 @@ 
 			$sql .= ' and tablename NOT IN (' . generateQuestionMarks($skipTalbes) . ') ';
 
 			//fix for Ticket #4016
-			if ($module == "Calendar")
-				$sql .= " group by vtiger_field.fieldlabel order by sequence";
-			else
-				$sql .= " group by vtiger_field.fieldid order by sequence";
+			if ($module == "Calendar") {
+							$sql .= " group by vtiger_field.fieldlabel order by sequence";
+			} else {
+							$sql .= " group by vtiger_field.fieldid order by sequence";
+			}
 		}
 		array_push($params, $skipTalbes);
 
@@ -674,8 +690,9 @@ 
 				$this->adv_rel_fields[$fieldtypeofdata][] = $adv_rel_field_tod_value;
 			}
 			//added to escape attachments fields in Reports as we have multiple attachments
-			if ($module == 'HelpDesk' && $fieldname == 'filename')
-				continue;
+			if ($module == 'HelpDesk' && $fieldname == 'filename') {
+							continue;
+			}
 
 			if (is_string($block) || $group_res_by_block === false) {
 				$module_columnlist[$optionvalue] = $fieldlabel;
@@ -916,8 +933,9 @@ 
 
 			$result = $adb->pquery($ssql, array($reportid, $groupId));
 			$noOfColumns = $adb->num_rows($result);
-			if ($noOfColumns <= 0)
-				continue;
+			if ($noOfColumns <= 0) {
+							continue;
+			}
 
 			while ($relcriteriarow = $adb->fetch_array($result)) {
 				$columnIndex = $relcriteriarow["columnindex"];
@@ -975,8 +993,9 @@ 
 			$i++;
 		}
 		// Clear the condition (and/or) for last group, if any.
-		if (!empty($advft_criteria[$i - 1]['condition']))
-			$advft_criteria[$i - 1]['condition'] = '';
+		if (!empty($advft_criteria[$i - 1]['condition'])) {
+					$advft_criteria[$i - 1]['condition'] = '';
+		}
 		$this->advft_criteria = $advft_criteria;
 		\App\Log::trace("Reports :: Successfully returned getAdvancedFilterList");
 		return true;
@@ -1229,13 +1248,15 @@ 
 	$idelrelcriteriagroupsql = "delete from vtiger_relcriteria_grouping where queryid=?";
 	$idelrelcriteriagroupsqlresult = $adb->pquery($idelrelcriteriagroupsql, array($reportid));
 
-	if (empty($advft_criteria))
-		return;
+	if (empty($advft_criteria)) {
+			return;
+	}
 
 	foreach ($advft_criteria as $column_index => $column_condition) {
 
-		if (empty($column_condition))
-			continue;
+		if (empty($column_condition)) {
+					continue;
+		}
 
 		$adv_filter_column = $column_condition["columnname"];
 		$adv_filter_comparator = $column_condition["comparator"];
@@ -1297,10 +1318,13 @@ 
 
 	foreach ($advft_criteria_groups as $group_index => $group_condition_info) {
 
-		if (empty($group_condition_info))
-			continue;
-		if (empty($group_condition_info["conditionexpression"]))
-			continue; // Case when the group doesn't have any column criteria
+		if (empty($group_condition_info)) {
+					continue;
+		}
+		if (empty($group_condition_info["conditionexpression"])) {
+					continue;
+		}
+		// Case when the group doesn't have any column criteria
 
 		$irelcriteriagroupsql = "insert into vtiger_relcriteria_grouping(GROUPID,QUERYID,GROUP_CONDITION,CONDITION_EXPRESSION) values (?,?,?,?)";
 		$irelcriteriagroupresult = $adb->pquery($irelcriteriagroupsql, array($group_index, $reportid, $group_condition_info["groupcondition"], $group_condition_info["conditionexpression"]));

modules/Reports/ScheduledReports.php

Doc Comments +3 added lines

@@ -340,6 +340,9 @@
 		return $rolesAndSubHTML;
 	}
 
+	/**
+	 * @param Users $user
+	 */
 	public static function getScheduledReports($adb, $user)
 	{
 

Braces +15 added lines, -10 removed lines

@@ -258,8 +258,9 @@ 
 	public static function generateRecipientOption($type, $value, $name = '')
 	{
 		switch ($type) {
-			case 'users' : if (empty($name))
-					$name = \includes\fields\Owner::getUserLabel($value);
+			case 'users' : if (empty($name)) {
+								$name = \includes\fields\Owner::getUserLabel($value);
+			}
 				$optionName = 'User::' . addslashes(decode_html($name));
 				$optionValue = 'users::' . $value;
 				break;
@@ -269,13 +270,15 @@ 
 				$optionName = 'Group::' . addslashes(decode_html($name));
 				$optionValue = 'groups::' . $value;
 				break;
-			case 'roles' : if (empty($name))
-					$name = \App\PrivilegeUtil::getRoleName($value);
+			case 'roles' : if (empty($name)) {
+								$name = \App\PrivilegeUtil::getRoleName($value);
+			}
 				$optionName = 'Roles::' . addslashes(decode_html($name));
 				$optionValue = 'roles::' . $value;
 				break;
-			case 'rs' : if (empty($name))
-					$name = \App\PrivilegeUtil::getRoleName($value);
+			case 'rs' : if (empty($name)) {
+								$name = \App\PrivilegeUtil::getRoleName($value);
+			}
 				$optionName = 'RoleAndSubordinates::' . addslashes(decode_html($name));
 				$optionValue = 'rs::' . $value;
 				break;
@@ -375,10 +378,12 @@ 
 
 		$currentModule = vglobal('currentModule');
 		$current_language = vglobal('current_language');
-		if (empty($currentModule))
-			$currentModule = 'Reports';
-		if (empty($current_language))
-			vglobal('current_language', 'en_us');
+		if (empty($currentModule)) {
+					$currentModule = 'Reports';
+		}
+		if (empty($current_language)) {
+					vglobal('current_language', 'en_us');
+		}
 
 		$scheduledReports = self::getScheduledReports($adb, $adminUser);
 		foreach ($scheduledReports as $scheduledReport) {