YetiForceCompany / YetiForceCRM

vtlib/Vtiger/Utils/StringTemplate.php

Doc Comments +1 added lines

@@ -112,6 +112,7 @@
 	/**
 	 * Clean up the input to be used as a regex
 	 * @access private
+	 * @param string $value
 	 */
 	public function __formatAsRegex($value)
 	{

Braces +6 added lines, -4 removed lines

@@ -70,8 +70,9 @@ 
 		unset($this->tplvars);
 
 		$this->tplvars = [];
-		foreach ($restorevars as $key => $val)
-			$this->assign($key, $val);
+		foreach ($restorevars as $key => $val) {
+					$this->assign($key, $val);
+		}
 	}
 
 	/**
@@ -82,8 +83,9 @@ 
 	 */
 	public function merge($instring, $avoidLookup = false)
 	{
-		if (empty($instring))
-			return $instring;
+		if (empty($instring)) {
+					return $instring;
+		}
 
 		if (!$avoidLookup) {
 

vtlib/Vtiger/Webservice.php

Doc Comments +3 added lines

@@ -20,6 +20,7 @@ 
 	 * Helper function to log messages
 	 * @param String Message to log
 	 * @param Boolean true appends linebreak, false to avoid it
+	 * @param string $message
 	 * @access private
 	 */
 	static function log($message, $delim = true)
@@ -30,6 +31,7 @@ 
 	/**
 	 * Initialize webservice for the given module
 	 * @param Module Instance of the module.
+	 * @param Module $moduleInstance
 	 */
 	static function initialize($moduleInstance)
 	{
@@ -45,6 +47,7 @@ 
 	/**
 	 * Initialize webservice for the given module
 	 * @param Module Instance of the module.
+	 * @param Module $moduleInstance
 	 */
 	static function uninitialize($moduleInstance)
 	{

vtlib/Vtiger/Zip.php

Doc Comments +2 added lines

@@ -69,6 +69,7 @@ 
 
 	/**
 	 * Normalize the directory path separators.
+	 * @param string $path
 	 */
 	public function __normalizePath($path)
 	{
@@ -79,6 +80,7 @@ 
 
 	/**
 	 * Copy the directory on the disk into zip file.
+	 * @param string $zipdirname
 	 */
 	public function copyDirectoryFromDisk($dirname, $zipdirname = null, $excludeList = null, $basedirname = null)
 	{

Braces +18 added lines, -12 removed lines

@@ -50,8 +50,9 @@ 
 		if ($search_index === 0) {
 			$startindex = strlen($base_realpath) + 1;
 			// On windows $base_realpath ends with / and On Linux it will not have / at end!
-			if (strrpos($base_realpath, '/') == strlen($base_realpath) - 1)
-				$startindex -= 1;
+			if (strrpos($base_realpath, '/') == strlen($base_realpath) - 1) {
+							$startindex -= 1;
+			}
 			$relpath = substr($src_realpath, $startindex);
 		}
 		return $relpath;
@@ -62,8 +63,9 @@ 
 	 */
 	public function __fixDirSeparator($path)
 	{
-		if ($path != '' && (strripos($path, '/') != strlen($path) - 1))
-			$path .= '/';
+		if ($path != '' && (strripos($path, '/') != strlen($path) - 1)) {
+					$path .= '/';
+		}
 		return $path;
 	}
 
@@ -72,8 +74,9 @@ 
 	 */
 	public function __normalizePath($path)
 	{
-		if ($path && strpos($path, '\\') !== false)
-			$path = preg_replace("/\\\\/", "/", $path);
+		if ($path && strpos($path, '\\') !== false) {
+					$path = preg_replace("/\\\\/", "/", $path);
+		}
 		return $path;
 	}
 
@@ -83,18 +86,21 @@ 
 	public function copyDirectoryFromDisk($dirname, $zipdirname = null, $excludeList = null, $basedirname = null)
 	{
 		$dir = opendir($dirname);
-		if (strripos($dirname, '/') != strlen($dirname) - 1)
-			$dirname .= '/';
+		if (strripos($dirname, '/') != strlen($dirname) - 1) {
+					$dirname .= '/';
+		}
 
-		if ($basedirname === null)
-			$basedirname = realpath($dirname);
+		if ($basedirname === null) {
+					$basedirname = realpath($dirname);
+		}
 
 		while (false !== ($file = readdir($dir))) {
 			if ($file != '.' && $file != '..' &&
 				$file != '.svn' && $file != 'CVS') {
 				// Exclude the file/directory 
-				if (!empty($excludeList) && in_array("$dirname$file", $excludeList))
-					continue;
+				if (!empty($excludeList) && in_array("$dirname$file", $excludeList)) {
+									continue;
+				}
 
 				if (is_dir("$dirname$file")) {
 					$this->copyDirectoryFromDisk("$dirname$file", $zipdirname, $excludeList, $basedirname);

api.php

Braces +7 added lines, -14 removed lines

@@ -19,33 +19,26 @@
 	if($service == "customerportal")
 	{
 		include("api/customerportal.php");
-	}	
-	elseif($service == "mobile")	
+	} elseif($service == "mobile")	
 	{		
 		include("api/mobile.php");
-	}
-	elseif($service == "yetiportal")	
+	} elseif($service == "yetiportal")	
 	{		
 		include("api/yetiportal.php");
-	}
-	elseif($service == "firefox")
+	} elseif($service == "firefox")
 	{
 		include("api/firefoxtoolbar.php");
-	}
-	elseif($service == "wordplugin")
+	} elseif($service == "wordplugin")
 	{
 		include("api/wordplugin.php");
-	}
-	elseif($service == "thunderbird")
+	} elseif($service == "thunderbird")
 	{
 		include("api/thunderbirdplugin.php");
-	}
-	else
+	} else
 	{
 		echo "No Service Configured for ". strip_tags($service);
 	}
-}
-else
+} else
 {
 	echo "<h1>YetiForceCRM API Services</h1>";
 	echo "<li>YetiForceCRM Yeti Portal EndPoint URL -- Click <a href='api.php?service=yetiportal'>here</a></li>";

Spacing +10 added lines, -10 removed lines

@@ -11,39 +11,39 @@
 require_once 'config/api.php';
 $service = $_REQUEST['service'];
 
-if(isset($service))
+if (isset($service))
 {
-	if(!in_array($service,$enabledServices)){
-		echo $service.' - Service is not active';
+	if (!in_array($service, $enabledServices)) {
+		echo $service . ' - Service is not active';
 		return;
 	}	
-	if($service == "customerportal")
+	if ($service == "customerportal")
 	{
 		include("api/customerportal.php");
 	}	
-	elseif($service == "mobile")	
+	elseif ($service == "mobile")	
 	{		
 		include("api/mobile.php");
 	}
-	elseif($service == "yetiportal")	
+	elseif ($service == "yetiportal")	
 	{		
 		include("api/yetiportal.php");
 	}
-	elseif($service == "firefox")
+	elseif ($service == "firefox")
 	{
 		include("api/firefoxtoolbar.php");
 	}
-	elseif($service == "wordplugin")
+	elseif ($service == "wordplugin")
 	{
 		include("api/wordplugin.php");
 	}
-	elseif($service == "thunderbird")
+	elseif ($service == "thunderbird")
 	{
 		include("api/thunderbirdplugin.php");
 	}
 	else
 	{
-		echo "No Service Configured for ". strip_tags($service);
+		echo "No Service Configured for " . strip_tags($service);
 	}
 }
 else

include/recaptcha/recaptchalib.php

Indentation -1 removed lines

@@ -98,7 +98,6 @@
  * @param string $pubkey A public key for reCAPTCHA
  * @param string $error The error given by reCAPTCHA (optional, default is null)
  * @param boolean $use_ssl Should the request be made over ssl? (optional, default is false)
-
  * @return string - The HTML to be embedded in the user's form.
  */
 function recaptcha_get_html($pubkey, $error = null, $use_ssl = false)

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
 	$http_request .= $req;
 
 	$response = '';
-	if (false == ( $fs = @fsockopen($host, $port, $errno, $errstr, 10) )) {
+	if (false == ($fs = @fsockopen($host, $port, $errno, $errstr, 10))) {
 		die('Could not open socket');
 	}
 

Braces +7 added lines, -4 removed lines

@@ -47,8 +47,9 @@ 
 function _recaptcha_qsencode($data)
 {
 	$req = "";
-	foreach ($data as $key => $value)
-		$req .= $key . '=' . urlencode(stripslashes($value)) . '&';
+	foreach ($data as $key => $value) {
+			$req .= $key . '=' . urlencode(stripslashes($value)) . '&';
+	}
 
 	// Cut the last '&'
 	$req = substr($req, 0, strlen($req) - 1);
@@ -83,8 +84,10 @@ 
 
 	fwrite($fs, $http_request);
 
-	while (!feof($fs))
-		$response .= fgets($fs, 1160); // One TCP-IP packet
+	while (!feof($fs)) {
+			$response .= fgets($fs, 1160);
+	}
+	// One TCP-IP packet
 	fclose($fs);
 	$response = explode("\r\n\r\n", $response, 2);
 

Doc Comments +6 added lines

@@ -206,6 +206,9 @@ 
 }
 /* Mailhide related code */
 
+/**
+ * @param string $ky
+ */
 function _recaptcha_aes_encrypt($val, $ky)
 {
 	if (!function_exists("mcrypt_encrypt")) {
@@ -217,6 +220,9 @@ 
 	return mcrypt_encrypt($enc, $ky, $val, $mode, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0");
 }
 
+/**
+ * @param string $x
+ */
 function _recaptcha_mailhide_urlbase64($x)
 {
 	return strtr(base64_encode($x), '+/', '-_');

include/utils/EmailTemplate.php

Spacing +2 added lines, -2 removed lines

@@ -120,7 +120,7 @@ 
 				$moduleTableIndexList = $meta->getEntityTableIndexList();
 				foreach ($tableList as $index => $tableName) {
 					if ($tableName != $tableList[0]) {
-						$sql .=' INNER JOIN ' . $tableName . ' ON ' . $tableList[0] . '.' .
+						$sql .= ' INNER JOIN ' . $tableName . ' ON ' . $tableList[0] . '.' .
 							$moduleTableIndexList[$tableList[0]] . '=' . $tableName . '.' .
 							$moduleTableIndexList[$tableName];
 					}
@@ -128,7 +128,7 @@ 
 				//If module is Leads and if you are not selected any leads fields then query failure is happening.
 				//By default we are checking where condition on base table.
 				if ($module == 'Leads' && !in_array('vtiger_leaddetails', $tableList)) {
-					$sql .=' INNER JOIN vtiger_leaddetails ON vtiger_leaddetails.leadid = vtiger_crmentity.crmid';
+					$sql .= ' INNER JOIN vtiger_leaddetails ON vtiger_leaddetails.leadid = vtiger_crmentity.crmid';
 				}
 
 				$sql .= ' WHERE';

Braces +6 added lines, -4 removed lines

@@ -209,8 +209,9 @@ 
 						$needle = '$' . strtolower($this->module) . '-' . $parentFieldColumnMapping[$params['field']] . ':' . $column . '$';
 						$this->processedDescription = str_replace($needle, $values[array_search($column, $fieldColumnMapping)], $this->processedDescription);
 					}
-					if (!$params['owner'])
-						$this->processedmodules[$module] = true;
+					if (!$params['owner']) {
+											$this->processedmodules[$module] = true;
+					}
 				}
 			}
 		}
@@ -253,7 +254,8 @@ 
 		$rows = $adb->num_rows($res);
 		if ($rows > 0) {
 			return true;
-		} else
-			return false;
+		} else {
+					return false;
+		}
 	}
 }

include/utils/ConfigReader.php

Braces +6 added lines, -4 removed lines

@@ -37,8 +37,9 @@ 
 
 	public function setConfig($key, $value)
 	{
-		if (empty($key))
-			return;
+		if (empty($key)) {
+					return;
+		}
 		$this->properties[$key] = $value;
 		//not neccessary for php5.x versions
 		self::$propertiesCache[$this->name] = $this->properties;
@@ -46,8 +47,9 @@ 
 
 	public function getConfig($key)
 	{
-		if (empty($key))
-			return '';
+		if (empty($key)) {
+					return '';
+		}
 		return $this->properties[$key];
 	}
 }

Doc Comments +7 added lines

@@ -15,6 +15,10 @@ 
 	protected $name;
 	static $propertiesCache = [];
 
+	/**
+	 * @param string $path
+	 * @param string $name
+	 */
 	public function __construct($path, $name, $force = false)
 	{
 		$this->load($path, $name, $force);
@@ -41,6 +45,9 @@ 
 		self::$propertiesCache[$this->name] = $this->properties;
 	}
 
+	/**
+	 * @param string $key
+	 */
 	public function getConfig($key)
 	{
 		if (empty($key))

include/utils/ExportUtils.php

Braces +3 added lines, -2 removed lines

@@ -28,8 +28,9 @@
 	$blockid_list = '(';
 	for ($i = 0; $i < $noofrows; $i++) {
 		$blockid = $adb->query_result($result, $i, "blockid");
-		if ($i != 0)
-			$blockid_list .= ', ';
+		if ($i != 0) {
+					$blockid_list .= ', ';
+		}
 		$blockid_list .= $blockid;
 		$block_label[$blockid] = $adb->query_result($result, $i, "blocklabel");
 	}

include/utils/InventoryUtils.php

Spacing +8 added lines, -8 removed lines

@@ -313,7 +313,7 @@ 
 	$moduleName = $entity->getModuleName();
 
 	$statusChanged = false;
-	$vtEntityDelta = new VTEntityDelta ();
+	$vtEntityDelta = new VTEntityDelta();
 	$oldEntity = $vtEntityDelta->getOldValue($moduleName, $entity_id, $statusFieldName);
 	$recordDetails = $entity->getData();
 	$statusChanged = $vtEntityDelta->hasChanged($moduleName, $entity_id, $statusFieldName);
@@ -941,19 +941,19 @@ 
 		for ($i = 0; $i < $noOfRows; ++$i) {
 			$status = $adb->query_result($result, $i, 'temp_status');
 			if ($obj->getImportRecordStatus('none') == $status) {
-				$statusCount['PENDING'] ++;
+				$statusCount['PENDING']++;
 			} elseif ($obj->getImportRecordStatus('failed') == $status) {
-				$statusCount['FAILED'] ++;
+				$statusCount['FAILED']++;
 			} else {
-				$statusCount['IMPORTED'] ++;
+				$statusCount['IMPORTED']++;
 				switch ($status) {
-					case $obj->getImportRecordStatus('created') : $statusCount['CREATED'] ++;
+					case $obj->getImportRecordStatus('created') : $statusCount['CREATED']++;
 						break;
-					case $obj->getImportRecordStatus('skipped') : $statusCount['SKIPPED'] ++;
+					case $obj->getImportRecordStatus('skipped') : $statusCount['SKIPPED']++;
 						break;
-					case $obj->getImportRecordStatus('updated') : $statusCount['UPDATED'] ++;
+					case $obj->getImportRecordStatus('updated') : $statusCount['UPDATED']++;
 						break;
-					case $obj->getImportRecordStatus('merged') : $statusCount['MERGED'] ++;
+					case $obj->getImportRecordStatus('merged') : $statusCount['MERGED']++;
 						break;
 				}
 			}

Doc Comments +1 added lines, -3 removed lines

@@ -17,6 +17,7 @@ 
  * Param $ext_prod_arr - existing vtiger_products
  * Param $module - module name
  * return type void
+ * @param string $mode
  */
 function updateStk($product_id, $qty, $mode, $ext_prod_arr, $module)
 {
@@ -250,9 +251,6 @@ 
 }
 
 /** 	Function used to delete the Inventory product details for the passed entity
- * 	@param int $objectid - entity id to which we want to delete the product details from REQUEST values where as the entity will be Purchase Order or Invoice
- * 	@param string $return_old_values - string which contains the string return_old_values or may be empty, if the string is return_old_values then before delete old values will be retrieved
- * 	@return array $ext_prod_arr - if the second input parameter is 'return_old_values' then the array which contains the productid and quantity which will be retrieved before delete the product details will be returned otherwise return empty
  */
 function deleteInventoryProductDetails($focus)
 {

Braces +21 added lines, -15 removed lines

@@ -128,16 +128,18 @@ 
 	$taxpercentage = $adb->query_result($res, 0, 'taxpercentage');
 
 	//This is to retrive the default configured value if the taxpercentage related to product is empty
-	if ($taxpercentage == '' && $default == 'default')
-		$taxpercentage = getTaxPercentage($type);
+	if ($taxpercentage == '' && $default == 'default') {
+			$taxpercentage = getTaxPercentage($type);
+	}
 
 
 	\App\log::trace("Exiting from getProductTaxPercentage($productid,$type) function. return value=$taxpercentage");
-	if ($current_user->truncate_trailing_zeros === true)
-		return \vtlib\Functions::formatDecimal($taxpercentage);
-	else
-		return $taxpercentage;
-}
+	if ($current_user->truncate_trailing_zeros === true) {
+			return \vtlib\Functions::formatDecimal($taxpercentage);
+	} else {
+			return $taxpercentage;
+	}
+	}
 
 /** 	Function used to get the list of Tax types as a array
  * 	@param string $available - available or empty where as default is all, if available then the taxes which are available now will be returned otherwise all taxes will be returned
@@ -369,8 +371,9 @@ 
 
 	$inv_table_array = [];
 	$inv_id_array = [];
-	if (!array_key_exists($module, $inv_table_array))
-		return '';
+	if (!array_key_exists($module, $inv_table_array)) {
+			return '';
+	}
 
 	$res = $adb->pquery("select taxtype from $inv_table_array[$module] where $inv_id_array[$module]=?", array($id));
 
@@ -425,8 +428,9 @@ 
 	$res = $adb->pquery("select $taxname from vtiger_inventoryproductrel where id = ? and productid = ?", array($id, $productid));
 	$taxvalue = $adb->query_result($res, 0, $taxname);
 
-	if ($taxvalue == '')
-		$taxvalue = '0';
+	if ($taxvalue == '') {
+			$taxvalue = '0';
+	}
 
 	\App\log::trace("Exit from function getInventoryProductTaxValue($id, $productid, $taxname).");
 
@@ -770,8 +774,9 @@ 
 		$subject = $row['subject'];
 		$sql = 'SELECT * FROM %s WHERE temp_status = %s';
 		$sql = sprintf($sql, $tableName, Import_Data_Action::$IMPORT_RECORD_NONE);
-		if (!empty($subject))
-			$sql .= ' && subject = "' . str_replace("\"", "\\\"", $subject) . '"';
+		if (!empty($subject)) {
+					$sql .= ' && subject = "' . str_replace("\"", "\\\"", $subject) . '"';
+		}
 		$subjectResult = $adb->query($sql);
 		$count = $adb->num_rows($subjectResult);
 		$subjectRowIDs = [];
@@ -888,8 +893,9 @@ 
 			foreach ($fieldMapping as $fieldName => $index) {
 				if ($moduleFields[$fieldName]->getTableName() == 'vtiger_inventoryproductrel') {
 					$lineItemData[$fieldName] = $lineItemFieldData[$fieldName];
-					if ($fieldName != 'productid')
-						$inventoryFieldData[$fieldName] = '';
+					if ($fieldName != 'productid') {
+											$inventoryFieldData[$fieldName] = '';
+					}
 				}
 			}
 			array_push($lineItems, $lineItemData);