YetiForceCompany / YetiForceCRM

modules/Settings/ConfReport/models/Module.php

Doc Comments +6 added lines

@@ -318,6 +318,9 @@ 
 		return $permissions;
 	}
 
+	/**
+	 * @param string $val
+	 */
 	public static function getFlag($val)
 	{
 		if ($val == 'On' || $val == 1 || stripos($val, 'On') !== false) {
@@ -326,6 +329,9 @@ 
 		return 'Off';
 	}
 
+	/**
+	 * @param string $value
+	 */
 	public function error2string($value)
 	{
 		$level_names = array(

Spacing +1 added lines, -1 removed lines

@@ -340,7 +340,7 @@
 		$levels = array();
 		if (($value & E_ALL) == E_ALL) {
 			$levels[] = 'E_ALL';
-			$value&=~E_ALL;
+			$value &= ~E_ALL;
 		}
 		foreach ($level_names as $level => $name)
 			if (($value & $level) == $level)

Braces +87 added lines, -58 removed lines

@@ -119,113 +119,139 @@ 
 			$directiveValues['suhosin.post.max_value_length'] = array('prefer' => '1500000');
 		}
 
-		if (ini_get('safe_mode') == '1' || stripos(ini_get('safe_mode'), 'On') !== false)
-			$directiveValues['safe_mode']['status'] = true;
+		if (ini_get('safe_mode') == '1' || stripos(ini_get('safe_mode'), 'On') !== false) {
+					$directiveValues['safe_mode']['status'] = true;
+		}
 		$directiveValues['safe_mode']['current'] = self::getFlag(ini_get('safe_mode'));
 
-		if (ini_get('display_errors') == '1' || stripos(ini_get('display_errors'), 'On') !== false)
-			$directiveValues['display_errors']['status'] = true;
+		if (ini_get('display_errors') == '1' || stripos(ini_get('display_errors'), 'On') !== false) {
+					$directiveValues['display_errors']['status'] = true;
+		}
 		$directiveValues['display_errors']['current'] = self::getFlag(ini_get('display_errors'));
 
-		if (ini_get('file_uploads') != '1' || stripos(ini_get('file_uploads'), 'Off') !== false)
-			$directiveValues['file_uploads']['status'] = true;
+		if (ini_get('file_uploads') != '1' || stripos(ini_get('file_uploads'), 'Off') !== false) {
+					$directiveValues['file_uploads']['status'] = true;
+		}
 		$directiveValues['file_uploads']['current'] = self::getFlag(ini_get('file_uploads'));
 
-		if ((ini_get('output_buffering') <= '4096' && ini_get('output_buffering') != '1') || stripos(ini_get('output_buffering'), 'Off') !== false)
-			$directiveValues['output_buffering']['status'] = true;
+		if ((ini_get('output_buffering') <= '4096' && ini_get('output_buffering') != '1') || stripos(ini_get('output_buffering'), 'Off') !== false) {
+					$directiveValues['output_buffering']['status'] = true;
+		}
 		if (!in_array(ini_get('output_buffering'), ['On', 1, 0, 'Off'])) {
 			$directiveValues['output_buffering']['current'] = ini_get('output_buffering');
 		} else {
 			$directiveValues['output_buffering']['current'] = self::getFlag(ini_get('output_buffering'));
 		}
 
-		if (ini_get('max_execution_time') != 0 && ini_get('max_execution_time') < 600)
-			$directiveValues['max_execution_time']['status'] = true;
+		if (ini_get('max_execution_time') != 0 && ini_get('max_execution_time') < 600) {
+					$directiveValues['max_execution_time']['status'] = true;
+		}
 		$directiveValues['max_execution_time']['current'] = ini_get('max_execution_time');
 
-		if (ini_get('max_input_time') != 0 && ini_get('max_input_time') < 600)
-			$directiveValues['max_input_time']['status'] = true;
+		if (ini_get('max_input_time') != 0 && ini_get('max_input_time') < 600) {
+					$directiveValues['max_input_time']['status'] = true;
+		}
 		$directiveValues['max_input_time']['current'] = ini_get('max_input_time');
 
-		if (ini_get('default_socket_timeout') != 0 && ini_get('default_socket_timeout') < 600)
-			$directiveValues['default_socket_timeout']['status'] = true;
+		if (ini_get('default_socket_timeout') != 0 && ini_get('default_socket_timeout') < 600) {
+					$directiveValues['default_socket_timeout']['status'] = true;
+		}
 		$directiveValues['default_socket_timeout']['current'] = ini_get('default_socket_timeout');
 
-		if (ini_get('mysql.connect_timeout') != 0 && ini_get('mysql.connect_timeout') < 600)
-			$directiveValues['mysql.connect_timeout']['status'] = true;
+		if (ini_get('mysql.connect_timeout') != 0 && ini_get('mysql.connect_timeout') < 600) {
+					$directiveValues['mysql.connect_timeout']['status'] = true;
+		}
 		$directiveValues['mysql.connect_timeout']['current'] = ini_get('mysql.connect_timeout');
 
-		if (vtlib\Functions::parseBytes(ini_get('memory_limit')) < 33554432)
-			$directiveValues['memory_limit']['status'] = true;
+		if (vtlib\Functions::parseBytes(ini_get('memory_limit')) < 33554432) {
+					$directiveValues['memory_limit']['status'] = true;
+		}
 		$directiveValues['memory_limit']['current'] = vtlib\Functions::showBytes(ini_get('memory_limit'));
 
-		if (vtlib\Functions::parseBytes(ini_get('post_max_size')) < 10485760)
-			$directiveValues['post_max_size']['status'] = true;
+		if (vtlib\Functions::parseBytes(ini_get('post_max_size')) < 10485760) {
+					$directiveValues['post_max_size']['status'] = true;
+		}
 		$directiveValues['post_max_size']['current'] = vtlib\Functions::showBytes(ini_get('post_max_size'));
 
-		if (vtlib\Functions::parseBytes(ini_get('upload_max_filesize')) < 10485760)
-			$directiveValues['upload_max_filesize']['status'] = true;
+		if (vtlib\Functions::parseBytes(ini_get('upload_max_filesize')) < 10485760) {
+					$directiveValues['upload_max_filesize']['status'] = true;
+		}
 		$directiveValues['upload_max_filesize']['current'] = vtlib\Functions::showBytes(ini_get('upload_max_filesize'));
 
-		if (ini_get('magic_quotes_gpc') == '1' || stripos(ini_get('magic_quotes_gpc'), 'On') !== false)
-			$directiveValues['magic_quotes_gpc']['status'] = true;
+		if (ini_get('magic_quotes_gpc') == '1' || stripos(ini_get('magic_quotes_gpc'), 'On') !== false) {
+					$directiveValues['magic_quotes_gpc']['status'] = true;
+		}
 		$directiveValues['magic_quotes_gpc']['current'] = self::getFlag(ini_get('magic_quotes_gpc'));
 
-		if (ini_get('magic_quotes_runtime') == '1' || stripos(ini_get('magic_quotes_runtime'), 'On') !== false)
-			$directiveValues['magic_quotes_runtime']['status'] = true;
+		if (ini_get('magic_quotes_runtime') == '1' || stripos(ini_get('magic_quotes_runtime'), 'On') !== false) {
+					$directiveValues['magic_quotes_runtime']['status'] = true;
+		}
 		$directiveValues['magic_quotes_runtime']['current'] = self::getFlag((ini_get('magic_quotes_runtime')));
 
-		if (ini_get('zlib.output_compression') == '1' || stripos(ini_get('zlib.output_compression'), 'On') !== false)
-			$directiveValues['zlib.output_compression']['status'] = true;
+		if (ini_get('zlib.output_compression') == '1' || stripos(ini_get('zlib.output_compression'), 'On') !== false) {
+					$directiveValues['zlib.output_compression']['status'] = true;
+		}
 		$directiveValues['zlib.output_compression']['current'] = self::getFlag((ini_get('zlib.output_compression')));
 
-		if (ini_get('zend.ze1_compatibility_mode') == '1' || stripos(ini_get('zend.ze1_compatibility_mode'), 'On') !== false)
-			$directiveValues['zend.ze1_compatibility_mode']['status'] = true;
+		if (ini_get('zend.ze1_compatibility_mode') == '1' || stripos(ini_get('zend.ze1_compatibility_mode'), 'On') !== false) {
+					$directiveValues['zend.ze1_compatibility_mode']['status'] = true;
+		}
 		$directiveValues['zend.ze1_compatibility_mode']['current'] = self::getFlag(ini_get('zend.ze1_compatibility_mode'));
 
 		if (extension_loaded('suhosin')) {
-			if (ini_get('suhosin.session.encrypt') == '1' || stripos(ini_get('suhosin.session.encrypt'), 'On') !== false)
-				$directiveValues['suhosin.session.encrypt']['status'] = true;
+			if (ini_get('suhosin.session.encrypt') == '1' || stripos(ini_get('suhosin.session.encrypt'), 'On') !== false) {
+							$directiveValues['suhosin.session.encrypt']['status'] = true;
+			}
 			$directiveValues['suhosin.session.encrypt']['current'] = self::getFlag(ini_get('suhosin.session.encrypt'));
 		}
-		if (ini_get('session.auto_start') == '1' || stripos(ini_get('session.auto_start'), 'On') !== false)
-			$directiveValues['session.auto_start']['status'] = true;
+		if (ini_get('session.auto_start') == '1' || stripos(ini_get('session.auto_start'), 'On') !== false) {
+					$directiveValues['session.auto_start']['status'] = true;
+		}
 		$directiveValues['session.auto_start']['current'] = self::getFlag(ini_get('session.auto_start'));
 
-		if (ini_get('mbstring.func_overload') == '1' || stripos(ini_get('mbstring.func_overload'), 'On') !== false)
-			$directiveValues['mbstring.func_overload']['status'] = true;
+		if (ini_get('mbstring.func_overload') == '1' || stripos(ini_get('mbstring.func_overload'), 'On') !== false) {
+					$directiveValues['mbstring.func_overload']['status'] = true;
+		}
 		$directiveValues['mbstring.func_overload']['current'] = self::getFlag(ini_get('mbstring.func_overload'));
 
-		if (ini_get('magic_quotes_sybase') == '1' || stripos(ini_get('magic_quotes_sybase'), 'On') !== false)
-			$directiveValues['magic_quotes_sybase']['status'] = true;
+		if (ini_get('magic_quotes_sybase') == '1' || stripos(ini_get('magic_quotes_sybase'), 'On') !== false) {
+					$directiveValues['magic_quotes_sybase']['status'] = true;
+		}
 		$directiveValues['magic_quotes_sybase']['current'] = self::getFlag(ini_get('magic_quotes_sybase'));
 
-		if (ini_get('log_errors') == '1' || stripos(ini_get('log_errors'), 'On') !== false)
-			$directiveValues['log_errors']['status'] = true;
+		if (ini_get('log_errors') == '1' || stripos(ini_get('log_errors'), 'On') !== false) {
+					$directiveValues['log_errors']['status'] = true;
+		}
 		$directiveValues['log_errors']['current'] = self::getFlag(ini_get('log_errors'));
 
-		if (ini_get('short_open_tag') != '1' || stripos(ini_get('short_open_tag'), 'Off') !== false)
-			$directiveValues['short_open_tag']['status'] = true;
+		if (ini_get('short_open_tag') != '1' || stripos(ini_get('short_open_tag'), 'Off') !== false) {
+					$directiveValues['short_open_tag']['status'] = true;
+		}
 		$directiveValues['short_open_tag']['current'] = self::getFlag(ini_get('short_open_tag'));
 
-		if (ini_get('session.gc_maxlifetime') < 21600)
-			$directiveValues['session.gc_maxlifetime']['status'] = true;
+		if (ini_get('session.gc_maxlifetime') < 21600) {
+					$directiveValues['session.gc_maxlifetime']['status'] = true;
+		}
 		$directiveValues['session.gc_maxlifetime']['current'] = ini_get('session.gc_maxlifetime');
 
-		if (ini_get('session.gc_divisor') < 500)
-			$directiveValues['session.gc_divisor']['status'] = true;
+		if (ini_get('session.gc_divisor') < 500) {
+					$directiveValues['session.gc_divisor']['status'] = true;
+		}
 		$directiveValues['session.gc_divisor']['current'] = ini_get('session.gc_divisor');
 
-		if (ini_get('session.gc_probability') < 1)
-			$directiveValues['session.gc_probability']['status'] = true;
+		if (ini_get('session.gc_probability') < 1) {
+					$directiveValues['session.gc_probability']['status'] = true;
+		}
 		$directiveValues['session.gc_probability']['current'] = ini_get('session.gc_probability');
 
-		if (ini_get('max_input_vars') < 5000)
-			$directiveValues['max_input_vars']['status'] = true;
+		if (ini_get('max_input_vars') < 5000) {
+					$directiveValues['max_input_vars']['status'] = true;
+		}
 		$directiveValues['max_input_vars']['current'] = ini_get('max_input_vars');
 
-		if (version_compare(PHP_VERSION, '5.4.0', '<'))
-			$directiveValues['PHP']['status'] = true;
+		if (version_compare(PHP_VERSION, '5.4.0', '<')) {
+					$directiveValues['PHP']['status'] = true;
+		}
 		$directiveValues['PHP']['current'] = PHP_VERSION;
 
 		if (extension_loaded('suhosin')) {
@@ -280,8 +306,9 @@ 
 		}
 
 		$errorReporting = stripos(ini_get('error_reporting'), '_') === false ? self::error2string(ini_get('error_reporting')) : ini_get('error_reporting');
-		if (in_array('E_NOTICE', $errorReporting) || in_array('E_DEPRECATED', $errorReporting) || in_array('E_STRICT', $errorReporting))
-			$directiveValues['error_reporting']['status'] = true;
+		if (in_array('E_NOTICE', $errorReporting) || in_array('E_DEPRECATED', $errorReporting) || in_array('E_STRICT', $errorReporting)) {
+					$directiveValues['error_reporting']['status'] = true;
+		}
 		$directiveValues['error_reporting']['current'] = implode(' | ', $errorReporting);
 
 		return $directiveValues;
@@ -335,16 +362,18 @@ 
 			E_COMPILE_ERROR => 'E_COMPILE_ERROR', E_COMPILE_WARNING => 'E_COMPILE_WARNING',
 			E_USER_ERROR => 'E_USER_ERROR', E_USER_WARNING => 'E_USER_WARNING',
 			E_USER_NOTICE => 'E_USER_NOTICE');
-		if (defined('E_STRICT'))
-			$level_names[E_STRICT] = 'E_STRICT';
+		if (defined('E_STRICT')) {
+					$level_names[E_STRICT] = 'E_STRICT';
+		}
 		$levels = array();
 		if (($value & E_ALL) == E_ALL) {
 			$levels[] = 'E_ALL';
 			$value&=~E_ALL;
 		}
-		foreach ($level_names as $level => $name)
-			if (($value & $level) == $level)
+		foreach ($level_names as $level => $name) {
+					if (($value & $level) == $level)
 				$levels[] = $name;
+		}
 		return $levels;
 	}
 }

modules/Users/CreateUserPrivilegeFile.php

Doc Comments +6 added lines, -6 removed lines

@@ -938,8 +938,8 @@ 
 
 /** Gives an array which contains the information for what all roles, groups and user's related module data that is to be shared  for the specified parent module and shared module 
 
- * @param $par_mod -- parent module name:: Type varchar
- * @param $share_mod -- shared module name:: Type varchar
+ * @param string $par_mod -- parent module name:: Type varchar
+ * @param string $share_mod -- shared module name:: Type varchar
  * @param $userid -- user id:: Type integer
  * @param $def_org_share -- default organization sharing permission array:: Type array
  * @param $mod_sharingrule_members -- Sharing Rule Members array:: Type array
@@ -1355,9 +1355,9 @@ 
 
 /** Function to populate the read/wirte Sharing permissions data for the specified user into the database 
  * @param $userid -- user id:: Type integer
- * @param $enttype -- can have the value of User or Group:: Type varchar
+ * @param string $enttype -- can have the value of User or Group:: Type varchar
  * @param $module -- module name:: Type varchar
- * @param $pertype -- can have the value of read or write:: Type varchar
+ * @param string $pertype -- can have the value of read or write:: Type varchar
  * @param $var_name_arr - Variable to use instead of including the sharing access again
  */
 function populateSharingPrivileges($enttype, $userid, $module, $pertype, $var_name_arr = false)
@@ -1432,10 +1432,10 @@ 
 
 /** Function to populate the read/wirte Sharing permissions related module data for the specified user into the database 
  * @param $userid -- user id:: Type integer
- * @param $enttype -- can have the value of User or Group:: Type varchar
+ * @param string $enttype -- can have the value of User or Group:: Type varchar
  * @param $module -- module name:: Type varchar
  * @param $relmodule -- related module name:: Type varchar
- * @param $pertype -- can have the value of read or write:: Type varchar
+ * @param string $pertype -- can have the value of read or write:: Type varchar
  * @param $var_name_arr - Variable to use instead of including the sharing access again
  */
 function populateRelatedSharingPrivileges($enttype, $userid, $module, $relmodule, $pertype, $var_name_arr = false)

Indentation -12 removed lines

@@ -154,7 +154,6 @@ 
 }
 
 /** Gives an array which contains the information for what all roles, groups and user data is to be shared with the spcified user for the specified module 
-
  * @param $module -- module name:: Type varchar
  * @param $userid -- user id:: Type integer
  * @param $def_org_share -- default organization sharing permission array:: Type array
@@ -937,7 +936,6 @@ 
 }
 
 /** Gives an array which contains the information for what all roles, groups and user's related module data that is to be shared  for the specified parent module and shared module 
-
  * @param $par_mod -- parent module name:: Type varchar
  * @param $share_mod -- shared module name:: Type varchar
  * @param $userid -- user id:: Type integer
@@ -1097,7 +1095,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1114,7 +1111,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1139,7 +1135,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1164,7 +1159,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1191,7 +1185,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1208,7 +1201,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1225,7 +1217,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1246,7 +1237,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1267,7 +1257,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */
@@ -1288,7 +1277,6 @@ 
 }
 
 /** Converts the input array  to a single string to facilitate the writing of the input array in a flat file 
-
  * @param $var -- input array:: Type array
  * @returns $code -- contains the whole array in a single string:: Type array 
  */

Spacing +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@ 
 
 	if ($handle) {
 		$newbuf = '';
-		$newbuf .="<?php\n";
+		$newbuf .= "<?php\n";
 		$user_focus = CRMEntity::getInstance('Users');
 		$user_focus->retrieve_entity_info($userid, 'Users');
 		$userInfo = [];
@@ -1217,7 +1217,7 @@ 
 	if (is_array($var)) {
 		$code = '[';
 		foreach ($var as $value) {
-			$code .="'" . $value . "',";
+			$code .= "'" . $value . "',";
 		}
 		$code .= ']';
 		return $code;

Braces +15 added lines, -10 removed lines

@@ -257,8 +257,9 @@ 
 
 		//Get roles from Role2Grp
 		$groupList = $current_user_groups;
-		if (empty($groupList))
-			$groupList = array(0);
+		if (empty($groupList)) {
+					$groupList = array(0);
+		}
 
 		if (!empty($groupList)) {
 			$query = "select vtiger_datashare_role2group.* from vtiger_datashare_role2group inner join vtiger_datashare_module_rel on vtiger_datashare_module_rel.shareid=vtiger_datashare_role2group.shareid where vtiger_datashare_module_rel.tabid=?";
@@ -1379,8 +1380,9 @@ 
 			$var_name = $module . '_share_write_permission';
 		}
 		// Lookup for the variable if not set through function argument		
-		if (!$var_name_arr)
-			$var_name_arr = $$var_name;
+		if (!$var_name_arr) {
+					$var_name_arr = $$var_name;
+		}
 		$user_arr = [];
 		if (sizeof($var_name_arr['ROLE']) > 0) {
 			foreach ($var_name_arr['ROLE'] as $roleid => $roleusers) {
@@ -1414,8 +1416,9 @@ 
 			$var_name = $module . '_share_write_permission';
 		}
 		// Lookup for the variable if not set through function argument
-		if (!$var_name_arr)
-			$var_name_arr = $$var_name;
+		if (!$var_name_arr) {
+					$var_name_arr = $$var_name;
+		}
 		$grp_arr = [];
 		if (sizeof($var_name_arr['GROUP']) > 0) {
 
@@ -1458,8 +1461,9 @@ 
 			$var_name = $module . '_' . $relmodule . '_share_write_permission';
 		}
 		// Lookup for the variable if not set through function argument
-		if (!$var_name_arr)
-			$var_name_arr = $$var_name;
+		if (!$var_name_arr) {
+					$var_name_arr = $$var_name;
+		}
 		$user_arr = [];
 		if (sizeof($var_name_arr['ROLE']) > 0) {
 			foreach ($var_name_arr['ROLE'] as $roleid => $roleusers) {
@@ -1493,8 +1497,9 @@ 
 			$var_name = $module . '_' . $relmodule . '_share_write_permission';
 		}
 		// Lookup for the variable if not set through function argument
-		if (!$var_name_arr)
-			$var_name_arr = $$var_name;
+		if (!$var_name_arr) {
+					$var_name_arr = $$var_name;
+		}
 		$grp_arr = [];
 		if (sizeof($var_name_arr['GROUP']) > 0) {
 

modules/Vtiger/actions/GenerateRecords.php

Doc Comments +3 added lines

@@ -17,6 +17,9 @@
 		}
 	}
 
+	/**
+	 * @param Vtiger_Record_Model $recordModel
+	 */
 	public function checkMandatoryFields($recordModel)
 	{
 		$mandatoryFields = $recordModel->getModule()->getMandatoryFieldModels();

modules/Vtiger/actions/PDF.php

Doc Comments +1 added lines, -1 removed lines

@@ -221,7 +221,7 @@
 	/**
 	 * Checks if given record has valid pdf template
 	 * @param Vtiger_Request $request
-	 * @return boolean true if valid template exists for this record
+	 * @return boolean|null true if valid template exists for this record
 	 */
 	public function hasValidTemplate(Vtiger_Request $request)
 	{

modules/Vtiger/actions/Save.php

Doc Comments +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
 
 	/**
 	 * Function to save record
-	 * @param <Vtiger_Request> $request - values of the record
+	 * @param Vtiger_Request $request - values of the record
 	 * @return <RecordModel> - record Model of saved record
 	 */
 	public function saveRecord($request)

Braces +6 added lines, -4 removed lines

@@ -87,8 +87,9 @@ 
 			$relatedRecordId = $recordModel->getId();
 
 			$relationModel = Vtiger_Relation_Model::getInstance($parentModuleModel, $relatedModule);
-			if ($relationModel)
-				$relationModel->addRelation($parentRecordId, $relatedRecordId);
+			if ($relationModel) {
+							$relationModel->addRelation($parentRecordId, $relatedRecordId);
+			}
 		}
 		if ($request->get('imgDeleted')) {
 			$imageIds = $request->get('imageid');
@@ -144,8 +145,9 @@ 
 					$fieldValue = trim($fieldValue);
 				}
 				$recordModel->set($fieldName, $fieldValue);
-			} else
-				$recordModel->set($fieldName, null);
+			} else {
+							$recordModel->set($fieldName, null);
+			}
 		}
 		return $recordModel;
 	}

modules/Vtiger/models/ChartFilter.php

Doc Comments +6 added lines

@@ -113,6 +113,9 @@ 
 		return [];
 	}
 
+	/**
+	 * @param Vtiger_Widget_Model $widgetModel
+	 */
 	public function setWidgetModel($widgetModel)
 	{
 		$this->widgetModel = $widgetModel;
@@ -127,6 +130,9 @@ 
 		}
 	}
 
+	/**
+	 * @return string
+	 */
 	public function getType()
 	{
 		return $this->extraData['chartType'];

Spacing +8 added lines, -8 removed lines

@@ -112,7 +112,7 @@ 
 					if (!isset($groupData[$displayValue]['count'])) {
 						$groupData[$displayValue]['count'] = 1;
 					} else {
-						$groupData[$displayValue]['count'] ++;
+						$groupData[$displayValue]['count']++;
 					}
 					if (!isset($groupData[$displayValue]['link'])) {
 						$moduleModel = $this->getTargetModuleModel();
@@ -125,7 +125,7 @@ 
 			$count = [];
 			while ($row = $db->getRow($result)) {
 				$sectorId = $this->getSector($sectors, $row[$groupField]);
-				if($sectorId !== false){
+				if ($sectorId !== false) {
 					if (!isset($count[$sectorId])) {
 						$count[$sectorId] = 1;
 					} else {
@@ -134,15 +134,15 @@ 
 				}
 				
 			}
-			foreach($sectors as $sectorId => $sectorValue){
+			foreach ($sectors as $sectorId => $sectorValue) {
 				$moduleModel = $this->getTargetModuleModel();
 				$displayValue = $groupFieldModel->getDisplayValue($sectorValue);
-				$displayValue .= ' - (' . (int)$count[$sectorId] .')';
-				$groupData[$displayValue]['count'] = (int)$sectorValue ;
-				if($sectorId == 0){
-					$groupData[$displayValue]['link'] = $moduleModel->getListViewUrl() . "&viewname=$filterId" . '&search_params=' . json_encode([[[$fieldName, 'm', $sectorValue]]]);;
+				$displayValue .= ' - (' . (int) $count[$sectorId] . ')';
+				$groupData[$displayValue]['count'] = (int) $sectorValue;
+				if ($sectorId == 0) {
+					$groupData[$displayValue]['link'] = $moduleModel->getListViewUrl() . "&viewname=$filterId" . '&search_params=' . json_encode([[[$fieldName, 'm', $sectorValue]]]); ;
 				} else {
-					$groupData[$displayValue]['link'] = $moduleModel->getListViewUrl() . "&viewname=$filterId" . '&search_params=' . json_encode([[[$fieldName, 'm', $sectorValue],[$fieldName, 'g', $sectors[$sectorId - 1]]]]);;
+					$groupData[$displayValue]['link'] = $moduleModel->getListViewUrl() . "&viewname=$filterId" . '&search_params=' . json_encode([[[$fieldName, 'm', $sectorValue], [$fieldName, 'g', $sectors[$sectorId - 1]]]]); ;
 				}
 			}
 		}

modules/Vtiger/models/ExportToXml.php

Doc Comments +6 added lines

@@ -122,6 +122,9 @@ 
 		return html_entity_decode($value);
 	}
 
+	/**
+	 * @param string $fileName
+	 */
 	public function outputFile($fileName)
 	{
 		header("Content-Disposition:attachment;filename=$fileName.xml");
@@ -133,6 +136,9 @@ 
 		readfile($this->tmpXmlPath);
 	}
 
+	/**
+	 * @param string $fileName
+	 */
 	protected function outputZipFile($fileName)
 	{
 

modules/Vtiger/models/InventoryField.php

Doc Comments -5 removed lines

@@ -16,8 +16,6 @@ 
 
 	/**
 	 * Create the name of the Inventory data table
-	 * @param string $module Module name
-	 * @param string $prefix Prefix table
 	 * @return string Table name
 	 */
 	public function getTableName($type = 'data')
@@ -118,8 +116,6 @@ 
 
 	/**
 	 * Get inventory columns
-	 * @param string $module Module name
-	 * @param boolean $returnInBlock Should the result be divided into blocks
 	 * @return array Inventory columns
 	 */
 	public function getColumns()
@@ -164,7 +160,6 @@ 
 
 	/**
 	 * Retrieve list of all fields
-	 * @param string $moduleName Module name
 	 * @return array Fields instance Vtiger_Basic_InventoryField
 	 */
 	public function getAllFields()

Spacing +2 added lines, -2 removed lines

@@ -497,9 +497,9 @@
 		$db = PearDatabase::getInstance();
 		$query = sprintf('UPDATE `%s` SET sequence = CASE id ', $this->getTableName('fields'));
 		foreach ($sequenceList as $sequence => $id) {
-			$query .=' WHEN ' . $id . ' THEN ' . $sequence;
+			$query .= ' WHEN ' . $id . ' THEN ' . $sequence;
 		}
-		$query .=' END ';
+		$query .= ' END ';
 		$query .= sprintf(' WHERE id IN (%s)', generateQuestionMarks($sequenceList));
 		return $db->pquery($query, array_values($sequenceList));
 	}

Braces +6 added lines, -4 removed lines

@@ -133,8 +133,9 @@ 
 		$columns = [];
 		foreach ($this->getFields() as $key => $field) {
 			$column = $field->getColumnName();
-			if (!empty($column) && $column != '-')
-				$columns[] = $column;
+			if (!empty($column) && $column != '-') {
+							$columns[] = $column;
+			}
 			foreach ($field->getCustomColumn() as $name => $field) {
 				$columns[] = $name;
 			}
@@ -187,8 +188,9 @@ 
 		}
 		$fields = [];
 		foreach ($fieldPaths as $fieldPath) {
-			if (!is_dir($fieldPath))
-				continue;
+			if (!is_dir($fieldPath)) {
+							continue;
+			}
 			foreach (new DirectoryIterator($fieldPath) as $fileinfo) {
 				if ($fileinfo->isFile() && $fileinfo->getFilename() != 'Basic.php') {
 					$fieldName = str_replace('.php', '', $fileinfo->getFilename());

modules/Vtiger/models/ListView.php

Doc Comments -1 removed lines

@@ -332,7 +332,6 @@
 
 	/**
 	 * Function to get the list view entries
-	 * @param Vtiger_Paging_Model $pagingModel
 	 * @return <Array> - Associative array of record id mapped to Vtiger_Record_Model instance.
 	 */
 	public function getListViewCount()

Braces +3 added lines, -2 removed lines

@@ -169,8 +169,9 @@
 		$headerFieldModels = [];
 		$headerFields = $listViewContoller->getListViewHeaderFields();
 		foreach ($headerFields as $fieldName => $webserviceField) {
-			if ($webserviceField && !in_array($webserviceField->getPresence(), [0, 2]))
-				continue;
+			if ($webserviceField && !in_array($webserviceField->getPresence(), [0, 2])) {
+							continue;
+			}
 			$headerFieldModels[$fieldName] = Vtiger_Field_Model::getInstance($fieldName, $module);
 		}
 		return $headerFieldModels;